From patchwork Thu Apr 2 12:35:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2 via Gcc-patches" X-Patchwork-Id: 1265573 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=BpJQr30p; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48tMx150kLz9sRR for ; Thu, 2 Apr 2020 23:35:47 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E765D388A009; Thu, 2 Apr 2020 12:35:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E765D388A009 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1585830944; bh=mkJlhmF62l5GbCUMYI/9c7r/KdMyOQYvwy0qxvVpNag=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BpJQr30p4OuxDFtCswEh8XCfRUpZF2naewbO5SEONfegeECAUWiaxnSiUfz8DKe71 ySUPADxjtdlwAqbwCaDOVo2/TLJt5GyUCxTyTo4Z3asMViIBnFWF1PPRLVwpiAupCR pe/67I0/YRRNjg4CASvYJAbVCSXPGwT1l7ebtUHY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id C86B6385E02A for ; Thu, 2 Apr 2020 12:35:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C86B6385E02A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-340-5iaSgJVIO8m6QxxHDW9QKA-1; Thu, 02 Apr 2020 08:35:39 -0400 X-MC-Unique: 5iaSgJVIO8m6QxxHDW9QKA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CFDA7100550D; Thu, 2 Apr 2020 12:35:38 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-52.ams2.redhat.com [10.36.113.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F4BC5D9C9; Thu, 2 Apr 2020 12:35:38 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 032CZal9014614; Thu, 2 Apr 2020 14:35:36 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 032CZZAB014613; Thu, 2 Apr 2020 14:35:35 +0200 Date: Thu, 2 Apr 2020 14:35:35 +0200 To: Richard Biener Subject: [committed] params: Decrease -param=max-find-base-term-values= default [PR92264] Message-ID: <20200402123535.GU2212@tucnak> References: <20200402102939.GQ2212@tucnak> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-19.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: "Li, Pan2 via Gcc-patches" Reply-To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" On Thu, Apr 02, 2020 at 12:44:32PM +0200, Richard Biener wrote: > > For the PR in question, my proposal would be to also lower > > -param=max-find-base-term-values= > > default from 2000 to 200 after this, at least in the above 4 > > bootstraps/regtests there is nothing that would ever result in > > find_base_term returning non-NULL with more than 200 VALUEs being processed. > > Sounds good to me. Here is what I've committed after another bootstrap/regtest on x86_64-linux and i686-linux. 2020-04-02 Jakub Jelinek PR rtl-optimization/92264 * params.opt (-param=max-find-base-term-values=): Decrease default from 2000 to 200. Jakub --- gcc/params.opt.jj 2020-03-21 18:29:59.102158469 +0100 +++ gcc/params.opt 2020-04-02 13:05:14.433729117 +0200 @@ -663,7 +663,7 @@ Common Joined UInteger Var(param_max_var Max. size of var tracking hash tables. -param=max-find-base-term-values= -Common Joined UInteger Var(param_max_find_base_term_values) Init(2000) Param Optimization +Common Joined UInteger Var(param_max_find_base_term_values) Init(200) Param Optimization Maximum number of VALUEs handled during a single find_base_term call. -param=max-vrp-switch-assertions=