From patchwork Wed Sep 6 01:40:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 810355 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nifty.com header.i=@nifty.com header.b="rGayAm3h"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xn5sS2bw3z9sNc for ; Wed, 6 Sep 2017 11:41:32 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753505AbdIFBla (ORCPT ); Tue, 5 Sep 2017 21:41:30 -0400 Received: from conuserg-09.nifty.com ([210.131.2.76]:17225 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753474AbdIFBla (ORCPT ); Tue, 5 Sep 2017 21:41:30 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-09.nifty.com with ESMTP id v861etHU030333; Wed, 6 Sep 2017 10:40:55 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com v861etHU030333 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1504662055; bh=StCdSR3mElgXxanw8Fw/g9I9oBXbD6s90xXDjX/QV4M=; h=From:To:Cc:Subject:Date:From; b=rGayAm3hkmLW/jghsWM68jKrUBO3rWamXzusgUQKBD6jNOy0Of6vmZnxtltWkzfAV w0cOHD0KMVdNFwY8VIVuPlWR52hzISq7sgRWmbyqQHkBneNP2fO2bjbIN9v6A/+pve K4zjG0clEKU2JpxYEla8lpnYcCSjK/j8xEEFqqALziuLELFyGDI8l1rkWmkfN6L9yb ZtYd2gYZFdGKR+jmPeSYqkhrFfsUBvb+GwtbSPa80v60IHQQM+st0T4Gt8HiPBvQyy lf7rNLxkDlfJcmrpTMsUqZyravIAsBUMho6Z5jVmHhFcyy5VGPJHrNWeN1JY6IzZuv Gi4OOw4UhGNPQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-gpio@vger.kernel.org Cc: David Daney , Masahiro Yamada , Linus Walleij , linux-kernel@vger.kernel.org Subject: [PATCH] gpio: thunderx: select IRQ_DOMAIN_HIERARCHY instead of depends on Date: Wed, 6 Sep 2017 10:40:52 +0900 Message-Id: <1504662052-12478-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org IRQ_DOMAIN_HIERARCHY is not user-configurable, but supposed to be selected by drivers that need IRQ domain hierarchy support. GPIO_THUNDERX is the only user of "depends on IRQ_DOMAIN_HIERARCHY". This means, we can not enable GPIO_THUNDERX unless other drivers select IRQ_DOMAIN_HIERARCHY elsewhere. This is odd. Flip the logic. Signed-off-by: Masahiro Yamada Acked-by: David Daney --- drivers/gpio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 3388d54..3f80f16 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -453,7 +453,8 @@ config GPIO_TS4800 config GPIO_THUNDERX tristate "Cavium ThunderX/OCTEON-TX GPIO" depends on ARCH_THUNDER || (64BIT && COMPILE_TEST) - depends on PCI_MSI && IRQ_DOMAIN_HIERARCHY + depends on PCI_MSI + select IRQ_DOMAIN_HIERARCHY select IRQ_FASTEOI_HIERARCHY_HANDLERS help Say yes here to support the on-chip GPIO lines on the ThunderX