From patchwork Tue Mar 31 17:16:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Patchwork-Id: 1264859 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IkuWEEhs; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48sGGC48Bdz9sRR for ; Wed, 1 Apr 2020 04:16:51 +1100 (AEDT) Received: from localhost ([::1]:42054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJKVN-0000fo-Gr for incoming@patchwork.ozlabs.org; Tue, 31 Mar 2020 13:16:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48927) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJKUq-0000eo-PI for qemu-devel@nongnu.org; Tue, 31 Mar 2020 13:16:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJKUp-0005lQ-IL for qemu-devel@nongnu.org; Tue, 31 Mar 2020 13:16:16 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:44454 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJKUp-0005kv-F2 for qemu-devel@nongnu.org; Tue, 31 Mar 2020 13:16:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585674974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zluSe7sWi+EQ03Ku1XnFDdBAnxU8/t9URFObDnnQIeE=; b=IkuWEEhsb9vJhvsxcfwPXgUYLqgzBWNnXYkqxtoQY1ienV7tBF0a7Gg0OfHnZh2UicnSRU DGEjKZVW4YIm+lp7/3q20rXpIF43DOTP1J7M5HcAPq3twIZrparagK5potYJYUeMRodLAh AOTL5KAaoV8vai3PoHRLJ5qsUGUB3kw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-236-3Jjx5Z81M32M7ZGEN7SraQ-1; Tue, 31 Mar 2020 13:16:13 -0400 X-MC-Unique: 3Jjx5Z81M32M7ZGEN7SraQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B65F08017CC; Tue, 31 Mar 2020 17:16:11 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.36.110.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2629160BFE; Tue, 31 Mar 2020 17:16:07 +0000 (UTC) From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3] configure: warn if not using a separate build directory Date: Tue, 31 Mar 2020 18:16:06 +0100 Message-Id: <20200331171606.386801-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Markus Armbruster , Liviu Ionescu , Stefan Hajnoczi , Paolo Bonzini , =?utf-8?q?Michal_Such=C3=A1nek?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aleksandar Markovic Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attempts to use an in-srcdir build setup, so that they are aware that they're building QEMU in an undesirable manner. Signed-off-by: Daniel P. Berrangé Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- Changed in v3: - Don't try to predict the future so much, just recommend a separate build dir configure | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/configure b/configure index e225a1e3ff..b4d1b01689 100755 --- a/configure +++ b/configure @@ -285,6 +285,16 @@ then error_exit "main directory cannot contain spaces nor colons" fi +canon_build_path=$(realpath -- "$PWD") +canon_source_path=$(realpath -- "$source_path") + +in_srcdir=no +if [ "$canon_build_path" = "$canon_source_path" ] +then + in_srcdir=yes +fi + + # default parameters cpu="" iasl="iasl" @@ -6799,6 +6809,22 @@ if test "$supported_os" = "no"; then echo "us upstream at qemu-devel@nongnu.org." fi +if test "$in_srcdir" = "yes"; then + echo + echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED" + echo + echo "Support for running the 'configure' script directly from the" + echo "source directory is deprecated. In source dir builds are not" + echo "covered by automated testing and thus may not correctly build" + echo "QEMU. Users are recommended to use a separate build directory:" + echo + echo " $ mkdir build" + echo " $ cd build" + echo " $ ../configure" + echo " $ make" + echo +fi + config_host_mak="config-host.mak" echo "# Automatically generated by configure - do not modify" >config-all-disas.mak