From patchwork Tue Mar 31 05:34:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rayagonda Kokatanur X-Patchwork-Id: 1264530 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=WpRboXzQ; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48rygx1GPRz9sQt for ; Tue, 31 Mar 2020 16:34:37 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ACF9581933; Tue, 31 Mar 2020 07:34:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.b="WpRboXzQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 81B638192F; Tue, 31 Mar 2020 07:34:27 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 73CC981923 for ; Tue, 31 Mar 2020 07:34:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rayagonda.kokatanur@broadcom.com Received: by mail-wm1-x342.google.com with SMTP id b12so1080329wmj.3 for ; Mon, 30 Mar 2020 22:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YiVjkigwHIujR+LXZQn/7z1bsnNHVS6z5qREoCkU/Og=; b=WpRboXzQvxUphCa9NFkA2z5Dyfp4hpVomdwOnDUBw6k/iRe2J5y4SpVKKSIbfrcMg8 7/Eo2SbVzcMXl0X29i3LUIQ/mQPbNUOX9ONxwBqJMxDuNJQgWW5lcm4xzwEnU74DpvRW ROGIyogJ6edLPwgUnPCzifCCzwE8soDsSyxT8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YiVjkigwHIujR+LXZQn/7z1bsnNHVS6z5qREoCkU/Og=; b=Lsq1rJ4LBMeU2jz7APEnrAJUHyDFNjMEFwk4nDKTVwjnvKi8c8yzvysCnyz8+BlM7T EWncfFRTz86G8T33elPByFaRlpVOr+FrN5mjqKLlid+WqfDLAyc5oA/ayiMeWGP0mSbX NObqxdBaANQ6bOdEp3y2O+gcdpnXy0KCFU5/FEVtpgb9RnKC0O2qhRFTKB1UtfsN8KLw z/oNhUowSa43x+aNNODpg2OUAEbNbvJMnQ8YHS4Cv5EKNSrxNQKNuN1LaBea+lKJlaZX RabFyaRIHjxgTrgNFgy6f3nx+3zEnw2eRtkkUrWmuCY+itq9RzZ5oVJk8jAQMSF5XNc9 XiEQ== X-Gm-Message-State: ANhLgQ2TBoZyT98Op4y8FAWXBK04WM5jp0bSgk5QP95xtDzk3BvyiM/P yy4R194uW8uNY2wo3QT0ASxZwnJ1RPOczTKAo4EyinZUMO3bShE6h6TLeokSt4OshhK4KgQL56N bvRQll84arTmhC4b7T4ZKJw1Uwm4SWemXwngW9Lvg5FXakru90eVo9vIfadmobAI0zFFX/SiMt0 jcZMVPWg== X-Google-Smtp-Source: ADFU+vuef4OA0Dj5z4NIBVUhtEyxX6hCW1t73SaXMabu9oBgn/6NFlR9p1j0/KgJ71TX9g7DVNe5GA== X-Received: by 2002:a1c:196:: with SMTP id 144mr1639525wmb.100.1585632863465; Mon, 30 Mar 2020 22:34:23 -0700 (PDT) Received: from rayagonda.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id w204sm2374854wma.1.2020.03.30.22.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 22:34:22 -0700 (PDT) From: Rayagonda Kokatanur To: u-boot@lists.denx.de, panto@antoniou-consulting.com, Bharat Kumar Reddy Gooty , Arun Parameswaran , Vladimir Olovyannikov Cc: Rayagonda Kokatanur Subject: [PATCH v1 1/4] drivers: mmc: iproc_sdhci: fix possible memory leak Date: Tue, 31 Mar 2020 11:04:03 +0530 Message-Id: <20200331053406.23063-2-rayagonda.kokatanur@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200331053406.23063-1-rayagonda.kokatanur@broadcom.com> References: <20200331053406.23063-1-rayagonda.kokatanur@broadcom.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean From: Bharat Kumar Reddy Gooty Free the pointer variable 'iproc_sdhci' upon failure to fix possible memory leak. Signed-off-by: Bharat Kumar Reddy Gooty Signed-off-by: Rayagonda Kokatanur --- drivers/mmc/iproc_sdhci.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/iproc_sdhci.c b/drivers/mmc/iproc_sdhci.c index 831dd32eb7..36ecdba5c6 100644 --- a/drivers/mmc/iproc_sdhci.c +++ b/drivers/mmc/iproc_sdhci.c @@ -176,8 +176,7 @@ static int iproc_sdhci_probe(struct udevice *dev) u32 f_min_max[2]; int ret; - iproc_host = (struct sdhci_iproc_host *) - malloc(sizeof(struct sdhci_iproc_host)); + iproc_host = malloc(sizeof(struct sdhci_iproc_host)); if (!iproc_host) { printf("%s: sdhci host malloc fail!\n", __func__); return -ENOMEM; @@ -198,6 +197,7 @@ static int iproc_sdhci_probe(struct udevice *dev) "clock-freq-min-max", f_min_max, 2); if (ret) { printf("sdhci: clock-freq-min-max not found\n"); + free(iproc_host); return ret; } host->max_clk = f_min_max[1]; @@ -212,8 +212,10 @@ static int iproc_sdhci_probe(struct udevice *dev) ret = sdhci_setup_cfg(&plat->cfg, &iproc_host->host, f_min_max[1], f_min_max[0]); - if (ret) + if (ret) { + free(iproc_host); return ret; + } iproc_host->host.mmc = &plat->mmc; iproc_host->host.mmc->dev = dev; From patchwork Tue Mar 31 05:34:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rayagonda Kokatanur X-Patchwork-Id: 1264531 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=bi4PlGG+; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48ryh74JXFz9sQt for ; Tue, 31 Mar 2020 16:34:47 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3EC838192A; Tue, 31 Mar 2020 07:34:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.b="bi4PlGG+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 81AB08192A; Tue, 31 Mar 2020 07:34:33 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 11C2E81930 for ; Tue, 31 Mar 2020 07:34:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rayagonda.kokatanur@broadcom.com Received: by mail-wm1-x342.google.com with SMTP id j19so1151579wmi.2 for ; Mon, 30 Mar 2020 22:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CxULYCPgICXI9aisXf1Kwxa4H66e4j4EXbQ/PZweic0=; b=bi4PlGG+6GAcsfMDnLQzhtwlfATclBRmnPkHe9NmOVyh0SAmN2V3+zXbMdTeCMfQxe mF7BD7VWsftUO3dmTMsUvquezBirSBPEWoVCbKjzswmjvUNebvcKIvSAmJyfXKUGafrt yS429R2G7sXmmTfwo5C1od6iK3RT1R5wZKK8Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CxULYCPgICXI9aisXf1Kwxa4H66e4j4EXbQ/PZweic0=; b=JZ1VM8tSz7eQlXbkBva4hpnToSZHB01ETrHlJoRT6nWlWMMelXIDmRGV+V2on3rfpR /QTtBGVNqBcpgEcwLvvUmZek956Oflc5EFABVJsZYOBO1ClnkVHbvVHPP81FsO1Q/Q1M /N+PzhO3zfIOzNdQUEcw6GcaHDIf57ITH3ekSS94c3VXqAcPE+ViaAnoCsrmKRu0C/Sa uF9YYN2pjSPJW7uPY+wxRtk17ZXKJ9+yYNmXJeiWne3sH7uXwkGC7W79MBy138+y1PMC JpVcUwuwrNAwqA1m/VY7HUKr3Suq9KXcMMY/FTSy4Z9loSRMtwtAiwABS5LkB/Bn8c18 oqnA== X-Gm-Message-State: ANhLgQ2IgDtpCnAqh/Qdf3h1zJCCvnLC9xi57aG9vTyDKT08aOsnrJ3t 7q1LdYmIXcaJdmtZwmIIFxrPnemrS/wBAR5v3pjKhdSowuQhjtEO7WMcWiMCqmKoCwZA7QD9Axr VRaENzqAY/tume6b8/UwxyPxzNPpmEoUAuC0ioyPGHYRr60COSbn07NObegTt2rAXMPaFcPUmJV WzmrTa1Q== X-Google-Smtp-Source: ADFU+vu3IqODSGpzV4v51MmB8RElqp5a4W4uZO/cOAOSNPmoAf7X+dWmfJL7AeyPs3IAdD5tz4lAoA== X-Received: by 2002:a7b:ce95:: with SMTP id q21mr1640931wmj.65.1585632868239; Mon, 30 Mar 2020 22:34:28 -0700 (PDT) Received: from rayagonda.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id w204sm2374854wma.1.2020.03.30.22.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 22:34:27 -0700 (PDT) From: Rayagonda Kokatanur To: u-boot@lists.denx.de, panto@antoniou-consulting.com, Bharat Kumar Reddy Gooty , Arun Parameswaran , Vladimir Olovyannikov Cc: Rayagonda Kokatanur Subject: [PATCH v1 2/4] drivers: mmc: iproc_sdhci: enable broken R1B response quirk Date: Tue, 31 Mar 2020 11:04:04 +0530 Message-Id: <20200331053406.23063-3-rayagonda.kokatanur@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200331053406.23063-1-rayagonda.kokatanur@broadcom.com> References: <20200331053406.23063-1-rayagonda.kokatanur@broadcom.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean From: Bharat Kumar Reddy Gooty Enable SDHCI_QUIRK_BROKEN_R1B quirk. Signed-off-by: Bharat Kumar Reddy Gooty Signed-off-by: Rayagonda Kokatanur --- drivers/mmc/iproc_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/iproc_sdhci.c b/drivers/mmc/iproc_sdhci.c index 36ecdba5c6..f65a1e543d 100644 --- a/drivers/mmc/iproc_sdhci.c +++ b/drivers/mmc/iproc_sdhci.c @@ -188,7 +188,7 @@ static int iproc_sdhci_probe(struct udevice *dev) host->ioaddr = (void *)devfdt_get_addr(dev); host->voltages = MMC_VDD_165_195 | MMC_VDD_32_33 | MMC_VDD_33_34; - host->quirks = SDHCI_QUIRK_BROKEN_VOLTAGE; + host->quirks = SDHCI_QUIRK_BROKEN_VOLTAGE | SDHCI_QUIRK_BROKEN_R1B; host->host_caps = MMC_MODE_DDR_52MHz; host->index = fdtdec_get_uint(gd->fdt_blob, node, "index", 0); host->ops = &sdhci_platform_ops; From patchwork Tue Mar 31 05:34:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rayagonda Kokatanur X-Patchwork-Id: 1264532 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=c9qT1Tka; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48ryhK3brJz9sQt for ; Tue, 31 Mar 2020 16:34:57 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7F95E81951; Tue, 31 Mar 2020 07:34:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.b="c9qT1Tka"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 300C681950; Tue, 31 Mar 2020 07:34:38 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AE31281942 for ; Tue, 31 Mar 2020 07:34:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rayagonda.kokatanur@broadcom.com Received: by mail-wr1-x444.google.com with SMTP id u10so24296474wro.7 for ; Mon, 30 Mar 2020 22:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KThrrqMuxQ2xPBeqG2CRFTQaj/aGs3gwFmDfPD+KZa4=; b=c9qT1TkaUS5WZvuNyFfoLhGDMScyeELajTYkXCaLkYTj/cewiWP2K6JcHzamHFcNKp +Bk2H2Y9dUjsWk4Zi59tXiUIg4irRVActloWpgVq1igadIGBI+ga+uHa7Ymf0CQP2Ymm Ibf6Ulit5O001qw7FOpvNiuFhfi3+eQWgrRPg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KThrrqMuxQ2xPBeqG2CRFTQaj/aGs3gwFmDfPD+KZa4=; b=INjNA4ji1ocPb/aLDa2TXpQhlmIP5ObWwKFWgpcgyKIyeHDPR8pgMbCZt1JdmlE4oM iihTPj49+bdhWqH68FLx+qAlFsibp4N2ZILu6o+NaAUz7qbKS3rAQ39cBN7f8Q+pC2jK uH4a7K8y1qoWKoDPRqmt/QnwJtmFIrUCxIuLvfxwu3KfML0HKvHOXP2fKuxcNZnqbNQJ 2ggFGGjfxdBd2ebg6FXWapp4sFQ6AVH9NgcJmAZSctjrB0+zhgCO5x/+A3v/eo7bHAVP kfNduADgVK6g5gTwWoLnlMgW1b9tw4DC0r5kb8Ip7H4tbv85F9H3aBrgNyxD9v7iRvow 1w3w== X-Gm-Message-State: ANhLgQ0YvpWEKE+VJgJMtcVKWATn4E6ENFtFiKkvv7p4o/V/6eR67upa 1TVfPrji/Mv+KuN0m47o+pd8hvK1siwPATZf25EXgq5PDtT7itXgPzo0ZXY9SuI1vcdL1DzcQV+ JjI6Jb8avi0xvZ3iYKuAGADvmktU4ZhTv8RxBQ7H/e4lBKKRDmid9gsP1rrnJcGn+3urICGi243 cSuawfIA== X-Google-Smtp-Source: ADFU+vsDEthjTYOCoF0fsf5Rk1qyRhINS8n91Efff1hXX4kLpV/JKtDi4cpF+GAhHQK4oKAw/Jg49w== X-Received: by 2002:adf:e946:: with SMTP id m6mr18938671wrn.187.1585632874887; Mon, 30 Mar 2020 22:34:34 -0700 (PDT) Received: from rayagonda.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id w204sm2374854wma.1.2020.03.30.22.34.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 22:34:34 -0700 (PDT) From: Rayagonda Kokatanur To: u-boot@lists.denx.de, panto@antoniou-consulting.com, Bharat Kumar Reddy Gooty , Arun Parameswaran , Vladimir Olovyannikov Cc: Rayagonda Kokatanur Subject: [PATCH v1 3/4] drivers: mmc: iproc_sdhci: fix compilation warning Date: Tue, 31 Mar 2020 11:04:05 +0530 Message-Id: <20200331053406.23063-4-rayagonda.kokatanur@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200331053406.23063-1-rayagonda.kokatanur@broadcom.com> References: <20200331053406.23063-1-rayagonda.kokatanur@broadcom.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean set_ios_post return type changed from void to int, correcting the same to fix compilation warning. Signed-off-by: Rayagonda Kokatanur Signed-off-by: Bharat Kumar Reddy Gooty --- drivers/mmc/iproc_sdhci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/iproc_sdhci.c b/drivers/mmc/iproc_sdhci.c index f65a1e543d..0f4d608869 100644 --- a/drivers/mmc/iproc_sdhci.c +++ b/drivers/mmc/iproc_sdhci.c @@ -136,7 +136,7 @@ static void sdhci_iproc_writeb(struct sdhci_host *host, u8 val, int reg) } #endif -static void sdhci_iproc_set_ios_post(struct sdhci_host *host) +static int sdhci_iproc_set_ios_post(struct sdhci_host *host) { u32 ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2); @@ -147,6 +147,8 @@ static void sdhci_iproc_set_ios_post(struct sdhci_host *host) ctrl |= UHS_DDR50_BUS_SPEED; sdhci_writew(host, ctrl, SDHCI_HOST_CONTROL2); + + return 0; } static struct sdhci_ops sdhci_platform_ops = { From patchwork Tue Mar 31 05:34:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rayagonda Kokatanur X-Patchwork-Id: 1264533 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=h5zljwmF; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48ryhW0TT0z9sQt for ; Tue, 31 Mar 2020 16:35:07 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6CB6C81947; Tue, 31 Mar 2020 07:34:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.b="h5zljwmF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B87E581948; Tue, 31 Mar 2020 07:34:43 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 701DF81947 for ; Tue, 31 Mar 2020 07:34:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rayagonda.kokatanur@broadcom.com Received: by mail-wr1-x441.google.com with SMTP id d5so24368020wrn.2 for ; Mon, 30 Mar 2020 22:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pSpBcO/sW+XwtPHdB2csNOQ9YuyOQ6UfnleHuzLzuyE=; b=h5zljwmFOXY7Zsg8bkdTytKzHrrs3DTKcfeIotT7/H+54Kyu/fQDI+6GtQgSUdZSRv +UbOaEf0t3h7Sx51rzNFQ+CBrRRbecn4uUKsZdaRdy9IOhM7g4eLTOKW8F8KfZ63v7Ie JKQjgl4yoZ2S4kpr2edDlE58VjMqlpjwnNpVE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pSpBcO/sW+XwtPHdB2csNOQ9YuyOQ6UfnleHuzLzuyE=; b=X9cR4V5TCwoWctusVDDnFw2Gb0Qw8bCVjTMNPB09RcKn36WoSPRZBirzXnEKaiAGi5 BMbifC7XTA06QG1B/XuFo9MBrS1HKBq82Esc+qxL5rWtN7cScflYPWbfAGKow1/va3v1 xeEoP9daGM91JEAypDEZKq9OpRPB+2QpWpUh5KlgqW6poi+fyvnNNmhy+u07UU3PF+Oi dCkndwiVc7E88ipeFDK0yDEDVRlluegwIR42LQWepFnO65S//t9IMAk54DqPU7cZUyrI tu4vwAQhnGWAPPyy+Ce5JuYn7chdREFRAJeELd3jE6K9afqW/UeMJmuLCOL1UEnjs5DA p60g== X-Gm-Message-State: ANhLgQ044tOlzkQCREkgD29ImdWRiA0g2D6G6yt1xh2bn9ZSguIop8mZ +m38kvaLbc0H4wrCPaplvism1j7zm92rUxwXwsSxvVoEwMZqJemlgd5u3zAqh3LQlJHQeX/wg9+ o3gT4jAtouApMlO8tNNtfCXP7MhHpP/betP6ZosInbjmgBBRmV+KlGTZaLxwtZn9lVN28Sr+A8l IXXhPYFg== X-Google-Smtp-Source: ADFU+vufMMkdzLA170ykLaeWUR173XN8/qiwo26tHiNL4zQi71OsS6g75+nJtqj8/0Q4yA2D6/bVHw== X-Received: by 2002:a5d:6906:: with SMTP id t6mr13992788wru.64.1585632879615; Mon, 30 Mar 2020 22:34:39 -0700 (PDT) Received: from rayagonda.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id w204sm2374854wma.1.2020.03.30.22.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 22:34:39 -0700 (PDT) From: Rayagonda Kokatanur To: u-boot@lists.denx.de, panto@antoniou-consulting.com, Bharat Kumar Reddy Gooty , Arun Parameswaran , Vladimir Olovyannikov Cc: Rayagonda Kokatanur Subject: [PATCH v1 4/4] drivers: mmc: iproc_sdhci: move host.mmc init before sdhci_setup_cfg Date: Tue, 31 Mar 2020 11:04:06 +0530 Message-Id: <20200331053406.23063-5-rayagonda.kokatanur@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200331053406.23063-1-rayagonda.kokatanur@broadcom.com> References: <20200331053406.23063-1-rayagonda.kokatanur@broadcom.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean move host.mmc before sdhci_setup_cfg Signed-off-by: Rayagonda Kokatanur Signed-off-by: Bharat Kumar Reddy Gooty --- drivers/mmc/iproc_sdhci.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/iproc_sdhci.c b/drivers/mmc/iproc_sdhci.c index 0f4d608869..c2319b4134 100644 --- a/drivers/mmc/iproc_sdhci.c +++ b/drivers/mmc/iproc_sdhci.c @@ -212,6 +212,11 @@ static int iproc_sdhci_probe(struct udevice *dev) memcpy(&iproc_host->host, host, sizeof(struct sdhci_host)); + iproc_host->host.mmc = &plat->mmc; + iproc_host->host.mmc->dev = dev; + iproc_host->host.mmc->priv = &iproc_host->host; + upriv->mmc = iproc_host->host.mmc; + ret = sdhci_setup_cfg(&plat->cfg, &iproc_host->host, f_min_max[1], f_min_max[0]); if (ret) { @@ -219,11 +224,6 @@ static int iproc_sdhci_probe(struct udevice *dev) return ret; } - iproc_host->host.mmc = &plat->mmc; - iproc_host->host.mmc->dev = dev; - iproc_host->host.mmc->priv = &iproc_host->host; - upriv->mmc = iproc_host->host.mmc; - return sdhci_probe(dev); }