From patchwork Thu Mar 26 16:27:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Pisati X-Patchwork-Id: 1262145 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48p9PH0VNBz9sSG; Fri, 27 Mar 2020 03:27:15 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jHVLa-0000ac-01; Thu, 26 Mar 2020 16:27:09 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jHVLY-0000aR-Kh for kernel-team@lists.ubuntu.com; Thu, 26 Mar 2020 16:27:08 +0000 Received: from 1.general.ppisati.uk.vpn ([10.172.193.134] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jHVLY-0006oI-Ab for kernel-team@lists.ubuntu.com; Thu, 26 Mar 2020 16:27:08 +0000 From: Paolo Pisati To: kernel-team@lists.ubuntu.com Subject: [PATCH] UBUNTU: SAUCE: ubuntu_kernel_selftests: skip ftrace unit test 'Kprobe event user-memory access' on ppc64|s390 Date: Thu, 26 Mar 2020 17:27:07 +0100 Message-Id: <20200326162707.95067-1-paolo.pisati@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1869227 Ftrace 'Kprobe event user-memory access' test constantly fails on ppc64: ftrace/test.d/kprobe/kprobe_args_user.tc: ... grep -q '\$arg' README || exit_unresolved # depends on arch ... the above README file is '/sys/kernel/tracing/README' and that grep line fails since '\$arg' is only available if: kernel/trace/trace.c: #ifdef CONFIG_HAVE_FUNCTION_ARG_ACCESS_API "\t $stack, $stack, $retval, $comm, $arg,\n" #else "\t $stack, $stack, $retval, $comm,\n" #endif and HAVE_FUNCTION_ARG_ACCESS_API is true only on architectures that supports the API needed to access function arguments from pt_regs, declared in asm/ptrace.h. Signed-off-by: Paolo Pisati Acked-by: Po-Hsu Lin --- ubuntu_kernel_selftests/ubuntu_kernel_selftests.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py index aa5f9430..cb1a4d4b 100644 --- a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py +++ b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py @@ -154,6 +154,16 @@ class ubuntu_kernel_selftests(test.test): 'kprobe/probepoint.tc', 'kprobe/kprobe_module.tc', ] + + # + # Ftrace 'Kprobe event user-memory access' test depends on + # HAVE_FUNCTION_ARG_ACCESS_API, but ppc64 doesn't support it: + # disable it to avoid an unresolved result (and thus a failure). + # + arch = platform.processor() + if arch in ['ppc64le', 's390x']: + filenames.append('kprobe/kprobe_args_user.tc') + for fn in filenames: fn = 'linux/tools/testing/selftests/ftrace/test.d/' + fn if os.path.exists(fn):