From patchwork Wed Mar 25 16:42:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fangrui Song X-Patchwork-Id: 1261533 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48nYrN5Rlqz9sQx for ; Thu, 26 Mar 2020 03:45:08 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=R7PnGgOm; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48nYrN2SPtzDqWx for ; Thu, 26 Mar 2020 03:45:08 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--maskray.bounces.google.com (client-ip=2607:f8b0:4864:20::44a; helo=mail-pf1-x44a.google.com; envelope-from=3oyp7xgckddyeskcjsqyggydw.ugedafmphhu-vwndaklk.grdstk.gjy@flex--maskray.bounces.google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=R7PnGgOm; dkim-atps=neutral Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48nYpq6wHPzDqZj for ; Thu, 26 Mar 2020 03:43:41 +1100 (AEDT) Received: by mail-pf1-x44a.google.com with SMTP id r13so2516806pfr.17 for ; Wed, 25 Mar 2020 09:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=W+RJLtrYnjjpgBQ3gpQ7MHIpp5jjX2BBq7fApCfnQBg=; b=R7PnGgOmAt/76/+T2nkV1r1xC59C8Bdemi8JIs5vw+Ye4LdEvxPP7JVv6jC/3v4NCk CZ5Sk9JVEjn7Ez74xCB9YNJu4OHk/R/3OjhkWUC7V6EJHogw1c/xL2WnyBtbbi8YpNi/ I+SEyFTn+jOaegYwmJJFLnYMt3nwQuDx2spCHwILmZ5zKe+yGIAKjBrg5F54/ZRzL8YW j4dOm5TztE62KMh+mURTAXERjgjQdti+Gv8+RT1gTeqE/wsUR6+glMQ/VkQyp9AAt/YA hvESOvJIelkUxc9UbAgwaCYzDXEaNLiNaiyPMY4cTy5klyGLEtd5yu/jGRZ1ro1wuMZS zkhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=W+RJLtrYnjjpgBQ3gpQ7MHIpp5jjX2BBq7fApCfnQBg=; b=UwhvrVSWLjNcIhZwHYurEl+Qt6KvZISbPEZSu/G38JvYgPZWIhAaDOUQ2/ibtlMPiQ uRuYRsvLbxevWLhU0H+lA8zn3SPy5gEwjpboFirtJ0RfqQZpRCgfR+AGLB96G5p4ky+E zNhaokqpWJdnzJNCVUqLFUwSoUthMuqDBpzENU/LGFrJvYnovNTlAq6MZl5q7YoS1V/d rXqYMV5y/DK1cEr74szOyzF9fXgNS+A75VuOnkOgyttcyU2Wo0+RXsb9vGOQRkONLH+x gsUljNrea7Ok0q/fONbtDcbU4m5+6FXF419MRGI/xQE+z4tR1TtLdAL5Y599pD/B5Z83 Kguw== X-Gm-Message-State: ANhLgQ0gkIAgI59HuwDBVcm2VYi71mvkW2ivMkWQu5a6wICX8mEfbD1E 0vIN+nQnuaza1eM/ePese00X5VueEUs3hKNj0yI6aQKhiOOiNYoxyfyp8Gf7nMsEOPv9T/uiD7A zRZfHue9UKrlubwuXifrFH/SIYGQf/EfLSQ1w8U225RY8A3TmIOPJ7YBjqrkZlCnX8Yh+EQ+4rw == X-Google-Smtp-Source: ADFU+vsbvA0bPKZuFuoyiAYYT2MAajBQClBv2FVQWpgTqGSwOk86q1wjxhji3lIrW877UAk2zXeS6eprXZB9 X-Received: by 2002:a17:90a:d101:: with SMTP id l1mr4885668pju.130.1585154617915; Wed, 25 Mar 2020 09:43:37 -0700 (PDT) Date: Wed, 25 Mar 2020 09:42:57 -0700 Message-Id: <20200325164257.170229-1-maskray@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.25.1.696.g5e7596f4ac-goog Subject: [PATCH v2] powerpc/boot: Delete unneeded .globl _zimage_start From: Fangrui Song To: linuxppc-dev@lists.ozlabs.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fangrui Song , Alan Modra , Nick Desaulniers , clang-built-linux@googlegroups.com, Joel Stanley Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" .globl sets the symbol binding to STB_GLOBAL while .weak sets the binding to STB_WEAK. GNU as let .weak override .globl since binutils-gdb 5ca547dc2399a0a5d9f20626d4bf5547c3ccfddd (1996). Clang integrated assembler let the last win but it may error in the future. Since it is a convention that only one binding directive is used, just delete .globl. Fixes: cd197ffcf10b "[POWERPC] zImage: Cleanup and improve zImage entry point" Fixes: ee9d21b3b358 "powerpc/boot: Ensure _zimage_start is a weak symbol" Link: https://github.com/ClangBuiltLinux/linux/issues/937 Signed-off-by: Fangrui Song Cc: Alan Modra Cc: Joel Stanley Cc: Michael Ellerman Cc: Nick Desaulniers Cc: Segher Boessenkool Cc: clang-built-linux@googlegroups.com --- arch/powerpc/boot/crt0.S | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/powerpc/boot/crt0.S b/arch/powerpc/boot/crt0.S index 92608f34d312..1d83966f5ef6 100644 --- a/arch/powerpc/boot/crt0.S +++ b/arch/powerpc/boot/crt0.S @@ -44,9 +44,6 @@ p_end: .long _end p_pstack: .long _platform_stack_top #endif - .globl _zimage_start - /* Clang appears to require the .weak directive to be after the symbol - * is defined. See https://bugs.llvm.org/show_bug.cgi?id=38921 */ .weak _zimage_start _zimage_start: .globl _zimage_start_lib