From patchwork Wed Mar 25 09:21:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chen Qun X-Patchwork-Id: 1261243 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48nN272yW1z9sRR for ; Wed, 25 Mar 2020 20:22:55 +1100 (AEDT) Received: from localhost ([::1]:60866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH2FR-0003RN-CB for incoming@patchwork.ozlabs.org; Wed, 25 Mar 2020 05:22:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52632) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH2Eo-0003NB-PV for qemu-devel@nongnu.org; Wed, 25 Mar 2020 05:22:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jH2En-0007uo-Lq for qemu-devel@nongnu.org; Wed, 25 Mar 2020 05:22:14 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:58822 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jH2En-0007nk-9g; Wed, 25 Mar 2020 05:22:13 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id D0EA5383E7485E33693D; Wed, 25 Mar 2020 17:22:05 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Mar 2020 17:21:59 +0800 From: Chen Qun To: , Subject: [PATCH 1/3] gdbstub: prevent uninitialized warning Date: Wed, 25 Mar 2020 17:21:35 +0800 Message-ID: <20200325092137.24020-2-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200325092137.24020-1-kuhn.chenqun@huawei.com> References: <20200325092137.24020-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, =?utf-8?q?Alex_Benn=C3=A9e?= , laurent@vivier.eu, Euler Robot , Chen Qun , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" According to the glib function requirements, we need initialise the variable. Otherwise there will be compilation warnings: qemu/gdbstub.c: In function ‘handle_query_thread_extra’: /usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: warning: ‘cpu_name’ may be used uninitialized in this function [-Wmaybe-uninitialized] g_free (*pp); ^~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Miroslav Rezanina --- Cc: "Alex Bennée" Cc: "Philippe Mathieu-Daudé" --- gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 013fb1ac0f..171e150950 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2060,8 +2060,8 @@ static void handle_query_thread_extra(GdbCmdContext *gdb_ctx, void *user_ctx) /* Print the CPU model and name in multiprocess mode */ ObjectClass *oc = object_get_class(OBJECT(cpu)); const char *cpu_model = object_class_get_name(oc); - g_autofree char *cpu_name; - cpu_name = object_get_canonical_path_component(OBJECT(cpu)); + g_autofree char *cpu_name = + object_get_canonical_path_component(OBJECT(cpu)); g_string_printf(rs, "%s %s [%s]", cpu_model, cpu_name, cpu->halted ? "halted " : "running"); } else { From patchwork Wed Mar 25 09:21:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Qun X-Patchwork-Id: 1261244 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48nN4H6sYvz9sQt for ; Wed, 25 Mar 2020 20:24:47 +1100 (AEDT) Received: from localhost ([::1]:60884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH2HF-00064A-T2 for incoming@patchwork.ozlabs.org; Wed, 25 Mar 2020 05:24:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52654) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH2Ep-0003ND-Bk for qemu-devel@nongnu.org; Wed, 25 Mar 2020 05:22:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jH2Eo-0007vk-Dl for qemu-devel@nongnu.org; Wed, 25 Mar 2020 05:22:15 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:58828 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jH2Eo-0007ni-1c; Wed, 25 Mar 2020 05:22:14 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id C909F889F01F33829259; Wed, 25 Mar 2020 17:22:05 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Mar 2020 17:21:59 +0800 From: Chen Qun To: , Subject: [PATCH 2/3] virtio-crypto: fix 80-char limit violations in virtio_crypto_device_realize() Date: Wed, 25 Mar 2020 17:21:36 +0800 Message-ID: <20200325092137.24020-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200325092137.24020-1-kuhn.chenqun@huawei.com> References: <20200325092137.24020-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen Qun , Euler Robot , zhang.zhanghailiang@huawei.com, laurent@vivier.eu Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Fix: aa8f057e74ae Reported-by: Euler Robot Signed-off-by: Chen Qun --- hw/virtio/virtio-crypto.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c index 4c65114de5..eb4a9e4e85 100644 --- a/hw/virtio/virtio-crypto.c +++ b/hw/virtio/virtio-crypto.c @@ -786,7 +786,8 @@ static void virtio_crypto_device_realize(DeviceState *dev, Error **errp) error_setg(errp, "'cryptodev' parameter expects a valid object"); return; } else if (cryptodev_backend_is_used(vcrypto->cryptodev)) { - char *path = object_get_canonical_path_component(OBJECT(vcrypto->conf.cryptodev)); + char *path = object_get_canonical_path_component( + OBJECT(vcrypto->conf.cryptodev)); error_setg(errp, "can't use already used cryptodev backend: %s", path); g_free(path); return; From patchwork Wed Mar 25 09:21:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chen Qun X-Patchwork-Id: 1261242 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48nN265Cpxz9sQt for ; Wed, 25 Mar 2020 20:22:54 +1100 (AEDT) Received: from localhost ([::1]:60860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH2FQ-0003P5-L6 for incoming@patchwork.ozlabs.org; Wed, 25 Mar 2020 05:22:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52651) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jH2Ep-0003NC-A4 for qemu-devel@nongnu.org; Wed, 25 Mar 2020 05:22:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jH2Eo-0007ve-Cn for qemu-devel@nongnu.org; Wed, 25 Mar 2020 05:22:15 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:58820 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jH2Eo-0007nh-1R; Wed, 25 Mar 2020 05:22:14 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id CCE4039DC149207BF30C; Wed, 25 Mar 2020 17:22:05 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Mar 2020 17:22:00 +0800 From: Chen Qun To: , Subject: [PATCH 3/3] crypto: Redundant type conversion for AES_KEY pointer Date: Wed, 25 Mar 2020 17:21:37 +0800 Message-ID: <20200325092137.24020-4-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200325092137.24020-1-kuhn.chenqun@huawei.com> References: <20200325092137.24020-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen Qun , Euler Robot , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , zhang.zhanghailiang@huawei.com, laurent@vivier.eu Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Fix: eaec903c5b8 Reported-by: Euler Robot Signed-off-by: Chen Qun Acked-by: Daniel P. Berrangé Reviewed-by: Laurent Vivier --- Cc: "Daniel P. Berrangé" --- crypto/cipher-builtin.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c index bf8413e71a..99d6280a16 100644 --- a/crypto/cipher-builtin.c +++ b/crypto/cipher-builtin.c @@ -133,8 +133,7 @@ static void qcrypto_cipher_aes_xts_encrypt(const void *ctx, { const QCryptoCipherBuiltinAESContext *aesctx = ctx; - qcrypto_cipher_aes_ecb_encrypt((AES_KEY *)&aesctx->enc, - src, dst, length); + qcrypto_cipher_aes_ecb_encrypt(&aesctx->enc, src, dst, length); } @@ -145,8 +144,7 @@ static void qcrypto_cipher_aes_xts_decrypt(const void *ctx, { const QCryptoCipherBuiltinAESContext *aesctx = ctx; - qcrypto_cipher_aes_ecb_decrypt((AES_KEY *)&aesctx->dec, - src, dst, length); + qcrypto_cipher_aes_ecb_decrypt(&aesctx->dec, src, dst, length); }