From patchwork Fri Mar 20 09:41:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 1258752 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48kJgg5BDtz9sRN; Fri, 20 Mar 2020 20:41:19 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jFE9U-0005Ux-1D; Fri, 20 Mar 2020 09:41:16 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jFE9S-0005Ur-Gs for fwts-devel@lists.ubuntu.com; Fri, 20 Mar 2020 09:41:14 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jFE9S-0007gC-7R; Fri, 20 Mar 2020 09:41:14 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH][V2] Makfile: add more warning flags to ensure we catch more issues Date: Fri, 20 Mar 2020 09:41:13 +0000 Message-Id: <20200320094113.883444-1-colin.king@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: Colin Ian King Increase the build warning checks to catch bad code. This builds with gcc 9.3, gcc 10.0, clang 9 and clang 10 without issues. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- V2: remove -Wmissing-format-attribute, I'll try and get that sorted for a later release. --- src/Makefile.am | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 904fc020..e0093aef 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -15,7 +15,12 @@ AM_CPPFLAGS = \ `pkg-config --silence-errors --cflags json-c` \ -pthread `pkg-config --cflags glib-2.0 gio-2.0` \ -Wall -Werror -Wextra \ - -Wno-address-of-packed-member + -Wno-address-of-packed-member \ + -Wfloat-equal -Wmissing-declarations \ + -Wno-long-long -Wredundant-decls -Wshadow \ + -Wno-missing-field-initializers \ + -Wno-missing-braces -Wno-sign-compare \ + -Wno-multichar -Wcast-qual bin_PROGRAMS = fwts