From patchwork Tue Mar 10 13:09:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Taihsiang Ho (tai271828)" X-Patchwork-Id: 1252145 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48cFpQ59S3zB3x5; Wed, 11 Mar 2020 00:11:08 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jBef1-0004qS-DW; Tue, 10 Mar 2020 13:11:03 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jBeey-0004po-P1 for kernel-team@lists.ubuntu.com; Tue, 10 Mar 2020 13:11:00 +0000 Received: from mail-wr1-f70.google.com ([209.85.221.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jBeey-0003Vo-Gp for kernel-team@lists.ubuntu.com; Tue, 10 Mar 2020 13:11:00 +0000 Received: by mail-wr1-f70.google.com with SMTP id t14so6733167wrs.12 for ; Tue, 10 Mar 2020 06:11:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=tBN8Sscq1ADf3KyhabSOyVGynPvUK5MtOFvCiBU7WZY=; b=M2dRFh2FNhgzRSLZ1fPbtsqdQlRl4euppoMCSrwZKMiN1577Peaxi4imlbHwMaKS4k IPWoJVpJpuIAHThk/p38SE6tppeVMuIpqo3gWvBOFwxUDn5KoDCsRWeEIOUktEfQ7crn xbiTfwjeGA2DlrUszAfafW1K7+QZ5g/R6SW7yZPQ9WKB6SbdeStdKK5PcgNlzBSUHJ/l oUuNODiAmvQScu6UYADO6RJDiDTEgj+wALAb6JuouEi1i2Fuw9BUMcIPxCzeRjmSu17d 1LZcxpvLk+LEhFLUet8UzAclSUZg/q3XyC2IfX/yYYqeJAAWP63tkva+jdCpI8NjO1ML I4wA== X-Gm-Message-State: ANhLgQ0VXVjAK3kgKbx/BBreiqxxcLsgVpY/MIvm2r1X8hFwme3Z2/b/ UjgBXAeWHNqhCxFA/ZGg9MFllz/5EaK5NKWSZ2GMgO+PvJzHrnI8ranDuZkhvQR6i4fx4D3VpJN TBkG4wwzaPkk2ychOUEZDGC+PIpVg9FBGrXno+/FhPA== X-Received: by 2002:a5d:4104:: with SMTP id l4mr26875350wrp.55.1583845859949; Tue, 10 Mar 2020 06:10:59 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuHwmDLZu/zbiGdeXDE24QhjffdPgepQAY18ibwxGStDoulnNfTMAYY/6zMlqiCVbcgU9S00g== X-Received: by 2002:a5d:4104:: with SMTP id l4mr26875341wrp.55.1583845859758; Tue, 10 Mar 2020 06:10:59 -0700 (PDT) Received: from localhost.localdomain (2001-1c02-0b0d-8800-e8c4-f1c7-b290-aeee.cable.dynamic.v6.ziggo.nl. [2001:1c02:b0d:8800:e8c4:f1c7:b290:aeee]) by smtp.gmail.com with ESMTPSA id v8sm64056972wrw.2.2020.03.10.06.10.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 06:10:59 -0700 (PDT) From: "Taihsiang Ho (tai271828)" To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/1][SRU][B] net: hns3: fix ETS bandwidth validation bug Date: Tue, 10 Mar 2020 14:09:59 +0100 Message-Id: <20200310130959.9523-2-taihsiang.ho@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200310130959.9523-1-taihsiang.ho@canonical.com> References: <20200310130959.9523-1-taihsiang.ho@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Yonglong Liu BugLink: http://bugs.launchpad.net/bugs/1859569 Some device only support 4 TCs, but the driver check the total bandwidth of 8 TCs, so may cause wrong configurations write to the hw. This patch uses hdev->tc_max to instead HNAE3_MAX_TC to fix it. Fixes: e432abfb99e5 ("net: hns3: add common validation in hclge_dcb") Signed-off-by: Yonglong Liu Signed-off-by: Huazhong Tan Signed-off-by: David S. Miller (cherry picked from commit c2d56897819338eb0ba8b93184f7d10329b36653) Signed-off-by: Taihsiang Ho (tai271828) Acked-by: Kleber Sacilotto de Souza Acked-by: Po-Hsu Lin --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c index af6ef1e70378..16b7e3ad6c2b 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c @@ -126,7 +126,7 @@ static int hclge_ets_validate(struct hclge_dev *hdev, struct ieee_ets *ets, if (ret) return ret; - for (i = 0; i < HNAE3_MAX_TC; i++) { + for (i = 0; i < hdev->tc_max; i++) { switch (ets->tc_tsa[i]) { case IEEE_8021QAZ_TSA_STRICT: if (hdev->tm_info.tc_info[i].tc_sch_mode !=