From patchwork Sun Mar 1 12:03:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Nick Erdmann X-Patchwork-Id: 1247275 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=nirf.de Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48VhqB6vY4z9sQt for ; Sun, 1 Mar 2020 23:07:32 +1100 (AEDT) Received: from localhost ([::1]:48014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8NNZ-000523-Dh for incoming@patchwork.ozlabs.org; Sun, 01 Mar 2020 07:07:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59858) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8NLq-00051f-RH for qemu-devel@nongnu.org; Sun, 01 Mar 2020 07:05:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8NLp-0003f0-Sz for qemu-devel@nongnu.org; Sun, 01 Mar 2020 07:05:42 -0500 Received: from photon.nirf.de ([147.135.208.3]:44708) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8NLp-0003e2-LK; Sun, 01 Mar 2020 07:05:41 -0500 Received: from [10.68.247.14] (pc-68-247.ram.rwth-aachen.de [137.226.68.247]) by photon.nirf.de (Postfix) with ESMTPSA id 8AF7E4342F; Sun, 1 Mar 2020 13:05:32 +0100 (CET) To: qemu-devel@nongnu.org From: Nick Erdmann Subject: [PATCH] vhost-vsock: fix error message output Message-ID: <04df3f47-c93b-1d02-d250-f9bda8dbc0fa@nirf.de> Date: Sun, 1 Mar 2020 13:03:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 147.135.208.3 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" error_setg_errno takes a positive error number, so we should not invert errno's sign. Signed-off-by: Nick Erdmann Reviewed-by: Ján Tomko Reviewed-by: Laurent Vivier Reviewed-by: Stefano Garzarella Reviewed-by: Stefan Hajnoczi --- hw/virtio/vhost-vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/hw/virtio/vhost-vsock.c b/hw/virtio/vhost-vsock.c index 66da96583b..9f9093e196 100644 --- a/hw/virtio/vhost-vsock.c +++ b/hw/virtio/vhost-vsock.c @@ -325,7 +325,7 @@ static void vhost_vsock_device_realize(DeviceState *dev, Error **errp) } else { vhostfd = open("/dev/vhost-vsock", O_RDWR); if (vhostfd < 0) { - error_setg_errno(errp, -errno, + error_setg_errno(errp, errno, "vhost-vsock: failed to open vhost device"); return; }