From patchwork Mon Feb 24 10:19:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Ivanov X-Patchwork-Id: 1242993 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cambridgegreys.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20170209 header.b=MIZ5PEQs; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48Qyjm6hV7z9sPk for ; Mon, 24 Feb 2020 21:19:56 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WOgptDYXX+Y/eeiFINRhUUa2vtpotKxqYN0AJznAFp8=; b=MIZ5PEQsMgwch0 jU+4gIRmRj+pRfMF7eVrMUoXHGm8kXkHv6T2DmmiitEX7TwQHHNI7FzRhA/34n8hjVYx10IpV5FyN IOc6ZWtB+MjlsrPiuiWJKa3ZyfLtVB+ElOcFjcutpGUKyRumIGRT4Uv2/tldve60LDOLcSSKpa4qf jXt+oqgOAbsTA2XAA5ovU/vcN7oVMWZO74K0yA3HC7OSCefGPr5bvK+yJ6NbRk0LTnLSnX15AiPEL 3eU4s11BW8RHbJnhDIs3PZGjigzBczSdbZSWtba1Ashc87tGegbMvFSdUf4h+mJqYJz8hT5PFzz7y xtJR/Kei9I1Ybx/rtjyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6Aq4-00077e-6w; Mon, 24 Feb 2020 10:19:48 +0000 Received: from ivanoab7.miniserver.com ([37.128.132.42] helo=www.kot-begemot.co.uk) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6Aq0-00076U-Lx for linux-um@lists.infradead.org; Mon, 24 Feb 2020 10:19:46 +0000 Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j6Aps-0004p1-6Q; Mon, 24 Feb 2020 10:19:38 +0000 Received: from jain.kot-begemot.co.uk ([192.168.3.3]) by jain.kot-begemot.co.uk with esmtp (Exim 4.92) (envelope-from ) id 1j6Api-0003hm-NT; Mon, 24 Feb 2020 10:19:31 +0000 From: anton.ivanov@cambridgegreys.com To: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-um@lists.infradead.org Subject: [PATCH v2] virtio: Work around frames incorrectly marked as gso Date: Mon, 24 Feb 2020 10:19:12 +0000 Message-Id: <20200224101912.14074-1-anton.ivanov@cambridgegreys.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Spam-Score: -1.0 X-Spam-Score: -0.7 X-Clacks-Overhead: GNU Terry Pratchett X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200224_021944_720173_76DA9C90 X-CRM114-Status: UNSURE ( 9.13 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.4 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (0.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jasowang@redhat.com, Anton Ivanov , eric.dumazet@gmail.com, mst@redhat.com Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Anton Ivanov Some of the locally generated frames marked as GSO which arrive at virtio_net_hdr_from_skb() have no GSO_TYPE, no fragments (data_len = 0) and length significantly shorter than the MTU (752 in my experiments). This is observed on raw sockets reading off vEth interfaces in all 4.x and 5.x kernels I tested. These frames are reported as invalid while they are in fact gso-less frames. This patch marks the vnet header as no-GSO for them instead of reporting it as invalid. Signed-off-by: Anton Ivanov Reported-by: kbuild test robot Acked-by: Michael S. Tsirkin --- include/linux/virtio_net.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h index 0d1fe9297ac6..94fb78c3a2ab 100644 --- a/include/linux/virtio_net.h +++ b/include/linux/virtio_net.h @@ -100,8 +100,8 @@ static inline int virtio_net_hdr_from_skb(const struct sk_buff *skb, { memset(hdr, 0, sizeof(*hdr)); /* no info leak */ - if (skb_is_gso(skb)) { - struct skb_shared_info *sinfo = skb_shinfo(skb); + struct skb_shared_info *sinfo = skb_shinfo(skb); + if (skb_is_gso(skb) && sinfo->gso_type) { /* This is a hint as to how much should be linear. */ hdr->hdr_len = __cpu_to_virtio16(little_endian,