From patchwork Sat Feb 22 21:31:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Duskett X-Patchwork-Id: 1242559 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Bc90PkQn; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48Q1k62BP1z9sRQ for ; Sun, 23 Feb 2020 08:31:58 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id B0FAD8488E; Sat, 22 Feb 2020 21:31:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0ICFdH3AaN1A; Sat, 22 Feb 2020 21:31:52 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 6DF1884A92; Sat, 22 Feb 2020 21:31:52 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 868C61BF302 for ; Sat, 22 Feb 2020 21:31:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 7C49A80A10 for ; Sat, 22 Feb 2020 21:31:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BvhZXtI35JD3 for ; Sat, 22 Feb 2020 21:31:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by whitealder.osuosl.org (Postfix) with ESMTPS id 7C25380A04 for ; Sat, 22 Feb 2020 21:31:46 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id a14so2513166pgb.11 for ; Sat, 22 Feb 2020 13:31:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K6CQeEOUsiwMpZWq0R/sTtk6tEv8IIOeuRQVfu+G3t4=; b=Bc90PkQniRHKlhTxtgcspUjehst4eXVqOHAlkdcdSnbB6AUqbLduKWIt7xR8jFSyDq 2qW+v87oOWznfkAZD2TJQVl/ZnvjBBlf128st6Qwtx7dkTdxe0iseJ0Rd7qH0xztqbKj 5rhuPWaS2uhvJsfrZ1pp6cxG1ab8VempQursJIljqo+mNWlqQv8Mkuej4UYDo1c32e3/ PcnXlibYM1NtbxskINEn3JrBK9UMhbqD6SVFdoHqriul/UG2A7Nq9jZQRqZ+zOFwBaoJ hiM8zL/4t6mZNtKYt9OYatkpPOM3FcJwzLZLzjaMRjQqcjl7rdvLkSOhmE+D73yQ/LwV 5l9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K6CQeEOUsiwMpZWq0R/sTtk6tEv8IIOeuRQVfu+G3t4=; b=EsaAgdGdhgmDplGa87OM59L4byU/ILHvU/EevDiTfCPiMipCgeH0s/yXYIdua9avWJ gXmkDQCovVq24/q3Kex2BdG0sOGwlpq4YJGH5gcWhFu/SOfNJzkeMU7VK4BIlm5P8Wor HJlX79ChIi1cF54KjhZHP4yBpcRLijrDeTMLvbwRmHLB7rj1pYIuZhTMAcMcAEZZa4iw GoD6S6G1A9/trhF4lWebn8r8esp41UFAXJqhh5p5ATEPC52D/dv2gS/85b55OixsuAmi zOvDiNoUGotreE4bOKz4PooA2heSVgCv+yt7kRTtuoFPmAGxjk8gexHTK2EfN0QTcNQ1 VI8w== X-Gm-Message-State: APjAAAV6CQ2r2fJAJuTwbixl2UR+CnVuqHGJsQG4O64jmpsYRq6lx7nt SjAoZ7KrHTpw2m3pL9tIt6d9kTK5+zI= X-Google-Smtp-Source: APXvYqyOWGEawrRV7BbchJfwlvxE8z1ev5FoxcZliKjcEws5Z8ShcTcDGZYJMIwsCpLvf1bFTBNkQg== X-Received: by 2002:aa7:9e0b:: with SMTP id y11mr46571527pfq.182.1582407105338; Sat, 22 Feb 2020 13:31:45 -0800 (PST) Received: from localhost.localdomain ([47.149.8.172]) by smtp.gmail.com with ESMTPSA id a9sm6892374pjk.1.2020.02.22.13.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Feb 2020 13:31:44 -0800 (PST) From: aduskett@gmail.com To: buildroot@buildroot.org Date: Sat, 22 Feb 2020 13:31:42 -0800 Message-Id: <20200222213142.2213941-1-aduskett@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/1] package/gobject-introspection: depend on python3 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Adam Duskett Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Adam Duskett Currently, the Config.in file has the line: select BR2_PACKAGE_PYTHON3 if !BR2_PACKAGE_PYTHON This line is incorrect as gobject-introspection does not support python2. Instead, remove the select line and make python3 a dependency with a new message that explains that gobject-introspection requires python3. Note: gobject-introspection does not require python3 to run on the target; however, because the tools run in a qemu wrapper, a cross-compiled python3 must be installed to staging. As there is no current mechanism to tell Buildroot only to install python to staging, then python must also be installed unconditionally to the target when building gobject-introspection. Signed-off-by: Adam Duskett --- package/gobject-introspection/Config.in | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/package/gobject-introspection/Config.in b/package/gobject-introspection/Config.in index 0537cc0404..26ca5d6e3a 100644 --- a/package/gobject-introspection/Config.in +++ b/package/gobject-introspection/Config.in @@ -9,11 +9,11 @@ config BR2_PACKAGE_GOBJECT_INTROSPECTION # can be verified. depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 depends on BR2_TOOLCHAIN_USES_GLIBC + depends on BR2_PACKAGE_PYTHON3 select BR2_PACKAGE_HOST_QEMU select BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE select BR2_PACKAGE_LIBFFI select BR2_PACKAGE_LIBGLIB2 - select BR2_PACKAGE_PYTHON3 if !BR2_PACKAGE_PYTHON select BR2_PACKAGE_ZLIB help GObject introspection is a middleware layer between C @@ -25,6 +25,9 @@ config BR2_PACKAGE_GOBJECT_INTROSPECTION https://wiki.gnome.org/action/show/Projects/GObjectIntrospection +comment "gobject-introspection needs python3" + depends on !BR2_PACKAGE_PYTHON3 + comment "gobject-introspection needs a glibc toolchain, gcc >= 4.9" depends on BR2_USE_MMU depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS