From patchwork Mon Feb 17 21:09:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 1239586 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=HFLzAI0Q; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48LxSY6jjhz9sPK for ; Tue, 18 Feb 2020 08:09:33 +1100 (AEDT) Received: from localhost ([::1]:53148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3ndz-0003ob-RA for incoming@patchwork.ozlabs.org; Mon, 17 Feb 2020 16:09:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41583) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3ndd-0003h4-No for qemu-devel@nongnu.org; Mon, 17 Feb 2020 16:09:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3ndc-0008TE-Qq for qemu-devel@nongnu.org; Mon, 17 Feb 2020 16:09:09 -0500 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:36826) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j3nda-0008Re-Rf; Mon, 17 Feb 2020 16:09:06 -0500 Received: by mail-pg1-x542.google.com with SMTP id d9so9862349pgu.3; Mon, 17 Feb 2020 13:09:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=GQgJidPFXL9L+5VnERG3WiMD3P/4Nq4D9jL2IVB/SHk=; b=HFLzAI0Qz2d9N2KTZKMjXm/yrQNnfkPwI22PNo2Tbt/FX4R0TjCJBrC88mBMYIuFOi RMj+6OQTwxEVd4gvGHCy+o6yG4N2uAGms7NFTbCTggjLFT279LQulPDQ7nPViHYL+Pjx ORqmWuIXXV9drPQn9jwkEWN5qOrhB+A2cm89+uMkS8wDPOxSgSP9DCRuBhLvg7fYZFfL YGgilcVnHgcPQymtbrq4KaCyQt0g8DeHhv5R6R/sS55HQhANjzZRITFCRcIsDWvj1r+P IV/Y6/2jeEyPqgC5lO/0wBNUVwSOhuh9dpLtR/9S65j3CIzFRDW+VTdhmoL64IMaZ65h aRmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=GQgJidPFXL9L+5VnERG3WiMD3P/4Nq4D9jL2IVB/SHk=; b=SPZB6x5mb3LKsOu5osu2HCJM/zWE7HxDfM3a3jb7Vrr1pRsuiRZ+YthEpjoOWaYCuI 4/ZIbpwsvu2OSRjaklIZ/eYBinXHKvVyA9Fg5S72YydBlDQu3KBhyV6Jkrj2wlwb1zYC R+ZCIHdnyjoVM1wh7t9KaceBeITZtdi7gzVeSdZJOx5+WJAQUfGqosoKpMSHgOTfrTVl vy/APJxFMz0SZFIT1H9fMW8Glq3MbsPcA+z3Wh/s1jRS/MdcIaTWjmsrcq8+nYRbroMA VkTYC+KqOWtgnycf5JpSECiSbtpZdvQY4sDv9y44TY0KI+F+mkRuWEC+HQBaEZMtWHsA zfmQ== X-Gm-Message-State: APjAAAWXW0c0FC5FFl2qg9dvYIPpjZfN+tLPhfgTnq4vK/ny0UVcnl/K 3ouNMD3edBjfEEy4zFqP8co= X-Google-Smtp-Source: APXvYqw22Y7+GUItDenCv8bMW2LrO43v/OZYYuWqrBUGKaG8E4TP2qhCaBXpS6MITeUMMQ90rro+yg== X-Received: by 2002:a63:d845:: with SMTP id k5mr18675513pgj.183.1581973745917; Mon, 17 Feb 2020 13:09:05 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id e9sm344058pjt.16.2020.02.17.13.09.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Feb 2020 13:09:05 -0800 (PST) From: Guenter Roeck To: Peter Maydell Subject: [PATCH] z2: Make providing flash images non-mandatory Date: Mon, 17 Feb 2020 13:09:03 -0800 Message-Id: <20200217210903.18602-1-linux@roeck-us.net> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::542 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Guenter Roeck Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Up to now, the z2 machine only boots if a flash image is provided. This is not really necessary; the machine can boot from initrd or from SD without it. At the same time, having to provide dummy flash images is a nuisance and does not add any real value. Make it optional. Signed-off-by: Guenter Roeck Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/z2.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/arm/z2.c b/hw/arm/z2.c index 34794fe3ae..4bb237f22d 100644 --- a/hw/arm/z2.c +++ b/hw/arm/z2.c @@ -314,12 +314,6 @@ static void z2_init(MachineState *machine) be = 0; #endif dinfo = drive_get(IF_PFLASH, 0, 0); - if (!dinfo && !qtest_enabled()) { - error_report("Flash image must be given with the " - "'pflash' parameter"); - exit(1); - } - if (!pflash_cfi01_register(Z2_FLASH_BASE, "z2.flash0", Z2_FLASH_SIZE, dinfo ? blk_by_legacy_dinfo(dinfo) : NULL, sector_len, 4, 0, 0, 0, 0, be)) {