From patchwork Mon Feb 17 18:17:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 1239492 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=QGE0Y8lV; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48Lsfv0cmrz9s29 for ; Tue, 18 Feb 2020 05:18:11 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D05D38105A; Mon, 17 Feb 2020 19:18:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QGE0Y8lV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3B863811F9; Mon, 17 Feb 2020 19:18:02 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B4AD38082C for ; Mon, 17 Feb 2020 19:17:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-qk1-x742.google.com with SMTP id h4so17087829qkm.0 for ; Mon, 17 Feb 2020 10:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=QeL13d4ZxzTbnn+Ua4E8pLWjhaZrddJIS0DSTenqRAA=; b=QGE0Y8lVt6+zUlVFhM+wUP/hHeX1JKq6yMLeB+Xslh+Es11ZDUtjj8jlcdfllG7q4u 1rn8IA2DVzxueB8qe3CDYTFjnpmqXLvrX4tRMxoG/UDaXlxsQkYjMKTlwJtYVS4PrsmJ eYQUosL2IgeNCiK8USpYmx7N8jgatPc+raQ0NmcQVt70ic2N0actqkopMPyH05V2nZy0 9SsMH4PHJHVQAjV/RG+Jye9oVIMQxk/qsKapfsmPNDJ7fnuJ/5dqL0FVwo7BN/T9wXMT b86jJVt3xD2JwxQCF14cJQchYIgTOkS1Zd3AcY0fqgGSX2mfZ0lwJwMMm/dZBULPm/MT L04g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QeL13d4ZxzTbnn+Ua4E8pLWjhaZrddJIS0DSTenqRAA=; b=MstGCDXBvAKAf6xfj27tm4nvOQT8wruRkMPd97iJTkRUHbuqkeWd+haxHWetXzCq7+ m/oHLDptL/IopEf4dXm6T0LIMW5TY6mhsaVlilmO3lxp0kLyGQhwy/JNrBt5lw2lu3l/ RtXhLF475SMEJ0bXTh35hsSxJVYMlC7fxerGB1Pxs65J6pNUdYbcyL4EGWI2sR8IfMJL UkhQmjm5BayIjvGOP1KkUo76aS5ukX+zs+uHuaqMhqpvffzCnilIUgm6btVZ+qXUdu9Y LzsAcGz3sfAXjooVTmn3N21M3caES+Y8JWrj0pvRbvReSQ+sCegUXFFmWv7Lm9fCqhNR whLw== X-Gm-Message-State: APjAAAU+Tt0eIyYbRhsd7PoVex8ggOsHZr8gx5y/7OH9G8IO8+nugVGy qoDD2Lrtao3x8rjgzi0ur6U= X-Google-Smtp-Source: APXvYqwXsrLkb0+BXr+pRKvVdO3Qd53GbH1kFghty+ltLgfI6jSVkKWrdXkp10Hsueh30Rb3BHrDJg== X-Received: by 2002:a05:620a:1656:: with SMTP id c22mr16006162qko.144.1581963477480; Mon, 17 Feb 2020 10:17:57 -0800 (PST) Received: from fabio-Latitude-E5450.nxp.com ([177.221.114.206]) by smtp.gmail.com with ESMTPSA id c45sm584595qtd.43.2020.02.17.10.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 10:17:56 -0800 (PST) From: Fabio Estevam To: sbabic@denx.de Cc: peng.fan@nxp.com, u-boot@lists.denx.de, agust@denx.de, Fabio Estevam Subject: [PATCH] imx8qxp_mek: Fix the console command line string Date: Mon, 17 Feb 2020 15:17:01 -0300 Message-Id: <20200217181701.25642-1-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.1 at phobos.denx.de X-Virus-Status: Clean Currently the expansion of the console variable leads to the following kernel command line: console=ttyLP0,${baudrate} earlycon root=/dev/mmcblk1p2 rootwait rw , which causes the console to not show characters after the LPUART driver is probed as the 'baudrate' variable is not properly translated. Fix it by splitting the console variable in two parts: one for the ttyLP0 part and the other one for the baudrate, which matches the way it is done on other i.MX targets. Tested by successfully booting a mainline kernel on a i.MX8QXP MEK board. Signed-off-by: Fabio Estevam --- Anatolij's patch is needed for booting: https://lists.denx.de/pipermail/u-boot/2020-February/400417.html include/configs/imx8qxp_mek.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/configs/imx8qxp_mek.h b/include/configs/imx8qxp_mek.h index 81ac4b52f3..0aaca3325b 100644 --- a/include/configs/imx8qxp_mek.h +++ b/include/configs/imx8qxp_mek.h @@ -65,7 +65,7 @@ "script=boot.scr\0" \ "image=Image\0" \ "panel=NULL\0" \ - "console=ttyLP0,${baudrate} earlycon\0" \ + "console=ttyLP0\0" \ "fdt_addr=0x83000000\0" \ "fdt_high=0xffffffffffffffff\0" \ "boot_fdt=try\0" \ @@ -76,7 +76,7 @@ "mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \ "mmcroot=" CONFIG_MMCROOT " rootwait rw\0" \ "mmcautodetect=yes\0" \ - "mmcargs=setenv bootargs console=${console} root=${mmcroot}\0 " \ + "mmcargs=setenv bootargs console=${console},${baudrate} root=${mmcroot}\0 " \ "loadbootscript=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ "bootscript=echo Running bootscript from mmc ...; " \ "source\0" \ @@ -104,7 +104,7 @@ "echo wait for boot; " \ "fi;" \ "fi;\0" \ - "netargs=setenv bootargs console=${console} " \ + "netargs=setenv bootargs console=${console},${baudrate} " \ "root=/dev/nfs " \ "ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \ "netboot=echo Booting from net ...; " \