From patchwork Sat Feb 15 20:38:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1238631 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=aOHnkeue; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48KhtG1Bpgz9s29 for ; Sun, 16 Feb 2020 07:39:02 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4241081200; Sat, 15 Feb 2020 21:38:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="aOHnkeue"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7C0DF810E3; Sat, 15 Feb 2020 21:38:55 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 07759810E3 for ; Sat, 15 Feb 2020 21:38:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1581799132; bh=TFZXbVTg4+li5PQfw3sU6JxFszrinEILNrtDXQnVG1U=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=aOHnkeuePpA1xZOcbk9NeC3SpYBy0E4tkzkyoSnE1HA1YMjgTqZVSy954GGH8Ckon RfrVh0cM6LUXH6TkSEszbbzzTShb3cN1unGoIakrPS6eZnOXc+bYuoVeg1eu/4WuOJ o5zz7eKmTCo0e25vQdq2ldMqyhpD2GsZHIDCWjxE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([84.119.33.160]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N6bfq-1jXP0P3ed4-0182sT; Sat, 15 Feb 2020 21:38:51 +0100 From: Heinrich Schuchardt To: Simon Glass Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] dm: core: remove redundant if statement Date: Sat, 15 Feb 2020 21:38:48 +0100 Message-Id: <20200215203848.17823-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:4vcFV8FSgkr63QfYe9YrzoOMSy54RlIhhbj4IscDJmrwmewTZpa gyH4i51LcluQaLft3dLF0nzgkJnYOT574RuVDg4d0VY+dXR0YqrszbpvOT8z3kHXlBuUc3C S7ZJRpmr3iNc64JqQPFWgv8owUn/ZzVrIqovOtzpsQYYcAX+TJ3OpXntGz1gDKSDIeHedMD sxox/6j/xbL4MXSlsYGLA== X-UI-Out-Filterresults: notjunk:1; V03:K0:EP9aLOF5Sa8=:7y6hXIxe3VzjNBX8EhnhSk 7MEQsYeRGmzPeChtv7rxeTynZuqHdIQHaYmRoZWqVGhpAOh6tV284nBkma+XE7KxX5HCB9+7W zxPiuXH/vDEMfliIhJTpw5BRttS23cKZW4uktWy2P6EIcCRs2Npjh6oXIdSFjTWwqbp2Nbv5N cgeQyshS00e+eLagaVJdPdsV3q/ebX/AnO/IvOG3geNVSZXJMsSYPvEPVtNBMxoQRqo+b55TC dhh4YxkMRj78EjRil3tGefQtE8UvOcp2dgdHRqzZTohY2vh57uUnkF6lU9/1x1Vd5dPKmRJH3 lLcl6WRrkOgVnJdU0j3ikuW9egCTxVo8KGJxUxBc2HmfkD5YLGLVO5+L53GTnMlePd0VayBSW Fa/4cewFckpSC/HbZAWjv5GB1KJhgroPyKFn2CufbkxRaC7oTY2j7LMIux9UeMl2NDFCfy+/U +3e9J9l47qWs5zBqBO5g//zVb24Xmg+iHOKz/FWfvCE3X4wcZ2f8d4YwQBnw3ezWhv3kBQNow mg8Uk3xB4CI9xV4GGxbGB1gDrrEt/ello/iEtlNPf0xDYWqaHmM2Zx/PI30StnQlvFq8KjCn5 mXQ3vs+sLIoSeSpVdGygM/o4uxKthndBfh5mXFTxOzV4EJjR92pLrGedDEflqzbfO07SmZdPX N09YaDMT3MCAktHucmVLpmNVfH98ruztwF1ILcKNDllZUofDyOjy2zYl3GPY9kZu2atxpZt4e Fufcth72aWIzdpLXDqm1JCaQpgEEjqEuMYGjtD8+pP+mdctdiTBhOOyiFwyWK6OqH7/7+XsMt yj3nrPiv8cIQOmysk7VX5hlJSIKCRsHmAgyLsl4oWwGlHLOJlHwdizw4uE6KBnadrLp5YHcdC qn7lotztsrIKXlIxPfORa3SY9UDsQey39z4QRXi6xWEJWdDuBXGWEEbIzxF5M29AgWrO8c7FQ oiHOaxKwiAsUgcr03O3Kpzm0N/aOzLH4U1LljTAqGf2UYlXM8LCiHkbPLFiZQHvpals1K/fzw LpB7/zO2Im/yF6jil8eU23/FPW6Q5CPvdsxGfjJ6TqHs2cpXOdTfSha7aFMdOgqTlVDVikS8Y 4QZtaYriThNRLPwszJV8lPHhJhQhgpLIzqh19Lp1TJm44JCa3DxJn6ax2QgS5BZ/WOwV2h8Hs WnzTrPL4GNymw2gQPkyVvU6A3uH6EbwZEu1O1yYO1qgF5hFdUz5Nc5+hT2zhPC9uh5Asz/Yij 5Jv7nFx7DuO/MsOt4 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.1 at phobos.denx.de X-Virus-Status: Clean The value of parent is not changed in the first if statement. So we can merge the two if statements depending on parent. Indicated by cppcheck. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass Reviewed-by: Simon Glass --- drivers/core/device.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.25.0 diff --git a/drivers/core/device.c b/drivers/core/device.c index 89ea820d48..534cfa7314 100644 --- a/drivers/core/device.c +++ b/drivers/core/device.c @@ -143,11 +143,9 @@ static int device_bind_common(struct udevice *parent, const struct driver *drv, goto fail_alloc3; } } - } - - /* put dev into parent's successor list */ - if (parent) + /* put dev into parent's successor list */ list_add_tail(&dev->sibling_node, &parent->child_head); + } ret = uclass_bind_device(dev); if (ret)