From patchwork Wed Nov 29 23:19:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dragan Stancevic X-Patchwork-Id: 842807 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3ynGhj6HP1z9s84; Thu, 30 Nov 2017 10:19:49 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1eKBdp-00012b-9j; Wed, 29 Nov 2017 23:19:45 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1eKBdn-00012R-SS for kernel-team@lists.ubuntu.com; Wed, 29 Nov 2017 23:19:43 +0000 Received: from mail-it0-f69.google.com ([209.85.214.69]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1eKBdn-0001rn-IR for kernel-team@lists.ubuntu.com; Wed, 29 Nov 2017 23:19:43 +0000 Received: by mail-it0-f69.google.com with SMTP id x32so18873137ita.1 for ; Wed, 29 Nov 2017 15:19:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=zvriduIStRRVoQ0oZutDAajMmbNSjsBzpLuKOP4D1DA=; b=R6tiiEwtfuV934CtntMaGmtDoAFWhCIHlJUpKz5JkH8L8vkNCt5bUGlKIoJavp0u4T lcC809S+fACnpgu4KqPJYyAaTbEY6XD9qFXHZ4UbEQcZX39h7XIzD864nBvNZqlI0iCW ZdokzhLn02uJ51shknQaxCHZbBIXZJ5gkVOexeka6YwKmANBEYMMnhNLj1bPbKn0hGhN SRV8ljEKgtk9ubiORs2sNNppYt71M/TI01k4S1O1DeNTl063kMcLWZe4Dgqr19sdyIh4 LZqXOnRPTP74z65gMpTD+srwBxCcb7s2pWc1W63Ui5NrG75xAWTIPCmoeQk+iXGYu2Gp SZDw== X-Gm-Message-State: AJaThX5AQhwxdE0PlFfmktgF4+Wx+6NzD1CTtQYDp6LfU66sDnpj73nT 9VvIloCQ6a8Q9AmNwhqfO8x7ROyKQk2eWmv5kJjClV452l6RHlQ5Yc12jYB1v5aTzGSvFZe1UCD o+EwStDplyCeU87AhMhnvSk6mCMZD/jDqQ7Z0dXiGbC4+wCTVAFhIpfrGTg== X-Received: by 10.36.162.76 with SMTP id o12mr679956iti.76.1511997582394; Wed, 29 Nov 2017 15:19:42 -0800 (PST) X-Google-Smtp-Source: AGs4zMb8ytDgil7+cUEE23rea7YJNb+Yovh0qHQpJ7XESchnfONGG+U/EvAd/1ZMGeKD8VVsf+Y8X0RjjD6fTo5urYQ= X-Received: by 10.36.162.76 with SMTP id o12mr679944iti.76.1511997582238; Wed, 29 Nov 2017 15:19:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.135.195 with HTTP; Wed, 29 Nov 2017 15:19:41 -0800 (PST) From: Dragan Stancevic Date: Wed, 29 Nov 2017 17:19:41 -0600 Message-ID: Subject: [PATCH][SRU][X] scsi_dh_alua: uninitialized variable in alua_rtpg() To: kernel-team@lists.ubuntu.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Dan Carpenter BugLink: https://bugs.launchpad.net/bugs/1720228 It's possible to use "err" without initializing it. If it happens to be a 2 which is SCSI_DH_RETRY then that could cause a bug. Bart Van Assche pointed out that we should probably re-initialize it for every iteration through the retry loop. Signed-off-by: Dan Carpenter Reviewed-by: Hannes Reinicke Signed-off-by: Martin K. Petersen Signed-off-by: James Bottomley (cherry picked from commit a4bd85203190990ad808abbd4a5dc848a950002c) Signed-off-by: Dragan Stancevic Acked-by: Colin Ian King Acked-by: Kleber Sacilotto de Souza --- drivers/scsi/device_handler/scsi_dh_alua.c | 1 + 1 file changed, 1 insertion(+) if (retval) { diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c index 8eaed05..a655cf2 100644 --- a/drivers/scsi/device_handler/scsi_dh_alua.c +++ b/drivers/scsi/device_handler/scsi_dh_alua.c @@ -532,6 +532,7 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg) return SCSI_DH_DEV_TEMP_BUSY; retry: + err = 0; retval = submit_rtpg(sdev, buff, bufflen, &sense_hdr, pg->flags);