From patchwork Thu Feb 13 08:51:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Matyukevich X-Patchwork-Id: 1237346 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=quantenna.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20170209 header.b=BJ8wBAQj; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=quantenna.com header.i=@quantenna.com header.a=rsa-sha256 header.s=selector1 header.b=PcDz8gxL; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48J9Ll72Rhz9sP7 for ; Thu, 13 Feb 2020 19:54:55 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gg+b0ULUx9p4OMjegkxWpjXYCB6Zuh1df43Xwe/AciY=; b=BJ8wBAQjBKsUKs y5u6jyR1oCl3K/tyRsioJF8bm1Fvq60YyL08mq9LCVGNSPx6XUT9NUuN/VCnVYrEynWli79EK3SMI TH4mSvejSUUjEP81E8tZ1EeFkoZ5XiZrsTOJvrs5AeNVcf/LOSMnaWGZeysY0xVY6PWOOMZNFkwyG zXsOdih1i25y9iV16y5DPwbOcduir9ZnkOqMgEIrj/jqF/+0JYLrCcMY15VCytp1VzI9znHYca/9l kQTd+wXkfJo2q+2Uq5JBW63O1Div4QfYxbtLstFyS0APxZTViObevQ3RBWsWm9j+qEliwa7xqysVE MnXEhj31IHqprY2k2J5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2AGm-0004Gf-94; Thu, 13 Feb 2020 08:54:48 +0000 Received: from mx0a-00183b01.pphosted.com ([67.231.149.44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2AGk-0004Fx-04 for hostap@lists.infradead.org; Thu, 13 Feb 2020 08:54:47 +0000 Received: from pps.filterd (m0048106.ppops.net [127.0.0.1]) by mx0a-00183b01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01D8kGEi028610 for ; Thu, 13 Feb 2020 01:54:45 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2171.outbound.protection.outlook.com [104.47.58.171]) by mx0a-00183b01.pphosted.com with ESMTP id 2y254nnfuw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 13 Feb 2020 01:54:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lAlCMTOXdZqj1DmUCzfhRCxgbWE5Jul9WXf/E8StOSCVks6cZmlYviAmLDzg3Y4T5fMrf6i5DuvvqUQHW7bA5HczGOCcmy4hdg0qYjc9Mxu+OHVLWGwWAqmO3AdHsg4dUTORYDEdN22o7isMTvu6j1jEL4jYdCnID2Dz8Bv3RrS+otIO0AZubtx1B5CLQBqryI4pbabJlWA1pZNz+0oGXWNjs6qbghm/fbRMosH6s1GM8BmZCCxegx7PXVNBc7PD+pmeG/aqc+BgAq82gnj6PcbPIbGxUH+USsUu8speOUnYLG/yax9EcjxcgsRKrOSy6V0c4V3pRx2vhSfzVEoy2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M1Dl9dsZGCvUr8ZWgajDmNUDzShG1aNcgMCxzBPJi0Q=; b=AdHwu0ZPJKWg35AvlbV3yNI8n2xsu4USIA69bZvmkt27uFjnfteExKQL9MkQm3+2Bs54PV3yz6NicdVlwTPC3lHnZygbD0UBXM48BzUbsME8gCqa5ehbuIkqZ6z42MiQEgpK/jL/BEiiDS1rk5HaEPssvxwTXZY/el463vX9sVhlrEciSL6xF3ome4DrPGzk+0/chP0i9V142glkwV0ht/U0czdB0Dfws7JKykZsXhjmzUlxfQiT4ViQL39gK9odcd0jsuNQCt+daV/s39Dir4C9GvAecy2N+kdFqrn/XEo4lnuobiF9h+cZUue6Sx+E3bIpWahelkFvZeIEQkMfcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=quantenna.com; dmarc=pass action=none header.from=quantenna.com; dkim=pass header.d=quantenna.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quantenna.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M1Dl9dsZGCvUr8ZWgajDmNUDzShG1aNcgMCxzBPJi0Q=; b=PcDz8gxLj2FGAtKnuKUfUW28wZ6/bBKI/nn6IXEyxINlqLy4XBsgjvh7MbbwFFECuwvpM7YsstNmeYnP6eVQ3AWlSBXFz4cEv0S/rCDd9Wt5jX3S7zuKOrLyiWDZXBiuJY52A8wyaMbMwAYEvtBtTw9jDw1RdyOarJ+Q99M1l/4= Received: from BYAPR05MB5366.namprd05.prod.outlook.com (20.177.187.25) by BYAPR05MB5126.namprd05.prod.outlook.com (20.177.230.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.9; Thu, 13 Feb 2020 08:54:43 +0000 Received: from BYAPR05MB5366.namprd05.prod.outlook.com ([fe80::86e:d929:ba3d:19cb]) by BYAPR05MB5366.namprd05.prod.outlook.com ([fe80::86e:d929:ba3d:19cb%4]) with mapi id 15.20.2750.007; Thu, 13 Feb 2020 08:54:42 +0000 Received: from SN6PR05MB4928.namprd05.prod.outlook.com (52.135.117.74) by SN6PR05MB5662.namprd05.prod.outlook.com (52.135.110.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.8; Thu, 13 Feb 2020 08:51:22 +0000 Received: from SN6PR05MB4928.namprd05.prod.outlook.com ([fe80::25b7:98a0:c066:1a9]) by SN6PR05MB4928.namprd05.prod.outlook.com ([fe80::25b7:98a0:c066:1a9%6]) with mapi id 15.20.2729.021; Thu, 13 Feb 2020 08:51:22 +0000 Received: from bars.quantenna.com (195.182.157.78) by LO2P265CA0075.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.22 via Frontend Transport; Thu, 13 Feb 2020 08:51:21 +0000 From: Sergey Matyukevich To: "hostap@lists.infradead.org" Subject: [PATCH 1/3] nl80211: pass WPA3 AKM suites to driver Thread-Topic: [PATCH 1/3] nl80211: pass WPA3 AKM suites to driver Thread-Index: AQHV4krDNf6PTxE/wUKw1dFhufZyMQ== Date: Thu, 13 Feb 2020 08:51:21 +0000 Message-ID: <20200213085112.27376-2-sergey.matyukevich.os@quantenna.com> References: <20200213085112.27376-1-sergey.matyukevich.os@quantenna.com> In-Reply-To: <20200213085112.27376-1-sergey.matyukevich.os@quantenna.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0075.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::15) To SN6PR05MB4928.namprd05.prod.outlook.com (2603:10b6:805:9d::10) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.11.0 x-originating-ip: [195.182.157.78] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7fa70313-6005-44c7-d846-08d7b061e63b x-ms-traffictypediagnostic: SN6PR05MB5662:|BYAPR05MB5126: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-moderation-data: 2/13/2020 8:54:40 AM x-ms-oob-tlc-oobclassifiers: OLM:2512; x-forefront-prvs: 031257FE13 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39840400004)(396003)(366004)(136003)(199004)(189003)(2616005)(86362001)(956004)(103116003)(4326008)(8936002)(6486002)(186003)(71200400001)(36756003)(16526019)(478600001)(66476007)(64756008)(66446008)(66556008)(7696005)(66946007)(1076003)(81166006)(107886003)(2906002)(52116002)(26005)(6916009)(5660300002)(316002)(81156014)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR05MB5126; H:BYAPR05MB5366.namprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: quantenna.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0VUgSKqWwo7Y5RX+BIOfUYzeRyI9bkn3GWKv3JDwBGAUeIJWXBbECjv4Dz+iUydQ966rsqf/l0u2+YtKe5kcLFFWNeZA/oCrUF29bfEHYwRwOriGYCQvaZGxgndQyL6dzdStkVJj/pcKeu9PmHbpB5+FbpcZSq2/TDdUMEIb2TW6Ytz7veTug+QGqWUYOlzts39CdgH7HZpPl64NuZkne4wKOAg4fnBliM3PbNiTUXWWru3oyBY3tVn8CvurhFU+IxsdXSGIqp5kVXXvwA1RMbbOjQl9ISvZTxp7DsqkIH+LN/PR5b6B2WHE4ur34ZZnySCrdZhitUl+YhRpxx/Zhxo2uxyEILC56Wg3DeYEv1dGsrCl0PQdl0QBbMRMmSdtXVVQt3eTlcyrVf/WbZc7KS0ee9YcAcO87Yh2V4603Bafdep7MjSTkBdN1iqYFWgj x-ms-exchange-antispam-messagedata: nKfkoGpuyRI9OpFjlMK/ty/3XgBmVWFT5sfC7jLibGq5PhQawCKPdLcOe1Mw3clPujkQeb7uzME+uJrAn4LZ0iTGFjUDVX0tpUQg4Ia4Mp/H8s2ZhUMbdY89ii5l+epZUFArzkLiOmmlr5Ba7hEwUA== MIME-Version: 1.0 X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fa70313-6005-44c7-d846-08d7b061e63b X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a355dbce-62b4-4789-9446-c1d5582180ff X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pCEwplWDrDpxJkVeoto+nDQeWcuGpjhkaQqxh87ZM5EvkRUDmihqL8JGv6K+9Z2PD31C1l3YUE974GPhryDbwHjjmBYL8Pcq5i433cV2XjGoNXpZZ7NigGNpqSwm2zvFE/J5hSDKwO56JYu63p8raBp6w9dZwUwX0XTgE/z8OH2cHdQUHsvh3MjCW/Gee7+m0dbkmc1d9W4EeF6VJpESXh/Q+Wn6mTx5oZSO1ERoep4= X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2020 08:54:42.9544 (UTC) X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB5126 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-13_01:2020-02-12, 2020-02-13 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=994 priorityscore=1501 spamscore=0 suspectscore=0 mlxscore=0 malwarescore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002130070 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200213_005446_056454_50644FAC X-CRM114-Status: UNSURE ( 9.05 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.9 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [67.231.149.44 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sergey Matyukevich Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Specify WPA3 AKM suites in set_ap command. Drivers may need to pass this information to firmware to setup SAE/OWE offload properly. Besides,drivers may use this information to perform early check SAE/OWE offload in hostapd. Signed-off-by: Sergey Matyukevich --- src/drivers/driver_nl80211.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index 7305ed60b..5d54614fc 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -4202,6 +4202,10 @@ static int wpa_driver_nl80211_set_ap(void *priv, suites[num_suites++] = RSN_AUTH_KEY_MGMT_UNSPEC_802_1X; if (params->key_mgmt_suites & WPA_KEY_MGMT_PSK) suites[num_suites++] = RSN_AUTH_KEY_MGMT_PSK_OVER_802_1X; + if (params->key_mgmt_suites & WPA_KEY_MGMT_SAE) + suites[num_suites++] = RSN_AUTH_KEY_MGMT_SAE; + if (params->key_mgmt_suites & WPA_KEY_MGMT_OWE) + suites[num_suites++] = RSN_AUTH_KEY_MGMT_OWE; if (num_suites && nla_put(msg, NL80211_ATTR_AKM_SUITES, num_suites * sizeof(u32), suites)) From patchwork Thu Feb 13 08:51:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Matyukevich X-Patchwork-Id: 1237347 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=quantenna.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20170209 header.b=RT5mgT6K; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=quantenna.com header.i=@quantenna.com header.a=rsa-sha256 header.s=selector1 header.b=ktfQ2F96; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48J9M05nsqz9sP7 for ; Thu, 13 Feb 2020 19:55:08 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iANHs14nwppvhetjn1f+sFpRgZK3G2RdhSy+mhg0DUk=; b=RT5mgT6KCT8Y2I bnVFJ2jZCLCvRM8yQGYHrbDH/VlmxPF5jft+TcGPqeD+EQm/nyiPS80AHkpbChyrtUSszR8PDQCMh QUatWmGtlTm1bw8FEW+OMhNmikMsDY4A02u1AfUDRKqi7oHDUFQUP1vWkBAKAaine/grCpoqEJFSL 0WwZnIZELknK+vyTYTZ10QFHpUFKsmXg3jSiTcb+WdG84CThhfk2WqGlVCQ1nWrTG1ddt2wO0sdid AcsmpYeqD4UF8WRIgMFPRyDj9gcB5aHpPoW8/2Tut8AlQlCk8oFDLESaDWQFpOMzWIJvqJRxRaN27 Nv/EPnH0oTniyZCAgZoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2AGy-0004RN-Hn; Thu, 13 Feb 2020 08:55:00 +0000 Received: from mx0b-00183b01.pphosted.com ([67.231.157.42] helo=mx0a-00183b01.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2AGm-0004GZ-0O for hostap@lists.infradead.org; Thu, 13 Feb 2020 08:54:49 +0000 Received: from pps.filterd (m0048104.ppops.net [127.0.0.1]) by mx0b-00183b01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01D8rXHc019800 for ; Thu, 13 Feb 2020 01:54:47 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2105.outbound.protection.outlook.com [104.47.70.105]) by mx0b-00183b01.pphosted.com with ESMTP id 2y1unaks7t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 13 Feb 2020 01:54:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aRr/wEOOz6qP8ZGM1TAqPK5UZ2CNm5CfIi6sL+FCQTLJ0rfTkCHG3CPInHGkKfIBwzb7th9x4y/PD2ioL9Tuy6vxw+lZvODxi3GR6/ZjWL8XOsvRRx+wrwP862BzqMMiBDqADnBlj7EsAgC+DXTMxcnlxzJIYuP0kprEbcAUNhn7AX31vFDeccDGnvUYAfQnAiymF3wV5kvvfIidEPu8dMjQCmfPi2MKLcV7ttjNvLm+vHLA6yqwRVD/NGdUaBWzGtvUS6i+haQ93o6t26v7VkVRGvvaHgviIvp73vMebrV5xpSld5jXjh/yZY2PfAZ/5ishJ7cxxL5rZOHe5nDrAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iR/oM1NzOx5iOo2BWN21xzuO/3uXpVKzQI1vf+g09BY=; b=iQZpiO6PoutiTPTXcalg9ccjX90gbcJSRDpXkQ5B9cEizkrf/Wyix+MNdDYZwT3ATMiGMuvAdBe07kK8D+ZLtTVdbxpaWLwER04vDXrXsfnK+YXATtyEPamudVkaLmHqNFcJhaegvqivTgVcXqOCLvOqDnpchtSjdnZ0terGMA0c+ccqr5+QEDGxCuDbdHNIJr8fvOc+P+1JDDRPvkFwNfj/hAoFJA4uA2hE6CKu9TNybJznceEwwZ1ngHdG3ItSWHlNKyXQved4hm5AmwYxbttTlvd1UF0N6pi8jPn/zy1P3q+S9mna3rdCBomLTMFkLjzSubnXDoGiJlehTOuUEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=quantenna.com; dmarc=pass action=none header.from=quantenna.com; dkim=pass header.d=quantenna.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quantenna.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iR/oM1NzOx5iOo2BWN21xzuO/3uXpVKzQI1vf+g09BY=; b=ktfQ2F96pgoDXaCW0ayNpbeolxgD8qRjTft6U5Qb5YpGyJSrq68wiA4rGMQtHRVnGYRMf7yIPP4TWinsqNZcvBCTvADYDv2azX/ZQOEur2Pn4THV3AsosETdh0dMm8nfTruUv8R5O/i3u9HTpUbHurBcXQBOvO3PjfbSuojhSl8= Received: from SN6PR05MB4686.namprd05.prod.outlook.com (52.135.114.208) by SN6PR05MB5039.namprd05.prod.outlook.com (20.177.249.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.16; Thu, 13 Feb 2020 08:54:45 +0000 Received: from SN6PR05MB4686.namprd05.prod.outlook.com ([fe80::5585:dabd:89cf:b48d]) by SN6PR05MB4686.namprd05.prod.outlook.com ([fe80::5585:dabd:89cf:b48d%3]) with mapi id 15.20.2750.007; Thu, 13 Feb 2020 08:54:45 +0000 Received: from SN6PR05MB4928.namprd05.prod.outlook.com (52.135.117.74) by SN6PR05MB5662.namprd05.prod.outlook.com (52.135.110.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.8; Thu, 13 Feb 2020 08:51:23 +0000 Received: from SN6PR05MB4928.namprd05.prod.outlook.com ([fe80::25b7:98a0:c066:1a9]) by SN6PR05MB4928.namprd05.prod.outlook.com ([fe80::25b7:98a0:c066:1a9%6]) with mapi id 15.20.2729.021; Thu, 13 Feb 2020 08:51:23 +0000 Received: from bars.quantenna.com (195.182.157.78) by LO2P265CA0075.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.22 via Frontend Transport; Thu, 13 Feb 2020 08:51:22 +0000 From: Sergey Matyukevich To: "hostap@lists.infradead.org" Subject: [PATCH 2/3] OWE: rename owe_assoc_req_process parameter reason to status Thread-Topic: [PATCH 2/3] OWE: rename owe_assoc_req_process parameter reason to status Thread-Index: AQHV4krE9W/tgCPD+0Swyt0GeIgpdw== Date: Thu, 13 Feb 2020 08:51:23 +0000 Message-ID: <20200213085112.27376-3-sergey.matyukevich.os@quantenna.com> References: <20200213085112.27376-1-sergey.matyukevich.os@quantenna.com> In-Reply-To: <20200213085112.27376-1-sergey.matyukevich.os@quantenna.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0075.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::15) To SN6PR05MB4928.namprd05.prod.outlook.com (2603:10b6:805:9d::10) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.11.0 x-originating-ip: [195.182.157.78] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a813576-74c2-498c-9846-08d7b061e6ec x-ms-traffictypediagnostic: SN6PR05MB5662:|SN6PR05MB5039: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-moderation-data: 2/13/2020 8:54:42 AM x-ms-oob-tlc-oobclassifiers: OLM:2803; x-forefront-prvs: 031257FE13 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39850400004)(346002)(376002)(136003)(366004)(189003)(199004)(64756008)(2906002)(66446008)(7696005)(2616005)(186003)(66556008)(956004)(478600001)(26005)(4326008)(5660300002)(6916009)(107886003)(52116002)(66476007)(66946007)(316002)(16526019)(86362001)(81156014)(103116003)(36756003)(81166006)(71200400001)(8676002)(1076003)(8936002)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR05MB5039; H:SN6PR05MB4686.namprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: quantenna.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iwSKE0k3FeQulHosVd7VQ6QpHHSDH6hMrJK7vTAR6/oKxMhXbYNaA8PXV9KBt0cq8RGTJbRvk2dNw0myYrUSd5KaBZGx6iIe6OJ3bMeHVVg7wPqcPerd67UkZjzf9/b1vxqnFHpACPIveozgDRzYOp0lfMNVJB6BYOq134ZVZUGh9WSCQ9qc2wZEwMD/6vykx/D2YTKYWHyFcmD4xvmQsIaUJ842bhiuptTC3L750bQ/nyeANKZhuDfkH5IgRV2TRUVsqp4XelW1CJQW+Oy+hMxPiJPT9jRfs+xBxVQ1qM+r+ExORCGf3pPFBJREzqAQR4OOhZpbsC9uRtoVkum7Tfmr0Hf7c8eH4jUVw4zFLRZpZA8//oh5uV0dfjCq9RzuTCBSc9EMNhkO0CpnhzlQpk+aKMlLb8kkuzd76tA2hqcSqjMdyBIdnxSmsuv6GDOI x-ms-exchange-antispam-messagedata: 54pEkOxRTlis0XLFwg7jmOWdInuFldVD5pMkA6dQGAvKxTq7bfplxkjSjrdRcpGTHd6f7Lo6h/JURlnZfiKWNN7CTjwt8LFRE91xEfdQgnkNG+mNViVB9L5+Spo43adCS4qgTnJIARh90vHaklSEDQ== MIME-Version: 1.0 X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a813576-74c2-498c-9846-08d7b061e6ec X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a355dbce-62b4-4789-9446-c1d5582180ff X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q0YJud5YFMsN5eVwRhCOx7o2p4XnGjkzV4AXhB69Z5SKIB0SgBJZoA9xaaH1/J8Yu+oGoAkpGwFOaxqXZM6KguRPuaGdRXHgp87IRVV08ZH3gt5/BUTmhd/hu/GVYNI4jxo9E+5peb+/YH/VTliIMg== X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2020 08:54:45.3643 (UTC) X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR05MB5039 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-13_01:2020-02-12, 2020-02-13 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 lowpriorityscore=0 phishscore=0 mlxlogscore=999 impostorscore=0 clxscore=1015 mlxscore=0 suspectscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002130071 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200213_005448_215480_91018A03 X-CRM114-Status: GOOD ( 11.85 ) X-Spam-Score: -0.9 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [67.231.157.42 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sergey Matyukevich Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org In the function owe_assoc_req_process, values assigned to reason argument imply that it should be renamed to status. Rename 'reason' to 'status' and modify the uses of owe_assoc_req_process accordingly. Signed-off-by: Sergey Matyukevich --- src/ap/drv_callbacks.c | 8 ++++---- src/ap/ieee802_11.c | 14 +++++++------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/ap/drv_callbacks.c b/src/ap/drv_callbacks.c index fdd845573..38506a097 100644 --- a/src/ap/drv_callbacks.c +++ b/src/ap/drv_callbacks.c @@ -577,18 +577,18 @@ skip_wpa_check: npos = owe_assoc_req_process(hapd, sta, elems.owe_dh, elems.owe_dh_len, p, sizeof(buf) - (p - buf), - &reason); + &status); if (npos) p = npos; + if (!npos && - reason == WLAN_STATUS_FINITE_CYCLIC_GROUP_NOT_SUPPORTED) { - status = WLAN_STATUS_FINITE_CYCLIC_GROUP_NOT_SUPPORTED; + status == WLAN_STATUS_FINITE_CYCLIC_GROUP_NOT_SUPPORTED) { hostapd_sta_assoc(hapd, addr, reassoc, status, buf, p - buf); return 0; } - if (!npos || reason != WLAN_STATUS_SUCCESS) + if (!npos || status != WLAN_STATUS_SUCCESS) goto fail; } #endif /* CONFIG_OWE */ diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c index 625e10b4b..68fdba4e0 100644 --- a/src/ap/ieee802_11.c +++ b/src/ap/ieee802_11.c @@ -3951,12 +3951,12 @@ done: #ifdef CONFIG_OWE u8 * owe_assoc_req_process(struct hostapd_data *hapd, struct sta_info *sta, const u8 *owe_dh, u8 owe_dh_len, - u8 *owe_buf, size_t owe_buf_len, u16 *reason) + u8 *owe_buf, size_t owe_buf_len, u16 *status) { #ifdef CONFIG_TESTING_OPTIONS if (hapd->conf->own_ie_override) { wpa_printf(MSG_DEBUG, "OWE: Using IE override"); - *reason = WLAN_STATUS_SUCCESS; + *status = WLAN_STATUS_SUCCESS; return wpa_auth_write_assoc_resp_owe(sta->wpa_sm, owe_buf, owe_buf_len, NULL, 0); } @@ -3966,18 +3966,18 @@ u8 * owe_assoc_req_process(struct hostapd_data *hapd, struct sta_info *sta, wpa_printf(MSG_DEBUG, "OWE: Using PMKSA caching"); owe_buf = wpa_auth_write_assoc_resp_owe(sta->wpa_sm, owe_buf, owe_buf_len, NULL, 0); - *reason = WLAN_STATUS_SUCCESS; + *status = WLAN_STATUS_SUCCESS; return owe_buf; } if (sta->owe_pmk && sta->external_dh_updated) { wpa_printf(MSG_DEBUG, "OWE: Using previously derived PMK"); - *reason = WLAN_STATUS_SUCCESS; + *status = WLAN_STATUS_SUCCESS; return owe_buf; } - *reason = owe_process_assoc_req(hapd, sta, owe_dh, owe_dh_len); - if (*reason != WLAN_STATUS_SUCCESS) + *status = owe_process_assoc_req(hapd, sta, owe_dh, owe_dh_len); + if (*status != WLAN_STATUS_SUCCESS) return NULL; owe_buf = wpa_auth_write_assoc_resp_owe(sta->wpa_sm, owe_buf, @@ -3988,7 +3988,7 @@ u8 * owe_assoc_req_process(struct hostapd_data *hapd, struct sta_info *sta, pub = crypto_ecdh_get_pubkey(sta->owe_ecdh, 0); if (!pub) { - *reason = WLAN_STATUS_UNSPECIFIED_FAILURE; + *status = WLAN_STATUS_UNSPECIFIED_FAILURE; return owe_buf; } From patchwork Thu Feb 13 08:51:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Matyukevich X-Patchwork-Id: 1237345 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=quantenna.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20170209 header.b=LD1pbMcB; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=quantenna.com header.i=@quantenna.com header.a=rsa-sha256 header.s=selector1 header.b=CMNLWlqT; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48J9LV419xz9sP7 for ; Thu, 13 Feb 2020 19:54:42 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pjGeO7f8q0jGltkvDjOCrKZMneg893sNH/y2aP+xahg=; b=LD1pbMcB0+VQYz 7lyAV1Y0bktiEW/n3r3tZIr71xvb0CERw8kQkHesMPTPhf9T/I/29WmeTJQoPN1dJj1cxJjEMbpcw hPBXKKAqom7crtS4/Q4M8WXBqQordx4h5TkmTgehzNSyYZy2urJXe3MqKWmy3B69VLZ/+HX9aSaQ7 X496z7t0FQ/i4nFqSAJeubKHMtxNJ21v21Yh6FSRR7DjgXCZXED4XqACud9jXtJtlsuJc+FNtBvgJ B5Bxs0tPoGCEysizZB761cdI76zAO+ULPTZ9YUYCU0CzSBVh0TTkUBvo5qIRNknk6Flpz/81Bt2Br M423hOI8d5ET8e4BHHdw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2AGY-00045Q-PU; Thu, 13 Feb 2020 08:54:34 +0000 Received: from mx0b-00183b01.pphosted.com ([67.231.157.42] helo=mx0a-00183b01.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2AGW-00044c-0H for hostap@lists.infradead.org; Thu, 13 Feb 2020 08:54:33 +0000 Received: from pps.filterd (m0059811.ppops.net [127.0.0.1]) by mx0b-00183b01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01D8pAxP012981 for ; Thu, 13 Feb 2020 01:54:31 -0700 Received: from nam02-bl2-obe.outbound.protection.outlook.com (mail-bl2nam02lp2056.outbound.protection.outlook.com [104.47.38.56]) by mx0b-00183b01.pphosted.com with ESMTP id 2y1u7fbt2v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 13 Feb 2020 01:54:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BrltY4m81LjZ3mfjmQM3a8EHxqovrsTG5SBZ21MROPybNVo8Ee9Vt69wIHObqvEop7dClFbmNENklNV1SgIAeVeGx1VtAddSDxfyR6hH1q7LGLWFVJEIf0sdBT5wevy+QCz5+dxE31T5BrrLKghPNU2s08wkuFmx73af0tdYjiuCQKsG3hjuhbsYPYjg/tUHeNP3I4cPZ9p8jEzH+I+daUQmQZWuktLydcDauFx3aeCf5T9R40eCoF5nFyegoA/qeUOMfWh3oZQoS9eCmnLD18Wg1YLqKRKdh7EiN4VQ4yBovz3SEz543PDkXNliiSMq/FMNDeSd4L6r9oPXmTp2Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ERmq/L16AA+9dCLC7wQqiDCbcjOBXCs8zc28MOss9wk=; b=LqkgOpYuiRr1lGBrZlocK6bY2kiN9pxePKV8S3FaRxW8O5zgTcp6QY65OgyPFE2IKYS+BTZqnmv9L5vW7JKwj3AJznl5ca2sYGDjpZPAqewhgp0tMLrEkc4GbRSdfuxFw939DTQGNPDAqb8ifcTY7c4jMkq8OZuhCCwOBqjU+gHaJYbnS5jqMNfvaTzR/6CJ2RiJv9HaZ+x9TMHuBVK1m4t8iKlU6MjrHN8tZ2LdJ4V/LWlKvtOhTKJKNpu4BqUroj9POvfNp+06eEVfFHL/IdCiZ3yy/dYJW1hU6OWRDtN99vSgUF6lfevWq7io90NLW2mc9qabeAe8kMTnEZH/GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=quantenna.com; dmarc=pass action=none header.from=quantenna.com; dkim=pass header.d=quantenna.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quantenna.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ERmq/L16AA+9dCLC7wQqiDCbcjOBXCs8zc28MOss9wk=; b=CMNLWlqTglcnuU6IeZf+X56JLyzqxhvwnAEddk2f48TTBRgmw+3Y8AB1xfSBHo/PL+QqRgkYEULOp078DKpsgqCoOUMTxtE+dGfOLXdmYDOOdpsWaOg5NEDo3LkLWe20mmJmR2a2f+JIAq5T5lBfCJYjkVvBjY4qdCNj3aLlG+U= Received: from MWHPR0501MB3801.namprd05.prod.outlook.com (10.167.163.161) by MWHPR0501MB3833.namprd05.prod.outlook.com (10.167.236.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.9; Thu, 13 Feb 2020 08:54:29 +0000 Received: from MWHPR0501MB3801.namprd05.prod.outlook.com ([fe80::386b:c91c:5887:1417]) by MWHPR0501MB3801.namprd05.prod.outlook.com ([fe80::386b:c91c:5887:1417%6]) with mapi id 15.20.2729.021; Thu, 13 Feb 2020 08:54:28 +0000 Received: from SN6PR05MB4928.namprd05.prod.outlook.com (52.135.117.74) by SN6PR05MB5662.namprd05.prod.outlook.com (52.135.110.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.8; Thu, 13 Feb 2020 08:51:24 +0000 Received: from SN6PR05MB4928.namprd05.prod.outlook.com ([fe80::25b7:98a0:c066:1a9]) by SN6PR05MB4928.namprd05.prod.outlook.com ([fe80::25b7:98a0:c066:1a9%6]) with mapi id 15.20.2729.021; Thu, 13 Feb 2020 08:51:24 +0000 Received: from bars.quantenna.com (195.182.157.78) by LO2P265CA0075.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.22 via Frontend Transport; Thu, 13 Feb 2020 08:51:23 +0000 From: Sergey Matyukevich To: "hostap@lists.infradead.org" Subject: [PATCH 3/3] OWE: allow adding new STAs w/o DH IEs when OWE is offloaded Thread-Topic: [PATCH 3/3] OWE: allow adding new STAs w/o DH IEs when OWE is offloaded Thread-Index: AQHV4krF3dQFyEm4Ok+veuNa34kGFQ== Date: Thu, 13 Feb 2020 08:51:24 +0000 Message-ID: <20200213085112.27376-4-sergey.matyukevich.os@quantenna.com> References: <20200213085112.27376-1-sergey.matyukevich.os@quantenna.com> In-Reply-To: <20200213085112.27376-1-sergey.matyukevich.os@quantenna.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0075.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::15) To SN6PR05MB4928.namprd05.prod.outlook.com (2603:10b6:805:9d::10) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.11.0 x-originating-ip: [195.182.157.78] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 34f2fd97-c17e-4462-331e-08d7b061e782 x-ms-traffictypediagnostic: SN6PR05MB5662:|MWHPR0501MB3833: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-moderation-data: 2/13/2020 8:54:26 AM x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 031257FE13 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(396003)(346002)(39850400004)(366004)(189003)(199004)(956004)(316002)(26005)(6916009)(81156014)(8936002)(52116002)(7696005)(8676002)(4326008)(81166006)(2616005)(103116003)(66946007)(36756003)(2906002)(5660300002)(1076003)(86362001)(66556008)(66476007)(66446008)(64756008)(107886003)(6486002)(16526019)(71200400001)(186003)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR0501MB3833; H:MWHPR0501MB3801.namprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: quantenna.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QDExq0B2aNKos3XeI6v0R/L3a8GDmw8x4EG9pNjonhsjQSbZk8LeqLoLT682DUV+qtevQf8nkhy7WqGWtpNhzwHbuVy7wQ5V4S1taTwQsSpYelSde3NktKzLb7CmYT4Z6wdASydTAodv/2TAcmCpZC6q71XWVefY3TFkRpHx4Tmqn3KZZT+CVGNF8Nq90/UDU3XrUS7MQzA/6s2dzqDyxVr5t2l5x5J2nge4hXEVJKY7akvW0fVQZlw8M2LxofC7gbiPAgtOczgCiTDrBrrBCFV3MTJKx9yM0jcogH+YL2dm4+bWf27yv51FUs8cqdpzPfPuEt6BkglKWFYxNLsyS7fH6KgTTckqp5DXiriKj+m5nE28qYoh8MoOXRjtNRyeIkUCvPywbNxNo6kgMlUZQkGdKG2azMO5Twm6+eLno68jvMWUM8HbHYflUyZalCbV x-ms-exchange-antispam-messagedata: TCP/XmLHkfA7CTHJPpkh7le2jNqOrxvTtmMRSvTjQAziX/CTpXT2SCVRGGYOZ/yflICx/37Kfe36iMzqxFpzi9Iud+Rm6FTfkkBgy1NnUFkZrSiWlXkqv82MzkVe767j58NCNb3tFmgd0wSoIQUSLw== MIME-Version: 1.0 X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34f2fd97-c17e-4462-331e-08d7b061e782 X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a355dbce-62b4-4789-9446-c1d5582180ff X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NVbhshEoxpCd6TfA5vlsRNDdhKF+GLaNvV59SFQQsyOe809gFa37P4Cbkepu1OnbY2vrrMJHWUiYcSS6kXIhNJyv44augF14x7sMaxGRbrRWv9hJhRANR1sDIjV5a6XrDWH6u25JrRQK4PWuUdgaZiBUoQXba0DUMNAtfpI3B9PuTgmU5pdL6/2coYS6Gpch27LdNIEDHX9h0+sGTzqc+Q== X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2020 08:54:28.9204 (UTC) X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0501MB3833 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-13_01:2020-02-12, 2020-02-13 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 spamscore=0 mlxscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002130070 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200213_005432_172386_35CDE069 X-CRM114-Status: GOOD ( 15.21 ) X-Spam-Score: -0.9 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [67.231.157.42 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sergey Matyukevich Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Drivers/cards supporting SME internally may perform OWE offloading to hostapd. This can be done using EVENT_UPDATE_DH mechanism and appropriate handler hostapd_notif_update_dh_ie. When this mechanism is in use, then hostapd creates STA entries for OWE processing and reports DH information element to driver. After association is completed, driver notifies hostapd that new STA is ready using EVENT_ASSOC mechanism and appropriate handler hostapd_notif_assoc. Currently the availability of DH IEs is validated in both events by the function wpa_validate_wpa_ie. However for EVENT_ASSOC this is needed only for non-SME drivers. For SME drivers this may be redundant since during processing of OWE offload STA entry has been already added and OWE PMK has been already created. This patch modifies OWE processing so that drivers performing OWE offload may not pass DH IE in EVENT_ASSOC. For this purpose the following changes have been introduced. Function wpa_validate_wpa_ie is modified so that it does not report failure if DH IE is not provided. DH IE availability is checked in owe_assoc_req_process in the case if previously derived OWE PMK is not available. Besides, availability of DH IE is verified in handle_assoc(check_assoc_ies). Signed-off-by: Sergey Matyukevich --- src/ap/drv_callbacks.c | 8 ++++++-- src/ap/ieee802_11.c | 15 +++++++++++++-- src/ap/wpa_auth_ie.c | 5 ----- 3 files changed, 19 insertions(+), 9 deletions(-) diff --git a/src/ap/drv_callbacks.c b/src/ap/drv_callbacks.c index 38506a097..f38719bff 100644 --- a/src/ap/drv_callbacks.c +++ b/src/ap/drv_callbacks.c @@ -570,8 +570,7 @@ skip_wpa_check: #ifdef CONFIG_OWE if ((hapd->conf->wpa_key_mgmt & WPA_KEY_MGMT_OWE) && - wpa_auth_sta_key_mgmt(sta->wpa_sm) == WPA_KEY_MGMT_OWE && - elems.owe_dh) { + wpa_auth_sta_key_mgmt(sta->wpa_sm) == WPA_KEY_MGMT_OWE) { u8 *npos; npos = owe_assoc_req_process(hapd, sta, @@ -588,6 +587,11 @@ skip_wpa_check: return 0; } + if (!npos && status == WLAN_STATUS_AKMP_NOT_VALID) { + reason = WLAN_REASON_AKMP_NOT_VALID; + goto fail; + } + if (!npos || status != WLAN_STATUS_SUCCESS) goto fail; } diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c index 68fdba4e0..e61ed595f 100644 --- a/src/ap/ieee802_11.c +++ b/src/ap/ieee802_11.c @@ -3352,8 +3352,13 @@ static u16 check_assoc_ies(struct hostapd_data *hapd, struct sta_info *sta, #ifdef CONFIG_OWE if ((hapd->conf->wpa_key_mgmt & WPA_KEY_MGMT_OWE) && - wpa_auth_sta_key_mgmt(sta->wpa_sm) == WPA_KEY_MGMT_OWE && - elems.owe_dh) { + wpa_auth_sta_key_mgmt(sta->wpa_sm) == WPA_KEY_MGMT_OWE) { + if (!elems.owe_dh) { + wpa_printf(MSG_DEBUG, + "OWE: No Diffie-Hellman Parameter element"); + return WLAN_STATUS_AKMP_NOT_VALID; + } + resp = owe_process_assoc_req(hapd, sta, elems.owe_dh, elems.owe_dh_len); if (resp != WLAN_STATUS_SUCCESS) @@ -3976,6 +3981,12 @@ u8 * owe_assoc_req_process(struct hostapd_data *hapd, struct sta_info *sta, return owe_buf; } + if (!owe_dh) { + wpa_printf(MSG_DEBUG, "OWE: No Diffie-Hellman Parameter element"); + *status = WLAN_STATUS_AKMP_NOT_VALID; + return NULL; + } + *status = owe_process_assoc_req(hapd, sta, owe_dh, owe_dh_len); if (*status != WLAN_STATUS_SUCCESS) return NULL; diff --git a/src/ap/wpa_auth_ie.c b/src/ap/wpa_auth_ie.c index 2e6d05910..88b5f9f16 100644 --- a/src/ap/wpa_auth_ie.c +++ b/src/ap/wpa_auth_ie.c @@ -842,11 +842,6 @@ int wpa_validate_wpa_ie(struct wpa_authenticator *wpa_auth, #endif /* CONFIG_IEEE80211R_AP */ #ifdef CONFIG_OWE - if (sm->wpa_key_mgmt == WPA_KEY_MGMT_OWE && !owe_dh) { - wpa_printf(MSG_DEBUG, - "OWE: No Diffie-Hellman Parameter element"); - return WPA_INVALID_AKMP; - } #ifdef CONFIG_DPP if (sm->wpa_key_mgmt == WPA_KEY_MGMT_DPP && owe_dh) { /* Diffie-Hellman Parameter element can be used with DPP as