From patchwork Thu Feb 6 14:26:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Castanho X-Patchwork-Id: 1234381 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-519055-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha1 header.s=default header.b=Giybw5fD; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48D12n4Fdgz9s3x for ; Fri, 7 Feb 2020 01:26:39 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :subject:to:message-id:date:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=Y22jDAMkB5lq8jQy j1+XufFsHeBzg62vAQuhOYBiXQauL1dNzzWoxicVDaT23tDEldIozgKuPlyoFxqI F4d/zg4lv3UV6Oto3VA60L0snBO/m9u2Ro4PLF1meBWj2NVBlDisYE9Xw24T/gsj UsROhAqkBe5UdzsnHbO9gcbntKo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :subject:to:message-id:date:mime-version:content-type :content-transfer-encoding; s=default; bh=Ve5cPvLIFGQx630uk9nWm+ 3DNn8=; b=Giybw5fDk2L6/pg2Q71jTG7+ief+JTm0AFjVJ5mNA/kj45L4JIzOxb JqK1dQA9c7ltJ7oNpHjptMmnF1NbtDM3/eePry5W+0Rt1TPSUeKfEO6x2m6kNtaW 0a3N0NUrc83cZDHd8ODwOiiLkCleAOUpUFKyUVv12fuSt/7hh7x4U= Received: (qmail 108431 invoked by alias); 6 Feb 2020 14:26:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 107744 invoked by uid 89); 6 Feb 2020 14:26:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy=wipe, quoted, HX-Proofpoint-Spam-Details:1011, HX-Languages-Length:1886 X-HELO: mx0b-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0b-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Feb 2020 14:26:30 +0000 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 016EHVZK180463 for ; Thu, 6 Feb 2020 09:26:28 -0500 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 2xyhnsmc9r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 06 Feb 2020 09:26:27 -0500 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 016EPWnn017611 for ; Thu, 6 Feb 2020 14:26:25 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma01dal.us.ibm.com with ESMTP id 2xykc98ygk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 06 Feb 2020 14:26:25 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 016EQOBt52298234 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 6 Feb 2020 14:26:24 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 880F9AE05C for ; Thu, 6 Feb 2020 14:26:24 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4240EAE062 for ; Thu, 6 Feb 2020 14:26:24 +0000 (GMT) Received: from [9.18.235.79] (unknown [9.18.235.79]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP for ; Thu, 6 Feb 2020 14:26:24 +0000 (GMT) From: Matheus Castanho Subject: Is machine_name fix still needed? To: gcc-patches@gcc.gnu.org Message-ID: <92e555ee-d244-d7fe-76c8-7c2cb6d3fca3@linux.ibm.com> Date: Thu, 6 Feb 2020 11:26:23 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 Hi, I recently faced problems while building GCC caused by a system header being broken by the machine_name fix from fixincludes [1]. And apparently I am not the first one [2][3]. After digging into the fixincludes code, I found the following comment on fixincludes/fixinc.in: > # # # # # # # # # # # # # # # # # # # # # > # > # Check to see if the machine_name fix needs to be disabled. > # > # On some platforms, machine_name doesn't work properly and > # breaks some of the header files. Since everything works > # properly without it, just wipe the macro list to > # disable the fix. Indeed adding the target to the case that follows this comment did the trick for me: diff --git a/fixincludes/fixinc.in b/fixincludes/fixinc.in index 15cbaa23544..c0791454b9c 100755 --- a/fixincludes/fixinc.in +++ b/fixincludes/fixinc.in @@ -136,6 +136,9 @@ fi # disable the fix. case "${target_canonical}" in + powerpc*-*-linux-*) + test -f ${MACRO_LIST} && echo > ${MACRO_LIST} + ;; *-*-vxworks*) test -f ${MACRO_LIST} && echo > ${MACRO_LIST} ;;