From patchwork Thu Feb 6 04:07:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chen Qun X-Patchwork-Id: 1234137 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48ClKc7130z9sRK for ; Thu, 6 Feb 2020 15:08:35 +1100 (AEDT) Received: from localhost ([::1]:60306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izYSt-000737-Jy for incoming@patchwork.ozlabs.org; Wed, 05 Feb 2020 23:08:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50342) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izYSb-000730-Vd for qemu-devel@nongnu.org; Wed, 05 Feb 2020 23:08:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izYSa-0006Fr-Tw for qemu-devel@nongnu.org; Wed, 05 Feb 2020 23:08:13 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:49730 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1izYSa-0005cL-J0; Wed, 05 Feb 2020 23:08:12 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A8F8C5063DAE48B9B491; Thu, 6 Feb 2020 12:08:04 +0800 (CST) Received: from HGHY4C002233111.china.huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Thu, 6 Feb 2020 12:07:56 +0800 From: To: , , Subject: [PATCH] aspeed/i2c:fix uninitialized variable warning Date: Thu, 6 Feb 2020 12:07:53 +0800 Message-ID: <20200206040753.42252-1-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, andrew@aj.id.au, zhang.zhanghailiang@huawei.com, Chen Qun , joel@jms.id.au Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Fix warning: hw/i2c/aspeed_i2c.c: In function ‘aspeed_i2c_bus_write’: glib/glib-autocleanups.h:28:3: warning: ‘cmd_flags’ may be used uninitialized in this function [-Wmaybe-uninitialized] g_free (*pp); ^~~~~~~~~~~~ hw/i2c/aspeed_i2c.c:403:22: note: ‘cmd_flags’ was declared here g_autofree char *cmd_flags; ^~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- hw/i2c/aspeed_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index 9cda968501..fb973a983d 100644 --- a/hw/i2c/aspeed_i2c.c +++ b/hw/i2c/aspeed_i2c.c @@ -400,7 +400,7 @@ static bool aspeed_i2c_check_sram(AspeedI2CBus *bus) static void aspeed_i2c_bus_cmd_dump(AspeedI2CBus *bus) { - g_autofree char *cmd_flags; + g_autofree char *cmd_flags = NULL; uint32_t count; if (bus->cmd & (I2CD_RX_BUFF_ENABLE | I2CD_RX_BUFF_ENABLE)) {