From patchwork Wed Nov 29 02:55:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Danomi Manchego X-Patchwork-Id: 842424 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ymljh4mwpz9s7f for ; Wed, 29 Nov 2017 14:03:51 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D7EDD87E54; Wed, 29 Nov 2017 03:03:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cbpA5y8ovYLY; Wed, 29 Nov 2017 03:03:42 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 86F1D88C28; Wed, 29 Nov 2017 03:03:42 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 644321BFF5F for ; Wed, 29 Nov 2017 03:03:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5F7D08827F for ; Wed, 29 Nov 2017 03:03:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zlLAe0545_rV for ; Wed, 29 Nov 2017 03:03:40 +0000 (UTC) X-Greylist: delayed 00:08:08 by SQLgrey-1.7.6 Received: from resqmta-ch2-05v.sys.comcast.net (resqmta-ch2-05v.sys.comcast.net [69.252.207.37]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 895208827C for ; Wed, 29 Nov 2017 03:03:40 +0000 (UTC) Received: from resomta-ch2-07v.sys.comcast.net ([69.252.207.103]) by resqmta-ch2-05v.sys.comcast.net with ESMTP id JsWheRMHvGMYDJsX5e8Jqb; Wed, 29 Nov 2017 02:55:31 +0000 Received: from dmocelo-Aspire-E5-575G.hsd1.nj.comcast.net ([IPv6:2601:87:c480:4d8f:19e7:c91e:b148:678b]) by resomta-ch2-07v.sys.comcast.net with SMTP id JsWzeKnb4LTOcJsX4eZFNO; Wed, 29 Nov 2017 02:55:31 +0000 From: Danomi Manchego To: buildroot@buildroot.org Date: Tue, 28 Nov 2017 21:55:24 -0500 Message-Id: <1511924124-3938-1-git-send-email-danomimanchego123@gmail.com> X-Mailer: git-send-email 2.7.4 X-CMAE-Envelope: MS4wfBWy+9dNW7/j3kZZSkTxtwqQ5Hkf3zl866Jjv786f6JQ3sv79UfmGgjrD4Ggwal4mH32h8MWeLbB2nH5NkeEiTZeVSqjY9kd+9gEeSTqCy1CbDC/fFLR prE89fqMB6wyOaoDa3guE5VVhDe0LOLp2s2k6MquKnMZFLFkjbzsW2G3CNUxjv9ORK519vrG8AZsrEnRkvxF0C/exh7mowSTDbTnxwIKTa6b/lxPaVW+ehlS UhCgiQ8EdNhLXpAO6H1PmA== Subject: [Buildroot] [PATCH 1/1] samba4: ensure that copied cache.txt is writable X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" If the Buildroot tree is read-only, then cache.txt is copied read-only into the build directory, and the configuration step fails. Fix this in the same way we do in other places, by opening permissions as we copy the file using $(INSTALL). Signed-off-by: Danomi Manchego --- package/samba4/samba4.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/samba4/samba4.mk b/package/samba4/samba4.mk index 7836df5..ade9add 100644 --- a/package/samba4/samba4.mk +++ b/package/samba4/samba4.mk @@ -86,7 +86,7 @@ endef SAMBA4_POST_INSTALL_TARGET_HOOKS += SAMBA4_REMOVE_CTDB_TESTS define SAMBA4_CONFIGURE_CMDS - cp package/samba4/samba4-cache.txt $(@D)/cache.txt; + $(INSTALL) -m 0644 package/samba4/samba4-cache.txt $(@D)/cache.txt; echo 'Checking uname machine type: $(BR2_ARCH)' >>$(@D)/cache.txt; (cd $(@D); \ PYTHON_CONFIG="$(STAGING_DIR)/usr/bin/python-config" \