From patchwork Tue Nov 28 16:48:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 842231 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nqMTWQky"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ymV6K2Jsmz9t16 for ; Wed, 29 Nov 2017 03:50:49 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753595AbdK1Qug (ORCPT ); Tue, 28 Nov 2017 11:50:36 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:38151 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbdK1Quf (ORCPT ); Tue, 28 Nov 2017 11:50:35 -0500 Received: by mail-wr0-f193.google.com with SMTP id o2so702421wro.5; Tue, 28 Nov 2017 08:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Ue0M7fOwjDZC/vGU00RbBsThucY3Y+oh9zQSdssHSAw=; b=nqMTWQkywrDgQrCi5HSJjrI4pQeu+naE1BJnZiuJo/FHA3fEKH0HJc4wZdpAlS3U/M gpl10SSKZ7gtdcLI2SKO2pX7JHzLBxtE/izOTxoiXhPf9/TDo6ZmX7MqPYUsc6lCi0lm okkW45scLrYwhajrlqcFfsGFPtMszqu7cmoxm7F2/Y/9JUtiqRj72BTJh/gwLc2CrIXS gaZeY7WJx+hkuwXLwdmmV9BwBD39PTe5ZaNuwmAe8rST/RnfrgubQNQqqomzpiWO3Zm9 7SzV0sB8DpW++NxjDDip2RsfQqMWQx2bPUHS3E6yHpbtMNjployFJA2rCr4sytDh5/Gx 036g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ue0M7fOwjDZC/vGU00RbBsThucY3Y+oh9zQSdssHSAw=; b=tRimtbEhbg9QsCScu77/ISB3gYBAhelI7iCOHrnpvzj/1otGrZUf874Z8Y5LlidEqJ CROIkM+nAVA7BRfWEnqrTJ7SKhsjPoA0O6eN4CKxk0YThPLj7pZ9WETbNcFiYh0zb27C YB58f1MwiVkzbWHSNy+RDW2t9bYZFY2DY6JHqhN7LPzmT0w1wPbnDfvjpCR4P9jyG5p9 oylct0U/7D2RbneWZJHJ8FP9LP0yHgtP5yB2HoDxX+l+V6PF/2gsE4tADO3RwlEkE55M hUqAOGrS9TNJXvjjBV0BXrotzcC5wxHeSAvQ/n+txbIbphxoKMEP49yk8iNjKyBjz6U/ fZ+A== X-Gm-Message-State: AJaThX40PBO9bZpw46VQ1Q0eL4lv3ON+OtXb4gl53K2jNpfXOixnk4ny Br7xye4vHE2TsEtLAyaPXUo= X-Google-Smtp-Source: AGs4zMb+P0lNd56cpatr+pUiIwXjcDTcF+4z8b3gCwjx+BxEhQRrlSHOf6oJfOBDNPDZucEwsu08dg== X-Received: by 10.223.186.9 with SMTP id o9mr25931956wrg.221.1511887833745; Tue, 28 Nov 2017 08:50:33 -0800 (PST) Received: from Red.local (LFbn-MAR-1-580-204.w90-118.abo.wanadoo.fr. [90.118.159.204]) by smtp.googlemail.com with ESMTPSA id j15sm3259603wmg.48.2017.11.28.08.50.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Nov 2017 08:50:33 -0800 (PST) From: Corentin Labbe To: alexandre.torgue@st.com, maxime.ripard@free-electrons.com, peppe.cavallaro@st.com, wens@csie.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-sunxi@googlegroups.com, Corentin Labbe Subject: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner, leds-active-low handling Date: Tue, 28 Nov 2017 17:48:22 +0100 Message-Id: <20171128164822.29218-1-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.13.6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver expect "allwinner,leds-active-low" to be in PHY node, but the binding doc expect it to be in MAC node. Since all board DT use it also in MAC node, the driver need to search allwinner,leds-active-low in MAC node. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index e5ff734d4f9b..9eb7f65d8000 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -808,8 +808,7 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv) val, reg); if (gmac->variant->soc_has_internal_phy) { - if (of_property_read_bool(priv->plat->phy_node, - "allwinner,leds-active-low")) + if (of_property_read_bool(node, "allwinner,leds-active-low")) reg |= H3_EPHY_LED_POL; else reg &= ~H3_EPHY_LED_POL;