From patchwork Fri Jan 24 14:16:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Richard Earnshaw (lists)" X-Patchwork-Id: 1228848 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-518218-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha1 header.s=default header.b=stfi+C/2; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4841RF6Sf8z9sRW for ; Sat, 25 Jan 2020 01:16:41 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=EbuvfxZmZYkRsUGjUKd4NdXN+h/CXY6JkTr2EXmVRaquxvXJ6n d6DFIe24MHg/5o7VG3xQu8tNvM7A4znsUZHetJcmkUWWA3e51sqWUUThf0Am85nT r5C491Kein7gt81sbdfzHNFXuGtOvzZlfyybz9or7L8UpLt5ENzx1xkRs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=47LCm1c2XlV6cPw1TFRLEL+c21E=; b=stfi+C/2iQcng6v3PynR IVTbOpiKuwFk8QtBAw9YMQOI7LlAo1SyyCYWIlC/yHfIfMspYHoIMz06E5XTDGEF NaZiq5T8pa1z/eqOHWqhXc0jB5Tqux6jPGKA+AB8r95M0zwy0ZoYP3Ugguq0QinH xlZH5839mUfiuCuwMChRVGA= Received: (qmail 77174 invoked by alias); 24 Jan 2020 14:16:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 77165 invoked by uid 89); 24 Jan 2020 14:16:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy=UD:git-add-user-branch.sh, git-add-user-branch.sh, startpoint, gitadduserbranchsh X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Jan 2020 14:16:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B52E1007; Fri, 24 Jan 2020 06:16:30 -0800 (PST) Received: from e120077-lin.cambridge.arm.com (e120077-lin.cambridge.arm.com [10.2.78.81]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C748B3F6C4; Fri, 24 Jan 2020 06:16:29 -0800 (PST) To: "gcc-patches@gcc.gnu.org" From: "Richard Earnshaw (lists)" Subject: contrib: Change 'remote' for personal branches and add branch creation script Message-ID: <839eb291-976b-8cc1-378f-dcc72cd4629b@arm.com> Date: Fri, 24 Jan 2020 14:16:28 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 Whilst trying to convert the add vendor branch script to work with personal branches I encountered a minor issue where git would report ambiguous refs when checking out the new branch. It turns out that this is because git considers / to be ambiguous if both refs/heads// and refs/remotes// exist in the list of known branches. Having thought about this a bit, I think the best solution is to adopt something more like the vendors space and call the remote users/ (this also works better if you want to set up remotes to track other users branches as well). So this patch has two parts. 1) It updates gcc-git-customization.sh to set up the new 'remote' and converts any existing remote and branches tracking that to the new format 2) It adds a new script to set up a personal branch on the gcc git repository. I'll produce an update to wwwdocs/.../gitwrite.html to cover these changes shortly. R. * gcc-git-customization.sh: Use users/ for the personal remote rather than just . Convert any existing user branches to the new remote. * git-add-user-branch.sh: New file. diff --git a/contrib/gcc-git-customization.sh b/contrib/gcc-git-customization.sh index c16db747503..f3e48316ead 100755 --- a/contrib/gcc-git-customization.sh +++ b/contrib/gcc-git-customization.sh @@ -128,7 +128,7 @@ url=$(git config --get "remote.${upstream}.url") pushurl=$(git config --get "remote.${upstream}.pushurl") for v in $vendors do - echo "Migrating vendor $v to new remote vendors/$v" + echo "Migrating vendor \"$v\" to new remote \"vendors/$v\"" git config --unset-all "remote.${upstream}.fetch" "refs/vendors/$v/" git config --unset-all "remote.${upstream}.push" "refs/vendors/$v/" git config "remote.vendors/${v}.url" "${url}" @@ -140,15 +140,36 @@ do git config --add "remote.vendors/${v}.fetch" "+refs/vendors/$v/tags/*:refs/tags/vendors/${v}/*" done -echo "Setting up tracking for personal namespace $remote_id in remotes/${new_pfx}" -git config "remote.${new_pfx}.url" "${url}" +# Convert the remote 'pfx' to users/pfx to avoid problems with ambiguous refs +# on user branches +old_remote=$(git config --get "remote.${old_pfx}.url") +if [ -n "${old_remote}" ] +then + echo "Migrating remote \"${old_pfx}\" to new remote \"users/${new_pfx}\"" + # Create a dummy fetch rule that will cause the subsequent prune to remove the old remote refs. + git config --replace-all "remote.${old_pfx}.fetch" "+refs/empty/*:refs/remotes/${old_pfx}/*" + # Remove any remotes + git remote prune ${old_pfx} + git config --remove-section "remote.${old_pfx}" + for br in $(git branch --list "${old_pfx}/*") + do + old_remote=$(git config --get "branch.${br}.remote") + if [ "${old_remote}" = "${old_pfx}" ] + then + git config "branch.${br}.remote" "users/${new_pfx}" + fi + done +fi + +echo "Setting up tracking for personal namespace $remote_id in remotes/users/${new_pfx}" +git config "remote.users/${new_pfx}.url" "${url}" if [ "x$pushurl" != "x" ] then - git config "remote.${new_pfx}.pushurl" "${pushurl}" + git config "remote.users/${new_pfx}.pushurl" "${pushurl}" fi -git config --replace-all "remote.${new_pfx}.fetch" "+refs/users/${remote_id}/heads/*:refs/remotes/${new_pfx}/*" ":refs/remotes/${old_pfx}/" -git config --replace-all "remote.${new_pfx}.fetch" "+refs/users/${remote_id}/tags/*:refs/tags/${new_pfx}/*" ":refs/tags/${old_pfx}/" -git config --replace-all "remote.${new_pfx}.push" "refs/heads/${new_pfx}/*:refs/users/${remote_id}/heads/*" ":refs/users/${remote_id}" +git config --replace-all "remote.users/${new_pfx}.fetch" "+refs/users/${remote_id}/heads/*:refs/remotes/users/${new_pfx}/*" "refs/users/${remote_id}/heads/" +git config --replace-all "remote.users/${new_pfx}.fetch" "+refs/users/${remote_id}/tags/*:refs/tags/users/${new_pfx}/*" "refs/users/${remote_id}/tags/" +git config --replace-all "remote.users/${new_pfx}.push" "refs/heads/${new_pfx}/*:refs/users/${remote_id}/heads/*" "refs/users/${remote_id}" if [ "$old_pfx" != "$new_pfx" -a "$old_pfx" != "${upstream}" ] then @@ -157,3 +178,5 @@ fi git config --unset-all "remote.${upstream}.fetch" "refs/users/${remote_id}/" git config --unset-all "remote.${upstream}.push" "refs/users/${remote_id}/" + +git fetch "users/${new_pfx}" diff --git a/contrib/git-add-user-branch.sh b/contrib/git-add-user-branch.sh new file mode 100755 index 00000000000..e014f7518fb --- /dev/null +++ b/contrib/git-add-user-branch.sh @@ -0,0 +1,46 @@ +#! /bin/sh -e + +# Create a new upstream user branch. + +# Usage: +# contrib/git-add-user-branch.sh [/] + +usage () +{ + echo "Usage:" + echo " $0 [/] " + echo + echo "personal space must already have been set up using" + echo "contrib/gcc-git-customization.sh" + exit 1 +} + +if [ $# != 2 ] +then + usage +fi + +userpfx=$(git config --get "gcc-config.userpfx") +user=$(git config --get "gcc-config.user") + +if [ -z "$userpfx" -o -z "$user" ] +then + usage +fi + +branch=$(echo "$1" | sed -r "s:(${userpfx}/)?(.*)$:\2:") +start=$2 + +# Sanity check the new branch argument. If there is no '/', then the +# vendor will be the same as the entire first argument. +if [ -z "$branch" ] +then + usage +fi + +git push users/${userpfx} ${start}:refs/users/${user}/heads/${branch} +git fetch -q users/${userpfx} +git branch ${userpfx}/${branch} remotes/users/${userpfx}/${branch} +echo "You are now ready to check out ${userpfx}/${branch}" +echo "To push the branch upstream use:" +echo " git push users/${userpfx} ${userpfx}/${branch}"