From patchwork Thu Jan 23 12:44:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Franciosi X-Patchwork-Id: 1228122 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nutanix.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256 header.s=proofpoint20171006 header.b=tAmjBbjA; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 483Qbc4nxNz9sRl for ; Fri, 24 Jan 2020 02:06:52 +1100 (AEDT) Received: from localhost ([::1]:58774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iue4I-0007Fm-06 for incoming@patchwork.ozlabs.org; Thu, 23 Jan 2020 10:06:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56299) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iubrL-00015g-1s for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:45:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iubrJ-0000UN-U8 for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:45:18 -0500 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]:45152) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iubrE-0000HP-5X; Thu, 23 Jan 2020 07:45:12 -0500 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00NCcAtY003898; Thu, 23 Jan 2020 04:45:03 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=proofpoint20171006; bh=X5AOSgpjJdxzXZAwFtpWGcUS1/ekd/WoU38JeRcWDlo=; b=tAmjBbjAkbYw7SMiJjBryzq0ytkhgHQwbMvg0Vb/ESH2IJc3wvP+/KudMJk2Welb/N7B 3dafNVykUq021Wpul7gzitwohtN4+tjFm/P+10gk0kwuTt8DmQNdPkd3rUObNCN7qrSE ljT/4lin4nQ7QwUKRC3OgrXXwZ+BYTHODmIoWQMWtfrTFcW70fxvkljrWM4y1wEzdhxz 2iRdhdnHsP9iEr/fEepaX4x3B/zJwRJnGUPVvReUV91WVdhixQsZA/v3bTnSGyMdzLRD 8trbgqMDl2AEJpaJE6IkZg9cb1OAmBn/TyqHtGJ4vgAVyd3LQ5VA670BDii4bHzdPmrD hQ== Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2105.outbound.protection.outlook.com [104.47.58.105]) by mx0a-002c1b01.pphosted.com with ESMTP id 2xky80ju1a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jan 2020 04:45:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IyfHH2wOsuW0o7Vpyw0o5QFmBvHyrbWbUJ0VPFlw+8i5fmFaESAL31W+V5krICor4/f8v9QaEKTY9r7Zuhg3spryaKtVdXoMDWytEcpmbNHlGobljiNqvfxjn0NPOESRVg+lvyH57mgtCQKDVYFzpint6JiTh27Sdv0ZresLs2XIMQr5ptQJz2creSP3ucgujAusBZhdxgpSFdRHnVdwq3yNKqmHX1oF46svpOe75HB8Pk/jggwxe4if2+BZWAD5auBEq1sRUk83zW7hgH1yIW1GquVQH9gKeRo98Vpmt+uLLxpLlm/MiLoE76o+StL+zmpn3MKeR5xE9UBtAdIWMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X5AOSgpjJdxzXZAwFtpWGcUS1/ekd/WoU38JeRcWDlo=; b=h6Z30UDSA99WrkqFLAhFTrNbjCE7CbG2KCOKDcXE0h3V6zOZN5D+G0LRBAt4I5imSKOftaty4957f5syZmZcUbiNx+iq6GBDhxJNU22n9wIOj/72UT/OEVVxqO9e/5uu4BNm6frXECy5YnY/yBqJioQyD8MJSaAf5hLKqvyMWJ0TgufiV+3Ic2WvQLPPJTz+Li87ZgznbkptWLFPJ0oLOpLJ9dCokIoNl9PSCUF51qNhp5e1WYrdcBVPEVnndE2RLuf6+F5iMv2+rxLP97UY17gmuvscPYeJWX74Un2S7B/955sg0OolAsxZ+PB60oS6K+JgPtUo7DUOEOiPmU+4Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none Received: from MWHPR02MB2656.namprd02.prod.outlook.com (10.168.206.142) by MWHPR02MB3246.namprd02.prod.outlook.com (10.164.204.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.24; Thu, 23 Jan 2020 12:44:59 +0000 Received: from MWHPR02MB2656.namprd02.prod.outlook.com ([fe80::c8f8:4820:a24c:3029]) by MWHPR02MB2656.namprd02.prod.outlook.com ([fe80::c8f8:4820:a24c:3029%10]) with mapi id 15.20.2644.028; Thu, 23 Jan 2020 12:44:59 +0000 Received: from nutanix.com (62.254.189.133) by BYAPR06CA0022.namprd06.prod.outlook.com (2603:10b6:a03:d4::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.20 via Frontend Transport; Thu, 23 Jan 2020 12:44:56 +0000 From: Felipe Franciosi To: Ronnie Sahlberg , Paolo Bonzini , Peter Lieven , "qemu-devel@nongnu.org" , "qemu-stable@nongnu.org" , "qemu-block@nongnu.org" Subject: [PATCH] iscsi: Cap block count from GET LBA STATUS (CVE-2020-1711) Thread-Topic: [PATCH] iscsi: Cap block count from GET LBA STATUS (CVE-2020-1711) Thread-Index: AQHV0ersGiQprkLuikaxEpLUh3OweQ== Date: Thu, 23 Jan 2020 12:44:59 +0000 Message-ID: <20200123124357.124019-1-felipe@nutanix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR06CA0022.namprd06.prod.outlook.com (2603:10b6:a03:d4::35) To MWHPR02MB2656.namprd02.prod.outlook.com (2603:10b6:300:45::14) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [62.254.189.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 97ef5eb9-ec24-4293-795f-08d7a0020ea8 x-ms-traffictypediagnostic: MWHPR02MB3246: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-proofpoint-crosstenant: true x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 029174C036 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(366004)(346002)(376002)(136003)(39860400002)(199004)(189003)(81156014)(8936002)(8676002)(81166006)(5660300002)(110136005)(316002)(16526019)(1076003)(54906003)(4326008)(186003)(7696005)(52116002)(86362001)(64756008)(71200400001)(2906002)(66946007)(26005)(478600001)(66476007)(66556008)(66446008)(956004)(2616005)(8886007)(7416002)(36756003)(55016002); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR02MB3246; H:MWHPR02MB2656.namprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nutanix.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uiCZPM0oFZ48Uw1KVOKUJKbttI9B33Kkr0J4m8cXub64MIX5UYpMwoqKA1T18MiXIQa3+hRFwYWs8+qBtOFnuq/sqXi2r5mZ7WPJoImg4b6wEsil5guKJP8tCqXiHRrCFmzYJvC9Ys4baEi6dQF7r3eZXdLkkNRVbPwbHtoFb2G/WPVsGd/PS1yaHRkjQcjBzm4qDQc+sVbNKdRlrvicBYMLsRhJ+UqZSO8sEaesTn583Nan5oTA+XuMn8HhgwtnrI7mFPP+2X/Yww2a9EtZnS46t1bqsqcw9+n43CEAcjnoub2SB0b8O4tcYASHesBkrOQZLFBxsXTOi2eueYcGyh/p+YglCujr9WKeE/qmn7rKqhcxRYK/db/SX8MNaXmXXYENaH5YIoruHYQTvN0LFoAueTPJsg5JdepfLl5QeF+BPaZQvGvRIN3GSMd2MAIY MIME-Version: 1.0 X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97ef5eb9-ec24-4293-795f-08d7a0020ea8 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2020 12:44:59.8002 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n9D3Fcy8vYmD9sHUG9v9jU+w+IhYFXdNNzZ4fyxaPwVxRofRIUnJxIJFTXnbnUHb6tfJCBczS+xymH0V4LXe5w/pBm54BPXl0mFJGNwbE6g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3246 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-01-23_08:2020-01-23, 2020-01-23 signatures=0 X-Proofpoint-Spam-Reason: safe X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.151.68 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Turschmid , Raphael Norwitz , Max Reitz , Stefan Hajnoczi , Felipe Franciosi , P J P Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" When querying an iSCSI server for the provisioning status of blocks (via GET LBA STATUS), Qemu only validates that the response descriptor zero's LBA matches the one requested. Given the SCSI spec allows servers to respond with the status of blocks beyond the end of the LUN, Qemu may have its heap corrupted by clearing/setting too many bits at the end of its allocmap for the LUN. A malicious guest in control of the iSCSI server could carefully program Qemu's heap (by selectively setting the bitmap) and then smash it. This limits the number of bits that iscsi_co_block_status() will try to update in the allocmap so it can't overflow the bitmap. Signed-off-by: Felipe Franciosi Signed-off-by: Peter Turschmid Signed-off-by: Raphael Norwitz --- block/iscsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 2aea7e3f13..cbd57294ab 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -701,7 +701,7 @@ static int coroutine_fn iscsi_co_block_status(BlockDriverState *bs, struct scsi_get_lba_status *lbas = NULL; struct scsi_lba_status_descriptor *lbasd = NULL; struct IscsiTask iTask; - uint64_t lba; + uint64_t lba, max_bytes; int ret; iscsi_co_init_iscsitask(iscsilun, &iTask); @@ -721,6 +721,7 @@ static int coroutine_fn iscsi_co_block_status(BlockDriverState *bs, } lba = offset / iscsilun->block_size; + max_bytes = (iscsilun->num_blocks - lba) * iscsilun->block_size; qemu_mutex_lock(&iscsilun->mutex); retry: @@ -764,7 +765,7 @@ retry: goto out_unlock; } - *pnum = (int64_t) lbasd->num_blocks * iscsilun->block_size; + *pnum = MIN((int64_t) lbasd->num_blocks * iscsilun->block_size, max_bytes); if (lbasd->provisioning == SCSI_PROVISIONING_TYPE_DEALLOCATED || lbasd->provisioning == SCSI_PROVISIONING_TYPE_ANCHORED) {