From patchwork Thu Jan 23 13:05:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 1227912 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=DMwuMaqS; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 483N0Q132tz9sP3 for ; Fri, 24 Jan 2020 00:09:42 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727307AbgAWNJk (ORCPT ); Thu, 23 Jan 2020 08:09:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:47718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbgAWNJk (ORCPT ); Thu, 23 Jan 2020 08:09:40 -0500 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09AF824655; Thu, 23 Jan 2020 13:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579784979; bh=xqbS5R4WS1AqgEI2Q7sHCOZQz4UNp2SDFty7q25qvLo=; h=From:To:Cc:Subject:Date:From; b=DMwuMaqSGLPfcLr2L6TqGCMEUgi+kfddrNA8gVSu835botzchuzQpa5ritngN/iUy GwOuqriXQ61rkxVb+vkk1dW+BkM9OFYGjtryD3z7Jwx57/ZH1kMzYK6OdTqyC+v2vO Fz3Psnhr26hqRa4R0RLGEZkD4hQkVFuQ4NvzngTg= From: Leon Romanovsky To: "David S . Miller" , Jakub Kicinski Cc: Leon Romanovsky , Michal Kalderon , linux-netdev , RDMA mailing list Subject: [PATCH net-next] net/core: Replace driver version to be kernel version Date: Thu, 23 Jan 2020 15:05:41 +0200 Message-Id: <20200123130541.30473-1-leon@kernel.org> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Leon Romanovsky In order to stop useless driver version bumps and unify output presented by ethtool -i, let's overwrite the version string. Before this change: [leonro@erver ~]$ ethtool -i eth0 driver: virtio_net version: 1.0.0 After this change: [leonro@server ~]$ ethtool -i eth0 driver: virtio_net version: 5.5.0-rc6+ Signed-off-by: Leon Romanovsky --- I wanted to change to VERMAGIC_STRING, but the output doesn't look pleasant to my taste and on my system is truncated to be "version: 5.5.0-rc6+ SMP mod_unload modve". After this patch, we can drop all those version assignments from the drivers. Inspired by nfp and hns code. --- net/core/ethtool.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.20.1 diff --git a/net/core/ethtool.c b/net/core/ethtool.c index cd9bc67381b2..3c6fb13a78bf 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -776,6 +777,8 @@ static noinline_for_stack int ethtool_get_drvinfo(struct net_device *dev, return -EOPNOTSUPP; } + strlcpy(info.version, UTS_RELEASE, sizeof(info.version)); + /* * this method of obtaining string set info is deprecated; * Use ETHTOOL_GSSET_INFO instead.