From patchwork Mon Nov 27 21:37:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasyl Gomonovych X-Patchwork-Id: 841895 X-Patchwork-Delegate: scottwood@freescale.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ym2Np4l9Kz9ryQ for ; Tue, 28 Nov 2017 10:01:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YDpjR6mT"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3ym2Np3Y41zDrbf for ; Tue, 28 Nov 2017 10:01:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YDpjR6mT"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4010:c07::241; helo=mail-lf0-x241.google.com; envelope-from=gomonovych@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YDpjR6mT"; dkim-atps=neutral Received: from mail-lf0-x241.google.com (mail-lf0-x241.google.com [IPv6:2a00:1450:4010:c07::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ym0Wv2dCCzDr9R for ; Tue, 28 Nov 2017 08:37:47 +1100 (AEDT) Received: by mail-lf0-x241.google.com with SMTP id i14so34528686lfc.1 for ; Mon, 27 Nov 2017 13:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=bUVoE8WgFFQoHEisKvTXYWGK+7fAuAlDz4MXW9BYxC0=; b=YDpjR6mTQcCHZp/OGz7neIRzGvU0Er5YC+GuJqAmY7EYGnRlq4famQRp5uPfQITu7Q nVU4EM9a/YozCILPeMdQ3HyUDburniKzCTMpTturf1Py+SGuBq87ggrVMNimwva87lgE g6JkvRzURQQGG7cZ7PMlO6C7JRu0zIVJwNx5HJyA0Xr05DWRk9Z8H8zciY3sXmC6d6Ci mMGRRnrp5oMjamFfKdEjXrtYElhrrJr+6VqbIkn6lmmK/xdhNgxaYDmwec/QQECriqdu hbP/p0JVeSc8pWkR5/iXCFqCGno3G4jors8roO/1AtctiDQL7Ww/kkSSSbehuP0iBuu2 4wZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bUVoE8WgFFQoHEisKvTXYWGK+7fAuAlDz4MXW9BYxC0=; b=K1GvJcG4oa0sfqqaKfIe5xVtNwytI36Qwn6JbxoqcG6mkBmijFJLOYQJKmY0n6SCOe qMVvFZrOyMb6y29s+XQwjcR3QjgNU1wDhO3qi4jr0+tHib989lX9eWbDYvTSHFBzELoW TIKvFQqrEHLkGAOQlQMx2ntiqYBrHPw6ocB9MCC8mEygOCwdMj81uGNkNnNAlFBSwuS2 q4wua9J9kvOP2FEH3tVj2I54qEKy+DRwgz6qhqQkVAuGxmIm6qR3rOTnq7Pd72ZOaOch WZ47j6+RBJ7NOj0gTqppRm4/YOq2QLpsi5Y0kWtaiGHkT+HUGpRU+yCxsRUDWHcBEgL3 e5BQ== X-Gm-Message-State: AJaThX4criJs+lkj9/PdeEgWpi0Ab9RwrECaTncaXXYacPsadQT51DKf 693DYIcyTponTVEUWz+zdvk= X-Google-Smtp-Source: AGs4zMb3NeFknAF3qw+asQAv6ANMRKKorMSxUf/npFs0hcCrc6WSEYbHaSGA9KetHb/mUohcVf6YmA== X-Received: by 10.25.207.8 with SMTP id f8mr14517410lfg.14.1511818663674; Mon, 27 Nov 2017 13:37:43 -0800 (PST) Received: from localhost.localdomain ([195.254.138.66]) by smtp.gmail.com with ESMTPSA id y20sm1369521lfd.58.2017.11.27.13.37.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 Nov 2017 13:37:42 -0800 (PST) From: Vasyl Gomonovych To: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, tyreld@linux.vnet.ibm.com, robh@kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH] powerpc/fsl_pci: Fix ptr_ret.cocci warnings Date: Mon, 27 Nov 2017 22:37:33 +0100 Message-Id: <1511818653-10278-1-git-send-email-gomonovych@gmail.com> X-Mailer: git-send-email 1.9.1 X-Mailman-Approved-At: Tue, 28 Nov 2017 10:00:08 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gomonovych@gmail.com, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" arch/powerpc/sysdev/fsl_pci.c:1307:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Vasyl Gomonovych --- arch/powerpc/sysdev/fsl_pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index 22d98057f773..e5afc3a9b533 100644 --- a/arch/powerpc/sysdev/fsl_pci.c +++ b/arch/powerpc/sysdev/fsl_pci.c @@ -1304,10 +1304,8 @@ static int add_err_dev(struct platform_device *pdev) pdev->resource, pdev->num_resources, &pd, sizeof(pd)); - if (IS_ERR(errdev)) - return PTR_ERR(errdev); - return 0; + return PTR_ERR_OR_ZERO(errdev); } static int fsl_pci_probe(struct platform_device *pdev)