From patchwork Sat Jan 18 15:42:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 1225173 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-517663-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=axis.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha1 header.s=default header.b=uzHsjQGi; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 480Mcy3lyrz9sPJ for ; Sun, 19 Jan 2020 02:42:24 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :message-id:from:to:subject:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=EjFJvn+mhIkEth1B nD/farnfmiuVeclp86yIPOMVYi6NY1o/kkR2ubq83Aw5hm2dK4+YURziYJ4OIH5d zdkkyOYusF8uGIxSwsOC1qfYODjNoXiYifCRz4r2zjFh/exEZC+orz3LjMYhfL8U uTahSTkxmbZOfemm8vZPApCovcY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :message-id:from:to:subject:mime-version:content-type :content-transfer-encoding; s=default; bh=DUMlqTKNL9ooh1TNysa0L2 03AyA=; b=uzHsjQGiHIa4ovo0Cz6DYD+ITQ9xXvsNeE9RkMX976YYqBUjUuQTAi XsZA/MhIWl2fa+FUrMzj7agkkIXCM42L5m/aCUkiocfmEPBsrjoZjUcBZlEqY/W4 9DNpcDhqn24DZJoILls6xH3KffiVd3QegJ0dhJOl03jsv36recBfE= Received: (qmail 47154 invoked by alias); 18 Jan 2020 15:42:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 47146 invoked by uid 89); 18 Jan 2020 15:42:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1103 X-HELO: smtp1.axis.com Received: from smtp1.axis.com (HELO smtp1.axis.com) (195.60.68.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 18 Jan 2020 15:42:16 +0000 IronPort-SDR: Z46YyCp6bSN8Zf7rRer6sfe+xzqfHIHI3MA2ofYj8Stkw8mPatK25qxTRMgp2NHU3oXuzsBt1n kR4YYU1aF/pVwOwzlIeyX4i29e9uWV6IuXK/XB0R4YrR2tgzVIVqhBpHRyImCSmQ1JnRQnvKam ZrDkvmprXxYm/b7vtEHF0nJCPIuydVjRLJxM7pTgt7/FDBP7sbYwIxNsy7mduzHHVZCINfGf5Z mhg1kdBsNjQVpVhnH5a5B0DbjfvyfRuLfBfayWxhT+7YvhtndLzf8bMfsHA+3ie0t7M7PlLDkX E5Y= Date: Sat, 18 Jan 2020 16:42:12 +0100 Message-ID: <202001181542.00IFgCk1005902@ignucius.se.axis.com> From: Hans-Peter Nilsson To: Subject: [COMMITTED] libgcc: cris: config/cris/arit.c (DS): Apply attribute __fallthrough__. MIME-Version: 1.0 X-IsSubscribed: yes libgcc: * config/cris/arit.c (DS): Apply attribute __fallthrough__. Without this, there are, for each compilation of arit.c, 30ish occurrences of "this statement may fall through [-Wimplicit-fallthrough=]", for lines that look like case 32: DS; case 31: DS; case 30: DS; case 29: DS; Noticed while working on the cc0 transition. Looks like I don't inspect the logs often. Adding -Werror to libgcc build-options should perhaps be considered? --- libgcc/config/cris/arit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libgcc/config/cris/arit.c b/libgcc/config/cris/arit.c index ba1c1e7..3369559 100644 --- a/libgcc/config/cris/arit.c +++ b/libgcc/config/cris/arit.c @@ -128,7 +128,8 @@ do_31div (unsigned long a, unsigned long b) i.e. "a - (b - 1) == (a - b) + 1". */ b--; -#define DS __asm__ ("dstep %2,%0" : "=r" (a) : "0" (a), "r" (b)) +#define DS __asm__ ("dstep %2,%0" : "=r" (a) : "0" (a), "r" (b)); \ + __attribute__ ((__fallthrough__)) switch (quot_digits) {