From patchwork Thu Jan 2 11:07:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 1217053 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-516575-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="W3KpEpLd"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47pQHG73p6z9sPn for ; Thu, 2 Jan 2020 22:07:37 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :subject:to:cc:message-id:date:mime-version:content-type; q=dns; s=default; b=XOKgCZDdC8f4K0bpidXleE90gGsdKg8C3p3D8sLGyvWidofV15 z0IGi1j3fduEDQFo/DEi3mmZcY0ltpa0l/PpK4i9ZV7H2ySesYNmMWEqakilkRLK g9gs9mxzuuy/N26stwTJaD4/G8zN5EezdCWNGp0uZCeUlInRiK3f2qSEY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :subject:to:cc:message-id:date:mime-version:content-type; s= default; bh=LERbCQHNewDfziHm7zf+311f6mk=; b=W3KpEpLdbkY0ppKR52gb T6GWtwuauVwuOBTAvpampQako/OAhvwQ5bntn3vOk9JBbgWJ68nHX7NVVjsHuPuw F2lpjxZHblH+I2deZrwsABYtEbyeMIf18D3FMCmVQ1398U+iOYWaGWBtrst3va6m /fq8QgDYoWvgMKelmApzy9I= Received: (qmail 12309 invoked by alias); 2 Jan 2020 11:07:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 12299 invoked by uid 89); 2 Jan 2020 11:07:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=mart X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Jan 2020 11:07:29 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9AB6AAD1E; Thu, 2 Jan 2020 11:07:27 +0000 (UTC) From: =?utf-8?q?Martin_Li=C5=A1ka?= Subject: [PATCH] Mark param_max_combine_insns with Optimization keyword. To: gcc-patches@gcc.gnu.org Cc: hubicka@ucw.cz Message-ID: <69e2b120-459b-9c7c-76a5-f90402df48a8@suse.cz> Date: Thu, 2 Jan 2020 12:07:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 X-IsSubscribed: yes Hi. The param is changed here: /* Restrict the amount of work combine does at -Og while retaining most of its useful transforms. */ if (opts->x_optimize_debug) SET_OPTION_IF_UNSET (opts, opts_set, param_max_combine_insns, 2); and so that it should be per-function. The only usage is in combine RTL pass, which is per-function optimization. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2020-01-02 Martin Liska PR tree-optimization/92860 * params.opt: Mart param_max_combine_insns with Optimization keyword. --- gcc/params.opt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/params.opt b/gcc/params.opt index c58a375e4c8..6f05b29a929 100644 --- a/gcc/params.opt +++ b/gcc/params.opt @@ -375,7 +375,7 @@ Common Joined UInteger Var(param_max_average_unrolled_insns) Init(80) Param The maximum number of instructions to consider to unroll in a loop on average. -param=max-combine-insns= -Common Joined UInteger Var(param_max_combine_insns) Init(4) IntegerRange(2, 4) Param +Common Joined UInteger Var(param_max_combine_insns) Init(4) IntegerRange(2, 4) Param Optimization The maximum number of insns combine tries to combine. -param=max-completely-peel-loop-nest-depth=