From patchwork Thu Dec 19 18:29:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thadeu Lima de Souza Cascardo X-Patchwork-Id: 1213642 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47f0mV42lrz9sPJ; Fri, 20 Dec 2019 05:30:16 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1ii0Yq-0003Dw-9R; Thu, 19 Dec 2019 18:30:08 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ii0Yk-0003Da-HM for kernel-team@lists.ubuntu.com; Thu, 19 Dec 2019 18:30:02 +0000 Received: from 1.general.cascardo.us.vpn ([10.172.70.58] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ii0Yj-0002ve-P1 for kernel-team@lists.ubuntu.com; Thu, 19 Dec 2019 18:30:02 +0000 From: Thadeu Lima de Souza Cascardo To: kernel-team@lists.ubuntu.com Subject: [U/F/E/D/B/X] UBUNTU: [Packaging]: config-check: some enforcement is ignored Date: Thu, 19 Dec 2019 15:29:51 -0300 Message-Id: <20191219182951.61115-1-cascardo@canonical.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" Whenever config-check finds an entry like: CONFIG_VFIO marknote it will consider marknote as the option name, as the regexp allows any characters not in the whitespace class (\S). By using a class like [^\s<], that is, not whitespace and not '<', it will be correctly parsed. We could fix the entries that have this problem, but fixing the parser is more robust. Ignore: yes Signed-off-by: Thadeu Lima de Souza Cascardo Acked-by: Marcelo Henrique Cerri Acked-by: Kleber Sacilotto de Souza --- debian/scripts/config-check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/scripts/config-check b/debian/scripts/config-check index 843f5999006b..95edd39dc407 100755 --- a/debian/scripts/config-check +++ b/debian/scripts/config-check @@ -113,7 +113,7 @@ for $config (keys %annot) { $options = $annot{$config}; $policy = undef; - while ($options =~ /\s*(\S+)<(.*?)?>/g) { + while ($options =~ /\s*([^\s<]+)<(.*?)?>/g) { ($option, $value) = ($1, $2); if ($option eq 'mark' && $value eq 'ENFORCED') {