From patchwork Tue Dec 17 15:36:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 1211473 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-108143-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="UII+SpyI"; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="Ax36XTok"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47cj144Rnkz9sPW for ; Wed, 18 Dec 2019 02:36:40 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=default; b=rns BeRBJwBIrY8/Acj17CFxtqOuiqPSsjBFwcSMIuynzmVR/DdK2AXBhvddQuCHgU7h EqchXXXJwTmQDQ178k7SV9jFGcrnpDz88VMGJb5JrNprx9HIxQRS7sem9fRrqioU V4/nyMX3zV+fZrAkJJCMYzw26KUI4xQwlrYBwAVw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type:content-transfer-encoding; s=default; bh=R4A64Bq9n B/J4zt38fxd0GoFAGo=; b=UII+SpyIdQRj3NqAASjzT3TxVch4lwUfsa8FdYOd6 g/j+g4X8PE6n24WBu0zuiUb4Pt9kFCdnZrOOHLuV64VjVALiP9FXloI3zqpwctM4 kVfu2JnBtzUJz/m2WT9YNBqAJTGXmJyTGwzuQyPUCHnGGhXa//yYmPJlVGU9IIvm JM= Received: (qmail 67863 invoked by alias); 17 Dec 2019 15:36:34 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 67855 invoked by uid 89); 17 Dec 2019 15:36:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576596991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xo9TdfARQZ6ssqeLfwEnvs6joI5WGVVvUUDWX67oNKw=; b=Ax36XToko73AYOiidw0ZQNLTGKUaHZdoa6rJnxwOAv2sbcvPktdGYVVs8sk8rytNzlx2br dYUMKiZ2p/d3C5SOWwhZKiZkx+mb9kXEhWhyXzcfCxpP+2giDbp+TdL6A3aEOkrIQvsf6L vhgFLcFvXedoilCr1nHOZ1PfBNY3L+g= From: Florian Weimer To: libc-alpha@sourceware.org Subject: [PATCH] build-many-glibcs.py: Do not build C++ PCHs by default Date: Tue, 17 Dec 2019 16:36:26 +0100 Message-ID: <87d0cn7ymd.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 They are not used during the subsequent glibc build, so creating them merely wastes time. ----- scripts/build-many-glibcs.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py index 193d49727b..92cc613c5d 100755 --- a/scripts/build-many-glibcs.py +++ b/scripts/build-many-glibcs.py @@ -1382,9 +1382,12 @@ class Config(object): else: tool_build = 'gcc' # libsanitizer commonly breaks because of glibc header - # changes, or on unusual targets. + # changes, or on unusual targets. C++ pre-compiled + # headers are not used during the glibc build and are + # expensive to create. if not self.ctx.full_gcc: - cfg_opts += ['--disable-libsanitizer'] + cfg_opts += ['--disable-libsanitizer', + '--disable-libstdcxx-pch'] langs = 'all' if self.ctx.full_gcc else 'c,c++' cfg_opts += ['--enable-languages=%s' % langs, '--enable-shared', '--enable-threads']