From patchwork Sun Dec 15 18:30:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 1209994 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OECtxzRj"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47bY0837KLz9sRC for ; Mon, 16 Dec 2019 05:31:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726481AbfLOSbk (ORCPT ); Sun, 15 Dec 2019 13:31:40 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:42592 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726219AbfLOSbj (ORCPT ); Sun, 15 Dec 2019 13:31:39 -0500 Received: by mail-lj1-f194.google.com with SMTP id e28so4242745ljo.9; Sun, 15 Dec 2019 10:31:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pJpJsdQ2YtTH6nu1Avkb9OWQxXwS0eSkzuTedWw0wzA=; b=OECtxzRjr3i8KK8Sx4kBdHFFatddwjCrYJBMoz/f5fc2dHM276Y2bip6GV1eHnCUqa aacw+T1Uo0Ft4EegS7TcMDSfknwrG8RYG5TpFErd4OWkwwluMHxAAwmucCxcpU57Za+Q cNFKvt2YW/vMPrp5m+3ugcPpwR6rmaf6g5QgZOL4dAXK8fhhprbvefMQNTWCLeTb/i5n 17XFj4R44a7TyiTSoC9HhszDi6Nj76+UFodIs0HuL9VJYepAUJ22ih8o0ueYzLc4sRzI XYT5iNCpw1LX/mWaHqCIsdmv7F8D58KXTnQ5HfXcIeLseCoOVHXFnZ3EqSIpx1R/hs0S O5ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pJpJsdQ2YtTH6nu1Avkb9OWQxXwS0eSkzuTedWw0wzA=; b=MvwsJXq1o0zaY+md34zfB7Cc/aOu0MkDh2pKTAWs8MQCcTc7avWgcfyk0Ka8L25S6o 39Z6eezK2HQQNCOA+Irk7dRcE05ALok5kuY2Z84mlRQcQIdmia+HdZiQUSopyMnU1hov cclDrwJxSfeVsuT7WGKAKhCQrz4MPxatfn3+lg911EIy8puNoAbIUIRJuDYPLsmQ7ARx Hl+nKQ5zQFjuUnz7ql2CyN1dKclZbwnArHJOs9TiW0emDdqyl+DLcA3GccTmJdWre64K CWlzySz4jW1i4ZuzkJba84zjr4uARWamDKt+oasFgQKafw0wHkfEu/DrWpqYog1faUGU seHw== X-Gm-Message-State: APjAAAVtsxVfoqlC+xK5sZVrLPmBRWIcWJddh4PVO1CMaPAaWZhUujQ3 TKJeOCs08FOh8iVWh096V/c= X-Google-Smtp-Source: APXvYqxRywx9Bm9sJE5wb3QBUbnF8bl4vnzWBM9c3XS3SduylB0SM0M0FGNl5sZ1Jer5c7GwR9hLOQ== X-Received: by 2002:a2e:9684:: with SMTP id q4mr17252373lji.242.1576434697498; Sun, 15 Dec 2019 10:31:37 -0800 (PST) Received: from localhost.localdomain (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.gmail.com with ESMTPSA id v2sm8814277ljv.70.2019.12.15.10.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2019 10:31:37 -0800 (PST) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/3] gpio: tegra: Use generic readl_relaxed/writel_relaxed accessors Date: Sun, 15 Dec 2019 21:30:45 +0300 Message-Id: <20191215183047.9414-2-digetx@gmail.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191215183047.9414-1-digetx@gmail.com> References: <20191215183047.9414-1-digetx@gmail.com> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org There is no point in using old-style raw accessors, the generic accessors do the same thing and also take into account CPU endianness. Tegra SoCs do not support big-endian mode in the upstream kernel, but let's switch away from the outdated things anyway, just to keep code up-to-date. Signed-off-by: Dmitry Osipenko --- drivers/gpio/gpio-tegra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index 6fdfe4c5303e..f6a382fbd12d 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio-tegra.c @@ -96,12 +96,12 @@ struct tegra_gpio_info { static inline void tegra_gpio_writel(struct tegra_gpio_info *tgi, u32 val, u32 reg) { - __raw_writel(val, tgi->regs + reg); + writel_relaxed(val, tgi->regs + reg); } static inline u32 tegra_gpio_readl(struct tegra_gpio_info *tgi, u32 reg) { - return __raw_readl(tgi->regs + reg); + return readl_relaxed(tgi->regs + reg); } static unsigned int tegra_gpio_compose(unsigned int bank, unsigned int port, From patchwork Sun Dec 15 18:30:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 1209992 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="r+ODSpg1"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47bY074YKxz9sR0 for ; Mon, 16 Dec 2019 05:31:51 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726539AbfLOSbm (ORCPT ); Sun, 15 Dec 2019 13:31:42 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:42593 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726445AbfLOSbl (ORCPT ); Sun, 15 Dec 2019 13:31:41 -0500 Received: by mail-lj1-f195.google.com with SMTP id e28so4242779ljo.9; Sun, 15 Dec 2019 10:31:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PKh3AEiH5cNq1LZRWLK77CjDsirV0QFS3e0KYYZWwGE=; b=r+ODSpg1q7HyaHldIiEUcpn3IpVUFMP8vT52IXPicCaTfiSAmz19aO1tYSI0nedft3 Db8lefvMiDzU6vhKQChxG+DyPjzAvaJnVRwuGsP3veLi6wocEHvhQuHKLO9drOkQEV6V jsvZuHxoWTTv7lL2ri7eIplo66cMuZnGxjR3uIRJImObPujfyRz2IQKyoajj4MUgSVq/ e4p8FsDUsmuNIip4P8qrC6nqtmajP9hGJPccgHlLJCgd0jR2diJUseXwBwjAU3ZqiLIA W/InAhtqbeO9va0/RXPAJfvsvYVRQWxhpx5HC+8qM4u7tDpBeA3b5uNlJ+R2lW3VF29P dY2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PKh3AEiH5cNq1LZRWLK77CjDsirV0QFS3e0KYYZWwGE=; b=sqxOgxaHcc2rVTRtXhKTUe0cMxbPAdygV9tz+tunR/nlvnTZvJ0oipG0iePmIJ9Agq MAKCv9Pg8aq1pgGn8RPI3xNhKZqpK/kPWYK+78SlHEvf7Fd1JWhDwc+S2vqTDfzldx4O uJbHa80H/szWV/8vEcdb+l/6SB1qnZ2sNnBr4isj7ILHPMgcspQtL0HnQ7DRw1qimZRW sEMhCqi+ThJGFSYhsMKkMoe3l0nES6hSzUd1ip+v4DHj+XB4i6XIxepxlGpeDjkslhbl ovI5busGuVbtRS01KXODd1Cnbheey9R++Y1xuyy8B/7VJ+umlse6RePx300wifpjDw9d ev7g== X-Gm-Message-State: APjAAAWo3b9KMqkogD29Ga1rPPu9lelXTR3jXPHmZhn9Bw9Dm/cvsR4J b1YN7Xj8xWsmtF8mMITzEt+RdOOt X-Google-Smtp-Source: APXvYqwhmwQ/qiTvRg66lREsz7P9Wx0VgwCd6UpJZi4Yp5C8JL0VR+XK5dj3RscJ1P+hJZ70rEgj5w== X-Received: by 2002:a2e:b010:: with SMTP id y16mr17070084ljk.238.1576434698505; Sun, 15 Dec 2019 10:31:38 -0800 (PST) Received: from localhost.localdomain (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.gmail.com with ESMTPSA id v2sm8814277ljv.70.2019.12.15.10.31.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2019 10:31:38 -0800 (PST) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/3] gpio: tegra: Properly handle irq_set_irq_wake() error Date: Sun, 15 Dec 2019 21:30:46 +0300 Message-Id: <20191215183047.9414-3-digetx@gmail.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191215183047.9414-1-digetx@gmail.com> References: <20191215183047.9414-1-digetx@gmail.com> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Technically upstream interrupt controller may fail changing of GPIO's bank wake-state and in this case the GPIO's wake-state shouldn't be changed. Signed-off-by: Dmitry Osipenko --- drivers/gpio/gpio-tegra.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index f6a382fbd12d..4790dfec7758 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio-tegra.c @@ -497,6 +497,11 @@ static int tegra_gpio_irq_set_wake(struct irq_data *d, unsigned int enable) struct tegra_gpio_bank *bank = irq_data_get_irq_chip_data(d); unsigned int gpio = d->hwirq; u32 port, bit, mask; + int err; + + err = irq_set_irq_wake(bank->irq, enable); + if (err) + return err; port = GPIO_PORT(gpio); bit = GPIO_BIT(gpio); @@ -507,7 +512,7 @@ static int tegra_gpio_irq_set_wake(struct irq_data *d, unsigned int enable) else bank->wake_enb[port] &= ~mask; - return irq_set_irq_wake(bank->irq, enable); + return 0; } #endif From patchwork Sun Dec 15 18:30:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 1209990 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NhUiZUfk"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47bY065B7Nz9sR1 for ; Mon, 16 Dec 2019 05:31:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726559AbfLOSbm (ORCPT ); Sun, 15 Dec 2019 13:31:42 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:42859 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbfLOSbl (ORCPT ); Sun, 15 Dec 2019 13:31:41 -0500 Received: by mail-lf1-f67.google.com with SMTP id y19so2629634lfl.9; Sun, 15 Dec 2019 10:31:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8WGNb8baWMu/OjrhEBuLnEY4Hx1XajfUZ1YMdab/qoo=; b=NhUiZUfkbwUwbh36Oycqj68dNdHAqfRHuVjH7dBuSS4W0MHBmL2vWQpIzIQP1uik3F 9S3id+ouVBS2uAJOuNP0kjhWFgL+wGb0zHoIETs9bO7zg3tR9bz75YFilmacFi+7wB9G N4SgoJUKeRHIYqILHaytlv4hmb3o+xuOFxQFt/0+ofoQXSMinlNobF+j5E0t4wDYUiHR NlrKnewXJk6IG5DxKd4k7fmkxiJUdPFfzmzSuJYWNYOS1ppy9sjCUJ0QWRw8025Bm6TJ KlH1edT8CCNVq3CHOzUsQEl6N8eOMG0Hecv9oBHTOCqQMZsptTgoens3d7iN5BlKrOwt jqPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8WGNb8baWMu/OjrhEBuLnEY4Hx1XajfUZ1YMdab/qoo=; b=blEnD34zGsLishrifzwFYljc2qDOkY5gUK1sHgWLXkM12cejQa9Vdt5ZrmSqHh9OLu ldR80+C+Bm5He3aepVNqgF7fEHRq5wVsw593cHHkd5ETjGwxziy8XvB+EdOteMDsSpGl ZWg8sU4FDfMRt08rXkN27GE6WclbclMX0Y9X9xG5OW19j2VqIk1TL/GSlNSdukcuaGXj Rt7wRgGZgZ64MGPr0qGugsjqqibcvhzYFyQnOl4urrw/iPvH3qj7vTDmmWf3Nh9BTlGJ gkzHOq+1px1CelXX4tjnGgCCewlAqkrOi63HlLc/rHaVRFMIpCGXGK81ENqtcyF7syMI Bm6Q== X-Gm-Message-State: APjAAAWdOmLxggiQpcYwpUVbgdlpWRh9Lky6TC/DEYI/i2DiU7xdQBsh /gOj+9ZoYJZINF2bQedbCNI= X-Google-Smtp-Source: APXvYqwAC+Ah7tQUHeZ3RPhMRnv+9rucKa6WFL204I6PVLtkjBFpZRQhumIjSBoL7UkDyziyacPSaQ== X-Received: by 2002:ac2:5983:: with SMTP id w3mr14711498lfn.137.1576434699420; Sun, 15 Dec 2019 10:31:39 -0800 (PST) Received: from localhost.localdomain (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.gmail.com with ESMTPSA id v2sm8814277ljv.70.2019.12.15.10.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2019 10:31:38 -0800 (PST) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 3/3] gpio: tegra: Use NOIRQ phase for suspend/resume Date: Sun, 15 Dec 2019 21:30:47 +0300 Message-Id: <20191215183047.9414-4-digetx@gmail.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191215183047.9414-1-digetx@gmail.com> References: <20191215183047.9414-1-digetx@gmail.com> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org All GPIO interrupts are disabled during of the NOIRQ suspend/resume phase, thus there is no need to manually disable the interrupts. This patch doesn't fix any problem, this is just a minor clean-up. Signed-off-by: Dmitry Osipenko --- drivers/gpio/gpio-tegra.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index 4790dfec7758..acb99eff9939 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio-tegra.c @@ -416,11 +416,8 @@ static void tegra_gpio_irq_handler(struct irq_desc *desc) static int tegra_gpio_resume(struct device *dev) { struct tegra_gpio_info *tgi = dev_get_drvdata(dev); - unsigned long flags; unsigned int b, p; - local_irq_save(flags); - for (b = 0; b < tgi->bank_count; b++) { struct tegra_gpio_bank *bank = &tgi->bank_info[b]; @@ -448,17 +445,14 @@ static int tegra_gpio_resume(struct device *dev) } } - local_irq_restore(flags); return 0; } static int tegra_gpio_suspend(struct device *dev) { struct tegra_gpio_info *tgi = dev_get_drvdata(dev); - unsigned long flags; unsigned int b, p; - local_irq_save(flags); for (b = 0; b < tgi->bank_count; b++) { struct tegra_gpio_bank *bank = &tgi->bank_info[b]; @@ -488,7 +482,7 @@ static int tegra_gpio_suspend(struct device *dev) GPIO_INT_ENB(tgi, gpio)); } } - local_irq_restore(flags); + return 0; } @@ -562,7 +556,7 @@ static inline void tegra_gpio_debuginit(struct tegra_gpio_info *tgi) #endif static const struct dev_pm_ops tegra_gpio_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(tegra_gpio_suspend, tegra_gpio_resume) + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(tegra_gpio_suspend, tegra_gpio_resume) }; static int tegra_gpio_probe(struct platform_device *pdev)