From patchwork Thu Nov 14 03:50:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver O'Halloran X-Patchwork-Id: 1194556 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47D6wj1YLYz9sPF for ; Thu, 14 Nov 2019 14:51:33 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DNxjTOSA"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47D6wh6H6szF22h for ; Thu, 14 Nov 2019 14:51:32 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::441; helo=mail-pf1-x441.google.com; envelope-from=oohall@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DNxjTOSA"; dkim-atps=neutral Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47D6wW3tKTzF0wY for ; Thu, 14 Nov 2019 14:51:22 +1100 (AEDT) Received: by mail-pf1-x441.google.com with SMTP id 3so3162339pfb.10 for ; Wed, 13 Nov 2019 19:51:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=q31br0DdvABQDmQhYJS/KUDTi9EL7bk7uXFvBv6ZK5w=; b=DNxjTOSAgnxpIvvFNbKOomN5CIXlWMcrSSTff776qWJPmMUKb2AqLKszqRAkpS8alQ vB+lYP9JLMVwxlYqAyS/JlFwNqdIRqHj7eB2mJcyDJv+Al3cmGGZf764X1+TnIitYQCa K0h6FqiHHsAr73DwmpPETqTrckgQc3v4RWp6j6AbISE+Tz132+EJZz+kTzeuPDVY88jP 5iNquO9u6fXMGITiPesGtiWUMVi5M8dvMsPtQjbI3cGSso+e5qra3kYCBrsvxIOJJ72Y aVonlhFuRXfblCtFINPrBTm9A7f4m1xyJXmFynRdrXKxqBsrU/jx3w83Oa3Ptj59KrjW D+9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=q31br0DdvABQDmQhYJS/KUDTi9EL7bk7uXFvBv6ZK5w=; b=jVP4R1NnoqoZG7uKoYuiawCEnADlwJxDK7k9iE1LnF6GWPt10QL/IgBG5m2fERp1Dc Zk4N/ukGiioKyOyYQmlMZMGBBiaei5JtvUltUg47EL9cZEp10sQuHvkcBIsRd6WdbV7j kbK7Ebt2Nl7VlFiQpF0jOiVTjLffilNYcTVBdeUKFSAIDsLFYwI67ZcpQzFIDjpF/AgD v5GB+cwAhPIgJ9IRS2b/hIU8Py53NwkLnSONzLwJ8FuP938JM36MsScvEfJH8tyeCiX1 lJmTGeXVokwTNA/RpBOUrOcwr6LIRne8dUm+u9JQ3bIUJjVHBgfrlTa8gPZ3u77Gm7OG KocA== X-Gm-Message-State: APjAAAXtExpFWLelwY3upF8MmYgPDK78mNuRe7IHDTAvJ2/Rgtzgf3HZ c4BZni8OiazIfdwwZmcVAEqKSgHWrmY= X-Google-Smtp-Source: APXvYqzqAhHzF27YbTDWm9gfJFW+wSFoh0+UX2WEaMWQBPOoa4953qQsLMbq/RxeyYNpF3ROAsh/OQ== X-Received: by 2002:a62:7c52:: with SMTP id x79mr8394957pfc.18.1573703477098; Wed, 13 Nov 2019 19:51:17 -0800 (PST) Received: from wafer.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id v10sm4280910pfg.11.2019.11.13.19.51.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2019 19:51:16 -0800 (PST) From: Oliver O'Halloran To: skiboot@lists.ozlabs.org Date: Thu, 14 Nov 2019 14:50:55 +1100 Message-Id: <20191114035055.23128-1-oohall@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [Skiboot] [PATCH] opal-ci: Remove clang builds on 18.04 X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" commit 3734172b0f40 ("build: fix non-constant build asserts") added the following check in asm/head.S: .if reset_patch_end - reset_patch_start > 0x100 .error "Reset patch overflow" .endif Some older versions of clang such as the one that ships with ubuntu 18.04 (vlang 6.0.0) don't consider symbol addresses as constant which causes the following error: asm/head.S:578:5: error: expected absolute expression .if reset_patch_end - reset_patch_start > 0x100 ^ asm/head.S:579:2: error: Reset patch overflow .error "Reset patch overflow" This appears to be a bug with the clang assembler that is fixed with versions of clang. Clang support in skiboot is best-effort so removing the clang builds from the Ubuntu 18.04 CI script is preferable to working around the limitations of the older versions of clang. Signed-off-by: Oliver O'Halloran --- opal-ci/build-ubuntu-18.04.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/opal-ci/build-ubuntu-18.04.sh b/opal-ci/build-ubuntu-18.04.sh index 6fd755f3d9f2..48eb825bf40b 100755 --- a/opal-ci/build-ubuntu-18.04.sh +++ b/opal-ci/build-ubuntu-18.04.sh @@ -29,8 +29,3 @@ rm -rf builddir mkdir builddir make SRC=$(pwd) -f ../Makefile -C builddir -j${MAKE_J} make clean - -echo "Building with clang..." -make clean -make -j${MAKE_J} CC=clang -make -j${MAKE_J} CC=clang check