From patchwork Wed Nov 13 21:50:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 1194479 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-513305-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="S80HPA57"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47CywC73RRz9sP3 for ; Thu, 14 Nov 2019 08:50:35 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version :content-transfer-encoding; q=dns; s=default; b=fGbfqyZk9EnvC7XU edGYwaaSf+iYuOD+fjJlBhyNaymx8X7iPRmltRNIYuV4pHOIn4V7bM/rXaljTPoJ 8rZDnJZPBFizwf7wDe/GqHz12o7bCG6YEwt+Ar7QDW1uLHk1758MZeEJDhbS8rnC +CVIR6bHmuU/s9+JoGFB+f5mJG4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=default; bh=V62FJGwzpPEf7ZeyAztwtl qmfs8=; b=S80HPA57Yjym494HrKqZSkNONHFIuXBOPB7zGlD+i5oW5tdQVDBH0W Ppo7nJAPFtcrFKUPNRrMLLx59LSVsLwkyXwQZ4lAsij0b5Lb6bJkUsh7QVa5xEth AqR4YE4F82jgnJopBvysixiG71IviV4fAbx+WDEOSxGAd6evwg+wA= Received: (qmail 115339 invoked by alias); 13 Nov 2019 21:50:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 115330 invoked by uid 89); 13 Nov 2019 21:50:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Nov 2019 21:50:26 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D80F2560BE; Wed, 13 Nov 2019 16:50:24 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id PB-KWX43fv21; Wed, 13 Nov 2019 16:50:24 -0500 (EST) Received: from murgatroyd.Home (174-29-59-178.hlrn.qwest.net [174.29.59.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 836D756005; Wed, 13 Nov 2019 16:50:24 -0500 (EST) From: Tom Tromey To: gcc-patches@gcc.gnu.org Cc: Tom Tromey Subject: [PATCH] Remove vestiges of MODIFY_JNI_METHOD_CALL Date: Wed, 13 Nov 2019 14:50:22 -0700 Message-Id: <20191113215022.24339-1-tromey@adacore.com> MIME-Version: 1.0 I happened to notice that MODIFY_JNI_METHOD_CALL was defined in cygming.h and documented in tm.texi. However, because it was only needed for gcj, it is obsolete. This patch removes the vestiges. Tested by grep, and rebuilding the documentation. gcc/ChangeLog 2019-11-13 Tom Tromey * doc/tm.texi: Rebuild. * doc/tm.texi.in (Misc): Don't document MODIFY_JNI_METHOD_CALL. * config/i386/cygming.h (MODIFY_JNI_METHOD_CALL): Don't define. --- gcc/ChangeLog | 6 ++++++ gcc/config/i386/cygming.h | 8 -------- gcc/doc/tm.texi | 16 ---------------- gcc/doc/tm.texi.in | 16 ---------------- 4 files changed, 6 insertions(+), 40 deletions(-) diff --git a/gcc/config/i386/cygming.h b/gcc/config/i386/cygming.h index 6426d96b13c..90006e1a013 100644 --- a/gcc/config/i386/cygming.h +++ b/gcc/config/i386/cygming.h @@ -385,14 +385,6 @@ do { \ const0_rtx)); \ } -/* Java Native Interface (JNI) methods on Win32 are invoked using the - stdcall calling convention. */ -#undef MODIFY_JNI_METHOD_CALL -#define MODIFY_JNI_METHOD_CALL(MDECL) \ - build_type_attribute_variant ((MDECL), \ - build_tree_list (get_identifier ("stdcall"), \ - NULL)) - /* For Win32 ABI compatibility */ #undef DEFAULT_PCC_STRUCT_RETURN #define DEFAULT_PCC_STRUCT_RETURN 0 diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi index 11c236e1c65..4b858d43712 100644 --- a/gcc/doc/tm.texi +++ b/gcc/doc/tm.texi @@ -11778,22 +11778,6 @@ object files that are not referenced from @code{main} and uses export lists. @end defmac -@defmac MODIFY_JNI_METHOD_CALL (@var{mdecl}) -Define this macro to a C expression representing a variant of the -method call @var{mdecl}, if Java Native Interface (JNI) methods -must be invoked differently from other methods on your target. -For example, on 32-bit Microsoft Windows, JNI methods must be invoked using -the @code{stdcall} calling convention and this macro is then -defined as this expression: - -@smallexample -build_type_attribute_variant (@var{mdecl}, - build_tree_list - (get_identifier ("stdcall"), - NULL)) -@end smallexample -@end defmac - @deftypefn {Target Hook} bool TARGET_CANNOT_MODIFY_JUMPS_P (void) This target hook returns @code{true} past the point in which new jump instructions could be created. On machines that require a register for diff --git a/gcc/doc/tm.texi.in b/gcc/doc/tm.texi.in index b8c41b5a7aa..a183cb35bd8 100644 --- a/gcc/doc/tm.texi.in +++ b/gcc/doc/tm.texi.in @@ -7996,22 +7996,6 @@ object files that are not referenced from @code{main} and uses export lists. @end defmac -@defmac MODIFY_JNI_METHOD_CALL (@var{mdecl}) -Define this macro to a C expression representing a variant of the -method call @var{mdecl}, if Java Native Interface (JNI) methods -must be invoked differently from other methods on your target. -For example, on 32-bit Microsoft Windows, JNI methods must be invoked using -the @code{stdcall} calling convention and this macro is then -defined as this expression: - -@smallexample -build_type_attribute_variant (@var{mdecl}, - build_tree_list - (get_identifier ("stdcall"), - NULL)) -@end smallexample -@end defmac - @hook TARGET_CANNOT_MODIFY_JUMPS_P @hook TARGET_HAVE_CONDITIONAL_EXECUTION