From patchwork Wed Nov 13 11:59:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1194226 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="qcUAjp/d"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47Cjqf4FDxz9sPZ for ; Wed, 13 Nov 2019 23:00:44 +1100 (AEDT) Received: from localhost ([::1]:43320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUrKD-000500-04 for incoming@patchwork.ozlabs.org; Wed, 13 Nov 2019 07:00:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33038) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUrJV-0004zd-MV for qemu-devel@nongnu.org; Wed, 13 Nov 2019 06:59:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUrJU-0004CU-KD for qemu-devel@nongnu.org; Wed, 13 Nov 2019 06:59:57 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:40065) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUrJU-0004BB-CR for qemu-devel@nongnu.org; Wed, 13 Nov 2019 06:59:56 -0500 Received: by mail-wm1-x331.google.com with SMTP id f3so1693001wmc.5 for ; Wed, 13 Nov 2019 03:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nyA9Rfm3P2Cacqj24bQZxFtOgORLSIreXZLe4TXhnIU=; b=qcUAjp/dL6/KapTqH2+MWLjDEK8bg8Eve6Ce6QtTFlnOSLLcHD5cQfqjmetgD9zA60 KgGrvcaEmnkleNHZKgikuOLP9ci2xSB3vc7ExV1PwLfCC41JK/Hz83tiYyClmCu9JWFZ ZyJKyXCdFr0EQDsLSUSwJN2rRNsB8B57OOsrKTYd4LMVlAwnqO6DqX9GJfWNTuXz6P+E P9szTeDJ1gYYUSSTwjhiG5Fzm1Azc1cwl7+JYiOLc7q28nCeAf5htKAE/gQlWxqqrpc5 QC1OxQHDodt3DKl+z2ZA0dXn3BkbHWJseh8B2VxrnuxiX1oat0NJNJa2QNdNzxy9pNlb Hz4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nyA9Rfm3P2Cacqj24bQZxFtOgORLSIreXZLe4TXhnIU=; b=shjpeJYWlYrTKFJIq+EYCFKj+knvtLfWsJvNEDecin0NNiXzlhJMiFtsEPAPCLLD7Z hmHzGTiui18zCbPu6q/o4WzJG7Z19c35BuUmW4WK54ZyCdy6CY3JdovEziONohYd3pGz ABV8SKKyXmxZOy2eODbqtEeTBP35eK6UflMyz3xe3keQlBZZnRSxD48f1NCsTLjxxGEP 3rBp8I6xfqitvGcH9Jjog0e3t2/w5BiJlsHYznp6oGf6m47XBRGHZm0yjHtMTnuI7hfO BiIdryF0DFCKckvxwF0yvpNQDvOM3v1vYs5JW9TjL+OKHz4rGXC1en1EQ3jMmzxjnm/u cX9g== X-Gm-Message-State: APjAAAXgvBh7Gg3fp8sAKm5uUPT+mkyL/M9mCI9+TL7xiWlWHOgsrLux Q7clMaO1pfbvtQkSn3SVRoe6bw== X-Google-Smtp-Source: APXvYqzxYD+OA422PVH4aovk7+qB+wzwg5vx1K3TDeVZeBfjAGLH00Lyi3LHquTeHaAKYMzkyEyIHQ== X-Received: by 2002:a1c:28d4:: with SMTP id o203mr2478473wmo.147.1573646394032; Wed, 13 Nov 2019 03:59:54 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id y67sm2183975wmy.31.2019.11.13.03.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2019 03:59:52 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 430431FF8C; Wed, 13 Nov 2019 11:59:52 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 1/5] tests/vm: make --interactive (and therefore DEBUG=1) unconditional Date: Wed, 13 Nov 2019 11:59:48 +0000 Message-Id: <20191113115952.775-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191113115952.775-1-alex.bennee@linaro.org> References: <20191113115952.775-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::331 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, Peter Maydell , berrange@redhat.com, stefanb@linux.vnet.ibm.com, =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= , richard.henderson@linaro.org, f4bug@amsat.org, =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , cota@braap.org, stefanha@redhat.com, marcandre.lureau@redhat.com, pbonzini@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" While the concept of only dropping to ssh if a test fails is nice it is more useful for this to be unconditional. You usually just want to get the build up and running and then noodle around debugging or attempting to replicate. Cc: Peter Maydell Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth --- v2 - fix spelling --- tests/vm/basevm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 91a9226026d..0b8c1b26576 100755 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -403,7 +403,7 @@ def main(vmcls): exitcode = 0 if vm.ssh(*cmd) != 0: exitcode = 3 - if exitcode != 0 and args.interactive: + if args.interactive: vm.ssh() if not args.snapshot: From patchwork Wed Nov 13 11:59:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1194230 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ghjrz3Ef"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47Cjtm22Fqz9sPZ for ; Wed, 13 Nov 2019 23:03:28 +1100 (AEDT) Received: from localhost ([::1]:43384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUrMr-0007g0-Kq for incoming@patchwork.ozlabs.org; Wed, 13 Nov 2019 07:03:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33056) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUrJW-0004zy-Rn for qemu-devel@nongnu.org; Wed, 13 Nov 2019 06:59:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUrJV-0004DK-TC for qemu-devel@nongnu.org; Wed, 13 Nov 2019 06:59:58 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:33606) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUrJV-0004Cp-NX for qemu-devel@nongnu.org; Wed, 13 Nov 2019 06:59:57 -0500 Received: by mail-wr1-x42b.google.com with SMTP id w9so2068482wrr.0 for ; Wed, 13 Nov 2019 03:59:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=stPfjhlfRMtU6DLfmn85a0s8Wa67hLr8dK2T2ih0OY4=; b=ghjrz3EfbiQsT3+7cAy6uSTO21arqBT2RfdyzbPyda5Yc7JKMQ9Rnnzhc0Xt5UzpfB Gf0t4Z2lKPAYYZlZzjT6QaO9Uqf6QGcN/o7SgOnKoMvck7ofZMT/ruRqkJ7KGnFvVC3p jFnvXxBSfKopEaCcA5JfK5RduVzXq7+13rMJB9Oan5X4SL2bZbPcudw03nqWIVbh9zLi UKzK+HoLOH1+qm7K5hdXqlW10dJdXwPrK5K2WOHj5WZlyPvKjtsppAQgT2lxutLH3eoT TSSEeLirOyDFKCYLbKSUqIN0DmFPrS4DypwFBIP5sQfNZWcbzjFcHTblPH7bGipxsmQW FMqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=stPfjhlfRMtU6DLfmn85a0s8Wa67hLr8dK2T2ih0OY4=; b=WqJ7zPn6slGxJIDdlmioJmFwOENbVfI1xOtx77dhkcfBsyackNne+d1XlPJlznScjK 5c0xOo8IO1GIsKk7lfniaDUa3UYWEKkG9zyn0biyABf8okly0hxk7AliwMiN3snbX0ku ZHO9G4XxuszeKSA8N3VZBE7xd9LGDZFHz/y9QgF9z7BJD8CAOqnlU2ZCRav+VvlzuH+m QmRVnSwL+gwLPuB/eobPtqDZ0VS10UoGW8qV2NCmtyhIqOtHrB/Cqoom1uuN8eKxghPt gd+7u/gKHbC343gJnpIwtvZx2apPaU1qNts5l15W2Gxpz5lCMNTaYdn+0Npnf33QHZoK sRMg== X-Gm-Message-State: APjAAAXzqkY5Wk2CjkQyL4ZHm3rV4TlKUDBdzPLxJ1AdIeJvO1wtSOqW Rbsi0vzdP+tFAzrzQPh2K5CkHQ== X-Google-Smtp-Source: APXvYqyMajJS/tDBpz4XlN2In++Z2eymT6t2FosMhvJpna+UJKiainjnIgtwK91nhA3uQwlDlNLL7g== X-Received: by 2002:adf:ffd0:: with SMTP id x16mr2348584wrs.86.1573646396534; Wed, 13 Nov 2019 03:59:56 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id d202sm1900461wmd.47.2019.11.13.03.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2019 03:59:52 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 57A141FF8F; Wed, 13 Nov 2019 11:59:52 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 2/5] docs/devel: rename plugins.rst to tcg-plugins.rst Date: Wed, 13 Nov 2019 11:59:49 +0000 Message-Id: <20191113115952.775-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191113115952.775-1-alex.bennee@linaro.org> References: <20191113115952.775-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42b X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, stefanb@linux.vnet.ibm.com, =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org, f4bug@amsat.org, cota@braap.org, stefanha@redhat.com, marcandre.lureau@redhat.com, pbonzini@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" This makes it a bit clearer what this is about. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- docs/devel/index.rst | 2 +- docs/devel/{plugins.rst => tcg-plugins.rst} | 0 MAINTAINERS | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) rename docs/devel/{plugins.rst => tcg-plugins.rst} (100%) diff --git a/docs/devel/index.rst b/docs/devel/index.rst index 2ff058bae38..c86a3cdff2f 100644 --- a/docs/devel/index.rst +++ b/docs/devel/index.rst @@ -22,4 +22,4 @@ Contents: decodetree secure-coding-practices tcg - plugins + tcg-plugins diff --git a/docs/devel/plugins.rst b/docs/devel/tcg-plugins.rst similarity index 100% rename from docs/devel/plugins.rst rename to docs/devel/tcg-plugins.rst diff --git a/MAINTAINERS b/MAINTAINERS index ff8d0d29f4b..b160d817208 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2369,6 +2369,7 @@ F: tcg/ TCG Plugins M: Alex Bennée S: Maintained +F: docs/devel/tcg-plugins.rst F: plugins/ F: tests/plugin From patchwork Wed Nov 13 11:59:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1194232 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="pCNQqF9/"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47Cjvs6gwHz9s7T for ; Wed, 13 Nov 2019 23:04:25 +1100 (AEDT) Received: from localhost ([::1]:43404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUrNn-0000WV-RE for incoming@patchwork.ozlabs.org; Wed, 13 Nov 2019 07:04:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33071) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUrJY-00050U-9c for qemu-devel@nongnu.org; Wed, 13 Nov 2019 07:00:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUrJX-0004E6-6b for qemu-devel@nongnu.org; Wed, 13 Nov 2019 07:00:00 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:35838) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUrJX-0004De-0p for qemu-devel@nongnu.org; Wed, 13 Nov 2019 06:59:59 -0500 Received: by mail-wr1-x444.google.com with SMTP id s5so2061926wrw.2 for ; Wed, 13 Nov 2019 03:59:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LLUdVSuPei6RAwTaPKVy6/3rq24iATJe7bkWNsh6uTU=; b=pCNQqF9/m0xFj0siyxMAgjxY47lz1d85wHe2FmDsJVgAWI6UEEaXZNn3dO6xloLRCA kEa8kLgYK0IepcSqjDfAK7XJ/4LQE74Yu4ro53r5zN5snIscTk8D4U0QFuRw+B2iQee/ MYM9A2vq295bQCvo+Cn5drsOYw9cLdCKvui9tlws63DKkyphv7drWEkifzMjvVQUXsEM Y+vKIWjBNQIDGxl5VDRgiivsgfpLjaLG3rFkcW/CWJg/c613PZqcu34KgUEApYuRnbaD v0tj8+MNK4UpWfdbf1lAZlnnqMc9ticIKHUwmCNIVTqK2zd6+BrH7600TVoediHOHWUv qEAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LLUdVSuPei6RAwTaPKVy6/3rq24iATJe7bkWNsh6uTU=; b=bZkQAiIpJQGxAIKYgA45trqfR/cWtu4M29daNplitkr9+0gMYdIoBKkrqqDzfkXvUf j+6WbgVS6U4ZxufTR+O+7BBG0KlRlvEvP23Dp2fVuiR6Pe6QGJgtsvgtUgiF6ojjrhjn dvW8pun8wZzTiRQeJ8TBxVV+etj5Qkjlmn3v0CX3LqFj/Nq9sI1mzOHyUWLYSjme1KwI +AJY5KnOLCpnP2W7AB250U2erkoE7HsNrCR6MijP2CzkFAVn4c7eJWi76BkRXbnAQUpp oJ0YRadzX+PuKturYn/x2i+N9VuGY3VLfJn7EKfGIa9dFGHqfAKyMuW5V+BqeSNYjEiN qvnA== X-Gm-Message-State: APjAAAUIgfSkf6fnj8OTCRtVhZUFWefy1SxGjB916Qxju2RjbKjmV0eU bXiJhJ2KpieqklthOvcZhQdsNw== X-Google-Smtp-Source: APXvYqy8fRBi/cqGcYgUKAmKaoTPeCDEPtLiFYN/CVJLjShe+/Yw7d/ENFCxKzSLESwWpiUxa9HzAw== X-Received: by 2002:a5d:48c8:: with SMTP id p8mr2617842wrs.318.1573646397870; Wed, 13 Nov 2019 03:59:57 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id 200sm2432008wme.32.2019.11.13.03.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2019 03:59:56 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 6D0EB1FF90; Wed, 13 Nov 2019 11:59:52 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 3/5] docs/devel: update tcg-plugins.rst with API versioning details Date: Wed, 13 Nov 2019 11:59:50 +0000 Message-Id: <20191113115952.775-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191113115952.775-1-alex.bennee@linaro.org> References: <20191113115952.775-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, stefanb@linux.vnet.ibm.com, =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org, f4bug@amsat.org, cota@braap.org, stefanha@redhat.com, marcandre.lureau@redhat.com, pbonzini@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" While we are at it fix up the quoted code sections with the inline :: approach. Signed-off-by: Alex Bennée Reviewed-by: Robert Foley --- v2 - fix grammar - mention we also will fail to load outside the range - clean-up code sections --- docs/devel/tcg-plugins.rst | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst index b18fb6729e3..718eef00f22 100644 --- a/docs/devel/tcg-plugins.rst +++ b/docs/devel/tcg-plugins.rst @@ -25,6 +25,23 @@ process. However the project reserves the right to change or break the API should it need to do so. The best way to avoid this is to submit your plugin upstream so they can be updated if/when the API changes. +API versioning +-------------- + +All plugins need to declare a symbol which exports the plugin API +version they were built against. This can be done simply by:: + + QEMU_PLUGIN_EXPORT int qemu_plugin_version = QEMU_PLUGIN_VERSION; + +The core code will refuse to load a plugin that doesn't export a +`qemu_plugin_version` symbol or if plugin version is outside of QEMU's +supported range of API versions. + +Additionally the `qemu_info_t` structure which is passed to the +`qemu_plugin_install` method of a plugin will detail the minimum and +current API versions supported by QEMU. The API version will be +incremented if new APIs are added. The minimum API version will be +incremented if existing APIs are changed or removed. Exposure of QEMU internals -------------------------- @@ -40,16 +57,14 @@ instructions and events are opaque to the plugins themselves. Usage ===== -The QEMU binary needs to be compiled for plugin support: +The QEMU binary needs to be compiled for plugin support:: -:: - configure --enable-plugins + configure --enable-plugins Once built a program can be run with multiple plugins loaded each with -their own arguments: +their own arguments:: -:: - $QEMU $OTHER_QEMU_ARGS \ + $QEMU $OTHER_QEMU_ARGS \ -plugin tests/plugin/libhowvec.so,arg=inline,arg=hint \ -plugin tests/plugin/libhotblocks.so From patchwork Wed Nov 13 11:59:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1194233 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="WxoFSJlE"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47Cjx14XkRz9sPZ for ; Wed, 13 Nov 2019 23:05:25 +1100 (AEDT) Received: from localhost ([::1]:43416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUrOl-0001OS-Ho for incoming@patchwork.ozlabs.org; Wed, 13 Nov 2019 07:05:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33101) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUrJb-00055Z-PL for qemu-devel@nongnu.org; Wed, 13 Nov 2019 07:00:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUrJa-0004GC-G3 for qemu-devel@nongnu.org; Wed, 13 Nov 2019 07:00:03 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:34040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUrJa-0004FL-99 for qemu-devel@nongnu.org; Wed, 13 Nov 2019 07:00:02 -0500 Received: by mail-wr1-x441.google.com with SMTP id e6so2070071wrw.1 for ; Wed, 13 Nov 2019 04:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dAtTKvTGGLbgatjy9hszVeJW8BTJjLusZ3gELbhkEj4=; b=WxoFSJlEj2PN5haYt/fN+QdjGnMogU4uXP9+eLqNngRW8W6VKaJiD34MZPW9lWFbNy 0hAd1JcemYlOV7G+BPHEt+aNr7WosFzhGp7kSpisaYUpdc80NVkUkxSAXGKX/BgTWurW ZDxlVvABf9GGjBnSNWlTKzoICPhca3e/1u1pa6/7ucvl4eUTrGy0ydy2E1PzlTo+Ng+W o+iRmSb/geS/VshGO5Yxo6oMtqoRyPo2Jvtglfbnie3ecdjf1xXdacCPKLYn15FYfdMj /MEU3cz9d3hvxTxJbJXZ9Ksd3hJhEvkgxx8RihVXe/hoLnezmPQArW+x6Qn6MvAFMFGo TyXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dAtTKvTGGLbgatjy9hszVeJW8BTJjLusZ3gELbhkEj4=; b=TrQlQKbNGvYQhtCfmOoZFun+pNb0ZBry581K08Xcj8aDJL+LKxvb37sBz6t+MLva85 qNhVFaWjw/zb3HaJh5zpFtfy0uOCekkmWwmi6NIdY88eSLvPBSO5lvOYq9X2x2jbEOnH hbk/47v7cSIWZu36NR/6xlPgvhA9bZvdfXterGqTT3xoe1LAqD6KBSFxYY1M8svBAbOX NC8SGZrCZ9PV+HexcXc3QUbz8LgEQUVesR7i9x5zPfqBmAwYwU3LUkNJDl5hOQz4W9G9 ffZkSApZzLKTwG+a3rtlOozbL0BJ+OfCYsVq7YVNnMWkwN6AFK17oj/Cdc7JxWTX+BHY 8bLA== X-Gm-Message-State: APjAAAVWeqp9hukRa5YryvavuGXML+5Wft3tT0GDxyGtzsjEWZtgdlqR yc/72MX5SyweRqCiPyKkadb1mrJpX24= X-Google-Smtp-Source: APXvYqxs9LH3o+w8MIelf4F6m1mYuGQZ0xo5bEOmeQ4kBkS7cjJ6Iuk+vDApcjg7kOVETzhqqaqwIA== X-Received: by 2002:a5d:6746:: with SMTP id l6mr2433214wrw.349.1573646400980; Wed, 13 Nov 2019 04:00:00 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id z4sm2181219wmf.36.2019.11.13.03.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2019 03:59:56 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 860281FF91; Wed, 13 Nov 2019 11:59:52 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 4/5] docs/devel: convert multi-thread-tcg to a .rst document Date: Wed, 13 Nov 2019 11:59:51 +0000 Message-Id: <20191113115952.775-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191113115952.775-1-alex.bennee@linaro.org> References: <20191113115952.775-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, stefanb@linux.vnet.ibm.com, =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org, f4bug@amsat.org, cota@braap.org, stefanha@redhat.com, marcandre.lureau@redhat.com, pbonzini@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Alex Bennée --- docs/devel/index.rst | 1 + ...ti-thread-tcg.txt => multi-thread-tcg.rst} | 28 ++++++++++++------- 2 files changed, 19 insertions(+), 10 deletions(-) rename docs/devel/{multi-thread-tcg.txt => multi-thread-tcg.rst} (96%) diff --git a/docs/devel/index.rst b/docs/devel/index.rst index c86a3cdff2f..3e6624ec604 100644 --- a/docs/devel/index.rst +++ b/docs/devel/index.rst @@ -22,4 +22,5 @@ Contents: decodetree secure-coding-practices tcg + multi-thread-tcg tcg-plugins diff --git a/docs/devel/multi-thread-tcg.txt b/docs/devel/multi-thread-tcg.rst similarity index 96% rename from docs/devel/multi-thread-tcg.txt rename to docs/devel/multi-thread-tcg.rst index 782bebc28b4..4e914bacc0c 100644 --- a/docs/devel/multi-thread-tcg.txt +++ b/docs/devel/multi-thread-tcg.rst @@ -1,7 +1,10 @@ -Copyright (c) 2015-2016 Linaro Ltd. +.. Copyright (c) 2015-2016 Linaro Ltd. +.. This work is licensed under the terms of the GNU GPL, version 2 or +.. later. See the COPYING file in the top-level directory. -This work is licensed under the terms of the GNU GPL, version 2 or -later. See the COPYING file in the top-level directory. +================== +Multi-threaded TCG +================== Introduction ============ @@ -40,7 +43,7 @@ Main Run Loop Even when there is no code being generated there are a number of structures associated with the hot-path through the main run-loop. These are associated with looking up the next translation block to -execute. These include: +execute. These include:: tb_jmp_cache (per-vCPU, cache of recent jumps) tb_ctx.htable (global hash table, phys address->tb lookup) @@ -61,7 +64,9 @@ have their block-to-block jumps patched. Global TCG State ---------------- -### User-mode emulation +User-mode emulation +~~~~~~~~~~~~~~~~~~~ + We need to protect the entire code generation cycle including any post generation patching of the translated code. This also implies a shared translation buffer which contains code running on all cores. Any @@ -78,7 +83,9 @@ patching. Code generation is serialised with mmap_lock(). -### !User-mode emulation +System emulation +~~~~~~~~~~~~~~~~ + Each vCPU has its own TCG context and associated TCG region, thereby requiring no locking. @@ -125,10 +132,11 @@ linked list of all Translation Blocks in that page (see page_next). Both the jump patching and the page cache involve linked lists that the invalidated TranslationBlock needs to be removed from. -DESIGN REQUIREMENT: Safely handle invalidation of TBs - - safely patch/revert direct jumps - - remove central PageDesc lookup entries - - ensure lookup caches/hashes are safely updated +DESIGN REQUIREMENTS: + - Safely handle invalidation of TBs + - safely patch/revert direct jumps + - remove central PageDesc lookup entries + - ensure lookup caches/hashes are safely updated (Current solution) From patchwork Wed Nov 13 11:59:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1194228 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="eVPQ0Y9W"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47Cjr65x47z9sPJ for ; Wed, 13 Nov 2019 23:01:10 +1100 (AEDT) Received: from localhost ([::1]:43356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUrKe-0005B0-C3 for incoming@patchwork.ozlabs.org; Wed, 13 Nov 2019 07:01:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33087) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUrJZ-00052p-MS for qemu-devel@nongnu.org; Wed, 13 Nov 2019 07:00:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUrJY-0004Ej-G7 for qemu-devel@nongnu.org; Wed, 13 Nov 2019 07:00:01 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:38302) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUrJY-0004EI-AH for qemu-devel@nongnu.org; Wed, 13 Nov 2019 07:00:00 -0500 Received: by mail-wm1-x341.google.com with SMTP id z19so1708516wmk.3 for ; Wed, 13 Nov 2019 04:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hHy+s1GjJ2Pj+MpNXAGF+PVR24txIcWOxbNUbbYLGfQ=; b=eVPQ0Y9WRTXYDIfJ8BZ5JDLy10VSWn1LR/H7bqSNCvQ7fQps7Uv7U7CFrqYkbH0eBS mlgJ7hcQgFGr22pq/Avy1TGMF3KGQPsGmEcJv+KndGM42thnxgrMG6TCsKcnn8qZ0SRU K/vFAPQaBdZ8J3bQwX3FhSqEnISwxrFI0BLwKP3kyUhWxjj6BGeNjPQQvSi89sygcHV1 SRoPFI8nhiZNzY0sULLPLIuVd0WZse8Tae/sWxCVJZFLdevQzuJ9sJGhYLu6AyDKt/BL c69wKSZnaaH2+9wy8KpvhwDpc9ockG3gyi5mcpsN5Y+fpAt2cSHwJ/EXB3ITJ5I0F2Pc 8IPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hHy+s1GjJ2Pj+MpNXAGF+PVR24txIcWOxbNUbbYLGfQ=; b=ScAFDyeWHtbuHN2xr90DVJVCcRGoMQhJwvvehS1/vKS555IpGISsCjZWxChQw5AYW7 WLgreDxm9AEp1TAuK+GySEChDQowWrpIAiE0xIXzz8ZIKOhPuJi1L/SoubT7XUQtaNnE OhfGzHgEqaCr2xZhzrIVrkwe4NGH28Wt7uIOZbPd1l9nkCuJOJofktLPcuPfcljFesoX HiksNV4l5h2dXBJXdhHUQgBuccgYtXWlsPK4AFWJC3ll0SmWKDJmrSHeHKJ6PJpv2SsG NiYsUb0IxmwdigO7tgTOYds2frJFKaQ7FyDGfSKOD8AJSwgWsBY0rrDkz6AQ3VCHY6ZF MGOg== X-Gm-Message-State: APjAAAUoZKc0pFnKQ9hfjOdkhZT7OPI+lts6bi0LK8+nZpOc9fNE6LM9 1uD2d1nNRS9upEAZKixLhCebsA== X-Google-Smtp-Source: APXvYqxyHMHZS0VXykLM0bZtp1uuPdIkgaCPZpMqf14Mw9nIRWQggtVjew7X1s9k6cqu7nam+EXwcw== X-Received: by 2002:a1c:9dd3:: with SMTP id g202mr2539263wme.43.1573646399143; Wed, 13 Nov 2019 03:59:59 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id h140sm2475558wme.22.2019.11.13.03.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2019 03:59:56 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 9BD381FF92; Wed, 13 Nov 2019 11:59:52 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 5/5] .travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS Date: Wed, 13 Nov 2019 11:59:52 +0000 Message-Id: <20191113115952.775-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191113115952.775-1-alex.bennee@linaro.org> References: <20191113115952.775-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, stefanb@linux.vnet.ibm.com, =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org, f4bug@amsat.org, =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , cota@braap.org, stefanha@redhat.com, marcandre.lureau@redhat.com, pbonzini@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The older clangs are still struggling to build and run everything withing the 50 minute timeout so lets lighten the load a bit more. We still have coverage for GCC and hopefully no obscure 32 bit guest only breakages slip through the cracks. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index b9a026c8eeb..c09b6a00143 100644 --- a/.travis.yml +++ b/.travis.yml @@ -79,7 +79,7 @@ env: - BASE_CONFIG="--disable-docs --disable-tools" - TEST_CMD="make check V=1" # This is broadly a list of "mainline" softmmu targets which have support across the major distros - - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" + - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" - CCACHE_SLOPPINESS="include_file_ctime,include_file_mtime" - CCACHE_MAXSIZE=1G