From patchwork Thu Nov 7 23:55:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Segher Boessenkool X-Patchwork-Id: 1191519 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-512770-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="ddGLq2jL"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 478KzQ6lhVz9sNH for ; Fri, 8 Nov 2019 10:55:46 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id; q=dns; s=default; b=EGwulxh+Fazd TyGbs/RhrnuKAapEuEGNgpC71UZ1JnDo7fOC5VCZkuwxIoTTpQLypL/lSdWKRL3S Sqqv2JUwGcFkjWp0hq7Y9YkUqtd8/PXPYJNy+rc31BKq4wSvaBjsBIlQNPdMf5+R t4fUoE8VteWBYhc37KeNExZ1xG/Y2T8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id; s=default; bh=WGuMc201QCuKF+d5Go 8732BT5YY=; b=ddGLq2jLH2Lyh2ov/yws3h/YC+aX36idMgejVN64umDr/pBAy3 DWKE92DUEgBBaiLeykEtlcZ2UAkmlFPZSwxRSDzZXtNG8ieNhak+OBuNqMy8I2at gXXSUjKADZy0SCg8Ha/M3fAdfOOiWI8xWHLs4w9hOG9XXn2DbfN6NRUvo= Received: (qmail 10285 invoked by alias); 7 Nov 2019 23:55:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 10276 invoked by uid 89); 7 Nov 2019 23:55:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1404 X-HELO: gcc1-power7.osuosl.org Received: from gcc1-power7.osuosl.org (HELO gcc1-power7.osuosl.org) (140.211.15.137) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Nov 2019 23:55:37 +0000 Received: by gcc1-power7.osuosl.org (Postfix, from userid 10019) id 2F6E912408CA; Thu, 7 Nov 2019 23:55:36 +0000 (UTC) From: Segher Boessenkool To: gcc-patches@gcc.gnu.org Cc: dje.gcc@gmail.com, Segher Boessenkool Subject: [PATCH] rs6000: Remove no longer correct assert Date: Thu, 7 Nov 2019 23:55:34 +0000 Message-Id: X-IsSubscribed: yes After the simplify-rtx patch, we can now be asked about conditions we wouldn't be asked about before. This is perfectly fine, except we have a little over-eager assert. Remove that one. I originally had this patch before the simplify-rtx one, but I reordered them without retesting every step. And broke the powerpc bootstraps now. So sorry. It failed in stage 1 before, it's still building but past there, so I'll commit this now. Segher 2019-11-07 Segher Boessenkool * config/rs6000/rs6000.c (validate_condition_mode): Don't assert for valid conditions. --- gcc/config/rs6000/rs6000.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c index d9d275b..d48157a 100644 --- a/gcc/config/rs6000/rs6000.c +++ b/gcc/config/rs6000/rs6000.c @@ -10250,14 +10250,6 @@ validate_condition_mode (enum rtx_code code, machine_mode mode) && code != UNGT && code != UNLT && code != UNGE && code != UNLE)); - /* These should never be generated except for - flag_finite_math_only. */ - gcc_assert (mode != CCFPmode - || flag_finite_math_only - || (code != LE && code != GE - && code != UNEQ && code != LTGT - && code != UNGT && code != UNLT)); - /* These are invalid; the information is not there. */ gcc_assert (mode != CCEQmode || code == EQ || code == NE); }