From patchwork Mon Sep 4 15:35:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 809724 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="ahu+T6qZ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xmDT45dHvz9t2c for ; Tue, 5 Sep 2017 01:35:52 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753932AbdIDPfi (ORCPT ); Mon, 4 Sep 2017 11:35:38 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:54966 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753748AbdIDPff (ORCPT ); Mon, 4 Sep 2017 11:35:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-ID:Subject:From:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CUxY/mue3Evy8XDyndIZI2KggdypeDW9LWaLMVg9E7s=; b=ahu+T6qZdVTPSeMB95CrVo/2Q 2FlwCLDH1Pbzn/7KtPJgC+nFUq+APERQnwY00GMtxHRkp1CxmqjUpQ/+35su8JsTIG2DhoM2njl4Z WOdoQfhOJ3yCO8mZlsnnL02fHhxq/pGffKLFv5YfvEO//3WC3twE6GZlU6rgSwiDiSPbyrM+bKhmp 27FcYqW03Wub9raRkkSJR9wVLkFo+xIxMkHm1YQIFgGgeR0R9+LRwzQmfxy7pPDYS63ukqMGIn78S AgoeL7eH0tBkpQBvhUWHKZ6ew7VUqDnnwQn6o3SpaxYFk9+9uvWK/c9Tpivg4w+OKtlcjhrgkJrHo Y9w93BzBA==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlap) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1dotPP-000132-0b; Mon, 04 Sep 2017 15:35:31 +0000 To: LKML , Linus Walleij , Baolin Wang , "linux-gpio@vger.kernel.org" From: Randy Dunlap Subject: [PATCH -next] pinctrl: sprd: fix build errors and dependencies Message-ID: Date: Mon, 4 Sep 2017 08:35:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Language: en-US Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Randy Dunlap Fix build errors when CONFIG_OF is not enabled. Also, the pinctrl-sprd-sc9860 driver uses functions from the pinctrl-sprd driver, so the former should depend on the latter driver. ../drivers/pinctrl/sprd/pinctrl-sprd.c: In function 'sprd_dt_node_to_map': ../drivers/pinctrl/sprd/pinctrl-sprd.c:290:2: error: implicit declaration of function 'pinconf_generic_parse_dt_config' [-Werror=implicit-function-declaration] ret = pinconf_generic_parse_dt_config(np, pctldev, &configs, ^ ../drivers/pinctrl/sprd/pinctrl-sprd.c: At top level: ../drivers/pinctrl/sprd/pinctrl-sprd.c:844:44: error: array type has incomplete element type static const struct pinconf_generic_params sprd_dt_params[] = { ^ Signed-off-by: Randy Dunlap Cc: Baolin Wang Cc: Linus Walleij Cc: linux-gpio@vger.kernel.org --- drivers/pinctrl/sprd/Kconfig | 2 ++ 1 file changed, 2 insertions(+) Why are these drivers not buildable as loadable modules? I.e., why bool instead of tristate? -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-next-20170904.orig/drivers/pinctrl/sprd/Kconfig +++ linux-next-20170904/drivers/pinctrl/sprd/Kconfig @@ -8,10 +8,12 @@ config PINCTRL_SPRD select PINCONF select GENERIC_PINCONF select GENERIC_PINMUX_FUNCTIONS + depends on OF help Say Y here to enable Spreadtrum pinctrl driver config PINCTRL_SPRD_SC9860 bool "Spreadtrum SC9860 pinctrl driver" + depends on PINCTRL_SPRD help Say Y here to enable Spreadtrum SC9860 pinctrl driver