From patchwork Tue Nov 5 11:34:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Malcomson X-Patchwork-Id: 1189604 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-512438-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="enrPHxLW"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="Cnt4u/Ts"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="Cnt4u/Ts"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 476ng44bDRz9sNT for ; Tue, 5 Nov 2019 22:36:16 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:mime-version; q=dns; s=default; b=O6ZmW7tbXvQU43L8 S/+Zm3a86N35drmuyuTsVwC7uyx7O/ruTbgSJq7FTKAE6Wjjz+oM6K5QSUVUPUFH cPXJGed04+YN6rsfR/8TNy14xrOz3a0D8cNpuD7fOi2thDWivNfhndUPLlfTjzmb C6ZZx342RANFjnJAdKaSsjXWQNs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:mime-version; s=default; bh=UE0RtKL2H5UO7R12WPaoaT lFdOg=; b=enrPHxLWW7wHfd44OMWTdvlD/401Hk4GMQld9o9BZKqoSJACNs6/JU X0O2lFd5cxCNyfh54fbu/PijnOnCd2v/1fZrFXvsYASDFkqhPfYgxQlzaTDBoByZ pw2c+msJTKft2U4hD1qlJGVidCTWf8uHeZwxP6RZLE1f1gT18zuUE= Received: (qmail 86232 invoked by alias); 5 Nov 2019 11:34:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 86109 invoked by uid 89); 5 Nov 2019 11:34:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR02-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr10046.outbound.protection.outlook.com (HELO EUR02-HE1-obe.outbound.protection.outlook.com) (40.107.1.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2019 11:34:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RrH88oPs6dCqZk1EmO18HCjeyTQ6tcMgP1DAGnAtN6A=; b=Cnt4u/Ts5E1FRl3gL9cejq6R0St6W6zCWmMGg8x+BNIBbW8xG5xmh9jA4NglPF//zv11a4r2DCjRylG5+Aj4BTGyppuDzSLlCjeiDpqRevOp3+pee6joWFbpeOXhdY0DWCf6cCBWdoM7N9pooraKETGeZZo6B4rEiWO8kLbFgzA= Received: from VE1PR08CA0006.eurprd08.prod.outlook.com (2603:10a6:803:104::19) by AM0PR08MB5412.eurprd08.prod.outlook.com (2603:10a6:208:186::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Tue, 5 Nov 2019 11:34:21 +0000 Received: from VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::208) by VE1PR08CA0006.outlook.office365.com (2603:10a6:803:104::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2408.24 via Frontend Transport; Tue, 5 Nov 2019 11:34:21 +0000 Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT015.mail.protection.outlook.com (10.152.18.176) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2387.20 via Frontend Transport; Tue, 5 Nov 2019 11:34:20 +0000 Received: ("Tessian outbound 0939a6bab6b1:v33"); Tue, 05 Nov 2019 11:34:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 14f39fed2b514dc8 X-CR-MTA-TID: 64aa7808 Received: from c07d5b7faf29.4 (cr-mta-lb-1.cr-mta-net [104.47.14.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7510E1D4-3988-457C-BA7F-29773ADA58D9.1; Tue, 05 Nov 2019 11:34:15 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c07d5b7faf29.4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Nov 2019 11:34:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XJQoNzW59ZFqX1D96eIS9+ePIFuXvCLQHtexiLCotl2R2e5l1oTahpR+T+txuT/q9dKI96pmM8EwnyGbTjAMXnTU8tfUvOqT/xkv0V6Tt6UGzI0O+Si0DnEdhi4le9pHnaAzIB4H7QyqcU5kLLX7fIb7xrBDUTqdoPDMtiexKBEzF4pah7cGX08MrQOafAaGSNd3Pw45HICKOn6PPn38LpLOxki4waw88ubgnxx9L6GrFKXK6+vEK6fKQj5Sq475kzRGkY/emV6d2ZffZd3XGo0nFrJDVX5uxoJcnmUoQZANWFi813nMaw0sOmBo6DtORZGA+VaqNLOxNJkvv7kjFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RrH88oPs6dCqZk1EmO18HCjeyTQ6tcMgP1DAGnAtN6A=; b=No/tym8q65of0xPGLj6AuHyYPJhZpDaJW6VPNRCaR5oA/pE13PgmAzOvupOw7UcLBeOqOjWGIXQvlD/qK9NZnpRwiqVrkL+1CNSG0f4NLjBhmQkuDTUmigwyFP2jhuD2T2fpYSVYK5cT0Id9va1HHfR4TUPuG/bP2NcycfHDxFzQ2FrPgRPzk1y4PWu4pTg2cg99E2yop3sWDfnCGfDBvsA7wTZV1tQHhnXVXeMdmDe7fQFwL7IU1MTiTj4uVsJyDuf8Jxu2UfEdAjqqceWBzfHglqYzZMP3qdjlMbVxO2ZTGg+HdIMoVGkeqrmfgiyp5A3Dlac8188Nv176/s+oVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RrH88oPs6dCqZk1EmO18HCjeyTQ6tcMgP1DAGnAtN6A=; b=Cnt4u/Ts5E1FRl3gL9cejq6R0St6W6zCWmMGg8x+BNIBbW8xG5xmh9jA4NglPF//zv11a4r2DCjRylG5+Aj4BTGyppuDzSLlCjeiDpqRevOp3+pee6joWFbpeOXhdY0DWCf6cCBWdoM7N9pooraKETGeZZo6B4rEiWO8kLbFgzA= Received: from HE1PR0802MB2251.eurprd08.prod.outlook.com (10.172.131.21) by HE1PR0802MB2313.eurprd08.prod.outlook.com (10.172.127.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Tue, 5 Nov 2019 11:34:13 +0000 Received: from HE1PR0802MB2251.eurprd08.prod.outlook.com ([fe80::e120:9a38:bcf4:6075]) by HE1PR0802MB2251.eurprd08.prod.outlook.com ([fe80::e120:9a38:bcf4:6075%5]) with mapi id 15.20.2408.024; Tue, 5 Nov 2019 11:34:13 +0000 From: Matthew Malcomson To: "gcc-patches@gcc.gnu.org" CC: nd , "kcc@google.com" , "dvyukov@google.com" , Martin Liska , Richard Earnshaw , Kyrylo Tkachov , "dodji@redhat.com" , "jakub@redhat.com" Subject: [PATCH 7/X] [libsanitizer] Add missing SANITIZER_INTERFACE_ATTRIBUTE on __hwasan_personality_wrapper Date: Tue, 5 Nov 2019 11:34:13 +0000 Message-ID: References: <157295142743.27946.1142544630216676787.scripted-patch-series@arm.com> In-Reply-To: <157295142743.27946.1142544630216676787.scripted-patch-series@arm.com> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Matthew.Malcomson@arm.com; x-ms-exchange-transport-forked: True x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:2803;OLM:2803; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(376002)(136003)(396003)(366004)(39860400002)(346002)(54534003)(189003)(199004)(11346002)(446003)(66616009)(5660300002)(26005)(102836004)(7696005)(2501003)(6506007)(7736002)(8676002)(81156014)(81166006)(33656002)(478600001)(74316002)(2906002)(76176011)(186003)(386003)(99936001)(8936002)(14454004)(2351001)(44832011)(486006)(476003)(66476007)(316002)(52116002)(71190400001)(6116002)(25786009)(3846002)(305945005)(54906003)(86362001)(66066001)(9686003)(6436002)(5024004)(5640700003)(4326008)(55016002)(99286004)(66446008)(71200400001)(66556008)(52536014)(66946007)(64756008)(256004)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0802MB2313; H:HE1PR0802MB2251.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: otz02JBTR81l8RDjRVvOAzJf8d/kXM4rT/O2Vw3pM9rvWFdM/bvrywSZZGaiJXXbxrICe/i10m87A45mCtoxYf3IGk50VNxtZB/YvnK2YTGAymZAPNmqpDKXaZFvzMKZAIjwgsA9dP1uocgYbpij2uCcTX96aOMTvlEtFGOtTIYcf73+CsmOqk96PaMbohZfj68AuVQAQQOSF/aIf4nV2mxhLr2Eo3kjPZ/lRAAQ1ObzPaezb5k9G0HGbA6nhqE+cJ/HLCd0xbcw+CCzcSL7Xxsl3jnQWqQ4DLrn4h2jmmdddhZbHiNXPQocph10knaap2r6hYs9T5p8UBkI6D66yeeIdDB0kJq2uuH+nGcyl57NJdJLfuWngOY8fcElACSzMP0PnduriMdCK+yXikUeNcSRTvtNSgzJmLxv6MHQkZxc78q9xOh4zKr9IoQv0hnn MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Matthew.Malcomson@arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f6785827-2893-40af-b77e-08d761e4151e X-IsSubscribed: yes Backport from llvm upstream llvm-svn: 375298. libsanitizer/ChangeLog: 2019-11-05 Matthew Malcomson * hwasan/hwasan_exceptions.cpp (__hwasan_personality_wrapper): Add missing interface attribute. ############### Attachment also inlined for ease of reply ############### diff --git a/libsanitizer/hwasan/hwasan_exceptions.cpp b/libsanitizer/hwasan/hwasan_exceptions.cpp index 57a1438064cd28bb609359a4c841acf78337ebc3..169e7876cb58a9dafb70973ed9fb1dfd815a7ceb 100644 --- a/libsanitizer/hwasan/hwasan_exceptions.cpp +++ b/libsanitizer/hwasan/hwasan_exceptions.cpp @@ -32,10 +32,13 @@ typedef _Unwind_Reason_Code PersonalityFn(int version, _Unwind_Action actions, typedef _Unwind_Word GetGRFn(_Unwind_Context* context, int index); typedef _Unwind_Word GetCFAFn(_Unwind_Context* context); -extern "C" _Unwind_Reason_Code __hwasan_personality_wrapper( - int version, _Unwind_Action actions, uint64_t exception_class, - _Unwind_Exception* unwind_exception, _Unwind_Context* context, - PersonalityFn* real_personality, GetGRFn* get_gr, GetCFAFn* get_cfa) { +extern "C" SANITIZER_INTERFACE_ATTRIBUTE _Unwind_Reason_Code +__hwasan_personality_wrapper(int version, _Unwind_Action actions, + uint64_t exception_class, + _Unwind_Exception* unwind_exception, + _Unwind_Context* context, + PersonalityFn* real_personality, GetGRFn* get_gr, + GetCFAFn* get_cfa) { _Unwind_Reason_Code rc; if (real_personality) rc = real_personality(version, actions, exception_class, unwind_exception, diff --git a/libsanitizer/hwasan/hwasan_exceptions.cpp b/libsanitizer/hwasan/hwasan_exceptions.cpp index 57a1438064cd28bb609359a4c841acf78337ebc3..169e7876cb58a9dafb70973ed9fb1dfd815a7ceb 100644 --- a/libsanitizer/hwasan/hwasan_exceptions.cpp +++ b/libsanitizer/hwasan/hwasan_exceptions.cpp @@ -32,10 +32,13 @@ typedef _Unwind_Reason_Code PersonalityFn(int version, _Unwind_Action actions, typedef _Unwind_Word GetGRFn(_Unwind_Context* context, int index); typedef _Unwind_Word GetCFAFn(_Unwind_Context* context); -extern "C" _Unwind_Reason_Code __hwasan_personality_wrapper( - int version, _Unwind_Action actions, uint64_t exception_class, - _Unwind_Exception* unwind_exception, _Unwind_Context* context, - PersonalityFn* real_personality, GetGRFn* get_gr, GetCFAFn* get_cfa) { +extern "C" SANITIZER_INTERFACE_ATTRIBUTE _Unwind_Reason_Code +__hwasan_personality_wrapper(int version, _Unwind_Action actions, + uint64_t exception_class, + _Unwind_Exception* unwind_exception, + _Unwind_Context* context, + PersonalityFn* real_personality, GetGRFn* get_gr, + GetCFAFn* get_cfa) { _Unwind_Reason_Code rc; if (real_personality) rc = real_personality(version, actions, exception_class, unwind_exception,