From patchwork Tue Nov 5 10:24:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189529 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m4S42Nxz9sNT for ; Tue, 5 Nov 2019 21:24:40 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388135AbfKEKYj (ORCPT ); Tue, 5 Nov 2019 05:24:39 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:42113 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388098AbfKEKYj (ORCPT ); Tue, 5 Nov 2019 05:24:39 -0500 Received: by mail-lj1-f195.google.com with SMTP id n5so10152908ljc.9; Tue, 05 Nov 2019 02:24:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bHPDrr3HiImPjNjg8bWMTYHlcggZ66/9TrLdtK5mAS4=; b=Op5fg1/UyCpjzEOZYxDCqmeU/YjTp70xoK3LZtOmCXG38Y+KkD/W79xQS4Asoo4J9+ aOlGdt64pvPg0bPrCZzijTbssONcGwbKxj2Td/Y+c33ZWFQeAYTc1HVYDMpkCf7o6o1z OY/oeV29zD/PPfeuAtfGYzdX1fnfTKmBNB1Yw+RI83e5lLO7VdGAoKBs9LvuXyYrhNze AJQkLvnrRe7n+AzLvOMS8yjwkXMaKsmVsMOz1AwuxqcngRDkA17NEk7bJqlBciodpcVF XqFAycCY4mEtWwUcLl7OvFceVTIQ7+maP58HJF2DP4ZznjpZEHPPZxolfKasjgR+dIOo k0ng== X-Gm-Message-State: APjAAAW9AKF/6nXs2LxQe1l+1h67Kv3kZfRvDnfy1Jm/rhczn61M8/f5 mG+ZRiOdqVscswc9O6/pWPI= X-Google-Smtp-Source: APXvYqw+ZGoOz3OiTd9yy3EqEwKGHGu7H0qfhS7OYfsTGPHGDgCtefUyk+bHnFzg2hW+fILf71btuw== X-Received: by 2002:a2e:96c1:: with SMTP id d1mr23520531ljj.87.1572949476956; Tue, 05 Nov 2019 02:24:36 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id j8sm2302302lja.32.2019.11.05.02.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:24:36 -0800 (PST) Date: Tue, 5 Nov 2019 12:24:27 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Thierry Reding , Uwe =?iso-8859-1?q?Kleine-K?= =?iso-8859-1?q?=F6nig?= , Linus Walleij , Bartosz Golaszewski , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 26/62] gpio: gpio-mvebu: Use new GPIO_LINE_DIRECTION Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-mvebu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 6c0687694341..9b2adf0ef880 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -384,7 +384,10 @@ static int mvebu_gpio_get_direction(struct gpio_chip *chip, unsigned int pin) regmap_read(mvchip->regs, GPIO_IO_CONF_OFF + mvchip->offset, &u); - return !!(u & BIT(pin)); + if (u & BIT(pin)) + return GPIO_LINE_DIRECTION_IN; + + return GPIO_LINE_DIRECTION_OUT; } static int mvebu_gpio_to_irq(struct gpio_chip *chip, unsigned int pin)