From patchwork Tue Nov 5 10:19:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189520 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476lyq5KpDz9sNT for ; Tue, 5 Nov 2019 21:19:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387773AbfKEKTq (ORCPT ); Tue, 5 Nov 2019 05:19:46 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:44003 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388281AbfKEKTq (ORCPT ); Tue, 5 Nov 2019 05:19:46 -0500 Received: by mail-lj1-f196.google.com with SMTP id y23so10232540ljh.10; Tue, 05 Nov 2019 02:19:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sWnRhLUvBnnlXa9gZ9XH8xo1NuNCA2taaToJuxQFH3o=; b=Z0lGIcFnt8Y8aRHf6p50pzCDiBcVVmdVuHuM/uZlkF7N8Qj0IJkZ81zopVSNqFOBJO FwUHexBbNTzMkRoDZU5+N+h7CNbUKJJaPu7pEWsqRmB5MLs8y2TlKxCciZ46aZCTgbA+ NmNBTSijYiwQehspOPwYD4/+WGh4ZBAzNGUr6SagGpvpudmSyvyOk3HBFwdR6ufNccCz TKH8L7OgP634b8k6TejM4fdIdYFjXCtQCX5BQCT1t5c2q78h+8O426jP+i2dhF+4C0Hx NtsxoUhtGEApkBqanPDhFJrDywJNio5pGLuknkNmZXZkiySo82xxsOhMlVcZvJvYHsHx 29pQ== X-Gm-Message-State: APjAAAWEKmkXlgd70BZVyEREqxLH+qzbOjeAtVtSjRkbEBcWq3zjBiPZ 0rKCpyJXI8O3E5suT2r13Ew= X-Google-Smtp-Source: APXvYqyZ/t5sC5Rt1hcuadq6uWUQjKX9muCvQ3n8q13yRCJoHU8trY9BEtNW6aopi38d03r8U9x+3g== X-Received: by 2002:a2e:8e28:: with SMTP id r8mr21646597ljk.21.1572949184057; Tue, 05 Nov 2019 02:19:44 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id x16sm9708480ljd.69.2019.11.05.02.19.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:19:43 -0800 (PST) Date: Tue, 5 Nov 2019 12:19:39 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 21/62] gpio: gpio-max3191x: Use new GPIO_LINE_DIRECTION Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-max3191x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c index 4b4b2ceb82fc..0696d5a21431 100644 --- a/drivers/gpio/gpio-max3191x.c +++ b/drivers/gpio/gpio-max3191x.c @@ -94,7 +94,7 @@ DECLARE_CRC8_TABLE(max3191x_crc8); static int max3191x_get_direction(struct gpio_chip *gpio, unsigned int offset) { - return 1; /* always in */ + return GPIO_LINE_DIRECTION_IN; /* always in */ } static int max3191x_direction_input(struct gpio_chip *gpio, unsigned int offset) From patchwork Tue Nov 5 10:21:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189522 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m1d6CJLz9s4Y for ; Tue, 5 Nov 2019 21:22:13 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730699AbfKEKWM (ORCPT ); Tue, 5 Nov 2019 05:22:12 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:39990 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730633AbfKEKWM (ORCPT ); Tue, 5 Nov 2019 05:22:12 -0500 Received: by mail-lf1-f65.google.com with SMTP id f4so14676478lfk.7; Tue, 05 Nov 2019 02:22:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9L58EzSLKcE9GwGbak6npuCDvAm3eZwiaRLQzP4rKQQ=; b=JtXtX2SE3ok6jO/+qKEMvLToLZJVvHH7in+EBgEoo90KTuFQ1m4Ao1m7JLFdxvJ/TL mcysL9MIiXxyOMbhiZ9+Urv7sG5OFXxMqjdjbD0gnr43OXQLL6Z0WIUqvYp5c1tcL3wO 0KHkPaHPrpwWpeHQtM+XCOIFClE0SkY82sSisxUsQqhMF0RmEmhzMJUkvF6U15fM4sE7 hMRPlRqtSeimPIfr2ErZxE5T67RW66NnsOpbxeJQJwV89Oy533pVGrxy7c8kg4Py4aOQ EGCRTi0UfiNeMSiFVMcOAOCYG+Ii7g3jIu/DOeEF1A762jmBKnO9WKb8qwZdgh+ai7Jo mLkA== X-Gm-Message-State: APjAAAXBSGHOTmnqcFbaDa4bS43gN1u65O+fo/voNTY5BZ1Nbv7q1u7h XyyFiPjMGjVPvLbWAhuaCOw= X-Google-Smtp-Source: APXvYqz2ZgcNJ4MCoGF8keVV4rB112hF71Xe9R9O8z7TzTWd6Yo0BErmrgMLUFAHk9Twa8zkPhyYiw== X-Received: by 2002:ac2:44af:: with SMTP id c15mr20247815lfm.39.1572949330293; Tue, 05 Nov 2019 02:22:10 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id u67sm11689034lja.78.2019.11.05.02.22.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:22:09 -0800 (PST) Date: Tue, 5 Nov 2019 12:21:58 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 22/62] gpio: gpio-mmio: Use new GPIO_LINE_DIRECTION Message-ID: <196d96a4cf8bee0189269e4df86965a0ec1a7daf.1572945799.git.matti.vaittinen@fi.rohmeurope.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-mmio.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c index 6f904c874678..cd07c948649f 100644 --- a/drivers/gpio/gpio-mmio.c +++ b/drivers/gpio/gpio-mmio.c @@ -370,15 +370,24 @@ static int bgpio_dir_in(struct gpio_chip *gc, unsigned int gpio) static int bgpio_get_dir(struct gpio_chip *gc, unsigned int gpio) { /* Return 0 if output, 1 if input */ - if (gc->bgpio_dir_unreadable) - return !(gc->bgpio_dir & bgpio_line2mask(gc, gpio)); - if (gc->reg_dir_out) - return !(gc->read_reg(gc->reg_dir_out) & bgpio_line2mask(gc, gpio)); + if (gc->bgpio_dir_unreadable) { + if (gc->bgpio_dir & bgpio_line2mask(gc, gpio)) + return GPIO_LINE_DIRECTION_OUT; + return GPIO_LINE_DIRECTION_IN; + } + + if (gc->reg_dir_out) { + if (gc->read_reg(gc->reg_dir_out) & bgpio_line2mask(gc, gpio)) + return GPIO_LINE_DIRECTION_OUT; + return GPIO_LINE_DIRECTION_IN; + } + if (gc->reg_dir_in) - return !!(gc->read_reg(gc->reg_dir_in) & bgpio_line2mask(gc, gpio)); + if (!(gc->read_reg(gc->reg_dir_in) & bgpio_line2mask(gc, gpio))) + return GPIO_LINE_DIRECTION_OUT; /* This should not happen */ - return 1; + return GPIO_LINE_DIRECTION_IN; } static int bgpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val) From patchwork Tue Nov 5 10:22:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189524 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m2L42hsz9s4Y for ; Tue, 5 Nov 2019 21:22:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388283AbfKEKWq (ORCPT ); Tue, 5 Nov 2019 05:22:46 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:42870 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388224AbfKEKWq (ORCPT ); Tue, 5 Nov 2019 05:22:46 -0500 Received: by mail-lj1-f196.google.com with SMTP id n5so10146372ljc.9; Tue, 05 Nov 2019 02:22:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Wn8DHqYZvLKcYPK20gCqPBfrT5YvPpFnu0f4gb8PdR0=; b=DL0mI8WoJmyFn9KK1v4UCJ+vyEw12y8hr4hlLvs/eovilpZiCk87tsIuoO5SUC/4m0 gYHLKdpfk8ecdCWqwdAVq8wOI332uVL3dCuqr/Lk8njOBhePZRamtajM4DNXMWBqyrc0 vpaHu07LFDv0mg6yMVkcFjWiVVCtseCwJyrrm/DTtlB8IQ0+e2zci5lxrzyN+XG6CROO /nKZSnq6C/nxyqY6N9rRDO1SzACFmHAc0C75mt5GOYuxQQnLXw6CYYcVUoFyLfyABAsn PbkMiERLcE/r5imSMc3HEUKnhgMLOME56tKjaNZulegPZgZB03azLZtre++pOJqL4KaC K7TA== X-Gm-Message-State: APjAAAX+Xjw0TZswKngRWzBxW/xFCEi9Jfop9+Wmfe3PzwIBTHoizOZZ u5BeV16VsGe6oVsD38kGO/w= X-Google-Smtp-Source: APXvYqwAAyPPQRtQKI8lv1ES4/GgGI+1EybKOl6LvlSe1oqrd77LyjusQj2ihN9kfAMHBVwR2A15DA== X-Received: by 2002:a2e:96c3:: with SMTP id d3mr8414236ljj.248.1572949364370; Tue, 05 Nov 2019 02:22:44 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id n25sm8376073lfg.42.2019.11.05.02.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:22:43 -0800 (PST) Date: Tue, 5 Nov 2019 12:22:39 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 23/62] gpio: gpio-merrifield: Use new GPIO_LINE_DIRECTION Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-merrifield.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-merrifield.c b/drivers/gpio/gpio-merrifield.c index 2f1e9da81c1e..d4fa6e9560f3 100644 --- a/drivers/gpio/gpio-merrifield.c +++ b/drivers/gpio/gpio-merrifield.c @@ -162,7 +162,10 @@ static int mrfld_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) { void __iomem *gpdr = gpio_reg(chip, offset, GPDR); - return !(readl(gpdr) & BIT(offset % 32)); + if (readl(gpdr) & BIT(offset % 32)) + return GPIO_LINE_DIRECTION_OUT; + + return GPIO_LINE_DIRECTION_IN; } static int mrfld_gpio_set_debounce(struct gpio_chip *chip, unsigned int offset, From patchwork Tue Nov 5 10:23:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189526 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m3J63FXz9sNT for ; Tue, 5 Nov 2019 21:23:40 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388224AbfKEKXk (ORCPT ); Tue, 5 Nov 2019 05:23:40 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:43500 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388167AbfKEKXj (ORCPT ); Tue, 5 Nov 2019 05:23:39 -0500 Received: by mail-lj1-f194.google.com with SMTP id y23so10246228ljh.10; Tue, 05 Nov 2019 02:23:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ppoAUF69jc850//5V8PML8lsgMuag5xwp3ksvqa8AOs=; b=i9dZbv0YyryUFJ6GWaNzYoQ9fuvAy+mKVopUzZSzQU6yyAu/VTJa2wuRYQhvQMeNr4 6E9r23hAMwfKTPI4IzHllyY6VdUto6zPXL4BUIscytvyz5ibA1eU8hqzu4IaTtgOiGBC o2NUuzRh4dZqt4TQq57MMj8ocvc9jP4UKkcbp4OgpMXguVo69NBxN4neDRnW4adga3a7 5k9xik5Ws9BraY0IUtgK+dX5CnutBjMQRJDeCfCC5vfOgG02ss1fPAqYSNkdPpAEAf6l Jxo5Qpovf+B9dv984BoxTZR7eFd8pMgxuEzpvPZkCc/2semZr1PAfbovhx7tYX6JSyz5 sZeQ== X-Gm-Message-State: APjAAAVIVJUmyz01vJdifWDPxOsOXtD7X3wEaG5QxHxeWNV+4NBCdlKf 89d0JnKflVjBeZDT9d4MeyBSEvRW/xA= X-Google-Smtp-Source: APXvYqzx/CIcT5sHxay54rlFG5oAjXyQYoexKeKby44uU1p7vbWAt0EIa+vP1MdCJ7tE1qsQ5rA23g== X-Received: by 2002:a2e:2a05:: with SMTP id q5mr14462156ljq.170.1572949417465; Tue, 05 Nov 2019 02:23:37 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id r22sm2966317lji.71.2019.11.05.02.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:23:37 -0800 (PST) Date: Tue, 5 Nov 2019 12:23:28 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Bamvor Jian Zhang , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 24/62] gpio: gpio-mockup: Use new GPIO_LINE_DIRECTION Message-ID: <5decca7b37c6fa4171b7617aec64856d3c5c7c69.1572945811.git.matti.vaittinen@fi.rohmeurope.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Use GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT instead of defining own enums. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-mockup.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index 213aedc97dc2..47c172b2f5ad 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -34,14 +34,9 @@ #define gpio_mockup_err(...) pr_err(GPIO_MOCKUP_NAME ": " __VA_ARGS__) -enum { - GPIO_MOCKUP_DIR_IN = 0, - GPIO_MOCKUP_DIR_OUT = 1, -}; - /* * struct gpio_pin_status - structure describing a GPIO status - * @dir: Configures direction of gpio as "in" or "out", 0=in, 1=out + * @dir: Configures direction of gpio as "in" or "out" * @value: Configures status of the gpio as 0(low) or 1(high) */ struct gpio_mockup_line_status { @@ -152,7 +147,7 @@ static int gpio_mockup_dirout(struct gpio_chip *gc, struct gpio_mockup_chip *chip = gpiochip_get_data(gc); mutex_lock(&chip->lock); - chip->lines[offset].dir = GPIO_MOCKUP_DIR_OUT; + chip->lines[offset].dir = GPIO_LINE_DIRECTION_OUT; __gpio_mockup_set(chip, offset, value); mutex_unlock(&chip->lock); @@ -164,7 +159,7 @@ static int gpio_mockup_dirin(struct gpio_chip *gc, unsigned int offset) struct gpio_mockup_chip *chip = gpiochip_get_data(gc); mutex_lock(&chip->lock); - chip->lines[offset].dir = GPIO_MOCKUP_DIR_IN; + chip->lines[offset].dir = GPIO_LINE_DIRECTION_IN; mutex_unlock(&chip->lock); return 0; From patchwork Tue Nov 5 10:23:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189528 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m3w3vldz9s4Y for ; Tue, 5 Nov 2019 21:24:12 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388363AbfKEKYL (ORCPT ); Tue, 5 Nov 2019 05:24:11 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:34061 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388166AbfKEKYL (ORCPT ); Tue, 5 Nov 2019 05:24:11 -0500 Received: by mail-lj1-f194.google.com with SMTP id 139so21205781ljf.1; Tue, 05 Nov 2019 02:24:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mn1lUL+cF0iyYDnoMGPe70AhLdUgNla1po75o8XNDJ4=; b=ZugkWOVisIFeZySyKekmApzUUFXxluOelOdWK4B4uc0JOsquaNkgKn6IOq2PdGLvIl YeIESps95f6s2WNIpCyBNNyUzt6eswoljxUdRk1EQtM48YOULxuoDRc7oEhJbafl5Rqz s4M/WfsNPhrLYekmMdGJh5IpckRB0SQCOkofGBtrFq3AaNO5/b7JzCwLBfEENyIxm7q1 EMrpFgoeNESmUGl72NCaXyPYZX/J5wvd4cHgRyPfS9NGgwKTZ64NL06WcIpQHjv3rh83 a1g2b2eW/I5XUVNCLbyByGyLwvL5BXgGK9UWsZRM+2mR6Z9O5u+rdyNUyTSEuoMcSSir JSsA== X-Gm-Message-State: APjAAAWrB/nvUd55zZ2UhYByARBoZulyKpRJ+xfaxe4UHv2QffD6BAzU YxYpcWMTTfpN2ysC27jo8C4= X-Google-Smtp-Source: APXvYqypuK9Q+P28kWExMGDAUWjISZsQXDzXTCFz9f0wYAi95lL7yAwVF6EJAzJVjBznJbW5l6HPSg== X-Received: by 2002:a2e:8e27:: with SMTP id r7mr768920ljk.101.1572949448567; Tue, 05 Nov 2019 02:24:08 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id o196sm9230433lff.59.2019.11.05.02.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:24:08 -0800 (PST) Date: Tue, 5 Nov 2019 12:23:52 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Marek Behun , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 25/62] gpio: gpio-moxtet: Use new GPIO_LINE_DIRECTION Message-ID: <980eece590eaa6c1c83332ff9fb198a033dca803.1572945817.git.matti.vaittinen@fi.rohmeurope.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-moxtet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-moxtet.c b/drivers/gpio/gpio-moxtet.c index 3fd729994a38..8299909318f4 100644 --- a/drivers/gpio/gpio-moxtet.c +++ b/drivers/gpio/gpio-moxtet.c @@ -78,9 +78,9 @@ static int moxtet_gpio_get_direction(struct gpio_chip *gc, unsigned int offset) /* All lines are hard wired to be either input or output, not both. */ if (chip->desc->in_mask & BIT(offset)) - return 1; + return GPIO_LINE_DIRECTION_IN; else if (chip->desc->out_mask & BIT(offset)) - return 0; + return GPIO_LINE_DIRECTION_OUT; else return -EINVAL; } From patchwork Tue Nov 5 10:24:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189530 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m4V5Zccz9sNT for ; Tue, 5 Nov 2019 21:24:42 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388197AbfKEKYj (ORCPT ); Tue, 5 Nov 2019 05:24:39 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:42113 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388098AbfKEKYj (ORCPT ); Tue, 5 Nov 2019 05:24:39 -0500 Received: by mail-lj1-f195.google.com with SMTP id n5so10152908ljc.9; Tue, 05 Nov 2019 02:24:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bHPDrr3HiImPjNjg8bWMTYHlcggZ66/9TrLdtK5mAS4=; b=Op5fg1/UyCpjzEOZYxDCqmeU/YjTp70xoK3LZtOmCXG38Y+KkD/W79xQS4Asoo4J9+ aOlGdt64pvPg0bPrCZzijTbssONcGwbKxj2Td/Y+c33ZWFQeAYTc1HVYDMpkCf7o6o1z OY/oeV29zD/PPfeuAtfGYzdX1fnfTKmBNB1Yw+RI83e5lLO7VdGAoKBs9LvuXyYrhNze AJQkLvnrRe7n+AzLvOMS8yjwkXMaKsmVsMOz1AwuxqcngRDkA17NEk7bJqlBciodpcVF XqFAycCY4mEtWwUcLl7OvFceVTIQ7+maP58HJF2DP4ZznjpZEHPPZxolfKasjgR+dIOo k0ng== X-Gm-Message-State: APjAAAW9AKF/6nXs2LxQe1l+1h67Kv3kZfRvDnfy1Jm/rhczn61M8/f5 mG+ZRiOdqVscswc9O6/pWPI= X-Google-Smtp-Source: APXvYqw+ZGoOz3OiTd9yy3EqEwKGHGu7H0qfhS7OYfsTGPHGDgCtefUyk+bHnFzg2hW+fILf71btuw== X-Received: by 2002:a2e:96c1:: with SMTP id d1mr23520531ljj.87.1572949476956; Tue, 05 Nov 2019 02:24:36 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id j8sm2302302lja.32.2019.11.05.02.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:24:36 -0800 (PST) Date: Tue, 5 Nov 2019 12:24:27 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Thierry Reding , Uwe =?iso-8859-1?q?Kleine-K?= =?iso-8859-1?q?=F6nig?= , Linus Walleij , Bartosz Golaszewski , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 26/62] gpio: gpio-mvebu: Use new GPIO_LINE_DIRECTION Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-mvebu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 6c0687694341..9b2adf0ef880 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -384,7 +384,10 @@ static int mvebu_gpio_get_direction(struct gpio_chip *chip, unsigned int pin) regmap_read(mvchip->regs, GPIO_IO_CONF_OFF + mvchip->offset, &u); - return !!(u & BIT(pin)); + if (u & BIT(pin)) + return GPIO_LINE_DIRECTION_IN; + + return GPIO_LINE_DIRECTION_OUT; } static int mvebu_gpio_to_irq(struct gpio_chip *chip, unsigned int pin) From patchwork Tue Nov 5 10:24:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189531 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m4x0zM7z9s4Y for ; Tue, 5 Nov 2019 21:25:05 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388133AbfKEKZE (ORCPT ); Tue, 5 Nov 2019 05:25:04 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:42162 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387945AbfKEKZE (ORCPT ); Tue, 5 Nov 2019 05:25:04 -0500 Received: by mail-lj1-f196.google.com with SMTP id n5so10154273ljc.9; Tue, 05 Nov 2019 02:25:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Bv+B7wRzEzNcU1QnMIvKDcqTaOyCGZVdxQ/FNOnMT1Y=; b=mrJB8d4fize7sCaAvs4m4PRauzDDEkp0qrkVrfXGPZL9vfBd0e+dosgyzJ/k09exN+ +ISSjdfgcAeU1g1uo8G3WhcwnbqZEftMpSvEK7HDwtl3emrrI8U0ZmUZFAtlW76yROkW BU/wMfZwZrAP2lrU+6PkASZTEuLoWe4KLU6nVQXEO1j8+7g8h7YxQdFJq9YToi4Z1AO1 vQMhjyQpl4M92t9VeJSg7LcvymlNtaAZedyQ4Yv9smFqz6Kn8PTK3BnWedHEAhURgsoC QqJT/k7zBC6c2PUbz/3JCL9EuN4ovYKoPjM/HpXyuayM6ZfuW3Kau0rk5MUvJwUzB0Sa jGeg== X-Gm-Message-State: APjAAAVjsX8mWnA6rKwq4hEp4AZz2apBmcFwYmSWKcIPYe2PPblqKFl7 /52FKYCSYjbRZgCaCvZZuPI= X-Google-Smtp-Source: APXvYqzZ7jxkgUCp8oVkJ5xSQdMV9c3vS9yER47vq2zT2lEe8mlFrHp8mlWwkM4USZUxlTsllt+VMQ== X-Received: by 2002:a2e:998a:: with SMTP id w10mr10343701lji.66.1572949501943; Tue, 05 Nov 2019 02:25:01 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id f3sm2795260lfp.0.2019.11.05.02.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:25:01 -0800 (PST) Date: Tue, 5 Nov 2019 12:24:57 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Linus Walleij , Bartosz Golaszewski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 27/62] gpio: gpio-mxs: Use new GPIO_LINE_DIRECTION Message-ID: <1c440ef37fb8bd690a62e4138028d0f41ebe76f4.1572945841.git.matti.vaittinen@fi.rohmeurope.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-mxs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c index 5e5437a2c607..c4a314c68555 100644 --- a/drivers/gpio/gpio-mxs.c +++ b/drivers/gpio/gpio-mxs.c @@ -248,7 +248,10 @@ static int mxs_gpio_get_direction(struct gpio_chip *gc, unsigned offset) u32 dir; dir = readl(port->base + PINCTRL_DOE(port)); - return !(dir & mask); + if (dir & mask) + return GPIO_LINE_DIRECTION_OUT; + + return GPIO_LINE_DIRECTION_IN; } static const struct platform_device_id mxs_gpio_ids[] = { From patchwork Tue Nov 5 10:25:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189533 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m5b51mkz9sNT for ; Tue, 5 Nov 2019 21:25:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388098AbfKEKZi (ORCPT ); Tue, 5 Nov 2019 05:25:38 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:45786 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388022AbfKEKZi (ORCPT ); Tue, 5 Nov 2019 05:25:38 -0500 Received: by mail-lj1-f193.google.com with SMTP id n21so7544506ljg.12; Tue, 05 Nov 2019 02:25:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZIE7PHR5n6kkKpkKiiyu4APe9Fu8muktBLyL9wQHbZs=; b=T/MgBrF8HqH0HavKNPg0BfFSIdhIhru9dR4Tp5HlufFedPpNd/9LdhmYUIVC4Yvsjc cpQoCUn8cwmHS/sQtEaOXIkSboWkiiN5y2mEkM7gkbfeguxW7FuH44vESTwAFn0dctRZ aLBu0i6spQSOArOzcy2TT+TP2EFqC27cIp6FPMmLvYt83EiBTjNGKT5r9I3PLMtYHeiJ nn8Imwci4SPoh4gFO+IKhWIZGC8RHZ+lsF9pOMpGO6jKSvKtq49c4tbowJfyH7/NDy7Z Elnl0tVfHePOhGeZR8AHc7MkUX/IQ4hh+Kqhb53tzZk01cHspo55X/fh97RMqyHvlF5/ Pcdg== X-Gm-Message-State: APjAAAXWwXX1PceKQYGK/FRYU+YuS7bLTgaMbK4Aq0TedekqcedWvKGS SrwnHbri1f6Tko3hL1v2mTs= X-Google-Smtp-Source: APXvYqz6MruEmXlY92dMfYrIVsfqdShngh3dj/+yBjpkU/WTQDGGf2OC6O0LQkqz7fwWBx69iNptPg== X-Received: by 2002:a05:651c:20f:: with SMTP id y15mr7302098ljn.31.1572949536259; Tue, 05 Nov 2019 02:25:36 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id g23sm2586949lja.104.2019.11.05.02.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:25:35 -0800 (PST) Date: Tue, 5 Nov 2019 12:25:26 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Linus Walleij , Bartosz Golaszewski , linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 28/62] gpio: gpio-omap: Use new GPIO_LINE_DIRECTION Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen Reviewed-by: Grygorii Strashko --- drivers/gpio/gpio-omap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index d0f27084a942..3bd8adaeed9e 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -805,8 +805,10 @@ static int omap_gpio_get_direction(struct gpio_chip *chip, unsigned offset) { struct gpio_bank *bank = gpiochip_get_data(chip); - return !!(readl_relaxed(bank->base + bank->regs->direction) & - BIT(offset)); + if (readl_relaxed(bank->base + bank->regs->direction) & BIT(offset)) + return GPIO_LINE_DIRECTION_IN; + + return GPIO_LINE_DIRECTION_OUT; } static int omap_gpio_input(struct gpio_chip *chip, unsigned offset) From patchwork Tue Nov 5 10:25:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189534 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m605SRVz9s4Y for ; Tue, 5 Nov 2019 21:26:00 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388353AbfKEKZ7 (ORCPT ); Tue, 5 Nov 2019 05:25:59 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:36827 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388022AbfKEKZ7 (ORCPT ); Tue, 5 Nov 2019 05:25:59 -0500 Received: by mail-lf1-f67.google.com with SMTP id a6so11287962lfo.3; Tue, 05 Nov 2019 02:25:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Q3EU3PFDxzbABDOEU3Nh58uvPPNzhd0ptTKha1CeP5E=; b=g5Vt16P/1dvdw0bs1f2D9dDgwooSBC106LecK/43nY64sjFWP1fGZ/YQMlO0dbD09o DqBmPxQcIktDBB06bQVOr2DGCbAjlKD/o9/RS1i1UuwmOE2MW20ytV8FZqvczZHHhOqJ kT5JCqC9FJ++ipFYx0nalDSu4C9pqsjzUZBDVlpJETzPDq0l293VNaAa2vqhP+/oXpMG i/OFl/3XOeBlFj8vOGg8DJ0vmYETQJ8095X3nQvBt3+EtRdN2JUSsV2NYuoMFhKD9tah 6dfUtYBb0VY8kn3ezikFsBWq9lwLTNpVa7S+glWLwAVnONfmyRLVy9WrFJaLDrjP8BzY g75A== X-Gm-Message-State: APjAAAUqnuFUU+dzZk+typM5TpFNC7zlnUVKqBne3CsuLuRxSLzwHHqe ZGlnF6z8n0AOEcWZMdYuTGo= X-Google-Smtp-Source: APXvYqzUg5ML8A6OCKXgQJp9pNhL+np8kVlPZqbb7r3PlE53j0mB2zKW91q7uiNNlZ60rsp1iWEXjw== X-Received: by 2002:a19:6759:: with SMTP id e25mr19266682lfj.80.1572949557418; Tue, 05 Nov 2019 02:25:57 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id v21sm6540529ljh.53.2019.11.05.02.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:25:57 -0800 (PST) Date: Tue, 5 Nov 2019 12:25:48 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 29/62] gpio: gpio-pca953x: Use new GPIO_LINE_DIRECTION Message-ID: <88f0dbb0b6dd84ffafa9294808b78526b1a9c160.1572945854.git.matti.vaittinen@fi.rohmeurope.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen Reviewed-by: Geert Uytterhoeven --- drivers/gpio/gpio-pca953x.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index de5d1383f28d..82122c3c688a 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -449,7 +449,10 @@ static int pca953x_gpio_get_direction(struct gpio_chip *gc, unsigned off) if (ret < 0) return ret; - return !!(reg_val & bit); + if (reg_val & bit) + return GPIO_LINE_DIRECTION_IN; + + return GPIO_LINE_DIRECTION_OUT; } static void pca953x_gpio_set_multiple(struct gpio_chip *gc, From patchwork Tue Nov 5 10:26:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189535 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m6k3cQJz9s4Y for ; Tue, 5 Nov 2019 21:26:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388022AbfKEK0i (ORCPT ); Tue, 5 Nov 2019 05:26:38 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:36528 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388518AbfKEK0h (ORCPT ); Tue, 5 Nov 2019 05:26:37 -0500 Received: by mail-lj1-f193.google.com with SMTP id k15so9054105lja.3; Tue, 05 Nov 2019 02:26:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IFjUGuI3ulVgt4ueQzweecNMeh52xwxpjnMtYpKO30k=; b=hxOc+w6zIYwCav103Eji3b7wV8rGPtAR4GZ6S89V6xhfQqMB/5wpcxjOEtd03aFyjF My6aTeMjRufTi55uqonU/VCjLBs6uA87ZPrTvsxvvE9ddvfMtODkdmCSOhHjxb9nF+Qo cUR0fVpCkYY61UNlyR8esyRRddFwpXchXZDug7b/9WYI3r6CpeRqUaQarhbgtOiN/VbW OQkpPjfwOFnFIV4PbibWV615LlNcT5grVZNam6dMrheoTZ2NO8eHOJpypE72+1kSw6ef 5J/VAnDgAV6ll005syCHEgZ5272UO0GFBrwT9NtqhETAietMAswdK1sQSQDf5EwNi2XR +sSQ== X-Gm-Message-State: APjAAAWxp+31RzGCLG36/kG4GbvnUrecEEavQJRJHDROY/37m2i5j//I wWJxvWasp3OEXyAVXZXlmbw= X-Google-Smtp-Source: APXvYqy8beBRgRqwBS8w8DAGqAgb3XZDbjvNI0FnIKwapbeGVtCNnUPErWGV8yj+8sR4iVURMT5xNA== X-Received: by 2002:a2e:6a19:: with SMTP id f25mr804262ljc.147.1572949595505; Tue, 05 Nov 2019 02:26:35 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id f3sm2801192lfp.0.2019.11.05.02.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:26:34 -0800 (PST) Date: Tue, 5 Nov 2019 12:26:26 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: William Breathitt Gray , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 30/62] gpio: gpio-pcie-idio-24: Use new GPIO_LINE_DIRECTION Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-pcie-idio-24.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-pcie-idio-24.c b/drivers/gpio/gpio-pcie-idio-24.c index 52f1647a46fd..44c1e4fc489f 100644 --- a/drivers/gpio/gpio-pcie-idio-24.c +++ b/drivers/gpio/gpio-pcie-idio-24.c @@ -104,15 +104,18 @@ static int idio_24_gpio_get_direction(struct gpio_chip *chip, /* FET Outputs */ if (offset < 24) - return 0; + return GPIO_LINE_DIRECTION_OUT; /* Isolated Inputs */ if (offset < 48) - return 1; + return GPIO_LINE_DIRECTION_IN; /* TTL/CMOS I/O */ /* OUT MODE = 1 when TTL/CMOS Output Mode is set */ - return !(ioread8(&idio24gpio->reg->ctl) & out_mode_mask); + if (ioread8(&idio24gpio->reg->ctl) & out_mode_mask) + return GPIO_LINE_DIRECTION_OUT; + + return GPIO_LINE_DIRECTION_IN; } static int idio_24_gpio_direction_input(struct gpio_chip *chip, From patchwork Tue Nov 5 10:26:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189536 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m7B1k4Jz9s4Y for ; Tue, 5 Nov 2019 21:27:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388148AbfKEK1B (ORCPT ); Tue, 5 Nov 2019 05:27:01 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:46274 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388224AbfKEK1B (ORCPT ); Tue, 5 Nov 2019 05:27:01 -0500 Received: by mail-lf1-f65.google.com with SMTP id 19so9527053lft.13; Tue, 05 Nov 2019 02:26:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=c7AanZ8nsR0tYhgpw6owQy8CmSNJrjmkJAunlkfPFMw=; b=iZ9Fg3k0BiA07Jtug52sH9usxofEwsyH+qcmsjGRmvOFBu/0MfjqZfS0laS/3bV4hn FC11oKuln7943bZplMXE5soJoQJSTsdVoS6KPB4oZO1jV0mrcf3MZTd1XxdriRzrGrb8 FAg/1k13B5EwmVdcd30lzoFUY+4JXsqgqB2YL/Tt6TAXHGZZoCREwQDqTNQHp2YeHRYr 54BNKr3rNBvaLb142tglNCZfzfXY6J60Z6uKNb93X0tAFCyZ+g1QO9T8PQxHRzcKaHpV xJOcoKpFy1z0sHwwpJV2zYmbGsBDIHVn/KV8Gij4DilHRaBp4n4d7OYkYs4KJ8twEn0v HBHA== X-Gm-Message-State: APjAAAXnFsUHkFm3oDRfAc7HChNzf3QDp331RpHiCEjk2KzbfQynDxp4 fbLWXGQ/nyMUacdvQ0ABhsk= X-Google-Smtp-Source: APXvYqyTlS24KTZI164vz+JNNkrAq5AbViNJ1xI4+KlGbFWmoxULKNPICG2K1vSYRKdhrjcxVUWQ5Q== X-Received: by 2002:ac2:523c:: with SMTP id i28mr19680268lfl.165.1572949618779; Tue, 05 Nov 2019 02:26:58 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id p193sm16344663lfa.18.2019.11.05.02.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:26:58 -0800 (PST) Date: Tue, 5 Nov 2019 12:26:49 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: William Breathitt Gray , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 31/62] gpio: gpio-pci-idio-16: Use new GPIO_LINE_DIRECTION Message-ID: <2c63de5d80da514a2fe2bcae203c1536e129bb5a.1572945863.git.matti.vaittinen@fi.rohmeurope.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-pci-idio-16.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pci-idio-16.c b/drivers/gpio/gpio-pci-idio-16.c index 5aa136a6a3e0..df51dd08bdfe 100644 --- a/drivers/gpio/gpio-pci-idio-16.c +++ b/drivers/gpio/gpio-pci-idio-16.c @@ -61,9 +61,9 @@ static int idio_16_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) { if (offset > 15) - return 1; + return GPIO_LINE_DIRECTION_IN; - return 0; + return GPIO_LINE_DIRECTION_OUT; } static int idio_16_gpio_direction_input(struct gpio_chip *chip, From patchwork Tue Nov 5 10:27:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189537 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m7b4fNkz9s4Y for ; Tue, 5 Nov 2019 21:27:23 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388224AbfKEK1W (ORCPT ); Tue, 5 Nov 2019 05:27:22 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:46433 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388203AbfKEK1W (ORCPT ); Tue, 5 Nov 2019 05:27:22 -0500 Received: by mail-lj1-f195.google.com with SMTP id e9so7870166ljp.13; Tue, 05 Nov 2019 02:27:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=j8Gc1QGqLuiDX4KtEcNe9mp0sStq7EkK4+n12XZ5wIk=; b=BAb+kI5DNNL2nCXF9L7Bj+3pECA62p321FvOnGnuamK9f8l/h7sbWwm3F92aWpf/OO j3vsnLr9L4mTwqygw3ELKutK2r8WksLB59zpQLcnm0cSUpPYiagNkOZssYn0P32NW0LS 7EamiCcTSBv2Gv+7J1uTu1Iqcc2IblTiM50wgJ37w2pSaSOAigWbA+m27wMrlUEQ1fmB euVFU1nfMkw9IiyVVl8ANrR/zLTDlMBkfxA8e8ogZ18C9sfKGXEsoV5MmU1aK/AhdApl YcRemBw0jwMd7IjEoxzyVhPg575dRMt59ippQLcNCVyHuW/6f73AyQ61eroT2vaIsX3w U0ow== X-Gm-Message-State: APjAAAXD1PSlCxRHPcd6lzH2kdsAUP07lJVAmLA7ATxai8h41e0oQB2P XW+DsduWvV9BbrLG/kiyAf/rsMaVskE= X-Google-Smtp-Source: APXvYqw1lQ5JZxU599cpBWBgKP8Dn7Q55c1wIza4ZY3KUM6AnCaTrx0vKDQ9wbI0SmmR9S5PUqdDkA== X-Received: by 2002:a2e:2e03:: with SMTP id u3mr5731752lju.115.1572949639908; Tue, 05 Nov 2019 02:27:19 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id 81sm9139854lje.70.2019.11.05.02.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:27:19 -0800 (PST) Date: Tue, 5 Nov 2019 12:27:10 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 32/62] gpio: gpio-pisosr: Use new GPIO_LINE_DIRECTION Message-ID: <326a9336a621d0434adc54f4742c8bf5cc7055a9.1572945867.git.matti.vaittinen@fi.rohmeurope.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen Reviewed-by: Geert Uytterhoeven --- drivers/gpio/gpio-pisosr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c index f809a5a8e9eb..1331b2a94679 100644 --- a/drivers/gpio/gpio-pisosr.c +++ b/drivers/gpio/gpio-pisosr.c @@ -65,7 +65,7 @@ static int pisosr_gpio_get_direction(struct gpio_chip *chip, unsigned offset) { /* This device always input */ - return 1; + return GPIO_LINE_DIRECTION_IN; } static int pisosr_gpio_direction_input(struct gpio_chip *chip, From patchwork Tue Nov 5 10:27:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189539 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m8D42hhz9sPF for ; Tue, 5 Nov 2019 21:27:56 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388396AbfKEK1w (ORCPT ); Tue, 5 Nov 2019 05:27:52 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:36688 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388093AbfKEK1w (ORCPT ); Tue, 5 Nov 2019 05:27:52 -0500 Received: by mail-lj1-f195.google.com with SMTP id k15so9058125lja.3; Tue, 05 Nov 2019 02:27:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bKWJvXabVxDLrzTtaVaaINFhEmEoNK3Y3Me2BG2EuT0=; b=isDhszbG6z1eAhgbONROZQD46lluVBaH4zdQKZZA7d/nAl2UoVaAllI5dobVnb1KHO /wtXSg2tTIBytiwdkUTunUdDgX+AruXiK+7OzJ9HmdcBPqySrWiOkhbMj2d18U2Z2WUa PX5eWdM4OAdp+CHR9ZD59IZPd51GOTcQK+obBhxNfUpJU/d/o4T/U1RT0Qq8k4T9ni71 hiFTG9Sz7tCYbq1jQD5e478h3QBquXJoUJjspTEsa44qFfbwlJ9w1UHJDe1kA4ssvMe8 wvl3IQzoe2HVyVUEyxNjR0NwfC79m/7ZSaR+kzJKrFtQwCq49vwqjU01Ge5FqGNyTSrl 93qA== X-Gm-Message-State: APjAAAXicapDphwp+taEodgOuO5uU4ExBTBOKbkjU4VHEdMmIl6H6idx ATldSFFUOLb9p2SUNYjjWiE= X-Google-Smtp-Source: APXvYqwTAYmj2PfkRK5CTWFqso1R5rjt46qiYvt23gDsKyo4PitSujmjf4gJwdMDJJIojbBvLB5Lbw== X-Received: by 2002:a2e:6c03:: with SMTP id h3mr5976462ljc.86.1572949669747; Tue, 05 Nov 2019 02:27:49 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id h16sm8513360ljb.10.2019.11.05.02.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:27:49 -0800 (PST) Date: Tue, 5 Nov 2019 12:27:39 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 33/62] gpio: gpio-pl061: Use new GPIO_LINE_DIRECTION Message-ID: <7217327d1ea69f886a2cdb8abf201a2cc7bb02d3.1572945872.git.matti.vaittinen@fi.rohmeurope.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen Reviewed-by: Geert Uytterhoeven --- drivers/gpio/gpio-pl061.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c index 722ce5cf861e..5df7782e348f 100644 --- a/drivers/gpio/gpio-pl061.c +++ b/drivers/gpio/gpio-pl061.c @@ -63,7 +63,10 @@ static int pl061_get_direction(struct gpio_chip *gc, unsigned offset) { struct pl061 *pl061 = gpiochip_get_data(gc); - return !(readb(pl061->base + GPIODIR) & BIT(offset)); + if (readb(pl061->base + GPIODIR) & BIT(offset)) + return GPIO_LINE_DIRECTION_OUT; + + return GPIO_LINE_DIRECTION_IN; } static int pl061_direction_input(struct gpio_chip *gc, unsigned offset) From patchwork Tue Nov 5 10:28:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189540 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m8h5tYxz9s4Y for ; Tue, 5 Nov 2019 21:28:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388093AbfKEK2U (ORCPT ); Tue, 5 Nov 2019 05:28:20 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:41623 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388022AbfKEK2U (ORCPT ); Tue, 5 Nov 2019 05:28:20 -0500 Received: by mail-lj1-f193.google.com with SMTP id m9so21138456ljh.8; Tue, 05 Nov 2019 02:28:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IM6/hCDcGMqvIg/AwNcP2jEs0lH1LP+44rKli/dOwmA=; b=JwMgtBZnEJ9nVAtIt3YQg2o7BJwk/s992rtYKU/ohRldRNUObRxS2jLznYEJYMB0YT WgHYRrJb2krx/mwsCSpVL5S6iOm1oyF81lpK5aQXAqQROowEVfh2i6myNgb38i+q0azh BNWAdMbB8qNkBK+JXDOzKS03eqE0q+ecsGgTLJFhYJgGthEENS7ZtNvh7BMb51sUmoP3 cYc8/fnhw283aHr9qiSfvbbV5irIjFK77JJuGXdZTs9a8VgzhFkotUGDiAMXPsINyqE+ vjy3XUIYB3oR2kbuO8TCoqumYb9GAVI/E5W8iXUE4hqQb9o672xyRKfPFzxGety+Wj+T sEuQ== X-Gm-Message-State: APjAAAWKystnXgsJlZxQdJtEHB7YOV2ErlA07pyyRhYRUf2JM9t/Vvg3 8d4TWIISGuREabO49krfrWI= X-Google-Smtp-Source: APXvYqxedWqwpibNee1F3pdyV0UbO7UJx5A0vtGukno687Fxa5nIr8MrVSqk4r/Wt/lFEQklGzs3/A== X-Received: by 2002:a05:651c:1202:: with SMTP id i2mr22513311lja.218.1572949697900; Tue, 05 Nov 2019 02:28:17 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id t16sm7260851ljc.106.2019.11.05.02.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:28:17 -0800 (PST) Date: Tue, 5 Nov 2019 12:28:12 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 34/62] gpio: gpio-raspberrypi-exp: Use new GPIO_LINE_DIRECTION Message-ID: <92a9de8da96f57c156ccd24dc37a330e352f6963.1572945875.git.matti.vaittinen@fi.rohmeurope.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-raspberrypi-exp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-raspberrypi-exp.c b/drivers/gpio/gpio-raspberrypi-exp.c index b77ea16ffa03..bb100e0124e6 100644 --- a/drivers/gpio/gpio-raspberrypi-exp.c +++ b/drivers/gpio/gpio-raspberrypi-exp.c @@ -147,7 +147,10 @@ static int rpi_exp_gpio_get_direction(struct gpio_chip *gc, unsigned int off) get.gpio); return ret ? ret : -EIO; } - return !get.direction; + if (get.direction) + return GPIO_LINE_DIRECTION_OUT; + + return GPIO_LINE_DIRECTION_IN; } static int rpi_exp_gpio_get(struct gpio_chip *gc, unsigned int off) From patchwork Tue Nov 5 10:28:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189541 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m9F314Gz9sNT for ; Tue, 5 Nov 2019 21:28:49 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388022AbfKEK2s (ORCPT ); Tue, 5 Nov 2019 05:28:48 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:45175 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730633AbfKEK2s (ORCPT ); Tue, 5 Nov 2019 05:28:48 -0500 Received: by mail-lj1-f196.google.com with SMTP id n21so7555363ljg.12; Tue, 05 Nov 2019 02:28:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8C/i1Bz93rFLif9JRdBLqc1lgGk+Jj//nwWjEvEZ0Gs=; b=S4y20MGAsIldrYEuxTI2BTAyYIjvk8au/epA+Uj/cNHETri85pVfEx04ggLLyxxV7W IDLcB/UQqbyrGVDhgm0JqDKeGA0Z/jnJZkJUoJ9RE/ToHrAt+784UZMj9M95eSLFI4Il FVAfRDJNPmPWpkr9tvbK3/jae7W1RI2GwkHe64WCK+wkmPfl0xf/QbikGdDoNMdYyJIW bkNw1phhfhfRkCxyuYySIeZ8ACeqKL5udGZCpbL5EBjmgDFGJtfjQZ81OQeyQqnsAlTM fkMDPASwPR9eEMv4AyEX4v1a7CuRbumzMo9/6Agu7IK6Ev6HZ1pOwzxnwheHqBhjK3wQ r+YQ== X-Gm-Message-State: APjAAAUSzUiwOj/wQcSfCg4JX0PMsDcvG39E0uocsZvsz/TF1ImKGt6i HEghOQueEI38Rwh8DohPPfU= X-Google-Smtp-Source: APXvYqxwcvj0cepLwQF9EuSzd7CrvTwSjy/SfoUGngFRGPcgCkux7Rk+SrJXZ8114KtAmv8NFKh9jA== X-Received: by 2002:a05:651c:313:: with SMTP id a19mr22603998ljp.199.1572949725913; Tue, 05 Nov 2019 02:28:45 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id s23sm8132349ljm.20.2019.11.05.02.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:28:45 -0800 (PST) Date: Tue, 5 Nov 2019 12:28:36 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 35/62] gpio: gpio-rcar: Use new GPIO_LINE_DIRECTION Message-ID: <05e85f2812eb4e6b92cdd9054ecba675d206db66.1572945879.git.matti.vaittinen@fi.rohmeurope.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen Reviewed-by: Geert Uytterhoeven --- drivers/gpio/gpio-rcar.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 187984d26f47..d7e6e68c25af 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -279,7 +279,10 @@ static int gpio_rcar_get_direction(struct gpio_chip *chip, unsigned int offset) { struct gpio_rcar_priv *p = gpiochip_get_data(chip); - return !(gpio_rcar_read(p, INOUTSEL) & BIT(offset)); + if (gpio_rcar_read(p, INOUTSEL) & BIT(offset)) + return GPIO_LINE_DIRECTION_OUT; + + return GPIO_LINE_DIRECTION_IN; } static int gpio_rcar_direction_input(struct gpio_chip *chip, unsigned offset) From patchwork Tue Nov 5 10:29:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189542 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476m9j0MY7z9sPF for ; Tue, 5 Nov 2019 21:29:13 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388281AbfKEK3M (ORCPT ); Tue, 5 Nov 2019 05:29:12 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:38782 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388335AbfKEK3L (ORCPT ); Tue, 5 Nov 2019 05:29:11 -0500 Received: by mail-lj1-f194.google.com with SMTP id v8so5525543ljh.5; Tue, 05 Nov 2019 02:29:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mEXk6XnbHnustkbALD4GoIWBLMq4ab5ZVfyYXu8ftbo=; b=mPBDFnc8d1wMmumejA46pceikuPBK/idHMNCymwspJvycLq49pf5nC0+FowA2zxPgd 1e3GtylVfTq4HNbIGe6IxLwPcrlVPkYgz+TNRpbHoVsSbSvy7tL4jbRKFLiBi3VvljGn IQKUwoWYIyIpgkXJ745j/JJQZzDkKkt5hOIvgwMXZ9It+gnM2vR0iP9gfVsHbvm1Fej2 wTdCtuNJ57fqdJy+ln7HiP/tQbeflh9QGY+4/G2U0Bntopjc6hqeP/sQOzCfXZKmO8cw Mv6QJ6QTNzmj8u9IEyRQ5lBCebg4BQfJROmHuHhEnMBBPg6j2/qspaF+eV//F0/gu3v6 NXTw== X-Gm-Message-State: APjAAAU0tOJ2DDpoKdAlG3GHRTVt8McTf+y5E7uia6veuZ+gyOpYscp/ FMEL6iZJgnc5yMpEEk1ct2g= X-Google-Smtp-Source: APXvYqxhwWsB2NR7HHLcVKSHMmbOFWRm2ae+FH1P5yZ43TEAAeNvs5K5SL1vG4Zk+QS9VZz1XDxGbw== X-Received: by 2002:a2e:9712:: with SMTP id r18mr8772570lji.12.1572949749648; Tue, 05 Nov 2019 02:29:09 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id k9sm1384712lfj.97.2019.11.05.02.29.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:29:09 -0800 (PST) Date: Tue, 5 Nov 2019 12:29:00 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 36/62] gpio: gpio-reg: Use new GPIO_LINE_DIRECTION Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-reg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-reg.c b/drivers/gpio/gpio-reg.c index fdc7a9d5b382..d35169bde25a 100644 --- a/drivers/gpio/gpio-reg.c +++ b/drivers/gpio/gpio-reg.c @@ -26,7 +26,8 @@ static int gpio_reg_get_direction(struct gpio_chip *gc, unsigned offset) { struct gpio_reg *r = to_gpio_reg(gc); - return r->direction & BIT(offset) ? 1 : 0; + return r->direction & BIT(offset) ? GPIO_LINE_DIRECTION_IN : + GPIO_LINE_DIRECTION_OUT; } static int gpio_reg_direction_output(struct gpio_chip *gc, unsigned offset, From patchwork Tue Nov 5 10:29:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 1189543 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476mBP0RKZz9sNT for ; Tue, 5 Nov 2019 21:29:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388248AbfKEK3r (ORCPT ); Tue, 5 Nov 2019 05:29:47 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:46741 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388022AbfKEK3r (ORCPT ); Tue, 5 Nov 2019 05:29:47 -0500 Received: by mail-lj1-f194.google.com with SMTP id e9so7878218ljp.13; Tue, 05 Nov 2019 02:29:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=T/zJmmC9BfN7o1sqvqhhANQRkLvNhk04+tink2hcu/o=; b=NRrZNRWtQFeuY8BCZag2f7Rog0KuEtFi5nLKSyqmYaX3f05q5ssPIIBOCVgWWNRgmC myMhAjD8xwfg8cIGFf2CQ/bM80caWovyZNlgeOVrzqjANokNO2OsKUcHcvGSMlb9qFya YJ3HD6q5IQSEFjmWELLZd8EVW/wr8vX9uK7gJ/pvh/hskaR6+mKnP5BpV2c5BdGclYYN KZCQYP/dNMaqPnxH3SCeARNWFJNsucv8JlIe7MkkyugvqWGFpEat/8Qr8QMH4n4pAzsH GOqUAC6jsgcCa55vg0rSiQtnDFpFJsz+GwftFZVrnEFWxklmhr2AR+DkSHXkMb0KLsr9 jjWw== X-Gm-Message-State: APjAAAXllbbP2+gFT1xJA/IG2foJ71fA5j/cl1H3WRzYb+MB4GPwB8tI BpU8407yym2d6vCXWVGNdk8= X-Google-Smtp-Source: APXvYqwAiLmM1AWBNWgvSloHZxacz7vhjYQV56y3Fw7fttafgeaQyw/oMgcvECS8UnmExC/IFeNwWQ== X-Received: by 2002:a2e:874a:: with SMTP id q10mr23012443ljj.14.1572949785377; Tue, 05 Nov 2019 02:29:45 -0800 (PST) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id s7sm8246972ljo.98.2019.11.05.02.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 02:29:44 -0800 (PST) Date: Tue, 5 Nov 2019 12:29:36 +0200 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Ludovic Desroches , Linus Walleij , Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 37/62] gpio: gpio-sama5d2-piobu: Use new GPIO_LINE_DIRECTION Message-ID: <4e20b399f7ef56a7df25f97a86b4e89e131083d0.1572945890.git.matti.vaittinen@fi.rohmeurope.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen --- drivers/gpio/gpio-sama5d2-piobu.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-sama5d2-piobu.c b/drivers/gpio/gpio-sama5d2-piobu.c index 7d718557092e..b04c561f3280 100644 --- a/drivers/gpio/gpio-sama5d2-piobu.c +++ b/drivers/gpio/gpio-sama5d2-piobu.c @@ -119,7 +119,8 @@ static int sama5d2_piobu_get_direction(struct gpio_chip *chip, if (ret < 0) return ret; - return (ret == PIOBU_IN) ? 1 : 0; + return (ret == PIOBU_IN) ? GPIO_LINE_DIRECTION_IN : + GPIO_LINE_DIRECTION_OUT; } /** @@ -154,9 +155,9 @@ static int sama5d2_piobu_get(struct gpio_chip *chip, unsigned int pin) /* if pin is input, read value from PDS else read from SOD */ int ret = sama5d2_piobu_get_direction(chip, pin); - if (ret == 1) + if (ret == GPIO_LINE_DIRECTION_IN) ret = sama5d2_piobu_read_value(chip, pin, PIOBU_PDS); - else if (!ret) + else if (ret == GPIO_LINE_DIRECTION_OUT) ret = sama5d2_piobu_read_value(chip, pin, PIOBU_SOD); if (ret < 0)