From patchwork Sun Nov 3 10:42:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 1188538 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bYpzfac+"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 475XYl3Qhrz9sP4 for ; Sun, 3 Nov 2019 21:42:19 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 109E689672; Sun, 3 Nov 2019 10:42:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IF4RbkPbgnmC; Sun, 3 Nov 2019 10:42:16 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 493CD8967D; Sun, 3 Nov 2019 10:42:16 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 72A751BF2CA for ; Sun, 3 Nov 2019 10:42:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 6CF082372E for ; Sun, 3 Nov 2019 10:42:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NGraIFfgkRyT for ; Sun, 3 Nov 2019 10:42:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by silver.osuosl.org (Postfix) with ESMTPS id 698CD203BB for ; Sun, 3 Nov 2019 10:42:13 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id s1so13872535wro.0 for ; Sun, 03 Nov 2019 02:42:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=St7Afirh+1s6Dr/eGAAjtIR6zfsBdgKZUnmdTlLqDDE=; b=bYpzfac+Agp2Hony0zN2wU/8KGxvNGmh6LexUx05veJ+sa1QdTYoNmEx0eZvFPLdtH JJmZ0pclF2L1Xoal5gsWIfjbsYfY4JuEYJQoFe4rVJWD+ZXbPSCUjHMzdmigmI49Wbma Fh6mtPj7v4/fq+FVdWXDQ1gTdD4CRb4rZZqhBBLdtk1fJFOfL1ldmDoRAEJuU3+Vhy3I /I2j0JE80hDpt2lrvMN3TYiT9x+BrSztjhZOeM9P1DHaFAXTJqVcu6Eq2D1XebkwyEFi yZJSSaLYiL22Py9EDUxf7OnT4jBl1kQQ+ydf5UCkbdoNKScj6vV8sk5JHRELaANqzi2U qW2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=St7Afirh+1s6Dr/eGAAjtIR6zfsBdgKZUnmdTlLqDDE=; b=HhfRzslfT1rOvlfEdVjhY9l3Dm3EcAV46L2tuKA9B8zQSlRJyT8yux/UmFmTYy3bdR OtaGh0F49zp2m25FnZU70+FVpP7/BbAeRLUdmPVfzQ+02Ppv7EoAFoe92JFz2xKTrXi+ 60wfRIOzM+wKQsH8b5l8qrHzaH1KDREAcHYmF+SyYM+5o+dVG44VAzTv2jTbxnD56L9h VdILQ1FQUO+tAfSr4ISYRh4v0xHl6g2dFXuqtV8iL7ouctEPlC2N/sJ/qtsrn2IrWmfs kurEhFr0+MeCEShpIGpybp4sK4LIjOPY/NmSYfov1TvPYzE1zyxvKliZMWgpDEhHzhm/ SYCw== X-Gm-Message-State: APjAAAV4xGOYda4/Sc/MQ5tEV6R632Cqf0qLNskI61EFAZfHcBVCvhOE CG1KkJsDTG8G2nmkdLhU5JyDxN0O X-Google-Smtp-Source: APXvYqwc1dwKQdVFWr/kYeGzVsqmlo/idYVe+Kc4ZujC2ImEBp5MtcvMoWY0F8linh1G4RGDFi3Dag== X-Received: by 2002:adf:da4a:: with SMTP id r10mr19511860wrl.356.1572777731730; Sun, 03 Nov 2019 02:42:11 -0800 (PST) Received: from scaer.home ([2a01:cb19:8b51:cb00:6d51:4858:69b2:a25e]) by smtp.gmail.com with ESMTPSA id v128sm18330642wmb.14.2019.11.03.02.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Nov 2019 02:42:11 -0800 (PST) From: "Yann E. MORIN" To: buildroot@buildroot.org Date: Sun, 3 Nov 2019 11:42:06 +0100 Message-Id: <20191103104206.1061-1-yann.morin.1998@free.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH] package/dtc: needs host-pkgconf unconditionally X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Carlos Santos , Titouan Christophe , "Yann E. MORIN" , Fabrice Fontaine Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Commits 495e757d2 (package/dtc: add optional libyaml dependency) and e43d9072a (package/dtc: fix build without libyaml), added a conditional dependency to host-pkgconf, when libyaml is enabled, while commit 56d6dd453 (package/dtc: disable valgrind) explicitly disabled support of valgrind. However, presence of libyaml, as well as that of valgrind, *is* detected by calling pkg-config: NO_VALGRIND := $(shell $(PKG_CONFIG) --exists valgrind; echo $$?) NO_YAML := $(shell $(PKG_CONFIG) --exists yaml-0.1; echo $$?) Passing NO_YAML=1 or NO_VALGRIND=1 do not prevent the tests from being executed, which would yield messages like: /bin/sh: 1: /home/ymorin/dev/buildroot/O/host/bin/pkg-config: not found (note however that, even if the test is executed, the value we pass on the command line still takes precedence, and the support for either is properly disabled.) So, move the dependency on host-pkgconfig out of the condition. Ditto for the host package. Signed-off-by: Yann E. MORIN Cc: Fabrice Fontaine Cc: Titouan Christophe Cc: Carlos Santos --- package/dtc/dtc.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/dtc/dtc.mk b/package/dtc/dtc.mk index 7fde0dc968..e0050416ce 100644 --- a/package/dtc/dtc.mk +++ b/package/dtc/dtc.mk @@ -10,8 +10,8 @@ DTC_SITE = https://www.kernel.org/pub/software/utils/dtc DTC_LICENSE = GPL-2.0+ or BSD-2-Clause (library) DTC_LICENSE_FILES = README.license GPL BSD-2-Clause DTC_INSTALL_STAGING = YES -DTC_DEPENDENCIES = host-bison host-flex -HOST_DTC_DEPENDENCIES = host-bison host-flex +DTC_DEPENDENCIES = host-bison host-flex host-pkgconf +HOST_DTC_DEPENDENCIES = host-bison host-flex host-pkgconf DTC_MAKE_OPTS = \ PREFIX=/usr \ @@ -25,7 +25,7 @@ HOST_DTC_MAKE_OPTS = \ NO_YAML=1 ifeq ($(BR2_PACKAGE_LIBYAML),y) -DTC_DEPENDENCIES += host-pkgconf libyaml +DTC_DEPENDENCIES += libyaml else DTC_MAKE_OPTS += NO_YAML=1 endif