From patchwork Thu Oct 31 16:23:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Mostafa X-Patchwork-Id: 1187588 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 473rGT24lBz9sPK; Fri, 1 Nov 2019 03:23:12 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1iQDE4-0006vE-3v; Thu, 31 Oct 2019 16:23:08 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iQDE0-0006uQ-6s for kernel-team@lists.ubuntu.com; Thu, 31 Oct 2019 16:23:04 +0000 Received: from 1.general.kamal.us.vpn ([10.172.68.52] helo=fourier) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iQDDz-00030v-Th for kernel-team@lists.ubuntu.com; Thu, 31 Oct 2019 16:23:04 +0000 Received: from kamal by fourier with local (Exim 4.90_1) (envelope-from ) id 1iQDDx-00013g-RX for kernel-team@lists.ubuntu.com; Thu, 31 Oct 2019 09:23:01 -0700 From: Kamal Mostafa To: kernel-team@lists.ubuntu.com Subject: [SRU][Bionic][PATCH 1/1] Revert "uio: use request_threaded_irq instead" Date: Thu, 31 Oct 2019 09:23:00 -0700 Message-Id: <20191031162300.4003-2-kamal@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191031162300.4003-1-kamal@canonical.com> References: <20191031162300.4003-1-kamal@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Xiubo Li BugLink: https://bugs.launchpad.net/bugs/1843487 Since mutex lock in irq hanler is useless currently, here will remove it together with it. This reverts commit 9421e45f5ff3d558cf8b75a8cc0824530caf3453. Reported-by: james.r.harris@intel.com CC: Ahsan Atta Signed-off-by: Xiubo Li Signed-off-by: Greg Kroah-Hartman (backported from commit 3d27c4de8d4fb2d4099ff324671792aa2578c6f9) [kamal: applied just the mutex removal bit.] Signed-off-by: Kamal Mostafa Acked-by: Stefan Bader --- drivers/uio/uio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index c7bc6b8f8d22..fb5c9701b1fb 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -445,13 +445,10 @@ static irqreturn_t uio_interrupt(int irq, void *dev_id) struct uio_device *idev = (struct uio_device *)dev_id; irqreturn_t ret; - mutex_lock(&idev->info_lock); - ret = idev->info->handler(irq, idev->info); if (ret == IRQ_HANDLED) uio_event_notify(idev->info); - mutex_unlock(&idev->info_lock); return ret; }