From patchwork Sun Oct 20 17:14:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Edlinger X-Patchwork-Id: 1180042 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-511383-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="SvxWFeBl"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46x5wc63ZYz9sP7 for ; Mon, 21 Oct 2019 04:14:22 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:content-type:mime-version; q=dns; s= default; b=wQ4DvBTefE8S0QoO1WB5LMq77Epd/w+f3SDQ6zbr87uCBiEFfrwYe sp2XidFi8zrdtFN2oTviqkV/GuTOAHKNUXOAAiaOsz4wFTUTqupsTZ8SImG+fSnb N1IHBIz/m6Hej5G3IBCNVFsEKEweDf4OfYynGQte5ha8M/2NIHJk/E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:content-type:mime-version; s= default; bh=ve6XaaeRa0Rw3BzwW3iuIZfcdPg=; b=SvxWFeBlO0Dr0Fxyl5dP fcAPptAS8mUozYgwSlVogZWxk46/9PpmIWGJv/Qj3c6GfTuC5S5f9/DlFzVvFLgL HNu80gvPADsviwnGP3C65L5BPsj055Z/v/E9dOoCrzQCyVlcHl8cmk7DizPkMu7j ZUzd/71/P63kYIXddnXH9hs= Received: (qmail 73826 invoked by alias); 20 Oct 2019 17:14:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 73691 invoked by uid 89); 20 Oct 2019 17:14:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 spammy=277155, bss, HX-Languages-Length:1043, uninitialized X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-oln040092070020.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.92.70.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 20 Oct 2019 17:14:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YmI5+83qVELozYTdWD416HK4hZQCU/t5zTcEkzFzZOLN7dMytwjsh+mt6a9GkG02AgqxeKC3kP0sn8ZOAlYJaBeUVG8at7Nn4wGnVZ72wduw6u8Ygw4nz4kKYm0CiI5qQH6zK5wW15xBmO8A1en3MuhQC5EhvE2DH38aw5bFCuLjoRePeF5cluSSA677fT+vvPcGzymPG+lkTt4HZS1yxMlsX3yYpOZCi44HpMFO5LjziKz9cz+eBoZK8Cu6jvRztTHDV90jrf2mqh5np1m4XVFMM7XgL6RpBBtPGPL0F+1z5dPvR/0/iApkzj5NJ3jy5soI2hUwI1mf5msVbAyCXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W9ap6HGjc1e5dyk6RbWYj0V0h3j5xKBSHta47WQETSY=; b=iLh5Q1kLQJ5TEWK+nsafIZgCCB7zHJoVbvVZQh0cfGdgFy8jppDKOF3cOdefSmgFXHh19vTZcZjkV3inKWVEp/AEZqf9MPtC2HvEvK0BrH/RgRcunvvhpGXfdygINX6vbDYg1rhuipBgNzjz4Y+/5eJ7rnNpfs4WOpOU/ClXVjgI3c68qjC6NNVbpTQvKOPN23hNlTwmsO78VyeOm9w+AB2rOhZEg4+0WwYEI0it4BPmcsyS260xVHv6PurLB/bJtEdm5xw9hg3NFTP7+fuUgNecgFRWT7ZDIfYwlxzCzSHEn86tfYgzSjLDp95wL77KxFvbNVnEayze7NJFKTjxNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com (10.152.18.60) by VE1EUR03HT201.eop-EUR03.prod.protection.outlook.com (10.152.19.195) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15; Sun, 20 Oct 2019 17:14:09 +0000 Received: from VI1PR03MB4528.eurprd03.prod.outlook.com (10.152.18.58) by VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Sun, 20 Oct 2019 17:14:09 +0000 Received: from VI1PR03MB4528.eurprd03.prod.outlook.com ([fe80::f12a:6f14:2368:e758]) by VI1PR03MB4528.eurprd03.prod.outlook.com ([fe80::f12a:6f14:2368:e758%4]) with mapi id 15.20.2347.028; Sun, 20 Oct 2019 17:14:09 +0000 From: Bernd Edlinger To: "gcc-patches@gcc.gnu.org" , Sandra Loosemore Subject: [PATCH] Fix description of -fcommon Date: Sun, 20 Oct 2019 17:14:09 +0000 Message-ID: x-microsoft-original-message-id: x-ms-exchange-transport-forked: True MIME-Version: 1.0 Hi, I've noticed that the description of -fcommon that gets printed with "gcc -v --help" is exactly the opposite of what this option actually does. With -fcommon, different global variables w/o initial value are plced in common blocks, similar to fortran named common blocks, while with -fno-common, those variables are placed in the .bss segment. I believe the description is describing the "flag_no_common", but that is not what the user needs to know. Bootstrapped and reg-tested on x86_64-pc-linux-gnu. Is it OK for trunk? Thanks Bernd. 2019-10-20 Bernd Edlinger * common.opt (-fcommon): Fix description. Index: gcc/common.opt =================================================================== --- gcc/common.opt (revision 277155) +++ gcc/common.opt (working copy) @@ -1132,7 +1132,7 @@ fcommon Common Report Var(flag_no_common,0) -Do not put uninitialized globals in the common section. +Put uninitialized globals in the common section. fcompare-debug Driver