From patchwork Thu Oct 17 16:55:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1178791 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZfF3Ynp9"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46vFfF1cM2z9sP3 for ; Fri, 18 Oct 2019 03:55:33 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 940EB86C45; Thu, 17 Oct 2019 16:55:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wwMEMV7YLSIV; Thu, 17 Oct 2019 16:55:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id DF0B286C5D; Thu, 17 Oct 2019 16:55:30 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id DFFDA1BF4E3 for ; Thu, 17 Oct 2019 16:55:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D07C287C99 for ; Thu, 17 Oct 2019 16:55:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5PL0Iqp7xPdC for ; Thu, 17 Oct 2019 16:55:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by whitealder.osuosl.org (Postfix) with ESMTPS id 0F4EB87C05 for ; Thu, 17 Oct 2019 16:55:29 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id i16so3299704wmd.3 for ; Thu, 17 Oct 2019 09:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WP51iUEaleLcwKoKknvXWAgZmLbotQM9FfkK8CmUwtQ=; b=ZfF3Ynp9Uv5+Zc5Wm5TcsoD0E3yoQtV3mV7z3RiG+TLCS6cXdXo/6kUOPxntDZ0aPE v0AgWcd2ZbzlwUWNVMTlNs7ckIWtHoTGz6eNJeeDJ17wV6dDmRCQQLDTaGnt+JvczqNc XJ2/5+T6kKFiQmsumSYRFgphPzBvUTJaKSfi33szWkYCiRs5LtTEDAWE/sB+PzqvJ3Fc WSo3AhnIK43i192zpZpD+e28ppEZAMai6MXiK9ef3qbLmjWIJ2Z4iQeTcOU/sAWM3Whp UzJ0FQpKu4mVf1DVCiNvGNjc0lSgkSFDMc3zHX6sHMHpaMf/eU/kz2n52f1/erneNfqB pBYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WP51iUEaleLcwKoKknvXWAgZmLbotQM9FfkK8CmUwtQ=; b=hbbURN85Ba4TpBHp9Q2pLFMXBTgTfxdk9NtWYzIV/NU14R+zRQpp+7kO9p2EqWiaGb ltwojlGrNebUI4pk5vlDUxj+ZsQaMr7jPt00gEgm2Yrap8mtMniK7iSOsfCwlafgBlYG L+M6fwArR5STWbmwXJfJxlgjT7Lo0ljQBJFF6SC+n9a3+6AGkPhnJiagU0L+ZADZdhtv spkJ8IS7SgB44FVdDLTAYhNX3fcbyORx6MlQ+hdq52DK4+zlQN4x7AVQtOts0Qly6kDN iu7yE//DqmYMMn7M5k2OXwOTSh/ftlAahEsm96Ak0X64nSGsL7OpflZICVe107HaWpli nECw== X-Gm-Message-State: APjAAAUSLbu8HvKnkthJvKpoavb8qBKkaMYFKAWkMCLeA+53goZGD1+F GaVJi2khREINnAmDprdm4BG8CXlC X-Google-Smtp-Source: APXvYqxVQEOASPwQz1Af4daF5i9bxTeshKfofdT1u7/rF6iomxB6pXM5TiCoKi2hubl4AqbfgUaCTg== X-Received: by 2002:a05:600c:2107:: with SMTP id u7mr3762647wml.13.1571331327078; Thu, 17 Oct 2019 09:55:27 -0700 (PDT) Received: from kali.home (lfbn-1-3732-187.w86-229.abo.wanadoo.fr. [86.229.230.187]) by smtp.gmail.com with ESMTPSA id o19sm3255210wmh.27.2019.10.17.09.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 09:55:26 -0700 (PDT) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Thu, 17 Oct 2019 18:55:59 +0200 Message-Id: <20191017165559.9662-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Subject: [Buildroot] [PATCH v3, 1/1] package/libopenssl: set no-asm with generic architectures X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabrice Fontaine Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Use no-asm when building statically with a generic architecture such as gcc or linux-generic32, see https://github.com/openssl/openssl/issues/9839 This will fix a static build failure on x86_64 due to the removal of x86/x86_64 BSAES and AES_ASM support by https://github.com/openssl/openssl/commit/87bea6550ae0dda7c40937cff2e86cc2b0b09491 Fixes: - http://autobuild.buildroot.org/results/e4f04bb13ec1b82b73db645bea4933e52bca4185 Signed-off-by: Fabrice Fontaine --- Changes v2 -> v3 (after review of Thomas Petazzoni): - Set no-asm with linux-generic32 Changes v1 -> v2 (after review of Thomas Petazzoni): - Set no-asm with all static builds and not only x86_64 package/libopenssl/libopenssl.mk | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/package/libopenssl/libopenssl.mk b/package/libopenssl/libopenssl.mk index 4a430bcb4d..59f2cf18eb 100644 --- a/package/libopenssl/libopenssl.mk +++ b/package/libopenssl/libopenssl.mk @@ -12,7 +12,10 @@ LIBOPENSSL_LICENSE_FILES = LICENSE LIBOPENSSL_INSTALL_STAGING = YES LIBOPENSSL_DEPENDENCIES = zlib HOST_LIBOPENSSL_DEPENDENCIES = host-zlib -LIBOPENSSL_TARGET_ARCH = linux-generic32 +# no-asm is needed with generic architectures such as linux-generic32, see +# https://github.com/openssl/openssl/issues/9839 +LIBOPENSSL_TARGET_ARCH = gcc no-asm +LIBOPENSSL_TARGET_ARCH = linux-generic32 no-asm LIBOPENSSL_CFLAGS = $(TARGET_CFLAGS) LIBOPENSSL_PROVIDES = openssl @@ -55,7 +58,9 @@ endif ifeq ($(BR2_STATIC_LIBS),y) # Use "gcc" minimalistic target to disable DSO -LIBOPENSSL_TARGET_ARCH = gcc +# no-asm is needed with generic architectures such as gcc, see +# https://github.com/openssl/openssl/issues/9839 +LIBOPENSSL_TARGET_ARCH = gcc no-asm else # Some architectures are optimized in OpenSSL # Doesn't work for thumb-only (Cortex-M?)