From patchwork Thu Oct 17 11:26:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georg-Johann Lay X-Patchwork-Id: 1178476 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-511206-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gjlay.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="nKHHOHgr"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gjlay.de header.i=@gjlay.de header.b="qgwj4Ber"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46v6MJ1BZTz9sPF for ; Thu, 17 Oct 2019 22:27:05 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=FbSSxCP/m5d5fMwT8rfTWpziCRi8AjocB/SvElMPFDwB1+PbGM uAIQ5r6NV0/SAlhapwY4TT7BTtkPgQjjlt/25/yQMU7drHTzyO0y2Z5cPissfFp1 s1pfXgYyWd3xN8H/873CEwN72NvtQAB/E+4JaGtA4MmVNGVBj0iKEd4dk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; s= default; bh=MgF6Hh0UUGJlIR3xCkxJqSR/tvk=; b=nKHHOHgri7W1BVR8p7Pa huACInqRlWuEv35qPYGwaRrCCVKgl5/Khu+kr4tE2Tl7mPov2vUnTE35U4tIjsro J0lZ05X+SdqjmA/hhrwdHiF/p4UJmKdtYk59KIFt7FXC0ITequDL1cefeieXIw7Q Z5E73Ns3rxk1hFVmSkgPI0c= Received: (qmail 46434 invoked by alias); 17 Oct 2019 11:26:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 46323 invoked by uid 89); 17 Oct 2019 11:26:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mo4-p00-ob.smtp.rzone.de Received: from mo4-p00-ob.smtp.rzone.de (HELO mo4-p00-ob.smtp.rzone.de) (81.169.146.218) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Oct 2019 11:26:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1571311614; s=strato-dkim-0002; d=gjlay.de; h=Date:Message-ID:Subject:From:Cc:To:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=umpD4ynyyUzmhJlDVUI5GO+c81rx5kgwLxUBsBi+h00=; b=qgwj4BerSr8ewU1Ibh2GSSTNbN0gRgCEycLnxJ1a1isFpBgoyCUYg6M9VKebzL+5hC Z/HGkByKxzK79lP/wZAlFBL5TGCcs8BO0SvtnSJfKo6uD3mppRb+UKZK4DoNuFITWLd+ Uuv7N2AuqN5QvFirGOAqCtLEe4yyCpSWM4ld8+bEn6dxT8+VY19CfzOw5Oh4KTd3KCje KXUsNmH95rWG54dq+uUbrrI+VgYm97L6AmcBHj7+XvbVBwKSc6jlo+a7mq+rA0/D2NsJ gYinnss72XpTcnprsJE/ztCmBJfu257ivu9jXa5/gEe5brF8E9e6NKnBHUdrGMRiBT+w mqqw== Received: from [192.168.114.100] by smtp.strato.de (RZmta 44.28.1 DYNA|AUTH) with ESMTPSA id t01740v9HBQr43e (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Thu, 17 Oct 2019 13:26:53 +0200 (CEST) To: gcc-patches@gcc.gnu.org Cc: Denis Chertykov From: Georg-Johann Lay Subject: [patch,avr]: PR86040: Fix missing reset of RAMPZ after ELPM. Message-ID: Date: Thu, 17 Oct 2019 13:26:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 X-IsSubscribed: yes Hi, for families avrxmega5/7 after ELPM the reset of RAMPZ to zero was missing in some situations due to shortcut-return in avr_out_lpm which which bypassed that reset. Ok to apply and backport? Johann PR target/86040 * config/avr/avr.c (avr_out_lpm): Do not shortcut-return. Index: config/avr/avr.c =================================================================== --- config/avr/avr.c (revision 276704) +++ config/avr/avr.c (working copy) @@ -3780,13 +3780,14 @@ avr_out_lpm (rtx_insn *insn, rtx *op, in gcc_unreachable(); case 1: - return avr_asm_len ("%4lpm %0,%a2", xop, plen, 1); + avr_asm_len ("%4lpm %0,%a2", xop, plen, 1); + break; case 2: if (REGNO (dest) == REG_Z) - return avr_asm_len ("%4lpm %5,%a2+" CR_TAB - "%4lpm %B0,%a2" CR_TAB - "mov %A0,%5", xop, plen, 3); + avr_asm_len ("%4lpm %5,%a2+" CR_TAB + "%4lpm %B0,%a2" CR_TAB + "mov %A0,%5", xop, plen, 3); else { avr_asm_len ("%4lpm %A0,%a2+" CR_TAB @@ -3815,9 +3816,9 @@ avr_out_lpm (rtx_insn *insn, rtx *op, in "%4lpm %B0,%a2+", xop, plen, 2); if (REGNO (dest) == REG_Z - 2) - return avr_asm_len ("%4lpm %5,%a2+" CR_TAB - "%4lpm %C0,%a2" CR_TAB - "mov %D0,%5", xop, plen, 3); + avr_asm_len ("%4lpm %5,%a2+" CR_TAB + "%4lpm %C0,%a2" CR_TAB + "mov %D0,%5", xop, plen, 3); else { avr_asm_len ("%4lpm %C0,%a2+" CR_TAB