From patchwork Mon Oct 14 11:43:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pankaj Bansal X-Patchwork-Id: 1176270 X-Patchwork-Delegate: priyanka.jain@nxp.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="deFOVUEe"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46sGsk6hp9z9sPc for ; Mon, 14 Oct 2019 22:43:36 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 43E08C21D56; Mon, 14 Oct 2019 11:43:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id ECB44C21C51; Mon, 14 Oct 2019 11:43:22 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id E1F8DC21C51; Mon, 14 Oct 2019 11:43:21 +0000 (UTC) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00060.outbound.protection.outlook.com [40.107.0.60]) by lists.denx.de (Postfix) with ESMTPS id 729ADC21BE5 for ; Mon, 14 Oct 2019 11:43:21 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hnUwgFIU1ZJP7ECT6pIXQS7AOtO4cxgD0LHNe+b8HyjI+800OwB2diHBeWN8nO+GScj2n3IfpBqz8zqmRjsU3wq+g76GDucDpp7rmkgR8Lq7Arbg4VZU6TBy0vwkiWwk0YxpJ84Q12lVDz1ZgCiEdn51wyNgzrAUENID0eCN8jKeCU47Ht2TTxEEfy/sBpdxXEVyIVjjthr+XZbtODkITtfhCEv/Bo+V/L2dfgu48stJKRcbni4ok2k2i//xw25U5MifjETLiYbtIMpMRW4DTKThBXWiWH9zTU6BtOR0S3e2R/gc93t0gflZT35F/qqKkVgsGi6y3kKm9aJfoYVXLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iMCwXZyxnoHTXBC4KMxZdUglvTTPOofSem83+8eRNBQ=; b=IwISYpFoCml93gBVyPSenRnyvDluRVsFus89tNdh4bEXffavxdU0ekSLGHD/wM7rQwaDGLQyc3Uy1u0won4lhdUyV3idduiqzyurhAroW0Sr9YBAJyz16g74x0zP2LkFX0swvwVnw10bBBjgKvfMS5rsGh559rSyML3HEQyFtTRd5lwIKA+7swX3s0cP2qwgonv/RFIYURPhFCuNgTvAYcGidP+Htposr5CS1eS4iUz8eSX8jZ3dKttLWeenDBRsMj/9m2b/FmqO1Nuaw3kH5yNnNgWrQw5dbIMmfru/OA5EY1SvcFyO+SFLGFms1dWGV2mh0SZoGJI0mfUTGM/d1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iMCwXZyxnoHTXBC4KMxZdUglvTTPOofSem83+8eRNBQ=; b=deFOVUEeh0EB7/Lk2SXd5EqO2VzPAwp2aztQf3e0/vjGx7Kvx9FbTWWrLGJrLdVObSyDHXB+RvXZP3r1OtEgE2iZoj+1Z1ZD36bLFVfqFOujKC1qk3d1ScDC8BgbQdG91CDJEOJBKUeCOxJ3R5Zobgd8uVTtyTJoAOc+D9xptD4= Received: from VI1PR0401MB2496.eurprd04.prod.outlook.com (10.168.65.10) by VI1PR0401MB2576.eurprd04.prod.outlook.com (10.168.65.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.22; Mon, 14 Oct 2019 11:43:20 +0000 Received: from VI1PR0401MB2496.eurprd04.prod.outlook.com ([fe80::b439:8d49:805b:22f4]) by VI1PR0401MB2496.eurprd04.prod.outlook.com ([fe80::b439:8d49:805b:22f4%12]) with mapi id 15.20.2347.021; Mon, 14 Oct 2019 11:43:19 +0000 From: Pankaj Bansal To: Priyanka Jain , Xiaowei Bao , Tom Rini , "Z.q. Hou" Thread-Topic: [PATCH] pci: layerscape: Only set EP CFG READY bit Thread-Index: AQHVgoSTX/ScqTkgWk+hl4FAS/sEjA== Date: Mon, 14 Oct 2019 11:43:19 +0000 Message-ID: <20191014170510.30692-1-pankaj.bansal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2PR06CA0205.apcprd06.prod.outlook.com (2603:1096:4:68::13) To VI1PR0401MB2496.eurprd04.prod.outlook.com (2603:10a6:800:56::10) x-mailer: git-send-email 2.17.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=pankaj.bansal@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [92.120.1.69] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 01e0fc08-5fd4-4ed1-c352-08d7509bb57c x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VI1PR0401MB2576:|VI1PR0401MB2576: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 01901B3451 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(396003)(376002)(39860400002)(346002)(189003)(199004)(2616005)(478600001)(8676002)(476003)(486006)(81156014)(81166006)(8936002)(71190400001)(71200400001)(66066001)(44832011)(256004)(26005)(186003)(14444005)(3846002)(6116002)(50226002)(2906002)(25786009)(5660300002)(14454004)(54906003)(1076003)(6512007)(6486002)(6436002)(110136005)(86362001)(99286004)(7736002)(4326008)(66476007)(66946007)(305945005)(66556008)(6636002)(102836004)(386003)(6506007)(36756003)(64756008)(66446008)(52116002)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0401MB2576; H:VI1PR0401MB2496.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WLB9Igp1s4dkp52gsZPg/S5cYVEQG+KOZGHU8zuwqNE60Lcw49dHPuBQcL7uYUeZwk23/TohB1L+53fMck9q42ntJXZu+HMTDzZWvg0gMkT9TIQwvvTkB83c2P0tMJZ9EooWo7opu8rBXJYZYvdlAr+RNsIlMNu++VXMe4etRSNGgtil7o1gsZ2zh95UWYX2uzrmDOxzp8VQYnZFv/tmoDQuesZuwMkozvrLqlaEkIu0PJymwULBreNYF6Viy5O14BOhxtYBzlTjr0esHZzpe0/huh+fXJOUKQZXdngUs8GkydEATxxdikrZOKXonKeu23uTpvPfW5fvh0zMCeYs8S3JPOZu/7dOL5udhlt+Ec40pWX4I57mSfkTHdsH0Kjd9gr3lUoCk2rJfOME0njxDZz+63m+bgEAmgNCXYht6HA= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01e0fc08-5fd4-4ed1-c352-08d7509bb57c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2019 11:43:19.5128 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GwNxkYZh5/MBJ3bZBfy6k5114tXDOz71ENUeGFoqS8uigZg8CzUFF+k3BoslM0bKqEw0GHhCZHq1B6gU+ooVMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2576 Cc: "u-boot@lists.denx.de" Subject: [U-Boot] [PATCH] pci: layerscape: Only set EP CFG READY bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" As part of EP setup, we want to set the config ready bit of controller, so that RC can read the config space of EP. Now, when we set the config ready bit we are inadvertently clearing the LTSSM_EN bit in same register, which restarts the link tarining between RC and EP. Therefore, just set the desired CFG_READY bit (bit 0), while leaving the other bits unchanged. Signed-off-by: Pankaj Bansal Reviewed-by: Hou Zhiqiang --- drivers/pci/pcie_layerscape.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pcie_layerscape.c b/drivers/pci/pcie_layerscape.c index d8a7b7c865..bb2ec7c2ce 100644 --- a/drivers/pci/pcie_layerscape.c +++ b/drivers/pci/pcie_layerscape.c @@ -407,7 +407,11 @@ static void ls_pcie_ep_setup_bars(void *bar_base) static void ls_pcie_ep_enable_cfg(struct ls_pcie *pcie) { - ctrl_writel(pcie, PCIE_CONFIG_READY, PCIE_PF_CONFIG); + u32 config; + + config = ctrl_readl(pcie, PCIE_PF_CONFIG); + config |= PCIE_CONFIG_READY; + ctrl_writel(pcie, config, PCIE_PF_CONFIG); } static void ls_pcie_setup_ep(struct ls_pcie *pcie)