From patchwork Mon Oct 7 21:08:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Matyukevich X-Patchwork-Id: 1172966 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UHWRYkMv"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lv4Y4otD"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46nCh36sh3z9sPT for ; Tue, 8 Oct 2019 08:06:10 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WdcEX5D483Gedri9xLkhz3cvmx/AnVQMmHj6TrNjSxQ=; b=UHWRYkMvflJMGJ YBM1O9AerH5QdlyLN+OfZj1F+++zzav/DdtRiKarJXdXjHIcYjG5qNUniSSKdetPOkk+5HmFsgE4z CLa1tboAo/gGS4Zo97ftxr3qEE6ugsQS+49b1unfZKEkMrzVOzXj/qEi+ClxctpxcGkaLEMbOFuS9 ErpzvoU3rU2TVxykUaEvRebMB3wcgVs5JoLIHbeuGF8XWAHw19o/CknkqDKwhhV5RFh2R+PCaZRja K0H8Ah0xjOCYm4m10Mt9fu/5P81lYximlkc0tFIUT/fLJe6G8mm4ORV8+6LX81rp0ZqwQViQJ9rAj k/nacufE4m2gxVaGaDig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHaCk-0002JI-0k; Mon, 07 Oct 2019 21:06:06 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHaCg-0002Is-Qw for hostap@lists.infradead.org; Mon, 07 Oct 2019 21:06:04 +0000 Received: by mail-lj1-x244.google.com with SMTP id b20so15230096ljj.5 for ; Mon, 07 Oct 2019 14:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bWiubCG18+tMy9QRnd15JnP0GTJHm+nep1H9R79s/8k=; b=lv4Y4otDleSIRApoQK4UaJSYC6+/fPrANh6Eq+S+TMqEIBzTdDS8kW8VhE44UTo1FO k1JiTiPl2H962VjLPTgwvuIUZz50ni326u0aBP1WtG+GlJ64hRdzPumUZwrR79wBnqow 8dEwYLl2dpz8s1KNaJ6DtdjPHCAXLq4LR+lwppAUEAx4qF61dmV+hi4hnAr6TxHUplVv JOuQobrIxSHYUcBFZqtgq+zKKjGN5HbbR3J/PMLyI5YvMmNq5Fw0hc+A7ky+QRp2nluR TD7V4z1/C0CbWqIs9JAiRxMMKIkSK46mF0RnLatcb7QmcDJShX2eQzQMGz23tUQ790F4 buNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bWiubCG18+tMy9QRnd15JnP0GTJHm+nep1H9R79s/8k=; b=q8/BQRiiCwk3YiaVcxBjtERu3wv9/w9F2Oy4xyo4YjEOBvhsXQGlY0z3A0CaPK5aBm Cm2c3QppwOExNOuqi5d+IK8fBw2Zn6cQWtlnIzNTaE3oPRE/H3JhAzXTIrR0np9s/QBg TLApaXvW9UBJcJAdWPVQ0IT/fGVYr4HYxVYGx19rvbYRlafZMWLHGIRuz+18+oU2ERrw GbQm9ARNnhB//VZ+1LQ9ix7L6Ukz/fwCWJqVtYps5JRyHnErroRJdT4WqHZvdyBq2Lmn hamTvGtIrcX/NBRAsZZ0WGrOZY6xCklii8fhWwnNHmoJn02PQzylvYNy/xTgIHm484n8 igmw== X-Gm-Message-State: APjAAAVrQAnv4qQBX3K2pY7tbs6YyGde1zCpIKol7+EY3BsPppLC5V89 mYblYvee2Gbr+gnMPTVug4YIYBaO X-Google-Smtp-Source: APXvYqxviBKDxjm1c0le/GCSECGfjN0PtZEMBF+ydDsKBoD+gWF4as17D0mTQaL/hK8HabUctsbjTw== X-Received: by 2002:a2e:9610:: with SMTP id v16mr12165082ljh.21.1570482360420; Mon, 07 Oct 2019 14:06:00 -0700 (PDT) Received: from localhost.localdomain (ppp91-122-167-66.pppoe.avangarddsl.ru. [91.122.167.66]) by smtp.googlemail.com with ESMTPSA id k13sm3509889ljc.96.2019.10.07.14.05.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 14:05:59 -0700 (PDT) From: Sergey Matyukevich To: hostap@lists.infradead.org Subject: [PATCH] drivers: support of dynamic VLAN requires Linux ioctls Date: Tue, 8 Oct 2019 00:08:32 +0300 Message-Id: <20191007210832.17435-1-geomatsi@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_140602_874490_CFBFD017 X-CRM114-Status: UNSURE ( 8.52 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:244 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (geomatsi[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jouni Malinen , Sergey Matyukevich , Arnout Vandecappelle Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Sergey Matyukevich Support of dynamic VLANs depends on Linux bridge ioctls. Add this dependency explicitely to drivers make files. This commit fixes build for minimal hostapd configs such as: CONFIG_DRIVER_WIRED=y CONFIG_FULL_DYNAMIC_VLAN=y Signed-off-by: Sergey Matyukevich --- src/drivers/drivers.mak | 11 ++++++----- src/drivers/drivers.mk | 11 ++++++----- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/drivers/drivers.mak b/src/drivers/drivers.mak index 442c59cf4..bc2e87e08 100644 --- a/src/drivers/drivers.mak +++ b/src/drivers/drivers.mak @@ -140,10 +140,6 @@ ifdef NEED_NETLINK DRV_OBJS += ../src/drivers/netlink.o endif -ifdef NEED_LINUX_IOCTL -DRV_OBJS += ../src/drivers/linux_ioctl.o -endif - ifdef NEED_RFKILL DRV_OBJS += ../src/drivers/rfkill.o endif @@ -152,13 +148,18 @@ ifdef NEED_RADIOTAP DRV_OBJS += ../src/utils/radiotap.o endif -ifdef CONFIG_VLAN_NETLINK ifdef CONFIG_FULL_DYNAMIC_VLAN +NEED_LINUX_IOCTL=y +ifdef CONFIG_VLAN_NETLINK NEED_LIBNL=y CONFIG_LIBNL3_ROUTE=y endif endif +ifdef NEED_LINUX_IOCTL +DRV_OBJS += ../src/drivers/linux_ioctl.o +endif + ifdef NEED_LIBNL ifndef CONFIG_LIBNL32 ifndef CONFIG_LIBNL20 diff --git a/src/drivers/drivers.mk b/src/drivers/drivers.mk index 599a0b579..c3c2c0fe1 100644 --- a/src/drivers/drivers.mk +++ b/src/drivers/drivers.mk @@ -132,10 +132,6 @@ ifdef NEED_NETLINK DRV_OBJS += src/drivers/netlink.c endif -ifdef NEED_LINUX_IOCTL -DRV_OBJS += src/drivers/linux_ioctl.c -endif - ifdef NEED_RFKILL DRV_OBJS += src/drivers/rfkill.c endif @@ -148,13 +144,18 @@ ifdef CONFIG_DRIVER_CUSTOM DRV_CFLAGS += -DCONFIG_DRIVER_CUSTOM endif -ifdef CONFIG_VLAN_NETLINK ifdef CONFIG_FULL_DYNAMIC_VLAN +NEED_LINUX_IOCTL=y +ifdef CONFIG_VLAN_NETLINK NEED_LIBNL=y CONFIG_LIBNL3_ROUTE=y endif endif +ifdef NEED_LINUX_IOCTL +DRV_OBJS += src/drivers/linux_ioctl.c +endif + ifdef NEED_LIBNL ifdef CONFIG_LIBNL32 DRV_LIBS += -lnl-3