From patchwork Fri Oct 4 21:21:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1172048 X-Patchwork-Delegate: i.maximets@samsung.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PHna783S"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46lN9V4nTDz9sN1 for ; Sat, 5 Oct 2019 07:21:49 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id CCCC1D13; Fri, 4 Oct 2019 21:21:46 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 14125C00 for ; Fri, 4 Oct 2019 21:21:46 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 478FAA8 for ; Fri, 4 Oct 2019 21:21:44 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id q7so4641625pfh.8 for ; Fri, 04 Oct 2019 14:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ywrZSYFPzw4mIAHhPbm+HyKqkBJyEDsqWYJ9psccLlg=; b=PHna783SSOv478yNBul+mgyLh63HiA5kw4V4JUXf12LgHH7tBY8rS7wXoZEBzFUEfm FWbs8JcG2pavdnAfbU9UYPAJ6GuOteofA+xGJEvhIUZfxk6Cf93OSNfQPPZvllBHZ/ty 0ho0ra/ax/UPi7RxPEattouKul+XCbilk1q5MEiAc/rshHyXV/fu+CL81gwCAD0Wm7IQ 1gbTwxkDUGKEFjNwB5Mk865vNTD+HQFZDWcHuRb/dJOAB8SOGxUdguG/eDVVk8gJKqcj 54V4j8XI2rTeekND2mzda1T3m2AbOfZ6xNgL03MsEmuDz7jyFSrEo8NBG5CuGYmjJzoR X66g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ywrZSYFPzw4mIAHhPbm+HyKqkBJyEDsqWYJ9psccLlg=; b=H9fH0KiNKmQo2SDjNLUQOOlRh1cm3S90lQmwPBc+3ezYilKlQDqSKn+7gCFRLSVubE LNlFnbuT9ry+ykN3nqoEEDT9Y8WtLR6ga9VUnn406sfuEBUmMkq8sRDtkof1ulC6mIBS XTNcC1uvAUe274z/oitexwJX9E/dtAwFL2uBG+qrxw1ukx5ObqgGOYYi60uKy3ZAd0QS LqtMFPlleqJhcinefbu/QNTSRlpLZvBlIDQ8wSF5xSfFFqC13zptPavjJ2M6VKtcnnop NCTk0thig0uSDpzQxSslC1E39gw2KGmECiPVCwAQViifUwHWF5m2tz4XXWjUDqieUOZ3 Lefw== X-Gm-Message-State: APjAAAVkunIXia2iwo2cLcdSP1ZOogAVT0u4gMRiOcGHUcM4dsV0XZkB /BQYdUhSWTIvcz5yMElRb06aeANlHa0= X-Google-Smtp-Source: APXvYqwuqjevHnUns3Jo5+BCq6eHxSh8+HkiR9D5ZGlIKqQLPIRRCKssSTJuF5Sn8B/WLdOA6d7RoQ== X-Received: by 2002:a63:d155:: with SMTP id c21mr17952293pgj.131.1570224103385; Fri, 04 Oct 2019 14:21:43 -0700 (PDT) Received: from sc9-mailhost2.vmware.com ([66.170.99.95]) by smtp.gmail.com with ESMTPSA id m102sm5603385pje.5.2019.10.04.14.21.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Oct 2019 14:21:42 -0700 (PDT) From: William Tu To: dev@openvswitch.org Date: Fri, 4 Oct 2019 14:21:15 -0700 Message-Id: <1570224076-122697-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: i.maximets@ovn.org Subject: [ovs-dev] [PATCH 1/2] travis: Fix 32-bit libunwind system build. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org 32-bit and 64-bit libunwind can not be installed at the same time. For 32-bit build, this patch removes the 64-bit libunwind and install 32-bit version. Fixes: e2ed6fbeb18c ("fatal-signal: Catch SIGSEGV and print backtrace.") Signed-off-by: William Tu Acked-by: Ilya Maximets --- .travis/linux-prepare.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.travis/linux-prepare.sh b/.travis/linux-prepare.sh index 70fd98f715ed..e546d32cb7df 100755 --- a/.travis/linux-prepare.sh +++ b/.travis/linux-prepare.sh @@ -14,3 +14,9 @@ cd .. pip install --disable-pip-version-check --user six flake8 hacking pip install --user --upgrade docutils + +if [ "$M32" ]; then + # 32-bit and 64-bit libunwind can not be installed at the same time. + # This will remove the 64-bit libunwind and install 32-bit version. + sudo apt-get install -y libunwind-dev:i386 +fi From patchwork Fri Oct 4 21:21:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1172049 X-Patchwork-Delegate: i.maximets@samsung.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MmPCAZZ8"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46lNBD3x6Yz9sN1 for ; Sat, 5 Oct 2019 07:22:28 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id A938FDA2; Fri, 4 Oct 2019 21:21:48 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id A187AD13 for ; Fri, 4 Oct 2019 21:21:46 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id DD193189 for ; Fri, 4 Oct 2019 21:21:44 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id p30so2378600pgl.2 for ; Fri, 04 Oct 2019 14:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=O0W2xtqVN8JzdmVEFdyJSV/NG8/MdbWQSSiKcGdw9Ss=; b=MmPCAZZ8WsrKhOVnevk4sK2M4FQ9+WTds3cfdVHTYWFCcrHVHHds6sPBm321WbOMHC dpsd+cRGSUeDXnJbI0FaHCrd1uo96wf3Xpsmuk+bemK72qGKaspvImC23DiDNDEPWcbw jgqdNdFrXY3SpuhUtXcOtv2SK/VP1pav0daXPiciUKXvmlOTb37oOJlMDYqH3aDtAYc2 0Ul3M1qlB6loEXbTgcNac3S1NLxBrneudPh0pbIE3jIMyHAGKdtXVVP6a9Zd2bbVTS7p JhP66pHrAfyfoWT0T4eo4u8FSb4e7oexOePDEF3dYKhjbdws1kKY3wSPJc5fZAoTUTWy YWdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=O0W2xtqVN8JzdmVEFdyJSV/NG8/MdbWQSSiKcGdw9Ss=; b=HQMFNLaP739Qg0V0/HubmYgzYXrTy9aRI+Fy0nU4qg9gBinwB0u/eo3wwmv6V0rTac s0WatK9QMmwr02SeN4PTB5KRiPVOht4yVOmgeGIONccYR92c5vwf+XXqvkl1HDkcBdPk CEdNeOcNHioH7ylMThVH6uSk4XV6aFiDRtIIXCmQq6DkmT6NxMVrFdupKJDz9QQTiGgn 8FhaYgePyhx3FAMduYOkp0+XfIg+GVf6FBEkTRtsJEVQ0vCIEohtPkw/qlj2mFL8ZfWr 8EaDqUp29TkW4Tc72riTvzcK9C6ym89pULidBY80ZuyJxOPlIpNOIxmsEMYGEa/62n7i 0YwA== X-Gm-Message-State: APjAAAWn34H4csBhRpXuTOadRSva4wRgk8Nd3ZuxA0ufJsHPFRldfNyM B5WqbVDFwezFx1vLJ3t1X2pGK+qkurc= X-Google-Smtp-Source: APXvYqy7bMjD31VE6War3LTzOaBGLcDjWyD8nQyqvnVnLUG3uIz3CyXjNYCNvBSL9LqibfLVPV/SOA== X-Received: by 2002:a17:90a:7bce:: with SMTP id d14mr19085892pjl.96.1570224104291; Fri, 04 Oct 2019 14:21:44 -0700 (PDT) Received: from sc9-mailhost2.vmware.com ([66.170.99.95]) by smtp.gmail.com with ESMTPSA id m102sm5603385pje.5.2019.10.04.14.21.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Oct 2019 14:21:43 -0700 (PDT) From: William Tu To: dev@openvswitch.org Date: Fri, 4 Oct 2019 14:21:16 -0700 Message-Id: <1570224076-122697-2-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1570224076-122697-1-git-send-email-u9012063@gmail.com> References: <1570224076-122697-1-git-send-email-u9012063@gmail.com> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: i.maximets@ovn.org Subject: [ovs-dev] [PATCH 2/2] backtrace: Fix 32-bit libunwind build. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org The libunwind unw_word_t type is defined as uint32_t for 32-bit system and uint64_t for 64-bit system. The patch fixes the compile error using PRIxPTR to print this value. Fixes: e2ed6fbeb18c ("fatal-signal: Catch SIGSEGV and print backtrace.") Signed-off-by: William Tu Acked-by: Ilya Maximets Signed-off-by: William Tu > Acked-by: Ilya Maximets > --- lib/backtrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/backtrace.c b/lib/backtrace.c index 9347634487c8..2853d5ff150d 100644 --- a/lib/backtrace.c +++ b/lib/backtrace.c @@ -102,7 +102,7 @@ log_received_backtrace(int fd) { if (backtrace[i].func[0] == 0) { break; } - VLOG_WARN("0x%016lx <%s+0x%lx>\n", + VLOG_WARN("0x%016"PRIxPTR" <%s+0x%"PRIxPTR">\n", backtrace[i].ip, backtrace[i].func, backtrace[i].offset);