From patchwork Tue Oct 1 13:36:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 1169951 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NRiO+Yiu"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46jL191Fyrz9sR4 for ; Tue, 1 Oct 2019 23:37:32 +1000 (AEST) Received: from localhost ([::1]:42224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFILK-00066Z-KZ for incoming@patchwork.ozlabs.org; Tue, 01 Oct 2019 09:37:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58032) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIKQ-00063r-Fb for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFIKP-0001cq-D8 for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:34 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:55337) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFIKP-0001c6-69 for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:33 -0400 Received: by mail-wm1-x344.google.com with SMTP id a6so3404342wma.5 for ; Tue, 01 Oct 2019 06:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=Zbk9ADfv/aZgjm2FIWSRUDzxAC8QdUqG74XPrXDWpjM=; b=NRiO+YiugOugcCGtjhMlcCXn0xz7uf/peQ5Gv8iBxErVhxlY8funZ05y7nDCiBnvoS jUK+RgfwmxyPc+UWKZrez3nj3UrhUCkW8yE+CIByGQdIm0UGqelK9tZX667kAsMUfmka 3YF8hvX2gFgYvnOId3xLxJObGccs1pELRmy1NOhas//Nv//4jAUeXRVUXBdtH/hQUVmo bMJZAUOKggMQeGWTUwt15nTIMp3BrTVXk0v8dxxWwKfx+Am6cDXVaClWnAoIUDtbELOt SVhPc58tF7cB6EqI+HKhybQWNUlu9smHjzT8zOotb8hiVDL81OcIrDgzICXMxBwSg/0r KKbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=Zbk9ADfv/aZgjm2FIWSRUDzxAC8QdUqG74XPrXDWpjM=; b=Xv3Ila/Oewn3c3OED6IVL5veo49r+rEdYK9d0NRXaxSsJAyoXt8A1gh6xnqpUggLmZ Ct6AohVEdA+2qVXpnxbZ6+qYxJb/TgvoGdGijH0XjXRP8uUDdSQR8sUlHOo/BIUnalE+ 2HPqXh5CD9ZgCbWJfjXhZtRe4cT1ny3DBhuXA9ktne5gcqFFV+LEFa8pb2EAQsEO9baL RfkhVboSuVhZ+gqI5p1lEJ801Eo0Uvqud3nU2uYSPDKmgx6qWYcVdZbsh0Xu9HyDHEMp Vb9t5SN6TZXXzKhXAc+24XG45M1aUFmXPx4EjX1PMrLRFGh6s9SUyGphInUzZRHZkweh I3WQ== X-Gm-Message-State: APjAAAVdemAzS2om8d/rsd0aWyVzwLWZxQirVH5TDbbqA/OR80u20lCn TytAuleWoTKiRC3GdLOZX0K7O2R0 X-Google-Smtp-Source: APXvYqy9f7n9GXVYFrXQLtjDSwIhKlhKTbQS5FeFOEfpD2BRmB26bw0U9lBE3u8OkD+mtwkoe4jHFg== X-Received: by 2002:a1c:3904:: with SMTP id g4mr4021048wma.116.1569936991624; Tue, 01 Oct 2019 06:36:31 -0700 (PDT) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id q192sm4424575wme.23.2019.10.01.06.36.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 06:36:31 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 1/8] ide: fix leak from qemu_allocate_irqs Date: Tue, 1 Oct 2019 15:36:21 +0200 Message-Id: <1569936988-635-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1569936988-635-1-git-send-email-pbonzini@redhat.com> References: <1569936988-635-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The array returned by qemu_allocate_irqs is malloced, free it. Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- hw/ide/cmd646.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index f3ccd11..19984d2 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -300,6 +300,7 @@ static void pci_cmd646_ide_realize(PCIDevice *dev, Error **errp) d->bmdma[i].bus = &d->bus[i]; ide_register_restart_cb(&d->bus[i]); } + g_free(irq); vmstate_register(DEVICE(dev), 0, &vmstate_ide_pci, d); qemu_register_reset(cmd646_reset, d); From patchwork Tue Oct 1 13:36:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 1169954 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SmJrF8Sj"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46jL3x2Rztz9sQy for ; Tue, 1 Oct 2019 23:39:57 +1000 (AEST) Received: from localhost ([::1]:42250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFINe-0000kG-RP for incoming@patchwork.ozlabs.org; Tue, 01 Oct 2019 09:39:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58049) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIKR-00064x-9L for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFIKQ-0001dk-CI for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:35 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:40940) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFIKQ-0001d2-6D for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:34 -0400 Received: by mail-wr1-x444.google.com with SMTP id l3so15558208wru.7 for ; Tue, 01 Oct 2019 06:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=1pkb/xxA0Q1jhhvqUg4yWzv1bTQ2+Quoe621ugFPlfQ=; b=SmJrF8SjcrcfJRtHSwE0H73LcQWxRbQdy3gsljzTtZRg5IeliTCSQ57dQLtJ1a8sID UGPY8Zcx+XzPSMSu05lqynPPEPruUJ86jlkQUhB9hAsqV7rgySJ7NV7s+bZyLoL6quME mLiW93ZGaqF1OBuz/NCOCGpFUROUvBfslZlv1vNwFzrGbJSmJcM27aqwn9eN9TX8horK w9mRUdsbL/tMT+rQEPyJeQZWDU3IXlvml+IFon1HRcMXEewfUG3oL1rYaYBNlUL/byPm +N7Mh6+cnf2Q1N4/nhs+vZ3w+NLvpi4jKUly1JLuJrcTkjjNPHmbArsBRQPfshZJUAoL 9jow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=1pkb/xxA0Q1jhhvqUg4yWzv1bTQ2+Quoe621ugFPlfQ=; b=pqK6K3O3zFhrFrQVJFlZbzT1qKIT1EyUXKHOp8xkWK3XAw2tBWO0aIkLQt0FPZYt72 TMvL6O3spQ7DAXFrtvbOGXc9GU02W/g3GnGrH0gV8Ceype0z6Tqx+2AGTLut4FFR3MK7 bGvjXaJsOkOLLGNGNskRB4mrdQYQbd0fNfGPEB9CwjuzEnJCHD92mJkNrw2fe4OT+s5q nokAJsv8lAB/yvjBWRXWMhl/abtG/nG3RTlC1Z+9RQNzIe2GdCUIKTUduCGOp1TpuBmr OYghRjZtYm9Gev/YThkqsOO0LZoVW4cDwQLE9nu52TwOUoAfB3nKB1LeBihwTYp5Pfw5 hMMw== X-Gm-Message-State: APjAAAXt69rdmGnRo8Z1sE0F9gHqBmHrNDh/MGwQrR4PWQ0HpQJ5OaqY nKOFl9uQ4E0M8tc9j7+u3uuLHX63 X-Google-Smtp-Source: APXvYqxmsbUj1UX0DV/N62uUEhdPZqJ9rU1FvXkwiS3SN165fxB727/d6jfDlDRBmCA42DOo+uUKog== X-Received: by 2002:adf:cf0e:: with SMTP id o14mr17627408wrj.277.1569936992349; Tue, 01 Oct 2019 06:36:32 -0700 (PDT) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id q192sm4424575wme.23.2019.10.01.06.36.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 06:36:31 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 2/8] microblaze: fix leak of fdevice tree blob Date: Tue, 1 Oct 2019 15:36:22 +0200 Message-Id: <1569936988-635-3-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1569936988-635-1-git-send-email-pbonzini@redhat.com> References: <1569936988-635-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The device tree blob returned by load_device_tree is malloced. Free it before returning. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé --- hw/microblaze/boot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/microblaze/boot.c b/hw/microblaze/boot.c index bade4d2..d1d7dfb 100644 --- a/hw/microblaze/boot.c +++ b/hw/microblaze/boot.c @@ -100,6 +100,7 @@ static int microblaze_load_dtb(hwaddr addr, } cpu_physical_memory_write(addr, fdt, fdt_size); + g_free(fdt); return fdt_size; } From patchwork Tue Oct 1 13:36:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 1169955 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="N4xxJ8Vg"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46jL6P3F7gz9sQm for ; Tue, 1 Oct 2019 23:42:04 +1000 (AEST) Received: from localhost ([::1]:42266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIPh-0002tB-Km for incoming@patchwork.ozlabs.org; Tue, 01 Oct 2019 09:42:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58064) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIKS-00065o-Gf for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFIKR-0001fO-AO for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:36 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:45663) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFIKR-0001eH-4T for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:35 -0400 Received: by mail-wr1-x444.google.com with SMTP id r5so15528489wrm.12 for ; Tue, 01 Oct 2019 06:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=H449cNVRaL6XSCU/dlyiydLxUhuSV3o/ZTq+QK6WcPM=; b=N4xxJ8Vg2YeUNbMhvLen/i9MIKIVgMVLZuXueiU8zCueNSbBv8W+wIIyvlvECjtaIM xpDD7yg+U/EDdtluSp5edBr8iCLm4hOYmadXcUHa00S+fRcJi2DN+08dyyThbNDlN5Gu o/jja2kxNh40CJPtkic97XD73AxZqtJxXhBxhCVRdtNMooUMmDCBaowujlSZ+RPwXTvG aqz3AmOds/IeE3yAnRYPaOfLGg9M6uAOLhd9gCInXa3sB+a2eOaQ94ZJp/P3Zqbeai3v mw2Y+Sb/f29jHcXf44OuWhHWJ19FD96gaEOU4r0BZ/Hdj1ujb3OcrcAWNFzKkTdSFuSo ek8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=H449cNVRaL6XSCU/dlyiydLxUhuSV3o/ZTq+QK6WcPM=; b=JK6RYR3w4kkiP7faYmd7i0CpM0Ac1DT6mAt5eaWMvDStb9DXHLbT/J3EF9bhIaqLPl T6xC+GS5x9NEmsGpY4wu10NZevGJ2OItCoq+iB198rdFHs4jkQIqfzUs7es4/kfaNF+T 87ANwVgpt8ZPdtELLp+8Nckw7/iw7k247vFF4Ms3aqVgI60oW8Abyk1cQWm0k/hWBQ3k yhE9KjzQSGTjtXbfCr1SKrJ7/zbGKVj/U1PCbNFFooZiKZ7o+leYTfNQ8Anz6EVN8hFf t+H4ngKv/KK6gk7hsczYeMeiqHM8ThF+5552UtN4PYxKjbb0ZuGmkZGL2dyRH6brB7fQ PTBg== X-Gm-Message-State: APjAAAXfS2TXMDl/fHuGilYdBnQotZ/2XXGLm+FYHPDbqLLndARskeVi yUeBKsb5AWVMnx1ZzSzh6OaKRM5+ X-Google-Smtp-Source: APXvYqwughsDhyVU0Q3karlrZt1Tq3v78M+NxGU6bgwcWg2U7AFNEkCNChPih6zjXsuTwN8TzmSjpA== X-Received: by 2002:a05:6000:10ce:: with SMTP id b14mr16831377wrx.96.1569936993346; Tue, 01 Oct 2019 06:36:33 -0700 (PDT) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id q192sm4424575wme.23.2019.10.01.06.36.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 06:36:32 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 3/8] mcf5208: fix leak from qemu_allocate_irqs Date: Tue, 1 Oct 2019 15:36:23 +0200 Message-Id: <1569936988-635-4-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1569936988-635-1-git-send-email-pbonzini@redhat.com> References: <1569936988-635-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The array returned by qemu_allocate_irqs is malloced, free it. Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- hw/m68k/mcf5208.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c index 012710d..60c5802 100644 --- a/hw/m68k/mcf5208.c +++ b/hw/m68k/mcf5208.c @@ -273,6 +273,8 @@ static void mcf5208evb_init(MachineState *machine) 0xfc030000, pic + 36); } + g_free(pic); + /* 0xfc000000 SCM. */ /* 0xfc004000 XBS. */ /* 0xfc008000 FlexBus CS. */ From patchwork Tue Oct 1 13:36:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 1169957 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="e6FssrIe"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46jL9L5BqZz9sDB for ; Tue, 1 Oct 2019 23:44:38 +1000 (AEST) Received: from localhost ([::1]:42292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFISC-0005qL-Gi for incoming@patchwork.ozlabs.org; Tue, 01 Oct 2019 09:44:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58081) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIKT-000672-My for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFIKS-0001gd-Lt for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:37 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:38776) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFIKS-0001fU-E6 for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:36 -0400 Received: by mail-wm1-x342.google.com with SMTP id 3so3296263wmi.3 for ; Tue, 01 Oct 2019 06:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=tpNzkqUfps0EVOpJsON6N0dLvxr0SOw+FOhA9QOcvjg=; b=e6FssrIejDBX0NLR1YTnlI8KiYgI6QnlkBuMSBmtX7Q1QHy2FDNv9j9p0rioddWfOO mVcTq7J9idwU2yKcCWi6pjyh/8BKuvnFcU6kCaBIHiuIg5wh3i+Xc5VyYLIOoYh2bkc5 XYUaTmjTd5aovlidUtQHqoKe9oaUYfVmre28e96C1VC691ZWhq8ivvPH0LpNNFdHjgPJ dIJYvL2xyacJiAME76ft8SwmN3ofxOc2WMxjygj+nSscbWhP5DB9vE0Fi514Zpq8paqU F+sofqluwulx6EuiMBV7aKcbmPHLkEdIsl7zHpm3n9wtcz9uIWeuM7w+7a45fCo0jS6B t0OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=tpNzkqUfps0EVOpJsON6N0dLvxr0SOw+FOhA9QOcvjg=; b=jYLl85sDrzWneofg2P+updfZcfDJ3TXP40zCEq+kSafr9BI1Iqgr8Kld707USJ+24J fUbdEcKSY5Kavoa4GWRjLQ1OeV8Meju3i1OPbXJ5VDi/aylN0vttV3oT32ZGnEhrK9Wm lZepUbDmD8RbEdGYZhDBmU6N8UxMQlSYCM8YeSZvkgOloOZBqiIz7SAAERMpHY6YEOsf Cy3xq9YhopVjhhqNT4uD001tc9G5dz9nCp2CrP9z0Tu6vYZd4ZxGCva+tC0RchuUaB7C M83pRWOOMJnIO9/+ODkrV38qRgIvt6pxhlnDjDwar92tBnmZ62G38DTxBQTovC3+cpw0 58HQ== X-Gm-Message-State: APjAAAXh1hAY5IZmRnfinOube7rM4eC7vcMhBZgvdhTstptqM1B5AKCs G7bA0pXZtqbrDZlz1S1L+AJOpaCZ X-Google-Smtp-Source: APXvYqxIg2uZIsI8eoULq10pSU1idgjjrU4pHfil7TIhIpgMMx6d03DxgaY7v5e1k0RmHn6q48qbYw== X-Received: by 2002:a1c:8097:: with SMTP id b145mr3912364wmd.29.1569936994124; Tue, 01 Oct 2019 06:36:34 -0700 (PDT) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id q192sm4424575wme.23.2019.10.01.06.36.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 06:36:33 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 4/8] hppa: fix leak from g_strdup_printf Date: Tue, 1 Oct 2019 15:36:24 +0200 Message-Id: <1569936988-635-5-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1569936988-635-1-git-send-email-pbonzini@redhat.com> References: <1569936988-635-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" memory_region_init_* takes care of copying the name into memory it owns. Free it in the caller. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé --- hw/hppa/dino.c | 1 + hw/hppa/machine.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c index e0466ee..ab6969b 100644 --- a/hw/hppa/dino.c +++ b/hw/hppa/dino.c @@ -485,6 +485,7 @@ PCIBus *dino_init(MemoryRegion *addr_space, memory_region_init_alias(&s->pci_mem_alias[i], OBJECT(s), name, &s->pci_mem, addr, DINO_MEM_CHUNK_SIZE); + g_free(name); } /* Set up PCI view of memory: Bus master address space. */ diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 2736ce8..7e23675 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -78,13 +78,15 @@ static void machine_hppa_init(MachineState *machine) /* Create CPUs. */ for (i = 0; i < smp_cpus; i++) { + char *name = g_strdup_printf("cpu%ld-io-eir", i); cpu[i] = HPPA_CPU(cpu_create(machine->cpu_type)); cpu_region = g_new(MemoryRegion, 1); memory_region_init_io(cpu_region, OBJECT(cpu[i]), &hppa_io_eir_ops, - cpu[i], g_strdup_printf("cpu%ld-io-eir", i), 4); + cpu[i], name, 4); memory_region_add_subregion(addr_space, CPU_HPA + i * 0x1000, cpu_region); + g_free(name); } /* Limit main memory. */ From patchwork Tue Oct 1 13:36:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 1169959 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WL3igQFx"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46jLFV5Dlgz9sPd for ; Tue, 1 Oct 2019 23:48:14 +1000 (AEST) Received: from localhost ([::1]:42342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIVf-0000AO-KX for incoming@patchwork.ozlabs.org; Tue, 01 Oct 2019 09:48:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58083) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIKT-00067B-PM for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFIKS-0001hF-RT for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:37 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:38778) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFIKS-0001g7-LM for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:36 -0400 Received: by mail-wm1-x344.google.com with SMTP id 3so3296333wmi.3 for ; Tue, 01 Oct 2019 06:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=+d1Xh6ZliwwFNLY1oySHOclHXGDSuGkLUL7VXwzAtgk=; b=WL3igQFxDImBfqKXOZ286t2HBWk4pXpnCkrPskxhy8EQHVHVONsan2tZumx2OZEt2C WK94e18MXug78KHcSUSnE5v/loDef1XJBg7e8HaTZTN/DQEH0/hekVEXOvY0bEVev/5E 9DrpKLQS4qHucCAQLIMqeX7ZeyMG9ZbUzXF0oeemtcJqnqqWa+4hAtZsezZyoybXacqK py07TvCSixYi2BNukJRXvTXvCM9gs3RL8iIG/L2tzLA56R2hlnkj/yWxxYgQqxZ/5Gev 91gppGY6P+abej5F+HgvP1vItKC0/wGDdl1Vd/lHsVV/9gB5tommjB3eMh62KjkjqbBF n0Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=+d1Xh6ZliwwFNLY1oySHOclHXGDSuGkLUL7VXwzAtgk=; b=OWbY0IsQP1Ji48H3K9G+8SJ8e0/TJu5Q70r64FZBOobOyEGUmsfIfsQztffBmLlGb4 U6/WkhZt0kefRI42zRyMJp9C8WIef+XyHzRH/4snKpotJD2Pp+6uWekdjCDdLKNdULBN vbaQhK41ptjAVTVSac1uJ91RqNnN4y2m7Guuyx9A04eRNcnSnflVhEbzjM9T6RnPwuJ/ 9uFCPV3W9yhMhNoQwFreITt64yBMTX0ryWW1ixCvRaC2mRL7I0bcVV0LnKX/tncK5CyX Nv5LWIohiWA+X2SchblgvN0KKmE8JM5SZOCtO8EzzjxHMGkZ3V4RK3vBekEEAPgqG47C TeXw== X-Gm-Message-State: APjAAAXLxhZnYGAn/uZ7S9DQ9LqRK9XWihMh/ot1lKUl/Ju/v5Nl2fQ4 ojfq1wKf1lG0SjXo5zohUwSLJYPI X-Google-Smtp-Source: APXvYqxPP4XLvu25pcsm89iM9p7KjWDt1pxWpiJRrMeNZPxozZ4iTGI+9XOZ3zzsf1byvTvJIQRDSA== X-Received: by 2002:a1c:1f47:: with SMTP id f68mr4106330wmf.78.1569936995187; Tue, 01 Oct 2019 06:36:35 -0700 (PDT) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id q192sm4424575wme.23.2019.10.01.06.36.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 06:36:34 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 5/8] mips: fix memory leaks in board initialization Date: Tue, 1 Oct 2019 15:36:25 +0200 Message-Id: <1569936988-635-6-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1569936988-635-1-git-send-email-pbonzini@redhat.com> References: <1569936988-635-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" They are not a big deal, but they upset asan. Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- hw/mips/mips_int.c | 1 + hw/mips/mips_jazz.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c index 5ebc961..863ed45 100644 --- a/hw/mips/mips_int.c +++ b/hw/mips/mips_int.c @@ -81,6 +81,7 @@ void cpu_mips_irq_init_cpu(MIPSCPU *cpu) for (i = 0; i < 8; i++) { env->irq[i] = qi[i]; } + g_free(qi); } void cpu_mips_soft_irq(CPUMIPSState *env, int irq, int level) diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c index c967b97..8d010a0 100644 --- a/hw/mips/mips_jazz.c +++ b/hw/mips/mips_jazz.c @@ -362,6 +362,8 @@ static void mips_jazz_init(MachineState *machine, /* LED indicator */ sysbus_create_simple("jazz-led", 0x8000f000, NULL); + + g_free(dmas); } static From patchwork Tue Oct 1 13:36:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 1169953 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="n1crnLFr"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46jL3N2Tzqz9sQw for ; Tue, 1 Oct 2019 23:39:28 +1000 (AEST) Received: from localhost ([::1]:42244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFINA-0008Sb-Ov for incoming@patchwork.ozlabs.org; Tue, 01 Oct 2019 09:39:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58099) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIKV-00069A-Bb for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFIKU-0001ij-0D for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:39 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:45662) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFIKT-0001hv-Q8 for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:37 -0400 Received: by mail-wr1-x442.google.com with SMTP id r5so15528736wrm.12 for ; Tue, 01 Oct 2019 06:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=XQJk1DHPtMxR5rn6iJkZ4+R9JTJIU95kBBNqy6kS5R0=; b=n1crnLFrnWMAFmXM2fvPkmuxHnEPVHkESQ7/Bj1t1Q6iM9SzCHQQ+OP82UYtbcGz3C RjugMKKrkxZJlez+WShpU2sM8BC8qoDJw08cwY0S0gFyYbH0wbl0I7g/o5wsk7adjR8P eguHOU361aa1FJhmNkZOczQnkfhebb3eJzRjf8kiomgnzFiH130uDqQsQjclR/0sA7P3 mO3orDyLiOxrCsiw1MQuwFDw33DtQh1UyRwaQhvaS+cDjrioeNOOs8yrse282rvOYwtD yIHjbG7ODvLysBxkfEGbWJU9HItY0OxMzHxvOrUUzwebhv8N9vpZ0RUm/MhSNKLPI6/n XP0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=XQJk1DHPtMxR5rn6iJkZ4+R9JTJIU95kBBNqy6kS5R0=; b=RZjWD8cixsHxghrUqf4JdJ3vpoLLPGX1knzkW6jYavYO1RnrH6z8/D99bxoP8SzQVU QqhisbfrGWpfj4BKiTi3UngkXlnqUNaFWZz9dJz0J5V6GUCoTbZmKJZWD2mVFg+3Lh8M 7g8acMP8noiC2CXpboBCu7cdy189xDhHDlgMP7rg3zWp8Uh8UYpDq/GSszhlj3PeH498 t/Gm9olVdOfSiu3ux8qfBxr+kXz3heP0tZAUHGY8PoocvVFlnjhs8O/3To5b6rgNTX9h NmhSxjItvvgkRPSkA/LlXo45CbredHM5Ai1chSRrej2/koqWLpP19ZwUDxeNaBkfY2Dp +1nw== X-Gm-Message-State: APjAAAVQ+VyMhWuHlC3CswrEXOeLxtBZfDim+tPhS0hlYsMUzQu2fSru N5XvutsiEYIZY7BwRWjsZqVl+JFT X-Google-Smtp-Source: APXvYqz8QwYaoriERgu8f+91qPdv085nQaa5oBF2PsiDoIinpGUS7jIDODgtJq3FkFdKvLRmXymuyA== X-Received: by 2002:adf:9d84:: with SMTP id p4mr17432697wre.39.1569936996448; Tue, 01 Oct 2019 06:36:36 -0700 (PDT) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id q192sm4424575wme.23.2019.10.01.06.36.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 06:36:35 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 6/8] cris: do not leak struct cris_disasm_data Date: Tue, 1 Oct 2019 15:36:26 +0200 Message-Id: <1569936988-635-7-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1569936988-635-1-git-send-email-pbonzini@redhat.com> References: <1569936988-635-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Use a stack-allocated struct to avoid a memory leak. Signed-off-by: Paolo Bonzini --- disas/cris.c | 59 +++++++++++++++++++++++++++++------------------------------ 1 file changed, 29 insertions(+), 30 deletions(-) diff --git a/disas/cris.c b/disas/cris.c index 2f43c9b..0b0a3fb 100644 --- a/disas/cris.c +++ b/disas/cris.c @@ -1294,24 +1294,17 @@ static int cris_constraint /* Parse disassembler options and store state in info. FIXME: For the time being, we abuse static variables. */ -static bfd_boolean -cris_parse_disassembler_options (disassemble_info *info, +static void +cris_parse_disassembler_options (struct cris_disasm_data *disdata, + char *disassembler_options, enum cris_disass_family distype) { - struct cris_disasm_data *disdata; - - info->private_data = calloc (1, sizeof (struct cris_disasm_data)); - disdata = (struct cris_disasm_data *) info->private_data; - if (disdata == NULL) - return false; - /* Default true. */ disdata->trace_case - = (info->disassembler_options == NULL - || (strcmp (info->disassembler_options, "nocase") != 0)); + = (disassembler_options == NULL + || (strcmp (disassembler_options, "nocase") != 0)); disdata->distype = distype; - return true; } static const struct cris_spec_reg * @@ -2736,9 +2729,10 @@ static int print_insn_cris_with_register_prefix (bfd_vma vma, disassemble_info *info) { - if (info->private_data == NULL - && !cris_parse_disassembler_options (info, cris_dis_v0_v10)) - return -1; + struct cris_disasm_data disdata; + info->private_data = &disdata; + cris_parse_disassembler_options (&disdata, info->disassembler_options, + cris_dis_v0_v10); return print_insn_cris_generic (vma, info, true); } /* Disassemble, prefixing register names with `$'. CRIS v32. */ @@ -2747,9 +2741,10 @@ static int print_insn_crisv32_with_register_prefix (bfd_vma vma, disassemble_info *info) { - if (info->private_data == NULL - && !cris_parse_disassembler_options (info, cris_dis_v32)) - return -1; + struct cris_disasm_data disdata; + info->private_data = &disdata; + cris_parse_disassembler_options (&disdata, info->disassembler_options, + cris_dis_v32); return print_insn_cris_generic (vma, info, true); } @@ -2761,9 +2756,10 @@ static int print_insn_crisv10_v32_with_register_prefix (bfd_vma vma, disassemble_info *info) { - if (info->private_data == NULL - && !cris_parse_disassembler_options (info, cris_dis_common_v10_v32)) - return -1; + struct cris_disasm_data disdata; + info->private_data = &disdata; + cris_parse_disassembler_options (&disdata, info->disassembler_options, + cris_dis_common_v10_v32); return print_insn_cris_generic (vma, info, true); } @@ -2773,9 +2769,10 @@ static int print_insn_cris_without_register_prefix (bfd_vma vma, disassemble_info *info) { - if (info->private_data == NULL - && !cris_parse_disassembler_options (info, cris_dis_v0_v10)) - return -1; + struct cris_disasm_data disdata; + info->private_data = &disdata; + cris_parse_disassembler_options (&disdata, info->disassembler_options, + cris_dis_v0_v10); return print_insn_cris_generic (vma, info, false); } @@ -2785,9 +2782,10 @@ static int print_insn_crisv32_without_register_prefix (bfd_vma vma, disassemble_info *info) { - if (info->private_data == NULL - && !cris_parse_disassembler_options (info, cris_dis_v32)) - return -1; + struct cris_disasm_data disdata; + info->private_data = &disdata; + cris_parse_disassembler_options (&disdata, info->disassembler_options, + cris_dis_v32); return print_insn_cris_generic (vma, info, false); } @@ -2798,9 +2796,10 @@ static int print_insn_crisv10_v32_without_register_prefix (bfd_vma vma, disassemble_info *info) { - if (info->private_data == NULL - && !cris_parse_disassembler_options (info, cris_dis_common_v10_v32)) - return -1; + struct cris_disasm_data disdata; + info->private_data = &disdata; + cris_parse_disassembler_options (&disdata, info->disassembler_options, + cris_dis_common_v10_v32); return print_insn_cris_generic (vma, info, false); } #endif From patchwork Tue Oct 1 13:36:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 1169956 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="E8vCfkrM"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46jL6T1Fk6z9sQm for ; Tue, 1 Oct 2019 23:42:09 +1000 (AEST) Received: from localhost ([::1]:42268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIPm-00030g-Iz for incoming@patchwork.ozlabs.org; Tue, 01 Oct 2019 09:42:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58110) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIKW-0006Au-E8 for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFIKV-0001jy-5r for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:40 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:42700) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFIKU-0001jI-VX for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:39 -0400 Received: by mail-wr1-x444.google.com with SMTP id n14so15544746wrw.9 for ; Tue, 01 Oct 2019 06:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=h0dNFhGs9tdhjt5L62PjdKnkeMNxQJzqGTxsdc27Rhw=; b=E8vCfkrMqnJ8bY4sWNztKHWCIaF+MTSy4TSsNdWhBxVsVndYT2Ldlc0DkdZLilDMue RoRqk8ox4gw97yo6i2iO5XMYASktiaaxHaLBluuv2JtnI19D5U8A2j+utnLewm3ymPe/ H+nZA62pYp79IhUncFc6jrew1aADxNzqBcm6/2uc7/hlw79j6pee/821PqknKZ5N1FxB jvW2HjWUSz4gK+NUvHfLb7vExahAhnRysWWumFBJ7RDVTgDRXU1X774PS6zQtphkk5fb pDnWgLWBcMRLMatYk3EfWZZApGhn0MBY6p9gz2EslgjVXuG/+Q8cEnUc9KTUCAaP0zQo sNXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=h0dNFhGs9tdhjt5L62PjdKnkeMNxQJzqGTxsdc27Rhw=; b=a7tcWBXnkATkz/d5i9vC8wUyaJq0pBm11xK5Cgzn76gy1xvuUj1SKlQ5lU2ilkOn1E kPFjRPpp1xYM56yW3rkWOlEN5NV/8FitLL7dM5d5xzm9d3xirULc55Wgz+n85QRhtu4Y H4x2lxf1WkfrUmmObNmVsHlMW2HQKLsD+N/dlYPeAsjeaR7AVlRr3/twxfjqBv8OHyBx xGDkUQZrwd2T54xcC+llpiQOJIXfkbYDyWePoetiR0sSOBtpeVp+dFOETSZLayCgreGy N4NWXEGpwjgEXqhQDfebLIWE7iMl/PxDTh57mjNXaY/0TQSBnx2ddaexGrDVX2rKKzuE VCIg== X-Gm-Message-State: APjAAAXpUiUVskiGe65NmnOBjoWOaN3PDmDnhmnmLW/WeF0ym/oi0+2F x4ONJVeigzyU06rw/wTSP2+Gr1c0 X-Google-Smtp-Source: APXvYqxCtaDnxm8VWWaAfnQGCJSLrrYmo3xnH99LJ5ru+ox+pxsNsCsCTBlI//T810K8YTUD4Atz/A== X-Received: by 2002:adf:c58b:: with SMTP id m11mr17113576wrg.252.1569936997688; Tue, 01 Oct 2019 06:36:37 -0700 (PDT) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id q192sm4424575wme.23.2019.10.01.06.36.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 06:36:36 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 7/8] lm32: do not leak memory on object_new/object_unref Date: Tue, 1 Oct 2019 15:36:27 +0200 Message-Id: <1569936988-635-8-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1569936988-635-1-git-send-email-pbonzini@redhat.com> References: <1569936988-635-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Bottom halves and ptimers are malloced, but nothing in these files is freeing memory allocated by instance_init. Since these are sysctl devices that are never unrealized, just moving the allocations to realize is enough to avoid the leak in practice (and also to avoid upsetting asan when running device-introspect-test). Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé --- hw/timer/lm32_timer.c | 6 +++--- hw/timer/milkymist-sysctl.c | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/timer/lm32_timer.c b/hw/timer/lm32_timer.c index ac3edaf..cf316ed 100644 --- a/hw/timer/lm32_timer.c +++ b/hw/timer/lm32_timer.c @@ -186,9 +186,6 @@ static void lm32_timer_init(Object *obj) sysbus_init_irq(dev, &s->irq); - s->bh = qemu_bh_new(timer_hit, s); - s->ptimer = ptimer_init(s->bh, PTIMER_POLICY_DEFAULT); - memory_region_init_io(&s->iomem, obj, &timer_ops, s, "timer", R_MAX * 4); sysbus_init_mmio(dev, &s->iomem); @@ -198,6 +195,9 @@ static void lm32_timer_realize(DeviceState *dev, Error **errp) { LM32TimerState *s = LM32_TIMER(dev); + s->bh = qemu_bh_new(timer_hit, s); + s->ptimer = ptimer_init(s->bh, PTIMER_POLICY_DEFAULT); + ptimer_set_freq(s->ptimer, s->freq_hz); } diff --git a/hw/timer/milkymist-sysctl.c b/hw/timer/milkymist-sysctl.c index 9583507..6aedc11 100644 --- a/hw/timer/milkymist-sysctl.c +++ b/hw/timer/milkymist-sysctl.c @@ -283,11 +283,6 @@ static void milkymist_sysctl_init(Object *obj) sysbus_init_irq(dev, &s->timer0_irq); sysbus_init_irq(dev, &s->timer1_irq); - s->bh0 = qemu_bh_new(timer0_hit, s); - s->bh1 = qemu_bh_new(timer1_hit, s); - s->ptimer0 = ptimer_init(s->bh0, PTIMER_POLICY_DEFAULT); - s->ptimer1 = ptimer_init(s->bh1, PTIMER_POLICY_DEFAULT); - memory_region_init_io(&s->regs_region, obj, &sysctl_mmio_ops, s, "milkymist-sysctl", R_MAX * 4); sysbus_init_mmio(dev, &s->regs_region); @@ -297,6 +292,11 @@ static void milkymist_sysctl_realize(DeviceState *dev, Error **errp) { MilkymistSysctlState *s = MILKYMIST_SYSCTL(dev); + s->bh0 = qemu_bh_new(timer0_hit, s); + s->bh1 = qemu_bh_new(timer1_hit, s); + s->ptimer0 = ptimer_init(s->bh0, PTIMER_POLICY_DEFAULT); + s->ptimer1 = ptimer_init(s->bh1, PTIMER_POLICY_DEFAULT); + ptimer_set_freq(s->ptimer0, s->freq_hz); ptimer_set_freq(s->ptimer1, s->freq_hz); } From patchwork Tue Oct 1 13:36:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 1169961 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JVZgO7RL"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46jLHq23rsz9sDB for ; Tue, 1 Oct 2019 23:50:15 +1000 (AEST) Received: from localhost ([::1]:42374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIXc-0002DQ-Th for incoming@patchwork.ozlabs.org; Tue, 01 Oct 2019 09:50:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58119) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIKX-0006Bp-AF for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFIKW-0001lb-A3 for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:41 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:36960) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFIKW-0001kR-4K for qemu-devel@nongnu.org; Tue, 01 Oct 2019 09:36:40 -0400 Received: by mail-wr1-x443.google.com with SMTP id i1so15585985wro.4 for ; Tue, 01 Oct 2019 06:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=o4ShqMwkYwxwFlVxZ6kVT6vik/5tXcWE7uO0LUlRUd4=; b=JVZgO7RLl95Eltb6TuuCJdM9LXXyc8wcyQEhxy/HYclwQW59uHhFmeF3u4icxTsHHm Ll2shWQlUuG1dDvmNqd20ST5H2PlnOnahCfGaiFK+sW3KxFiiRn3ZvkexYho61PsgkBW CsN1Zw7mJNdn/OZfVr3pT9A7IbNZcm8vyLWvaylXjv1p+N3fyopxzOqKWY4ucalsN/Mj qIBEwBtVkTAJeDrLtgf96/SBHxzL5ZzTZc3GZK6JMZBI0YfUvUI7Mv6dStPc0ooR0ZDG xsEQq5QSihARJDdI9mliedf5MV2npl2k/SwJQRYTEI+ESQq6MOUNQ7bJ5gk4utVQrVEC S/nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=o4ShqMwkYwxwFlVxZ6kVT6vik/5tXcWE7uO0LUlRUd4=; b=pOo2PluP/l2WUc+wyE0rJuAMpiZ/Js5N0oFuviywTjF5TE2mkd0tcOB7J3kU1FPkkZ VRgLCzxusnhBCvuk93Puf1aZBcbBkqkfSK353mkiwr16Q28r+KpLd1tIV/3yF/h/P5LX kk5CXIE4EYVnj31OAbgFl3vcOCVBYy3xPbZnr5SC/O1NTmWeEC53Bsn6WSxYNt0R8e84 TVNODsjHbTREOXIkjlraW6nFCeIZIxPgIYYMNOJe7gj460eXhJbbtnN19GiPYjUCIJub 1SOF/LKye0CSEz0Vl2mRvRDfu4ibPfxJ3m5K8108g8E4Z+SOSAXfF+9e8ybxgtUFZbrt JeBg== X-Gm-Message-State: APjAAAUC852c449PnYZwazmxmJk+iBguTPZJTPVpl+asfNxagsc5lfiT n2Pqcd8OVCavtgC7lfb7e6mA7wAd X-Google-Smtp-Source: APXvYqxCIA5lbehH0rrYkeapVwuSFFskgmYqhzyQP6QgHEkEFoOghys9fq3Qmew6AaIR64zP6IT43Q== X-Received: by 2002:a5d:6a09:: with SMTP id m9mr16909132wru.12.1569936998867; Tue, 01 Oct 2019 06:36:38 -0700 (PDT) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id q192sm4424575wme.23.2019.10.01.06.36.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 06:36:37 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 8/8] docker: test-debug: disable LeakSanitizer Date: Tue, 1 Oct 2019 15:36:28 +0200 Message-Id: <1569936988-635-9-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1569936988-635-1-git-send-email-pbonzini@redhat.com> References: <1569936988-635-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" There are just too many leaks in device-introspect-test (especially for the plethora of arm and aarch64 boards) to make LeakSanitizer useful; disable it for now. Whoever is interested in debugging leaks can also use valgrind like this: QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64 \ QTEST_QEMU_IMG=qemu-img \ valgrind --trace-children=yes --leak-check=full \ tests/device-introspect-test -p /aarch64/device/introspect/concrete/defaults/none Signed-off-by: Paolo Bonzini --- tests/docker/test-debug | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/test-debug b/tests/docker/test-debug index 137f4f2..c050fa0 100755 --- a/tests/docker/test-debug +++ b/tests/docker/test-debug @@ -21,6 +21,7 @@ cd "$BUILD_DIR" OPTS="--cxx=clang++ --cc=clang --host-cc=clang" OPTS="--enable-debug --enable-sanitizers $OPTS" +export ASAN_OPTIONS=detect_leaks=0 build_qemu $OPTS check_qemu check V=1 install_qemu