From patchwork Fri Sep 27 14:17:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cleber Rosa X-Patchwork-Id: 1168619 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46fwcK4M9Hz9sPS for ; Sat, 28 Sep 2019 01:26:09 +1000 (AEST) Received: from localhost ([::1]:52394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDs8F-0001vr-0k for incoming@patchwork.ozlabs.org; Fri, 27 Sep 2019 11:26:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46542) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDr43-00011E-C4 for qemu-devel@nongnu.org; Fri, 27 Sep 2019 10:17:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDr42-0003Sb-0O for qemu-devel@nongnu.org; Fri, 27 Sep 2019 10:17:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51724) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iDr3x-0003Nq-Ve; Fri, 27 Sep 2019 10:17:38 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DB3B3091740; Fri, 27 Sep 2019 14:17:31 +0000 (UTC) Received: from dhcp-17-179.bos.redhat.com (dhcp-17-179.bos.redhat.com [10.18.17.179]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A33AA60BF3; Fri, 27 Sep 2019 14:17:30 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Subject: [PATCH 1/4] qemu-iotests: remove bash shebang from library files Date: Fri, 27 Sep 2019 10:17:25 -0400 Message-Id: <20190927141728.7137-2-crosa@redhat.com> In-Reply-To: <20190927141728.7137-1-crosa@redhat.com> References: <20190927141728.7137-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 27 Sep 2019 14:17:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Max Reitz , Cleber Rosa Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Due to not being able to find a reason to have shebangs on files that are not executable. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/common.config | 2 -- tests/qemu-iotests/common.filter | 2 -- tests/qemu-iotests/common.nbd | 1 - tests/qemu-iotests/common.pattern | 2 -- tests/qemu-iotests/common.qemu | 2 -- tests/qemu-iotests/common.rc | 2 -- tests/qemu-iotests/common.tls | 2 -- 7 files changed, 13 deletions(-) diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config index 9bd1a5a6fc..6956d38d4c 100644 --- a/tests/qemu-iotests/common.config +++ b/tests/qemu-iotests/common.config @@ -1,5 +1,3 @@ -#!/usr/bin/env bash -# # Copyright (C) 2009 Red Hat, Inc. # Copyright (c) 2000-2003,2006 Silicon Graphics, Inc. All Rights Reserved. # diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index 445a1c23e0..043c62c10c 100644 --- a/tests/qemu-iotests/common.filter +++ b/tests/qemu-iotests/common.filter @@ -1,5 +1,3 @@ -#!/usr/bin/env bash -# # Copyright (C) 2009 Red Hat, Inc. # Copyright (c) 2000-2001 Silicon Graphics, Inc. All Rights Reserved. # diff --git a/tests/qemu-iotests/common.nbd b/tests/qemu-iotests/common.nbd index 24b01b60aa..5a9991b7ef 100644 --- a/tests/qemu-iotests/common.nbd +++ b/tests/qemu-iotests/common.nbd @@ -1,4 +1,3 @@ -#!/usr/bin/env bash # -*- shell-script-mode -*- # # Helpers for NBD server related config diff --git a/tests/qemu-iotests/common.pattern b/tests/qemu-iotests/common.pattern index 4f5e5bcea0..e8d97dd2bb 100644 --- a/tests/qemu-iotests/common.pattern +++ b/tests/qemu-iotests/common.pattern @@ -1,5 +1,3 @@ -#!/usr/bin/env bash -# # Copyright (C) 2009 Red Hat, Inc. # # This program is free software; you can redistribute it and/or modify diff --git a/tests/qemu-iotests/common.qemu b/tests/qemu-iotests/common.qemu index 8d2021a7eb..5bdfde890d 100644 --- a/tests/qemu-iotests/common.qemu +++ b/tests/qemu-iotests/common.qemu @@ -1,5 +1,3 @@ -#!/usr/bin/env bash -# # This allows for launching of multiple QEMU instances, with independent # communication possible to each instance. # diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index e45cdfa66b..19bddacf11 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@ -1,5 +1,3 @@ -#!/usr/bin/env bash -# # Copyright (C) 2009 Red Hat, Inc. # Copyright (c) 2000-2006 Silicon Graphics, Inc. All Rights Reserved. # diff --git a/tests/qemu-iotests/common.tls b/tests/qemu-iotests/common.tls index 54c331d7a5..61f8ef6037 100644 --- a/tests/qemu-iotests/common.tls +++ b/tests/qemu-iotests/common.tls @@ -1,5 +1,3 @@ -#!/usr/bin/env bash -# # Helpers for TLS related config # # Copyright (C) 2018 Red Hat, Inc. From patchwork Fri Sep 27 14:17:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cleber Rosa X-Patchwork-Id: 1168657 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46fxzh54v2z9sP3 for ; Sat, 28 Sep 2019 02:28:00 +1000 (AEST) Received: from localhost ([::1]:53222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDt65-0003l5-SO for incoming@patchwork.ozlabs.org; Fri, 27 Sep 2019 12:27:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46537) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDr43-000118-6h for qemu-devel@nongnu.org; Fri, 27 Sep 2019 10:17:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDr42-0003Sp-4u for qemu-devel@nongnu.org; Fri, 27 Sep 2019 10:17:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47604) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iDr3x-0003Nu-NG; Fri, 27 Sep 2019 10:17:37 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7560E3090FC9; Fri, 27 Sep 2019 14:17:32 +0000 (UTC) Received: from dhcp-17-179.bos.redhat.com (dhcp-17-179.bos.redhat.com [10.18.17.179]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9E93960BE2; Fri, 27 Sep 2019 14:17:31 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Subject: [PATCH 2/4] qemu-iotests: remove forceful execution success from library files Date: Fri, 27 Sep 2019 10:17:26 -0400 Message-Id: <20190927141728.7137-3-crosa@redhat.com> In-Reply-To: <20190927141728.7137-1-crosa@redhat.com> References: <20190927141728.7137-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 27 Sep 2019 14:17:32 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Max Reitz , Cleber Rosa Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Should not be necessary on files that are not executed standalone. Signed-off-by: Cleber Rosa Reviewed-by: Eric Blake --- tests/qemu-iotests/common.config | 3 --- tests/qemu-iotests/common.filter | 3 --- tests/qemu-iotests/common.rc | 3 --- 3 files changed, 9 deletions(-) diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config index 6956d38d4c..0a24d960ff 100644 --- a/tests/qemu-iotests/common.config +++ b/tests/qemu-iotests/common.config @@ -34,6 +34,3 @@ _optstr_add() echo "$2" fi } - -# make sure this script returns success -true diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index 043c62c10c..55db15865a 100644 --- a/tests/qemu-iotests/common.filter +++ b/tests/qemu-iotests/common.filter @@ -221,6 +221,3 @@ _filter_qmp_empty_return() { grep -v '{"return": {}}' } - -# make sure this script returns success -true diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index 19bddacf11..d7e6456086 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@ -600,6 +600,3 @@ _require_drivers() fi done } - -# make sure this script returns success -true From patchwork Fri Sep 27 14:17:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cleber Rosa X-Patchwork-Id: 1168655 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46fxyB2QcFz9sP3 for ; Sat, 28 Sep 2019 02:26:42 +1000 (AEST) Received: from localhost ([::1]:53184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDt4p-0002ZX-D4 for incoming@patchwork.ozlabs.org; Fri, 27 Sep 2019 12:26:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46552) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDr43-00011Z-SJ for qemu-devel@nongnu.org; Fri, 27 Sep 2019 10:17:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDr41-0003SE-Fl for qemu-devel@nongnu.org; Fri, 27 Sep 2019 10:17:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56752) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iDr3y-0003O5-1A; Fri, 27 Sep 2019 10:17:38 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 71134317528B; Fri, 27 Sep 2019 14:17:33 +0000 (UTC) Received: from dhcp-17-179.bos.redhat.com (dhcp-17-179.bos.redhat.com [10.18.17.179]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9852D60C44; Fri, 27 Sep 2019 14:17:32 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Subject: [PATCH 3/4] qemu-iotests: 044: pass is actually a noop, so remove it Date: Fri, 27 Sep 2019 10:17:27 -0400 Message-Id: <20190927141728.7137-4-crosa@redhat.com> In-Reply-To: <20190927141728.7137-1-crosa@redhat.com> References: <20190927141728.7137-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 27 Sep 2019 14:17:33 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Max Reitz , Cleber Rosa Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Cleber Rosa Reviewed-by: Eric Blake Reviewed-by: John Snow --- tests/qemu-iotests/044 | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044 index 05ea1f49c5..eb42df0fe1 100755 --- a/tests/qemu-iotests/044 +++ b/tests/qemu-iotests/044 @@ -105,17 +105,14 @@ class TestRefcountTableGrowth(iotests.QMPTestCase): def setUp(self): qemu_img('create', '-f', iotests.imgfmt, '-o', 'cluster_size=512', test_img, '16G') self.preallocate(test_img) - pass def tearDown(self): os.remove(test_img) - pass def test_grow_refcount_table(self): qemu_io('-c', 'write 3800M 1M', test_img) qemu_img_verbose('check' , test_img) - pass if __name__ == '__main__': iotests.main(supported_fmts=['qcow2'], From patchwork Fri Sep 27 14:17:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cleber Rosa X-Patchwork-Id: 1168652 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46fxtf0Sf9z9sP3 for ; Sat, 28 Sep 2019 02:23:37 +1000 (AEST) Received: from localhost ([::1]:53158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDt1o-0007uU-TU for incoming@patchwork.ozlabs.org; Fri, 27 Sep 2019 12:23:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46525) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDr42-00010c-Ps for qemu-devel@nongnu.org; Fri, 27 Sep 2019 10:17:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDr41-0003SN-Me for qemu-devel@nongnu.org; Fri, 27 Sep 2019 10:17:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51902) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iDr3y-0003OR-1F; Fri, 27 Sep 2019 10:17:38 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6FB7310C0925; Fri, 27 Sep 2019 14:17:34 +0000 (UTC) Received: from dhcp-17-179.bos.redhat.com (dhcp-17-179.bos.redhat.com [10.18.17.179]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 926D760BE2; Fri, 27 Sep 2019 14:17:33 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Subject: [PATCH 4/4] qemu-iotests: 044: remove inaccurate docstring class description Date: Fri, 27 Sep 2019 10:17:28 -0400 Message-Id: <20190927141728.7137-5-crosa@redhat.com> In-Reply-To: <20190927141728.7137-1-crosa@redhat.com> References: <20190927141728.7137-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Fri, 27 Sep 2019 14:17:34 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Max Reitz , Cleber Rosa Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Cleber Rosa Reviewed-by: Eric Blake Reviewed-by: John Snow --- tests/qemu-iotests/044 | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044 index eb42df0fe1..0ca4bcfc6d 100755 --- a/tests/qemu-iotests/044 +++ b/tests/qemu-iotests/044 @@ -34,7 +34,6 @@ if sys.version_info.major == 2: test_img = os.path.join(iotests.test_dir, 'test.img') class TestRefcountTableGrowth(iotests.QMPTestCase): - '''Abstract base class for image mirroring test cases''' def preallocate(self, name): fd = open(name, "r+b")