From patchwork Thu Sep 12 09:12:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 1161447 X-Patchwork-Delegate: twarren@nvidia.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46TY2w60Xkz9s4Y for ; Thu, 12 Sep 2019 19:13:12 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 80E1DC21DD7; Thu, 12 Sep 2019 09:13:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 0BEB9C21D56; Thu, 12 Sep 2019 09:13:09 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id BB812C21D8A; Thu, 12 Sep 2019 09:13:07 +0000 (UTC) Received: from mout.perfora.net (mout.perfora.net [74.208.4.194]) by lists.denx.de (Postfix) with ESMTPS id 683B0C21C2F for ; Thu, 12 Sep 2019 09:13:05 +0000 (UTC) Received: from marcel-nb-toradex-int.toradex.int ([46.140.72.82]) by mrelay.perfora.net (mreueus004 [74.208.5.2]) with ESMTPSA (Nemesis) id 1M6V2j-1i21cy2xPl-006uOl; Thu, 12 Sep 2019 11:13:02 +0200 From: Marcel Ziswiler To: u-boot@lists.denx.de Date: Thu, 12 Sep 2019 11:12:52 +0200 Message-Id: <20190912091256.15573-2-marcel@ziswiler.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190912091256.15573-1-marcel@ziswiler.com> References: <20190912091256.15573-1-marcel@ziswiler.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:5xKiWvDLliGfQ3SRoF4duNf3UhI+zRMOZlNk1onvcXjoFjA3LCJ 8zcsxpE6ItnH4yE5KF00b9K19PACok+vS5yg/wND7cZGB+KATxH3hYDcbvsu4QFcmuUwjDV BvXVvZQ3N91dFInmebkbVFQESukBnEcjhtamt9mlBAAPNbRMwfMj0ZEG4qjHeYjtSUT6kz7 javYNiMDmTlqgfsjv/L3A== X-UI-Out-Filterresults: notjunk:1; V03:K0:Yc/4I1pZpUE=:GXb9iHUkBvfkrmXeJ/87Ii qwQtZvackY6eXVz86jYFOJZeV6n+dvOHYfmD+t8sXcNktI7bFS2L4G/ZMzu6j0zpEfRIirxbR 2NVHCTjrfn36FPhYEnSdlgh+kFoJgfYtA7Fn8c0iOzry/FSJWAfQv9/UhqkzE7MRgotMLDuE/ ih/4vLGBwc8LLVRAw9hT3TeSNxaeadtp73x5zFe+ktqNQikBzBw+CrG0CKxMCmhX8MMZhJg7g vPX5d1oXXuDDaN638jWUrcytnHL6uo6pHbDDTq0QG5Zdp0y4k+wL2I8+w6P1kwlKx/WPHRdCh Skv+0Lp+9xCb4zfPy9PgjDQdGWdrIUBouzp+4PDmrbhc4SIxViRZ0ZUVP2E+3Bcl6uPIFc98N m3UZw8GWhGjxK74xVqPJI+7x2jFlZzJ9YweE653xSjTlGLn2Ax7G0qxRY5JcwIy75VRo/emaL tjIZwmckDyQGO3rzJzyio/4UTT+Rkx5kiztafHY9b8xKKqSvjn9ei01tjAtNpeTmTEK9+gzNm 0yjmMFK8lIo9I5lrcIo6/nUuGa/FTm3l5/pX6J05OMA/HqtQdVUK4jwPaV2qduAg6SHqGpXvv JAe1QVCrRdKnB9GEc69y61fw7GAwe7VQW1EAzTyVoFuaJebFmlykO1ikuZz+T7oqHBL3zrkCr haRjg9w44baCB+9oUmJxRLfu1XdzzGZpyRnxQ3Q08xrexjT8wcEwPnh/4xiK+vrrp1p9uec9d /idnmQT7tySO8R4FzaWEhc/0t8nnVp8vohxqApxsIaG3H4xwwSNqvvKq9+Lnh+zg0sVp2ABYQ zclA77pm4MLeUq9sUxWxArvs2g+8wnuH72QDTBtX+jI4wQsuOotVC9BgghYkNEfuHFUXm+rxg J4NweFC6xfYpCCrF4vhuCNLvklBHITXjUlT9OoDmM= Cc: Marcel Ziswiler , Stefan Agner Subject: [U-Boot] [PATCH v1 1/5] apalis/colibri_t30: add comment about tristate and input vs. output pinmuxing X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Marcel Ziswiler Add pinmuxing comment stating that TRISTATE means the output driver is tri-stated and INPUT means the input driver is enabled vs. OUTPUT where it is disabled. Signed-off-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- board/toradex/apalis_t30/pinmux-config-apalis_t30.h | 2 ++ board/toradex/colibri_t30/pinmux-config-colibri_t30.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/board/toradex/apalis_t30/pinmux-config-apalis_t30.h b/board/toradex/apalis_t30/pinmux-config-apalis_t30.h index 49c2df7ab2..8d6696aaad 100644 --- a/board/toradex/apalis_t30/pinmux-config-apalis_t30.h +++ b/board/toradex/apalis_t30/pinmux-config-apalis_t30.h @@ -11,7 +11,9 @@ .pingrp = PMUX_PINGRP_##_pingrp, \ .func = PMUX_FUNC_##_mux, \ .pull = PMUX_PULL_##_pull, \ +/* TRISTATE here means output driver is tri-stated */ \ .tristate = PMUX_TRI_##_tri, \ +/* INPUT here means input driver is enabled vs. OUTPUT where it is disabled */ \ .io = PMUX_PIN_##_io, \ .lock = PMUX_PIN_LOCK_DEFAULT, \ .od = PMUX_PIN_OD_DEFAULT, \ diff --git a/board/toradex/colibri_t30/pinmux-config-colibri_t30.h b/board/toradex/colibri_t30/pinmux-config-colibri_t30.h index bdbbf5e49a..6181b506a4 100644 --- a/board/toradex/colibri_t30/pinmux-config-colibri_t30.h +++ b/board/toradex/colibri_t30/pinmux-config-colibri_t30.h @@ -11,7 +11,9 @@ .pingrp = PMUX_PINGRP_##_pingrp, \ .func = PMUX_FUNC_##_mux, \ .pull = PMUX_PULL_##_pull, \ +/* TRISTATE here means output driver is tri-stated */ \ .tristate = PMUX_TRI_##_tri, \ +/* INPUT here means input driver is enabled vs. OUTPUT where it is disabled */ \ .io = PMUX_PIN_##_io, \ .lock = PMUX_PIN_LOCK_DEFAULT, \ .od = PMUX_PIN_OD_DEFAULT, \ From patchwork Thu Sep 12 09:12:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 1161449 X-Patchwork-Delegate: twarren@nvidia.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46TY4Z0VJPz9s4Y for ; Thu, 12 Sep 2019 19:14:38 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id CBB3CC21DB6; Thu, 12 Sep 2019 09:13:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,UPPERCASE_50_75 autolearn=no autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 090C9C21CB6; Thu, 12 Sep 2019 09:13:10 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id E08CAC21CB6; Thu, 12 Sep 2019 09:13:07 +0000 (UTC) Received: from mout.perfora.net (mout.perfora.net [74.208.4.194]) by lists.denx.de (Postfix) with ESMTPS id 74941C21D56 for ; Thu, 12 Sep 2019 09:13:06 +0000 (UTC) Received: from marcel-nb-toradex-int.toradex.int ([46.140.72.82]) by mrelay.perfora.net (mreueus004 [74.208.5.2]) with ESMTPSA (Nemesis) id 1MyKcC-1iKePL05aG-00yk2M; Thu, 12 Sep 2019 11:13:03 +0200 From: Marcel Ziswiler To: u-boot@lists.denx.de Date: Thu, 12 Sep 2019 11:12:53 +0200 Message-Id: <20190912091256.15573-3-marcel@ziswiler.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190912091256.15573-1-marcel@ziswiler.com> References: <20190912091256.15573-1-marcel@ziswiler.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:FG1OxtgJv51+Zv0zopWa2QG1GGNtV25VZ5l2FH21z8/PZB0y4cN AUtqQXY9VqXSVEIf9Ht4UnLLUY+lqABl8xgkd2NUVcYWCWc9SS70wdGTyRqaP8Ubh1kW0Ds 52S1pLZivUsMzlkdeQynYtHBdtvmF2tBrM03rO2+2B0yhX32VOrgKUDcB3byo+tkR8BBieA RffX9eZTO+VOagFHtfbtA== X-UI-Out-Filterresults: notjunk:1; V03:K0:ZLNSaDhH6mk=:R0AWkbYDfXw1vC/wXEEbDd z1B+szeXkZUgMsKzYPleCBsOc80ZCtafx/wGay7how8VvMjsblaZMTnraDgNhAOeC46m9EvSy NfBSj9q4soCAHzuc1w9eOCyBjB8hCdWy4KWmQMxgXAin5TSHHYYvjOU1MifL8FUS9N7ziXEaL zbnz0pnG7qe9O/MbsWYwJqugKzYQgNlnJFMX4p375wK0bC3ShDYqA0wEpfXR0znu8gJcf9Izi 906OliLDbDq+KeTmReC3xFSPj/revH4m41n4+JeFf2ATPYF4DCCzv4Fu0XC9Hvo1MVYqIzzcU lulEhtS8mT+Cv5WzgWs3HlD833oW2I/qv7z5jFR9urQwgQNdyapzDALZEekT/beFvN323mOVw DW+1MnYUY2+7870rdBqE+U6V1Usqgp+P2bDmL6+7gRjJmibIw9Oad3qiUBn4hwkUREPMvRqvE gpllq6AmPXYZAPNNKr2GJW3fLR5j1OYJwemyzKUbdJYT5cKDFXo18F7LuMIHHLIwaOFkA0jxD MKKoqGATnglzctQYlJjMZcPV25YEsPkStxIIVDvRXbjKbDUuC04kCMJAtnS/qbpx/4IVv80E0 k7pI+I4j6VHFKV32p+10fBw+Oym/+gJogbmLWSzXupKeeXWxJqiwGFmrgTnXhSNw5kNQq6FLJ yexJSfUP+YBaTf1IMD4pwlWu2bJVBnfsInAK35nIF/YOX02JB8JJ4GN+ljATupC1BR0kLIxNI 38ZDjRmtc90BWmjn4RJ3cDkFCC75wQ9YMe/HbDaI81bUs4jexOyXklbx42de1gRjr0rFLCet3 no4SBbcFM1/lDMgRIO1b1lyo4TeFGxc8b9NRrMEvXQC62b3FEvFxc6tT+pHunrdSaS1sAYcbF fsc9X4cqxAcUMpVHYzFYUDanJL3OMQuxccSF2kx2M= Cc: Marcel Ziswiler , Stefan Agner Subject: [U-Boot] [PATCH v1 2/5] colibri_t30: fix spi1 and uart2/3 resp. uartb/c pinmuxing X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Marcel Ziswiler Fix SPI1 and UART2/3 resp. UARTB/C pinmuxing. Note: The former was illegally muxing multiple SoC balls onto the same internal SoC signal which caused rather strange behaviour regarding the RS232 serial transceiver ForceOFF# pins as available on Iris. Signed-off-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- .../colibri_t30/pinmux-config-colibri_t30.h | 23 ++++++++++--------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/board/toradex/colibri_t30/pinmux-config-colibri_t30.h b/board/toradex/colibri_t30/pinmux-config-colibri_t30.h index 6181b506a4..c583583b3f 100644 --- a/board/toradex/colibri_t30/pinmux-config-colibri_t30.h +++ b/board/toradex/colibri_t30/pinmux-config-colibri_t30.h @@ -181,13 +181,14 @@ static struct pmux_pingrp_config tegra3_pinmux_common[] = { LV_PINMUX(VI_D10_PT2, RSVD1, NORMAL, NORMAL, INPUT, DISABLE, DISABLE), LV_PINMUX(VI_MCLK_PT1, VI, UP, NORMAL, INPUT, DISABLE, DISABLE), DEFAULT_PINMUX(UART2_RXD_PC3, UARTB, NORMAL, NORMAL, INPUT), - DEFAULT_PINMUX(UART2_TXD_PC2, UARTB, NORMAL, NORMAL, OUTPUT), - DEFAULT_PINMUX(UART2_RTS_N_PJ6, UARTB, NORMAL, NORMAL, OUTPUT), - DEFAULT_PINMUX(UART2_CTS_N_PJ5, UARTB, NORMAL, NORMAL, INPUT), - DEFAULT_PINMUX(UART3_TXD_PW6, UARTC, NORMAL, NORMAL, OUTPUT), - DEFAULT_PINMUX(UART3_RXD_PW7, UARTC, NORMAL, NORMAL, INPUT), - DEFAULT_PINMUX(UART3_CTS_N_PA1, UARTC, NORMAL, NORMAL, INPUT), - DEFAULT_PINMUX(UART3_RTS_N_PC0, UARTC, NORMAL, NORMAL, OUTPUT), + DEFAULT_PINMUX(UART2_TXD_PC2, UARTB, NORMAL, NORMAL, INPUT), + DEFAULT_PINMUX(UART2_RTS_N_PJ6, GMI, NORMAL, NORMAL, INPUT), + DEFAULT_PINMUX(UART2_CTS_N_PJ5, GMI, NORMAL, NORMAL, INPUT), + DEFAULT_PINMUX(UART3_TXD_PW6, GMI, NORMAL, NORMAL, INPUT), + DEFAULT_PINMUX(UART3_RXD_PW7, GMI, NORMAL, NORMAL, INPUT), + DEFAULT_PINMUX(UART3_CTS_N_PA1, GMI, NORMAL, NORMAL, INPUT), + DEFAULT_PINMUX(UART3_RTS_N_PC0, GMI, NORMAL, NORMAL, INPUT), + DEFAULT_PINMUX(PU0, RSVD1, NORMAL, NORMAL, INPUT), DEFAULT_PINMUX(PU1, RSVD1, NORMAL, NORMAL, OUTPUT), DEFAULT_PINMUX(PU2, RSVD1, NORMAL, NORMAL, INPUT), @@ -270,10 +271,10 @@ static struct pmux_pingrp_config tegra3_pinmux_common[] = { DEFAULT_PINMUX(DAP2_SCLK_PA3, I2S1, NORMAL, NORMAL, INPUT), DEFAULT_PINMUX(SPI2_CS1_N_PW2, SPI2, UP, NORMAL, INPUT), - DEFAULT_PINMUX(SPI1_MOSI_PX4, SPI1, NORMAL, NORMAL, INPUT), - DEFAULT_PINMUX(SPI1_SCK_PX5, SPI1, NORMAL, NORMAL, INPUT), - DEFAULT_PINMUX(SPI1_CS0_N_PX6, SPI1, NORMAL, NORMAL, INPUT), - DEFAULT_PINMUX(SPI1_MISO_PX7, SPI1, NORMAL, NORMAL, INPUT), + DEFAULT_PINMUX(SPI1_MOSI_PX4, GMI, NORMAL, NORMAL, INPUT), + DEFAULT_PINMUX(SPI1_SCK_PX5, GMI, NORMAL, NORMAL, INPUT), + DEFAULT_PINMUX(SPI1_CS0_N_PX6, GMI, NORMAL, NORMAL, INPUT), + DEFAULT_PINMUX(SPI1_MISO_PX7, RSVD4, NORMAL, NORMAL, INPUT), /* LAN_RESET */ DEFAULT_PINMUX(PEX_L0_PRSNT_N_PDD0, RSVD2, NORMAL, NORMAL, OUTPUT), From patchwork Thu Sep 12 09:12:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 1161451 X-Patchwork-Delegate: twarren@nvidia.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46TY594SC7z9s4Y for ; Thu, 12 Sep 2019 19:15:09 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 364F6C21DF9; Thu, 12 Sep 2019 09:13:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,UPPERCASE_50_75 autolearn=no autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id A421EC21E1E; Thu, 12 Sep 2019 09:13:10 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 8F8B8C21C2F; Thu, 12 Sep 2019 09:13:08 +0000 (UTC) Received: from mout.perfora.net (mout.perfora.net [74.208.4.194]) by lists.denx.de (Postfix) with ESMTPS id E1197C21D56 for ; Thu, 12 Sep 2019 09:13:07 +0000 (UTC) Received: from marcel-nb-toradex-int.toradex.int ([46.140.72.82]) by mrelay.perfora.net (mreueus004 [74.208.5.2]) with ESMTPSA (Nemesis) id 1MBEOI-1hxulK0uQ2-00Cfou; Thu, 12 Sep 2019 11:13:04 +0200 From: Marcel Ziswiler To: u-boot@lists.denx.de Date: Thu, 12 Sep 2019 11:12:54 +0200 Message-Id: <20190912091256.15573-4-marcel@ziswiler.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190912091256.15573-1-marcel@ziswiler.com> References: <20190912091256.15573-1-marcel@ziswiler.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:HAzBvKR9zxkjhRbw9AdEkCLupl2xRF/v1kMsGFPYQUAIRzY1el6 7coO1NiyHRCeUxFqzX4bDg8M8B45HZ4+qLMyYZjdFYvlttCGbfVb90m9Z3zg+42O+Cu3/7d bYOuG0/3dn/g80bt6rao8V9gwp8W3Q9wb+9QVO5ijzMHD9I9ObeBFfK9+LukPHqPPiodw+Z 4o0k5KxDhPeLOtxbvgLjQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:7DwWbPAc4bM=:IwbnrztXgfepdSujr1mUZW PGyL/BGLF0ViDtwNuW9Y+ZdFp5LOyQPwho6oe5gyiP3TowbcOgBvaJ4DjhfyKz+sgYWDIv3+o vmEfaKgUIPlRNG9XoFe0WvXhJgkHdpPi4+LN5Z/nPs2PCHtIgsEAT2uA3LhhKJbnDE8uozogn o+b6wp9+o0P0HsJtIv5Om+sO792I02aAoC77lahp4kw7vfe0OeQ2gkXH7mru/dTR/9IJ18CYx /1c19+l43FgD4SjrV2+6YZrmN1XcGGw3bXqNQmIKZGGr3w2So9VkZn/FgsUALRjGUEPnuk+2A DpLKhGTlZJOyg+u783MT13G1I9h5g3s6BxNzBG344kO60amcOOMSwcwpZNR7Ve6Cb49piL7D6 zCExEkyHcZsm/j1M448Bhw6BiWMo2coNirWTHhKJ2nCM8sl1ZckeW5ZcQ+6FG1CWDX42zZDTc +nx2yr+NpVUUQc8DhcGxn87nsnksl4nIXwmS04FfDh2xwWrI/72lc7XwcXgeXYW/2XgGv2KqS Y5ZaR+ugggQd69Tsjpr9ofelHpD9zAiT4pIuaAZgWRh1vF2pJlDSGGPLTp3u8/woZDsXsHQ9E dmPYIYk1PUTMVPcqXVNf/JsyIxS4OwqfahGf7BDiy675LpFpcML8JmDU0xreJ7ow6VNxx+9EU 7nqMjj1mgq0uQ/Px41a2rSG05w40hiYq4MMqLl4SMfP/KaecDyqy9rVuaprGpxn6q2snT3jYO HUjeduajbVvicTytmQeZ2L6FFuhEvf7FC5Ozupzaw03+htu4nb0HAWmkh97f8UMhmswZm+I4G 5/p7UBwANuXiF1XU/3huf4N3Jfqicyh12w2xwsGjJoAcTm7z81UZwwMDYMHIj2RjViSB/Nvil VKR+95f2sYPGpg6sc+/pffwNfTiXjcBjRlIh6UL6k= Cc: Marcel Ziswiler , Stefan Agner Subject: [U-Boot] [PATCH v1 3/5] apalis/colibri_t30: avoid uart input from floating pins X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Marcel Ziswiler Avoid UART input from floating RX pins on UARTB and UARTC (Colibri T30) and UARTB, UARTC and UARTD (Apalis T30). Note: Floating pins may cause spurious break conditions potentially interrupting U-Boot's autoboot. Signed-off-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- board/toradex/apalis_t30/pinmux-config-apalis_t30.h | 9 ++++++--- board/toradex/colibri_t30/pinmux-config-colibri_t30.h | 7 ++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/board/toradex/apalis_t30/pinmux-config-apalis_t30.h b/board/toradex/apalis_t30/pinmux-config-apalis_t30.h index 8d6696aaad..3a2cf4606e 100644 --- a/board/toradex/apalis_t30/pinmux-config-apalis_t30.h +++ b/board/toradex/apalis_t30/pinmux-config-apalis_t30.h @@ -120,7 +120,8 @@ static struct pmux_pingrp_config tegra3_pinmux_common[] = { DEFAULT_PINMUX(ULPI_DATA6_PO7, UARTA, NORMAL, NORMAL, INPUT), DEFAULT_PINMUX(ULPI_DATA7_PO0, UARTA, NORMAL, NORMAL, OUTPUT), DEFAULT_PINMUX(ULPI_CLK_PY0, UARTD, NORMAL, NORMAL, OUTPUT), - DEFAULT_PINMUX(ULPI_DIR_PY1, UARTD, NORMAL, NORMAL, INPUT), + /* UARTD RX, make sure we don't get input form a floating Pin */ + DEFAULT_PINMUX(ULPI_DIR_PY1, UARTD, UP, NORMAL, INPUT), DEFAULT_PINMUX(ULPI_NXT_PY2, UARTD, NORMAL, NORMAL, INPUT), DEFAULT_PINMUX(ULPI_STP_PY3, UARTD, NORMAL, NORMAL, OUTPUT), DEFAULT_PINMUX(DAP3_FS_PP0, I2S2, NORMAL, NORMAL, INPUT), @@ -189,12 +190,14 @@ static struct pmux_pingrp_config tegra3_pinmux_common[] = { LV_PINMUX(VI_MCLK_PT1, VI, NORMAL, NORMAL, OUTPUT, DISABLE, DISABLE), LV_PINMUX(VI_PCLK_PT0, VI, NORMAL, NORMAL, INPUT, DISABLE, DISABLE), LV_PINMUX(VI_VSYNC_PD6, VI, NORMAL, NORMAL, INPUT, DISABLE, DISABLE), - DEFAULT_PINMUX(UART2_RXD_PC3, UARTB, NORMAL, NORMAL, INPUT), + /* UARTB RX, make sure we don't get input form a floating Pin */ + DEFAULT_PINMUX(UART2_RXD_PC3, UARTB, UP, NORMAL, INPUT), DEFAULT_PINMUX(UART2_TXD_PC2, UARTB, NORMAL, NORMAL, OUTPUT), DEFAULT_PINMUX(UART2_RTS_N_PJ6, UARTB, DOWN, TRISTATE, OUTPUT), /* NC */ DEFAULT_PINMUX(UART2_CTS_N_PJ5, UARTB, DOWN, TRISTATE, OUTPUT), /* NC */ DEFAULT_PINMUX(UART3_TXD_PW6, UARTC, NORMAL, NORMAL, OUTPUT), - DEFAULT_PINMUX(UART3_RXD_PW7, UARTC, NORMAL, NORMAL, INPUT), + /* UARTC RX, make sure we don't get input form a floating Pin */ + DEFAULT_PINMUX(UART3_RXD_PW7, UARTC, UP, NORMAL, INPUT), DEFAULT_PINMUX(UART3_CTS_N_PA1, UARTC, NORMAL, NORMAL, INPUT), DEFAULT_PINMUX(UART3_RTS_N_PC0, PWM0, NORMAL, NORMAL, OUTPUT), DEFAULT_PINMUX(PU0, RSVD1, DOWN, TRISTATE, OUTPUT), diff --git a/board/toradex/colibri_t30/pinmux-config-colibri_t30.h b/board/toradex/colibri_t30/pinmux-config-colibri_t30.h index c583583b3f..5ac1a6da97 100644 --- a/board/toradex/colibri_t30/pinmux-config-colibri_t30.h +++ b/board/toradex/colibri_t30/pinmux-config-colibri_t30.h @@ -180,7 +180,8 @@ static struct pmux_pingrp_config tegra3_pinmux_common[] = { LV_PINMUX(VI_D7_PL5, SDMMC2, NORMAL, NORMAL, INPUT, DISABLE, DISABLE), LV_PINMUX(VI_D10_PT2, RSVD1, NORMAL, NORMAL, INPUT, DISABLE, DISABLE), LV_PINMUX(VI_MCLK_PT1, VI, UP, NORMAL, INPUT, DISABLE, DISABLE), - DEFAULT_PINMUX(UART2_RXD_PC3, UARTB, NORMAL, NORMAL, INPUT), + /* UARTC RX, make sure we don't get input form a floating Pin */ + DEFAULT_PINMUX(UART2_RXD_PC3, UARTB, UP, NORMAL, INPUT), DEFAULT_PINMUX(UART2_TXD_PC2, UARTB, NORMAL, NORMAL, INPUT), DEFAULT_PINMUX(UART2_RTS_N_PJ6, GMI, NORMAL, NORMAL, INPUT), DEFAULT_PINMUX(UART2_CTS_N_PJ5, GMI, NORMAL, NORMAL, INPUT), @@ -207,11 +208,11 @@ static struct pmux_pingrp_config tegra3_pinmux_common[] = { DEFAULT_PINMUX(GMI_AD8_PH0, PWM0, NORMAL, NORMAL, OUTPUT), /* LCD1_BL_PWM */ DEFAULT_PINMUX(GMI_AD10_PH2, NAND, NORMAL, NORMAL, OUTPUT), /* LCD1_BL_EN */ DEFAULT_PINMUX(GMI_A16_PJ7, UARTD, NORMAL, NORMAL, INPUT), - DEFAULT_PINMUX(GMI_A17_PB0, UARTD, NORMAL, NORMAL, INPUT), + /* UARTB RX, make sure we don't get input form a floating Pin */ + DEFAULT_PINMUX(GMI_A17_PB0, UARTD, UP, NORMAL, INPUT), DEFAULT_PINMUX(GMI_A18_PB1, UARTD, NORMAL, NORMAL, INPUT), DEFAULT_PINMUX(GMI_A19_PK7, UARTD, NORMAL, NORMAL, INPUT), - /* Multiplexed with KB_ROW10/KB_ROW11/KB_ROW12/KB_ROW15 */ DEFAULT_PINMUX(CAM_MCLK_PCC0, VI_ALT2, UP, TRISTATE, INPUT), DEFAULT_PINMUX(PCC1, RSVD1, NORMAL, TRISTATE, INPUT), From patchwork Thu Sep 12 09:12:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 1161452 X-Patchwork-Delegate: twarren@nvidia.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46TY5J2VJWz9s4Y for ; Thu, 12 Sep 2019 19:15:16 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 154B8C21E1E; Thu, 12 Sep 2019 09:13:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 64A9BC21E35; Thu, 12 Sep 2019 09:13:22 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 94EB4C21E2F; Thu, 12 Sep 2019 09:13:12 +0000 (UTC) Received: from mout.perfora.net (mout.perfora.net [74.208.4.194]) by lists.denx.de (Postfix) with ESMTPS id E4889C21C2F for ; Thu, 12 Sep 2019 09:13:08 +0000 (UTC) Received: from marcel-nb-toradex-int.toradex.int ([46.140.72.82]) by mrelay.perfora.net (mreueus004 [74.208.5.2]) with ESMTPSA (Nemesis) id 1Mvan4-1iQh5r1nGg-00sih6; Thu, 12 Sep 2019 11:13:05 +0200 From: Marcel Ziswiler To: u-boot@lists.denx.de Date: Thu, 12 Sep 2019 11:12:55 +0200 Message-Id: <20190912091256.15573-5-marcel@ziswiler.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190912091256.15573-1-marcel@ziswiler.com> References: <20190912091256.15573-1-marcel@ziswiler.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:StIIFK+TZgnk9rMgeKfycJq3ZzlO8qlpOpf3r9Zc/nCzGpNzxjb yQA7uJnXj6DkELlK7WzxSIW+idFseg9AgM4fKDnbQZxoHTZ1sKiKhz1tnkHlEc0ZhD25/Tn fAGIAl4vIYRTt6gFWp+TbNeP16Y3b5ZTlLYnd83iFkcbJ0+pUQzW2iktJ77dNCHlqOJBxma nEvAtlsUvxdLNTo5ekQuA== X-UI-Out-Filterresults: notjunk:1; V03:K0:+ZafffwxDzs=:CzeRr7u+ai1BSaMg6XpvYF 4Ulb1sr+Ansfhf58vprYmJYiR9CllOF6Iu8VT1N80sDi5r7+4+GiiwEo742sN4cpkXj/fsl2P wX68MGUIyRxlh0hnhFg+uXrCREhcmH0EOrtLWJlrEbZORZqLuWoTW41JWKLMEluDIHt6n67UD kHiSQW5PrJXPY+XaorSiu2NVjqL75TxI3QNBKbGC+sjCJ85Wrd5Bo85fcqBcLEVuZfYFWQron P7O8CA73NWOQo2mJJdOo4U45xHDwleSTjmxl8t4mKj1nyuYmkRjFdPdx/UN8OI4YlxV23OX7a EceqaU0qefN2NbQ4zlSuVD150RbRSvZlR0exI6dGiuxXz1fzEHHkV/08/AYasjh/v8znIdxQw lDiq1yrLYqpKOmXLrhW6sf55dzQvcukgRUSDu/TTGMgsHKeUgEQfoH5DB6Y62mqTXmzmNSXhe jwWlwUTajjDqGtKN8izdYeOFxBuFpbiWq32aDUE4RIgj7IEhrwoqFNY5g0k2R0ctNU6lxjkDd temtQiPAGahwAT5opXgnkh15CrYOxvu4fOgB3lg9NDlQ/K1kCHGPE20pVZeNOC20L3rTbu2p8 AAsKXWu/JFlMQZt5tjmYaD1wyJ08tMCSWd5VinF1ZE0DBbc7hHTUtJEbcwK3tQ3+3VlqBA/2h 2Kvnjdl/zHuXGfS1uGAD1uN9wWTviouHn5KkcYW8UiM+Yz3NZv9qIUsmWLpfaQYBuCpldEWqe zZgss/UtmNhAsLB1FBTjpcmFfPSbhCFpn06qp7sRnhDINCb/y5gSYgZ3LkcnDjdRJ37Lc7/9K 5LRZF/mY13MgNFt/gYG/8Bt76TMxm63AMBb1nb6ux/zycQ2vPZ86BujSvHF3qL1qg9SbjYap2 dkTlY3M4kGbFj/FTHGKlhb4b6JGZCdV1A5zH/d3bo= Cc: Marcel Ziswiler , Stefan Agner Subject: [U-Boot] [PATCH v1 4/5] apalis/colibri_t30: add note about colibri vs. nvidia uart mapping X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Marcel Ziswiler The following mapping is applicable for Apalis T30: Apalis UART1: NVIDIA UARTA Apalis UART2: NVIDIA UARTD Apalis UART3: NVIDIA UARTB Apalis UART4: NVIDIA UARTC The following mapping is applicable for Colibri T30: Colibri UART-A: NVIDIA UARTA Colibri UART-B: NVIDIA UARTD Colibri UART-C: NVIDIA UARTB Signed-off-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk --- include/configs/apalis_t30.h | 9 ++++++++- include/configs/colibri_t30.h | 8 +++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/include/configs/apalis_t30.h b/include/configs/apalis_t30.h index f6adfeb96a..b6711c57b8 100644 --- a/include/configs/apalis_t30.h +++ b/include/configs/apalis_t30.h @@ -12,7 +12,14 @@ #include "tegra30-common.h" -/* Board-specific serial config */ +/* + * Board-specific serial config + * + * Apalis UART1: NVIDIA UARTA + * Apalis UART2: NVIDIA UARTD + * Apalis UART3: NVIDIA UARTB + * Apalis UART4: NVIDIA UARTC + */ #define CONFIG_TEGRA_ENABLE_UARTA #define CONFIG_SYS_NS16550_COM1 NV_PA_APB_UARTA_BASE diff --git a/include/configs/colibri_t30.h b/include/configs/colibri_t30.h index 8ff6433f45..6053776019 100644 --- a/include/configs/colibri_t30.h +++ b/include/configs/colibri_t30.h @@ -14,7 +14,13 @@ /* High-level configuration options */ -/* Board-specific serial config */ +/* + * Board-specific serial config + * + * Colibri UART-A: NVIDIA UARTA + * Colibri UART-B: NVIDIA UARTD + * Colibri UART-C: NVIDIA UARTB + */ #define CONFIG_TEGRA_ENABLE_UARTA #define CONFIG_SYS_NS16550_COM1 NV_PA_APB_UARTA_BASE From patchwork Thu Sep 12 09:12:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 1161453 X-Patchwork-Delegate: twarren@nvidia.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46TY6F57GBz9s4Y for ; Thu, 12 Sep 2019 19:16:05 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 62DA6C21DD4; Thu, 12 Sep 2019 09:14:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 1E3D2C21DED; Thu, 12 Sep 2019 09:13:31 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 5B1AEC21DB6; Thu, 12 Sep 2019 09:13:13 +0000 (UTC) Received: from mout.perfora.net (mout.perfora.net [74.208.4.194]) by lists.denx.de (Postfix) with ESMTPS id 4B8EEC21E0D for ; Thu, 12 Sep 2019 09:13:10 +0000 (UTC) Received: from marcel-nb-toradex-int.toradex.int ([46.140.72.82]) by mrelay.perfora.net (mreueus004 [74.208.5.2]) with ESMTPSA (Nemesis) id 1N189m-1iEcnY2btK-012ZWG; Thu, 12 Sep 2019 11:13:07 +0200 From: Marcel Ziswiler To: u-boot@lists.denx.de Date: Thu, 12 Sep 2019 11:12:56 +0200 Message-Id: <20190912091256.15573-6-marcel@ziswiler.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190912091256.15573-1-marcel@ziswiler.com> References: <20190912091256.15573-1-marcel@ziswiler.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:Cs798ZI/AxzmdJ3x7FC0/5Zxb17pWFThiiwrP120ii8AfvJ3yhf JKYxustYeSxb3TjzpJs5ducugZUZ+ps/5DI04L6OrB4zMtA2iAQz3AoMB5FZiRxmXn2RNEt 820fESwRSs/cLiwno5rP5MUcCmz2RVUc9WvMlUReN0GJHyPg0kLKHm59NvaoT1uDWgfDvfN TThOKND82r+SCAMb8itSA== X-UI-Out-Filterresults: notjunk:1; V03:K0:JMYnm9xwRs4=:duL51z2NkzDFFZBAdLz43U mWCjOihvNXelwu40tIrGuEITJORvicOqGrRBUYOBzoG4gDPwO4SjR2PCVyfUIPJDGHS4Etvbj +DM2ihAfGS9XIXdFPZJZ73S6XjRQwspfY409FTfjSimQ46INh+Zz6EmyLJVxqP7xQE9wtSQks q+UVZ/Lh6dCB+xjyKjPa0wf+AjTioNFecJ+0EYENGjP/msx+arYh1kW1qMDMjgDm5ExNRfcUx ZzVfDXfY675M6sGM9NeUDu2Uzvuc7ArGszPbTMCCwQKzUns+uCad6/z8+QQFxqoUza4kU40df ln5mVevFqO+0xAN2vhpzwJT1xr4NLO1/k1tLX4LnaKopr8Ay2UeGf5ulkKBEkoUjqQA7IuGTE jyJhu4YPdU5+4w/2ua1FvuO3yhu4IW9dvRuHuib+1ALKSLh9D2D/6zcsDrtoitUEJQanIEUt0 OT+XaQfIbM/Us7eU197ClaTRh5FSujQjVPO/lIfOOIZSAI47Wn8mDodA/rFWez9S/lZ3Qcjrd t21xp0VmMBY9leHrko08A5hSxNuv8F7q0p0WWStmqmJCV6JEYb3MEj+zXgpNylMxF6ybKVxSA rhfnVccOyl2YHGAbgbZ0kxVGJh0Nq7Uy4G412PxhdPvZxucGBMWzMBkknUPK0xheVNMIOyafz m47XU+1VvjtBvjOEglLpOFrC9Pkm14X6CkrUA1NVhr/QsiGckKE9SaNSMa55OUHguqJIO2eHL aduRnX3+MTGSaz5h7IBRJ1YxbMcvrkkMwa43bpXA8mDNEOUjArTTrizo5uERMkd6e7bM4+KIB MxLP+mTVP4b9pZ1l5mlvECQ5mHY6xU8fm3t5glRiigisKPMIHnmxczfPYhNiuwQQXpmNSsn8B SSTj0654uKRanuAOsK3Egs5mjqc4gjzcsQDX6yWo8= Cc: Marcel Ziswiler , Stefan Agner Subject: [U-Boot] [PATCH v1 5/5] colibri_t30: disable rs232 serial transceiver forceoff pins X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Marcel Ziswiler Use gpio_early_init_uart() function to disable RS232 serial transceiver ForceOFF# pins on Iris. Signed-off-by: Marcel Ziswiler --- board/toradex/colibri_t30/colibri_t30.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/board/toradex/colibri_t30/colibri_t30.c b/board/toradex/colibri_t30/colibri_t30.c index b6b00e3860..eb53fa6126 100644 --- a/board/toradex/colibri_t30/colibri_t30.c +++ b/board/toradex/colibri_t30/colibri_t30.c @@ -55,6 +55,17 @@ void pinmux_init(void) ARRAY_SIZE(colibri_t30_padctrl)); } +/* + * Disable RS232 serial transceiver ForceOFF# pins on Iris + */ +void gpio_early_init_uart(void) +{ + gpio_request(TEGRA_GPIO(X, 6), "Force OFF# X13"); + gpio_direction_output(TEGRA_GPIO(X, 6), 1); + gpio_request(TEGRA_GPIO(X, 7), "Force OFF# X14"); + gpio_direction_output(TEGRA_GPIO(X, 7), 1); +} + /* * Enable AX88772B USB to LAN controller */