From patchwork Fri Nov 10 17:48:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 836809 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3yYSFH5pRXz9sRW; Sat, 11 Nov 2017 04:48:35 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1eDDPt-0006I6-WD; Fri, 10 Nov 2017 17:48:33 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1eDDPs-0006Hm-Op for fwts-devel@lists.ubuntu.com; Fri, 10 Nov 2017 17:48:32 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1eDDPs-0000bo-CK; Fri, 10 Nov 2017 17:48:32 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] dmi: dmicheck: zero buffer buf, cleans up a static analysis warning Date: Fri, 10 Nov 2017 17:48:31 +0000 Message-Id: <20171110174831.1056-1-colin.king@canonical.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: Colin Ian King This is not strictly necessary, but it cleans up a static analysis warning from CoverityScan. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/dmi/dmicheck/dmicheck.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c index a55597f1..9bc8804c 100644 --- a/src/dmi/dmicheck/dmicheck.c +++ b/src/dmi/dmicheck/dmicheck.c @@ -306,6 +306,8 @@ static int dmi_load_file(const char* filename, void *buf, size_t size) int fd; ssize_t ret; + (void)memset(buf, 0, size); + if ((fd = open(filename, O_RDONLY)) < 0) return FWTS_ERROR; ret = read(fd, buf, size);